2021-02-08 08:46:10 +03:00
|
|
|
#!/usr/bin/env python3
|
|
|
|
|
|
|
|
##
|
2023-03-07 05:58:19 +03:00
|
|
|
## Copyright(c) 2019-2023 Qualcomm Innovation Center, Inc. All Rights Reserved.
|
2021-02-08 08:46:10 +03:00
|
|
|
##
|
|
|
|
## This program is free software; you can redistribute it and/or modify
|
|
|
|
## it under the terms of the GNU General Public License as published by
|
|
|
|
## the Free Software Foundation; either version 2 of the License, or
|
|
|
|
## (at your option) any later version.
|
|
|
|
##
|
|
|
|
## This program is distributed in the hope that it will be useful,
|
|
|
|
## but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
## GNU General Public License for more details.
|
|
|
|
##
|
|
|
|
## You should have received a copy of the GNU General Public License
|
|
|
|
## along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
|
|
##
|
|
|
|
|
|
|
|
import sys
|
|
|
|
import re
|
|
|
|
import string
|
|
|
|
import hex_common
|
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2021-02-08 08:46:10 +03:00
|
|
|
##
|
|
|
|
## Helpers for gen_tcg_func
|
|
|
|
##
|
|
|
|
def gen_decl_ea_tcg(f, tag):
|
2023-02-25 07:33:03 +03:00
|
|
|
f.write(" TCGv EA G_GNUC_UNUSED = tcg_temp_new();\n")
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2021-02-25 21:15:07 +03:00
|
|
|
def genptr_decl_pair_writable(f, tag, regtype, regid, regno):
|
2023-03-20 12:25:33 +03:00
|
|
|
regN = f"{regtype}{regid}N"
|
|
|
|
if regtype == "R":
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const int {regN} = insn->regno[{regno}];\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "C":
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const int {regN} = insn->regno[{regno}] + HEX_REG_SA0;\n")
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
f.write(f" TCGv_i64 {regtype}{regid}V = " f"get_result_gpr_pair(ctx, {regN});\n")
|
|
|
|
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2021-02-25 21:15:07 +03:00
|
|
|
def genptr_decl_writable(f, tag, regtype, regid, regno):
|
2023-03-20 12:25:33 +03:00
|
|
|
regN = f"{regtype}{regid}N"
|
|
|
|
if regtype == "R":
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const int {regN} = insn->regno[{regno}];\n")
|
|
|
|
f.write(f" TCGv {regtype}{regid}V = get_result_gpr(ctx, {regN});\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "C":
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const int {regN} = insn->regno[{regno}] + HEX_REG_SA0;\n")
|
|
|
|
f.write(f" TCGv {regtype}{regid}V = get_result_gpr(ctx, {regN});\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "P":
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const int {regN} = insn->regno[{regno}];\n")
|
|
|
|
f.write(f" TCGv {regtype}{regid}V = tcg_temp_new();\n")
|
Hexagon (target/hexagon) Remove gen_log_predicated_reg_write[_pair]
We assign the instruction destination register to hex_new_value[num]
instead of a TCG temp that gets copied back to hex_new_value[num].
We introduce new functions get_result_gpr[_pair] to facilitate getting
the proper destination register.
Since we preload hex_new_value for predicated instructions, we don't
need the check for slot_cancelled. So, we call gen_log_reg_write instead.
We update the helper function generation and gen_tcg.h to maintain the
disable-hexagon-idef-parser configuration.
Here is a simple example of the differences in the TCG code generated:
IN:
0x00400094: 0xf900c102 { if (P0) R2 = and(R0,R1) }
BEFORE
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
mov_i32 loc2,$0x0
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 loc2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
and_i32 tmp0,slot_cancelled,$0x8
movcond_i32 new_r2,tmp0,$0x0,loc2,new_r2,eq
mov_i32 r2,new_r2
AFTER
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 new_r2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
mov_i32 r2,new_r2
We'll remove the unnecessary manipulation of slot_cancelled in a
subsequent patch.
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230307025828.1612809-13-tsimpson@quicinc.com>
2023-03-07 05:58:26 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2021-02-08 08:46:10 +03:00
|
|
|
def genptr_decl(f, tag, regtype, regid, regno):
|
2023-03-20 12:25:33 +03:00
|
|
|
regN = f"{regtype}{regid}N"
|
|
|
|
if regtype == "R":
|
|
|
|
if regid in {"ss", "tt"}:
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" TCGv_i64 {regtype}{regid}V = tcg_temp_new_i64();\n")
|
|
|
|
f.write(f" const int {regN} = insn->regno[{regno}];\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regid in {"dd", "ee", "xx", "yy"}:
|
2021-02-25 21:15:07 +03:00
|
|
|
genptr_decl_pair_writable(f, tag, regtype, regid, regno)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regid in {"s", "t", "u", "v"}:
|
|
|
|
f.write(
|
|
|
|
f" TCGv {regtype}{regid}V = " f"hex_gpr[insn->regno[{regno}]];\n"
|
|
|
|
)
|
|
|
|
elif regid in {"d", "e", "x", "y"}:
|
2021-02-25 21:15:07 +03:00
|
|
|
genptr_decl_writable(f, tag, regtype, regid, regno)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "P":
|
|
|
|
if regid in {"s", "t", "u", "v"}:
|
|
|
|
f.write(
|
|
|
|
f" TCGv {regtype}{regid}V = " f"hex_pred[insn->regno[{regno}]];\n"
|
|
|
|
)
|
|
|
|
elif regid in {"d", "e", "x"}:
|
2021-02-25 21:15:07 +03:00
|
|
|
genptr_decl_writable(f, tag, regtype, regid, regno)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "C":
|
|
|
|
if regid == "ss":
|
|
|
|
f.write(f" TCGv_i64 {regtype}{regid}V = " f"tcg_temp_new_i64();\n")
|
|
|
|
f.write(f" const int {regN} = insn->regno[{regno}] + " "HEX_REG_SA0;\n")
|
|
|
|
elif regid == "dd":
|
2021-02-25 21:15:07 +03:00
|
|
|
genptr_decl_pair_writable(f, tag, regtype, regid, regno)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regid == "s":
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" TCGv {regtype}{regid}V = tcg_temp_new();\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
f.write(
|
|
|
|
f" const int {regtype}{regid}N = insn->regno[{regno}] + "
|
|
|
|
"HEX_REG_SA0;\n"
|
|
|
|
)
|
|
|
|
elif regid == "d":
|
2021-02-25 21:15:07 +03:00
|
|
|
genptr_decl_writable(f, tag, regtype, regid, regno)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "M":
|
|
|
|
if regid == "u":
|
|
|
|
f.write(f" const int {regtype}{regid}N = " f"insn->regno[{regno}];\n")
|
|
|
|
f.write(
|
|
|
|
f" TCGv {regtype}{regid}V = hex_gpr[{regtype}{regid}N + "
|
|
|
|
"HEX_REG_M0];\n"
|
|
|
|
)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "V":
|
|
|
|
if regid in {"dd"}:
|
|
|
|
f.write(f" const int {regtype}{regid}N = " f"insn->regno[{regno}];\n")
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const intptr_t {regtype}{regid}V_off =\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.is_tmp_result(tag):
|
|
|
|
f.write(
|
|
|
|
f" ctx_tmp_vreg_off(ctx, {regtype}{regid}N, 2, " "true);\n"
|
|
|
|
)
|
2020-12-10 03:35:22 +03:00
|
|
|
else:
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" ctx_future_vreg_off(ctx, {regtype}{regid}N,")
|
2020-12-10 03:35:22 +03:00
|
|
|
f.write(" 2, true);\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
if not hex_common.skip_qemu_helper(tag):
|
|
|
|
f.write(f" TCGv_ptr {regtype}{regid}V = " "tcg_temp_new_ptr();\n")
|
|
|
|
f.write(
|
|
|
|
f" tcg_gen_addi_ptr({regtype}{regid}V, cpu_env, "
|
|
|
|
f"{regtype}{regid}V_off);\n"
|
|
|
|
)
|
|
|
|
elif regid in {"uu", "vv", "xx"}:
|
|
|
|
f.write(f" const int {regtype}{regid}N = " f"insn->regno[{regno}];\n")
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const intptr_t {regtype}{regid}V_off =\n")
|
|
|
|
f.write(f" offsetof(CPUHexagonState, {regtype}{regid}V);\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
if not hex_common.skip_qemu_helper(tag):
|
|
|
|
f.write(f" TCGv_ptr {regtype}{regid}V = " "tcg_temp_new_ptr();\n")
|
|
|
|
f.write(
|
|
|
|
f" tcg_gen_addi_ptr({regtype}{regid}V, cpu_env, "
|
|
|
|
f"{regtype}{regid}V_off);\n"
|
|
|
|
)
|
|
|
|
elif regid in {"s", "u", "v", "w"}:
|
|
|
|
f.write(f" const int {regtype}{regid}N = " f"insn->regno[{regno}];\n")
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const intptr_t {regtype}{regid}V_off =\n")
|
|
|
|
f.write(f" vreg_src_off(ctx, {regtype}{regid}N);\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
if not hex_common.skip_qemu_helper(tag):
|
|
|
|
f.write(f" TCGv_ptr {regtype}{regid}V = " "tcg_temp_new_ptr();\n")
|
|
|
|
elif regid in {"d", "x", "y"}:
|
|
|
|
f.write(f" const int {regtype}{regid}N = " f"insn->regno[{regno}];\n")
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const intptr_t {regtype}{regid}V_off =\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
if regid == "y":
|
2022-07-19 02:03:18 +03:00
|
|
|
f.write(" offsetof(CPUHexagonState, vtmp);\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
elif hex_common.is_tmp_result(tag):
|
|
|
|
f.write(
|
|
|
|
f" ctx_tmp_vreg_off(ctx, {regtype}{regid}N, 1, " "true);\n"
|
|
|
|
)
|
2020-12-10 03:35:22 +03:00
|
|
|
else:
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" ctx_future_vreg_off(ctx, {regtype}{regid}N,")
|
2023-03-20 12:25:33 +03:00
|
|
|
f.write(" 1, true);\n")
|
2022-11-08 19:28:57 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
if not hex_common.skip_qemu_helper(tag):
|
|
|
|
f.write(f" TCGv_ptr {regtype}{regid}V = " "tcg_temp_new_ptr();\n")
|
|
|
|
f.write(
|
|
|
|
f" tcg_gen_addi_ptr({regtype}{regid}V, cpu_env, "
|
|
|
|
f"{regtype}{regid}V_off);\n"
|
|
|
|
)
|
2020-12-10 03:35:22 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "Q":
|
|
|
|
if regid in {"d", "e", "x"}:
|
|
|
|
f.write(f" const int {regtype}{regid}N = " f"insn->regno[{regno}];\n")
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const intptr_t {regtype}{regid}V_off =\n")
|
|
|
|
f.write(f" get_result_qreg(ctx, {regtype}{regid}N);\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
if not hex_common.skip_qemu_helper(tag):
|
|
|
|
f.write(f" TCGv_ptr {regtype}{regid}V = " "tcg_temp_new_ptr();\n")
|
|
|
|
f.write(
|
|
|
|
f" tcg_gen_addi_ptr({regtype}{regid}V, cpu_env, "
|
|
|
|
f"{regtype}{regid}V_off);\n"
|
|
|
|
)
|
|
|
|
elif regid in {"s", "t", "u", "v"}:
|
|
|
|
f.write(f" const int {regtype}{regid}N = " f"insn->regno[{regno}];\n")
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const intptr_t {regtype}{regid}V_off =\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
f.write(
|
|
|
|
f" offsetof(CPUHexagonState, " f"QRegs[{regtype}{regid}N]);\n"
|
|
|
|
)
|
|
|
|
if not hex_common.skip_qemu_helper(tag):
|
|
|
|
f.write(f" TCGv_ptr {regtype}{regid}V = " "tcg_temp_new_ptr();\n")
|
2020-12-10 03:35:22 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2020-12-10 03:35:22 +03:00
|
|
|
def genptr_decl_new(f, tag, regtype, regid, regno):
|
2023-03-20 12:25:33 +03:00
|
|
|
if regtype == "N":
|
|
|
|
if regid in {"s", "t"}:
|
|
|
|
f.write(
|
|
|
|
f" TCGv {regtype}{regid}N = "
|
2023-04-28 02:00:07 +03:00
|
|
|
f"get_result_gpr(ctx, insn->regno[{regno}]);\n"
|
2023-03-20 12:25:33 +03:00
|
|
|
)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "P":
|
|
|
|
if regid in {"t", "u", "v"}:
|
|
|
|
f.write(
|
|
|
|
f" TCGv {regtype}{regid}N = "
|
2023-04-28 02:00:09 +03:00
|
|
|
f"ctx->new_pred_value[insn->regno[{regno}]];\n"
|
2023-03-20 12:25:33 +03:00
|
|
|
)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "O":
|
|
|
|
if regid == "s":
|
|
|
|
f.write(
|
|
|
|
f" const intptr_t {regtype}{regid}N_num = "
|
|
|
|
f"insn->regno[{regno}];\n"
|
|
|
|
)
|
|
|
|
if hex_common.skip_qemu_helper(tag):
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" const intptr_t {regtype}{regid}N_off =\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
f.write(" ctx_future_vreg_off(ctx, " f"{regtype}{regid}N_num,")
|
2020-12-10 03:35:22 +03:00
|
|
|
f.write(" 1, true);\n")
|
|
|
|
else:
|
2023-03-20 12:25:33 +03:00
|
|
|
f.write(
|
|
|
|
f" TCGv {regtype}{regid}N = "
|
|
|
|
f"tcg_constant_tl({regtype}{regid}N_num);\n"
|
|
|
|
)
|
2020-12-10 03:35:22 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2023-05-24 17:41:47 +03:00
|
|
|
def genptr_decl_opn(f, tag, regtype, regid, i):
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.is_pair(regid):
|
2021-02-08 08:46:10 +03:00
|
|
|
genptr_decl(f, tag, regtype, regid, i)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif hex_common.is_single(regid):
|
2021-02-08 08:46:10 +03:00
|
|
|
if hex_common.is_old_val(regtype, regid, tag):
|
2023-03-20 12:25:33 +03:00
|
|
|
genptr_decl(f, tag, regtype, regid, i)
|
2021-02-08 08:46:10 +03:00
|
|
|
elif hex_common.is_new_val(regtype, regid, tag):
|
2020-12-10 03:35:22 +03:00
|
|
|
genptr_decl_new(f, tag, regtype, regid, i)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-24 17:41:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-24 17:41:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
def genptr_decl_imm(f, immlett):
|
|
|
|
if immlett.isupper():
|
2021-02-08 08:46:10 +03:00
|
|
|
i = 1
|
|
|
|
else:
|
|
|
|
i = 0
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" int {hex_common.imm_name(immlett)} = insn->immed[{i}];\n")
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2020-12-10 03:35:22 +03:00
|
|
|
def genptr_src_read(f, tag, regtype, regid):
|
2023-03-20 12:25:33 +03:00
|
|
|
if regtype == "R":
|
|
|
|
if regid in {"ss", "tt", "xx", "yy"}:
|
|
|
|
f.write(
|
|
|
|
f" tcg_gen_concat_i32_i64({regtype}{regid}V, "
|
|
|
|
f"hex_gpr[{regtype}{regid}N],\n"
|
|
|
|
)
|
|
|
|
f.write(
|
|
|
|
f" hex_gpr[{regtype}"
|
|
|
|
f"{regid}N + 1]);\n"
|
|
|
|
)
|
|
|
|
elif regid in {"x", "y"}:
|
Hexagon (target/hexagon) Remove gen_log_predicated_reg_write[_pair]
We assign the instruction destination register to hex_new_value[num]
instead of a TCG temp that gets copied back to hex_new_value[num].
We introduce new functions get_result_gpr[_pair] to facilitate getting
the proper destination register.
Since we preload hex_new_value for predicated instructions, we don't
need the check for slot_cancelled. So, we call gen_log_reg_write instead.
We update the helper function generation and gen_tcg.h to maintain the
disable-hexagon-idef-parser configuration.
Here is a simple example of the differences in the TCG code generated:
IN:
0x00400094: 0xf900c102 { if (P0) R2 = and(R0,R1) }
BEFORE
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
mov_i32 loc2,$0x0
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 loc2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
and_i32 tmp0,slot_cancelled,$0x8
movcond_i32 new_r2,tmp0,$0x0,loc2,new_r2,eq
mov_i32 r2,new_r2
AFTER
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 new_r2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
mov_i32 r2,new_r2
We'll remove the unnecessary manipulation of slot_cancelled in a
subsequent patch.
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230307025828.1612809-13-tsimpson@quicinc.com>
2023-03-07 05:58:26 +03:00
|
|
|
## For read/write registers, we need to get the original value into
|
|
|
|
## the result TCGv. For conditional instructions, this is done in
|
|
|
|
## gen_start_packet. For unconditional instructions, we do it here.
|
2023-03-20 12:25:33 +03:00
|
|
|
if "A_CONDEXEC" not in hex_common.attribdict[tag]:
|
|
|
|
f.write(
|
|
|
|
f" tcg_gen_mov_tl({regtype}{regid}V, "
|
|
|
|
f"hex_gpr[{regtype}{regid}N]);\n"
|
|
|
|
)
|
|
|
|
elif regid not in {"s", "t", "u", "v"}:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "P":
|
|
|
|
if regid == "x":
|
|
|
|
f.write(
|
|
|
|
f" tcg_gen_mov_tl({regtype}{regid}V, "
|
|
|
|
f"hex_pred[{regtype}{regid}N]);\n"
|
|
|
|
)
|
|
|
|
elif regid not in {"s", "t", "u", "v"}:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "C":
|
|
|
|
if regid == "ss":
|
|
|
|
f.write(
|
|
|
|
f" gen_read_ctrl_reg_pair(ctx, {regtype}{regid}N, "
|
|
|
|
f"{regtype}{regid}V);\n"
|
|
|
|
)
|
|
|
|
elif regid == "s":
|
|
|
|
f.write(
|
|
|
|
f" gen_read_ctrl_reg(ctx, {regtype}{regid}N, "
|
|
|
|
f"{regtype}{regid}V);\n"
|
|
|
|
)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "M":
|
|
|
|
if regid != "u":
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "V":
|
|
|
|
if regid in {"uu", "vv", "xx"}:
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" tcg_gen_gvec_mov(MO_64, {regtype}{regid}V_off,\n")
|
|
|
|
f.write(f" vreg_src_off(ctx, {regtype}{regid}N),\n")
|
2020-12-10 03:35:22 +03:00
|
|
|
f.write(" sizeof(MMVector), sizeof(MMVector));\n")
|
|
|
|
f.write(" tcg_gen_gvec_mov(MO_64,\n")
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" {regtype}{regid}V_off + sizeof(MMVector),\n")
|
|
|
|
f.write(f" vreg_src_off(ctx, {regtype}{regid}N ^ 1),\n")
|
2020-12-10 03:35:22 +03:00
|
|
|
f.write(" sizeof(MMVector), sizeof(MMVector));\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regid in {"s", "u", "v", "w"}:
|
|
|
|
if not hex_common.skip_qemu_helper(tag):
|
|
|
|
f.write(
|
|
|
|
f" tcg_gen_addi_ptr({regtype}{regid}V, cpu_env, "
|
|
|
|
f"{regtype}{regid}V_off);\n"
|
|
|
|
)
|
|
|
|
elif regid in {"x", "y"}:
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" tcg_gen_gvec_mov(MO_64, {regtype}{regid}V_off,\n")
|
|
|
|
f.write(f" vreg_src_off(ctx, {regtype}{regid}N),\n")
|
2020-12-10 03:35:22 +03:00
|
|
|
f.write(" sizeof(MMVector), sizeof(MMVector));\n")
|
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "Q":
|
|
|
|
if regid in {"s", "t", "u", "v"}:
|
|
|
|
if not hex_common.skip_qemu_helper(tag):
|
|
|
|
f.write(
|
|
|
|
f" tcg_gen_addi_ptr({regtype}{regid}V, cpu_env, "
|
|
|
|
f"{regtype}{regid}V_off);\n"
|
|
|
|
)
|
|
|
|
elif regid in {"x"}:
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" tcg_gen_gvec_mov(MO_64, {regtype}{regid}V_off,\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
f.write(
|
|
|
|
f" offsetof(CPUHexagonState, " f"QRegs[{regtype}{regid}N]),\n"
|
|
|
|
)
|
2020-12-10 03:35:22 +03:00
|
|
|
f.write(" sizeof(MMQReg), sizeof(MMQReg));\n")
|
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
|
|
|
def genptr_src_read_new(f, regtype, regid):
|
|
|
|
if regtype == "N":
|
|
|
|
if regid not in {"s", "t"}:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "P":
|
|
|
|
if regid not in {"t", "u", "v"}:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "O":
|
|
|
|
if regid != "s":
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
|
|
|
def genptr_src_read_opn(f, regtype, regid, tag):
|
|
|
|
if hex_common.is_pair(regid):
|
2020-12-10 03:35:22 +03:00
|
|
|
genptr_src_read(f, tag, regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif hex_common.is_single(regid):
|
2021-02-08 08:46:10 +03:00
|
|
|
if hex_common.is_old_val(regtype, regid, tag):
|
2020-12-10 03:35:22 +03:00
|
|
|
genptr_src_read(f, tag, regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
elif hex_common.is_new_val(regtype, regid, tag):
|
2023-03-20 12:25:33 +03:00
|
|
|
genptr_src_read_new(f, regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-24 17:41:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-24 17:41:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-05-24 17:41:47 +03:00
|
|
|
def gen_helper_call_opn(f, tag, regtype, regid, i):
|
2023-03-20 12:25:33 +03:00
|
|
|
if i > 0:
|
|
|
|
f.write(", ")
|
|
|
|
if hex_common.is_pair(regid):
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f"{regtype}{regid}V")
|
2023-03-20 12:25:33 +03:00
|
|
|
elif hex_common.is_single(regid):
|
2021-02-08 08:46:10 +03:00
|
|
|
if hex_common.is_old_val(regtype, regid, tag):
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f"{regtype}{regid}V")
|
2021-02-08 08:46:10 +03:00
|
|
|
elif hex_common.is_new_val(regtype, regid, tag):
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f"{regtype}{regid}N")
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-24 17:41:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-24 17:41:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
|
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
def gen_helper_decl_imm(f, immlett):
|
|
|
|
f.write(
|
|
|
|
f" TCGv tcgv_{hex_common.imm_name(immlett)} = "
|
|
|
|
f"tcg_constant_tl({hex_common.imm_name(immlett)});\n"
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
def gen_helper_call_imm(f, immlett):
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f", tcgv_{hex_common.imm_name(immlett)}")
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2021-02-08 08:46:10 +03:00
|
|
|
def genptr_dst_write_pair(f, tag, regtype, regid):
|
2023-04-28 01:59:53 +03:00
|
|
|
f.write(f" gen_log_reg_write_pair(ctx, {regtype}{regid}N, "
|
|
|
|
f"{regtype}{regid}V);\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2021-02-08 08:46:10 +03:00
|
|
|
|
|
|
|
def genptr_dst_write(f, tag, regtype, regid):
|
2023-03-20 12:25:33 +03:00
|
|
|
if regtype == "R":
|
|
|
|
if regid in {"dd", "xx", "yy"}:
|
2021-02-08 08:46:10 +03:00
|
|
|
genptr_dst_write_pair(f, tag, regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regid in {"d", "e", "x", "y"}:
|
|
|
|
f.write(
|
2023-04-28 01:59:53 +03:00
|
|
|
f" gen_log_reg_write(ctx, {regtype}{regid}N, "
|
|
|
|
f"{regtype}{regid}V);\n"
|
2023-03-20 12:25:33 +03:00
|
|
|
)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "P":
|
|
|
|
if regid in {"d", "e", "x"}:
|
|
|
|
f.write(
|
|
|
|
f" gen_log_pred_write(ctx, {regtype}{regid}N, "
|
|
|
|
f"{regtype}{regid}V);\n"
|
|
|
|
)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "C":
|
|
|
|
if regid == "dd":
|
|
|
|
f.write(
|
|
|
|
f" gen_write_ctrl_reg_pair(ctx, {regtype}{regid}N, "
|
|
|
|
f"{regtype}{regid}V);\n"
|
|
|
|
)
|
|
|
|
elif regid == "d":
|
|
|
|
f.write(
|
|
|
|
f" gen_write_ctrl_reg(ctx, {regtype}{regid}N, "
|
|
|
|
f"{regtype}{regid}V);\n"
|
|
|
|
)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2020-12-10 03:35:22 +03:00
|
|
|
def genptr_dst_write_ext(f, tag, regtype, regid, newv="EXT_DFL"):
|
2023-03-20 12:25:33 +03:00
|
|
|
if regtype == "V":
|
|
|
|
if regid in {"xx"}:
|
|
|
|
f.write(
|
|
|
|
f" gen_log_vreg_write_pair(ctx, {regtype}{regid}V_off, "
|
|
|
|
f"{regtype}{regid}N, {newv});\n"
|
|
|
|
)
|
|
|
|
elif regid in {"y"}:
|
|
|
|
f.write(
|
|
|
|
f" gen_log_vreg_write(ctx, {regtype}{regid}V_off, "
|
|
|
|
f"{regtype}{regid}N, {newv});\n"
|
|
|
|
)
|
|
|
|
elif regid not in {"dd", "d", "x"}:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif regtype == "Q":
|
|
|
|
if regid not in {"d", "e", "x"}:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2020-12-10 03:35:22 +03:00
|
|
|
else:
|
2023-05-04 19:17:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2020-12-10 03:35:22 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
|
|
|
def genptr_dst_write_opn(f, regtype, regid, tag):
|
|
|
|
if hex_common.is_pair(regid):
|
|
|
|
if hex_common.is_hvx_reg(regtype):
|
|
|
|
if hex_common.is_tmp_result(tag):
|
2020-12-10 03:35:22 +03:00
|
|
|
genptr_dst_write_ext(f, tag, regtype, regid, "EXT_TMP")
|
|
|
|
else:
|
|
|
|
genptr_dst_write_ext(f, tag, regtype, regid)
|
|
|
|
else:
|
|
|
|
genptr_dst_write(f, tag, regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
elif hex_common.is_single(regid):
|
|
|
|
if hex_common.is_hvx_reg(regtype):
|
|
|
|
if hex_common.is_new_result(tag):
|
2020-12-10 03:35:22 +03:00
|
|
|
genptr_dst_write_ext(f, tag, regtype, regid, "EXT_NEW")
|
2023-03-20 12:25:33 +03:00
|
|
|
elif hex_common.is_tmp_result(tag):
|
2020-12-10 03:35:22 +03:00
|
|
|
genptr_dst_write_ext(f, tag, regtype, regid, "EXT_TMP")
|
|
|
|
else:
|
|
|
|
genptr_dst_write_ext(f, tag, regtype, regid, "EXT_DFL")
|
|
|
|
else:
|
|
|
|
genptr_dst_write(f, tag, regtype, regid)
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
2023-05-24 17:41:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2021-02-08 08:46:10 +03:00
|
|
|
|
|
|
|
##
|
|
|
|
## Generate the TCG code to call the helper
|
|
|
|
## For A2_add: Rd32=add(Rs32,Rt32), { RdV=RsV+RtV;}
|
|
|
|
## We produce:
|
2022-11-08 19:28:56 +03:00
|
|
|
## static void generate_A2_add(DisasContext *ctx)
|
Hexagon (target/hexagon) Remove gen_log_predicated_reg_write[_pair]
We assign the instruction destination register to hex_new_value[num]
instead of a TCG temp that gets copied back to hex_new_value[num].
We introduce new functions get_result_gpr[_pair] to facilitate getting
the proper destination register.
Since we preload hex_new_value for predicated instructions, we don't
need the check for slot_cancelled. So, we call gen_log_reg_write instead.
We update the helper function generation and gen_tcg.h to maintain the
disable-hexagon-idef-parser configuration.
Here is a simple example of the differences in the TCG code generated:
IN:
0x00400094: 0xf900c102 { if (P0) R2 = and(R0,R1) }
BEFORE
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
mov_i32 loc2,$0x0
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 loc2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
and_i32 tmp0,slot_cancelled,$0x8
movcond_i32 new_r2,tmp0,$0x0,loc2,new_r2,eq
mov_i32 r2,new_r2
AFTER
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 new_r2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
mov_i32 r2,new_r2
We'll remove the unnecessary manipulation of slot_cancelled in a
subsequent patch.
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230307025828.1612809-13-tsimpson@quicinc.com>
2023-03-07 05:58:26 +03:00
|
|
|
## {
|
|
|
|
## Insn *insn __attribute__((unused)) = ctx->insn;
|
|
|
|
## const int RdN = insn->regno[0];
|
|
|
|
## TCGv RdV = get_result_gpr(ctx, RdN);
|
|
|
|
## TCGv RsV = hex_gpr[insn->regno[1]];
|
|
|
|
## TCGv RtV = hex_gpr[insn->regno[2]];
|
|
|
|
## <GEN>
|
2023-04-28 01:59:53 +03:00
|
|
|
## gen_log_reg_write(ctx, RdN, RdV);
|
Hexagon (target/hexagon) Remove gen_log_predicated_reg_write[_pair]
We assign the instruction destination register to hex_new_value[num]
instead of a TCG temp that gets copied back to hex_new_value[num].
We introduce new functions get_result_gpr[_pair] to facilitate getting
the proper destination register.
Since we preload hex_new_value for predicated instructions, we don't
need the check for slot_cancelled. So, we call gen_log_reg_write instead.
We update the helper function generation and gen_tcg.h to maintain the
disable-hexagon-idef-parser configuration.
Here is a simple example of the differences in the TCG code generated:
IN:
0x00400094: 0xf900c102 { if (P0) R2 = and(R0,R1) }
BEFORE
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
mov_i32 loc2,$0x0
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 loc2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
and_i32 tmp0,slot_cancelled,$0x8
movcond_i32 new_r2,tmp0,$0x0,loc2,new_r2,eq
mov_i32 r2,new_r2
AFTER
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 new_r2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
mov_i32 r2,new_r2
We'll remove the unnecessary manipulation of slot_cancelled in a
subsequent patch.
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230307025828.1612809-13-tsimpson@quicinc.com>
2023-03-07 05:58:26 +03:00
|
|
|
## }
|
2021-02-08 08:46:10 +03:00
|
|
|
##
|
|
|
|
## where <GEN> depends on hex_common.skip_qemu_helper(tag)
|
|
|
|
## if hex_common.skip_qemu_helper(tag) is True
|
|
|
|
## <GEN> is fGEN_TCG_A2_add({ RdV=RsV+RtV;});
|
|
|
|
## if hex_common.skip_qemu_helper(tag) is False
|
|
|
|
## <GEN> is gen_helper_A2_add(RdV, cpu_env, RsV, RtV);
|
|
|
|
##
|
|
|
|
def gen_tcg_func(f, tag, regs, imms):
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f"static void generate_{tag}(DisasContext *ctx)\n")
|
2023-03-20 12:25:33 +03:00
|
|
|
f.write("{\n")
|
2022-11-08 19:28:56 +03:00
|
|
|
|
|
|
|
f.write(" Insn *insn __attribute__((unused)) = ctx->insn;\n")
|
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.need_ea(tag):
|
|
|
|
gen_decl_ea_tcg(f, tag)
|
|
|
|
i = 0
|
2021-02-08 08:46:10 +03:00
|
|
|
## Declare all the operands (regs and immediates)
|
2023-05-24 17:41:47 +03:00
|
|
|
for regtype, regid in regs:
|
|
|
|
genptr_decl_opn(f, tag, regtype, regid, i)
|
2021-02-08 08:46:10 +03:00
|
|
|
i += 1
|
2023-03-20 12:25:33 +03:00
|
|
|
for immlett, bits, immshift in imms:
|
|
|
|
genptr_decl_imm(f, immlett)
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
if "A_PRIV" in hex_common.attribdict[tag]:
|
|
|
|
f.write(" fCHECKFORPRIV();\n")
|
|
|
|
if "A_GUEST" in hex_common.attribdict[tag]:
|
|
|
|
f.write(" fCHECKFORGUEST();\n")
|
2021-02-08 08:46:10 +03:00
|
|
|
|
|
|
|
## Read all the inputs
|
2023-05-24 17:41:47 +03:00
|
|
|
for regtype, regid in regs:
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.is_read(regid):
|
|
|
|
genptr_src_read_opn(f, regtype, regid, tag)
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2022-09-23 20:38:30 +03:00
|
|
|
if hex_common.is_idef_parser_enabled(tag):
|
|
|
|
declared = []
|
|
|
|
## Handle registers
|
2023-05-24 17:41:47 +03:00
|
|
|
for regtype, regid in regs:
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.is_pair(regid) or (
|
|
|
|
hex_common.is_single(regid)
|
|
|
|
and hex_common.is_old_val(regtype, regid, tag)
|
|
|
|
):
|
2023-03-20 12:25:32 +03:00
|
|
|
declared.append(f"{regtype}{regid}V")
|
2022-09-23 20:38:30 +03:00
|
|
|
if regtype == "M":
|
2023-03-20 12:25:32 +03:00
|
|
|
declared.append(f"{regtype}{regid}N")
|
2022-09-23 20:38:30 +03:00
|
|
|
elif hex_common.is_new_val(regtype, regid, tag):
|
2023-03-20 12:25:32 +03:00
|
|
|
declared.append(f"{regtype}{regid}N")
|
2022-09-23 20:38:30 +03:00
|
|
|
else:
|
2023-05-24 17:41:47 +03:00
|
|
|
hex_common.bad_register(regtype, regid)
|
2022-09-23 20:38:30 +03:00
|
|
|
|
|
|
|
## Handle immediates
|
2023-03-20 12:25:33 +03:00
|
|
|
for immlett, bits, immshift in imms:
|
2022-09-23 20:38:30 +03:00
|
|
|
declared.append(hex_common.imm_name(immlett))
|
|
|
|
|
|
|
|
arguments = ", ".join(["ctx", "ctx->insn", "ctx->pkt"] + declared)
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" emit_{tag}({arguments});\n")
|
2022-09-23 20:38:30 +03:00
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
elif hex_common.skip_qemu_helper(tag):
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" fGEN_TCG_{tag}({hex_common.semdict[tag]});\n")
|
2021-02-08 08:46:10 +03:00
|
|
|
else:
|
|
|
|
## Generate the call to the helper
|
2023-03-20 12:25:33 +03:00
|
|
|
for immlett, bits, immshift in imms:
|
|
|
|
gen_helper_decl_imm(f, immlett)
|
2022-11-08 19:28:59 +03:00
|
|
|
if hex_common.need_pkt_has_multi_cof(tag):
|
|
|
|
f.write(" TCGv pkt_has_multi_cof = ")
|
|
|
|
f.write("tcg_constant_tl(ctx->pkt->pkt_has_multi_cof);\n")
|
Hexagon (target/hexagon) Short-circuit packet register writes
In certain cases, we can avoid the overhead of writing to hex_new_value
and write directly to hex_gpr. We add need_commit field to DisasContext
indicating if the end-of-packet commit is needed. If it is not needed,
get_result_gpr() and get_result_gpr_pair() can return hex_gpr.
We pass the ctx->need_commit to helpers when needed.
Finally, we can early-exit from gen_reg_writes during packet commit.
There are a few instructions whose semantics write to the result before
reading all the inputs. Therefore, the idef-parser generated code is
incompatible with short-circuit. We tell idef-parser to skip them.
For debugging purposes, we add a cpu property to turn off short-circuit.
When the short-circuit property is false, we skip the analysis and force
the end-of-packet commit.
Here's a simple example of the TCG generated for
0x004000b4: 0x7800c020 { R0 = #0x1 }
BEFORE:
---- 004000b4
movi_i32 new_r0,$0x1
mov_i32 r0,new_r0
AFTER:
---- 004000b4
movi_i32 r0,$0x1
This patch reintroduces a use of check_for_attrib, so we remove the
G_GNUC_UNUSED added earlier in this series.
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Brian Cain <bcain@quicinc.com>
Message-Id: <20230427230012.3800327-12-tsimpson@quicinc.com>
2023-04-28 02:00:02 +03:00
|
|
|
if hex_common.need_pkt_need_commit(tag):
|
|
|
|
f.write(" TCGv pkt_need_commit = ")
|
|
|
|
f.write("tcg_constant_tl(ctx->need_commit);\n")
|
2021-02-08 08:46:10 +03:00
|
|
|
if hex_common.need_part1(tag):
|
2021-10-11 19:48:52 +03:00
|
|
|
f.write(" TCGv part1 = tcg_constant_tl(insn->part1);\n")
|
2021-02-08 08:46:10 +03:00
|
|
|
if hex_common.need_slot(tag):
|
2023-04-28 02:00:11 +03:00
|
|
|
f.write(" TCGv slotval = gen_slotval(ctx);\n")
|
2022-11-08 19:29:00 +03:00
|
|
|
if hex_common.need_PC(tag):
|
|
|
|
f.write(" TCGv PC = tcg_constant_tl(ctx->pkt->pc);\n")
|
2022-11-08 19:29:01 +03:00
|
|
|
if hex_common.helper_needs_next_PC(tag):
|
|
|
|
f.write(" TCGv next_PC = tcg_constant_tl(ctx->next_PC);\n")
|
2023-03-20 12:25:32 +03:00
|
|
|
f.write(f" gen_helper_{tag}(")
|
2023-03-20 12:25:33 +03:00
|
|
|
i = 0
|
2021-02-08 08:46:10 +03:00
|
|
|
## If there is a scalar result, it is the return type
|
2023-05-24 17:41:47 +03:00
|
|
|
for regtype, regid in regs:
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.is_written(regid):
|
|
|
|
if hex_common.is_hvx_reg(regtype):
|
2020-12-10 03:35:22 +03:00
|
|
|
continue
|
2023-05-24 17:41:47 +03:00
|
|
|
gen_helper_call_opn(f, tag, regtype, regid, i)
|
2021-02-08 08:46:10 +03:00
|
|
|
i += 1
|
2023-03-20 12:25:33 +03:00
|
|
|
if i > 0:
|
|
|
|
f.write(", ")
|
2021-02-08 08:46:10 +03:00
|
|
|
f.write("cpu_env")
|
2023-03-20 12:25:33 +03:00
|
|
|
i = 1
|
Hexagon (target/hexagon) Remove gen_log_predicated_reg_write[_pair]
We assign the instruction destination register to hex_new_value[num]
instead of a TCG temp that gets copied back to hex_new_value[num].
We introduce new functions get_result_gpr[_pair] to facilitate getting
the proper destination register.
Since we preload hex_new_value for predicated instructions, we don't
need the check for slot_cancelled. So, we call gen_log_reg_write instead.
We update the helper function generation and gen_tcg.h to maintain the
disable-hexagon-idef-parser configuration.
Here is a simple example of the differences in the TCG code generated:
IN:
0x00400094: 0xf900c102 { if (P0) R2 = and(R0,R1) }
BEFORE
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
mov_i32 loc2,$0x0
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 loc2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
and_i32 tmp0,slot_cancelled,$0x8
movcond_i32 new_r2,tmp0,$0x0,loc2,new_r2,eq
mov_i32 r2,new_r2
AFTER
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 new_r2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
mov_i32 r2,new_r2
We'll remove the unnecessary manipulation of slot_cancelled in a
subsequent patch.
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230307025828.1612809-13-tsimpson@quicinc.com>
2023-03-07 05:58:26 +03:00
|
|
|
## For conditional instructions, we pass in the destination register
|
2023-03-20 12:25:33 +03:00
|
|
|
if "A_CONDEXEC" in hex_common.attribdict[tag]:
|
2023-05-24 17:41:47 +03:00
|
|
|
for regtype, regid in regs:
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.is_writeonly(regid) and not hex_common.is_hvx_reg(
|
|
|
|
regtype
|
|
|
|
):
|
2023-05-24 17:41:47 +03:00
|
|
|
gen_helper_call_opn(f, tag, regtype, regid, i)
|
Hexagon (target/hexagon) Remove gen_log_predicated_reg_write[_pair]
We assign the instruction destination register to hex_new_value[num]
instead of a TCG temp that gets copied back to hex_new_value[num].
We introduce new functions get_result_gpr[_pair] to facilitate getting
the proper destination register.
Since we preload hex_new_value for predicated instructions, we don't
need the check for slot_cancelled. So, we call gen_log_reg_write instead.
We update the helper function generation and gen_tcg.h to maintain the
disable-hexagon-idef-parser configuration.
Here is a simple example of the differences in the TCG code generated:
IN:
0x00400094: 0xf900c102 { if (P0) R2 = and(R0,R1) }
BEFORE
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
mov_i32 loc2,$0x0
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 loc2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
and_i32 tmp0,slot_cancelled,$0x8
movcond_i32 new_r2,tmp0,$0x0,loc2,new_r2,eq
mov_i32 r2,new_r2
AFTER
---- 00400094
mov_i32 slot_cancelled,$0x0
mov_i32 new_r2,r2
and_i32 tmp0,p0,$0x1
brcond_i32 tmp0,$0x0,eq,$L1
and_i32 tmp0,r0,r1
mov_i32 new_r2,tmp0
br $L2
set_label $L1
or_i32 slot_cancelled,slot_cancelled,$0x8
set_label $L2
mov_i32 r2,new_r2
We'll remove the unnecessary manipulation of slot_cancelled in a
subsequent patch.
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230307025828.1612809-13-tsimpson@quicinc.com>
2023-03-07 05:58:26 +03:00
|
|
|
i += 1
|
2023-05-24 17:41:47 +03:00
|
|
|
for regtype, regid in regs:
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.is_written(regid):
|
|
|
|
if not hex_common.is_hvx_reg(regtype):
|
2020-12-10 03:35:22 +03:00
|
|
|
continue
|
2023-05-24 17:41:47 +03:00
|
|
|
gen_helper_call_opn(f, tag, regtype, regid, i)
|
2020-12-10 03:35:22 +03:00
|
|
|
i += 1
|
2023-05-24 17:41:47 +03:00
|
|
|
for regtype, regid in regs:
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.is_read(regid):
|
|
|
|
if hex_common.is_hvx_reg(regtype) and hex_common.is_readwrite(regid):
|
2020-12-10 03:35:22 +03:00
|
|
|
continue
|
2023-05-24 17:41:47 +03:00
|
|
|
gen_helper_call_opn(f, tag, regtype, regid, i)
|
2021-02-08 08:46:10 +03:00
|
|
|
i += 1
|
2023-03-20 12:25:33 +03:00
|
|
|
for immlett, bits, immshift in imms:
|
|
|
|
gen_helper_call_imm(f, immlett)
|
2021-02-08 08:46:10 +03:00
|
|
|
|
2022-11-08 19:28:59 +03:00
|
|
|
if hex_common.need_pkt_has_multi_cof(tag):
|
|
|
|
f.write(", pkt_has_multi_cof")
|
Hexagon (target/hexagon) Short-circuit packet register writes
In certain cases, we can avoid the overhead of writing to hex_new_value
and write directly to hex_gpr. We add need_commit field to DisasContext
indicating if the end-of-packet commit is needed. If it is not needed,
get_result_gpr() and get_result_gpr_pair() can return hex_gpr.
We pass the ctx->need_commit to helpers when needed.
Finally, we can early-exit from gen_reg_writes during packet commit.
There are a few instructions whose semantics write to the result before
reading all the inputs. Therefore, the idef-parser generated code is
incompatible with short-circuit. We tell idef-parser to skip them.
For debugging purposes, we add a cpu property to turn off short-circuit.
When the short-circuit property is false, we skip the analysis and force
the end-of-packet commit.
Here's a simple example of the TCG generated for
0x004000b4: 0x7800c020 { R0 = #0x1 }
BEFORE:
---- 004000b4
movi_i32 new_r0,$0x1
mov_i32 r0,new_r0
AFTER:
---- 004000b4
movi_i32 r0,$0x1
This patch reintroduces a use of check_for_attrib, so we remove the
G_GNUC_UNUSED added earlier in this series.
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Brian Cain <bcain@quicinc.com>
Message-Id: <20230427230012.3800327-12-tsimpson@quicinc.com>
2023-04-28 02:00:02 +03:00
|
|
|
if hex_common.need_pkt_need_commit(tag):
|
|
|
|
f.write(", pkt_need_commit")
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.need_PC(tag):
|
|
|
|
f.write(", PC")
|
|
|
|
if hex_common.helper_needs_next_PC(tag):
|
|
|
|
f.write(", next_PC")
|
|
|
|
if hex_common.need_slot(tag):
|
2023-04-28 02:00:11 +03:00
|
|
|
f.write(", slotval")
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.need_part1(tag):
|
|
|
|
f.write(", part1")
|
2021-02-08 08:46:10 +03:00
|
|
|
f.write(");\n")
|
|
|
|
|
|
|
|
## Write all the outputs
|
2023-05-24 17:41:47 +03:00
|
|
|
for regtype, regid in regs:
|
2023-03-20 12:25:33 +03:00
|
|
|
if hex_common.is_written(regid):
|
|
|
|
genptr_dst_write_opn(f, regtype, regid, tag)
|
2021-02-08 08:46:10 +03:00
|
|
|
|
|
|
|
f.write("}\n\n")
|
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2021-02-08 08:46:10 +03:00
|
|
|
def gen_def_tcg_func(f, tag, tagregs, tagimms):
|
|
|
|
regs = tagregs[tag]
|
|
|
|
imms = tagimms[tag]
|
|
|
|
|
|
|
|
gen_tcg_func(f, tag, regs, imms)
|
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2021-02-08 08:46:10 +03:00
|
|
|
def main():
|
|
|
|
hex_common.read_semantics_file(sys.argv[1])
|
|
|
|
hex_common.read_attribs_file(sys.argv[2])
|
|
|
|
hex_common.read_overrides_file(sys.argv[3])
|
2021-05-18 20:01:09 +03:00
|
|
|
hex_common.read_overrides_file(sys.argv[4])
|
2021-02-08 08:46:10 +03:00
|
|
|
hex_common.calculate_attribs()
|
2022-09-23 20:38:30 +03:00
|
|
|
## Whether or not idef-parser is enabled is
|
|
|
|
## determined by the number of arguments to
|
|
|
|
## this script:
|
|
|
|
##
|
|
|
|
## 5 args. -> not enabled,
|
|
|
|
## 6 args. -> idef-parser enabled.
|
|
|
|
##
|
|
|
|
## The 6:th arg. then holds a list of the successfully
|
|
|
|
## parsed instructions.
|
|
|
|
is_idef_parser_enabled = len(sys.argv) > 6
|
|
|
|
if is_idef_parser_enabled:
|
|
|
|
hex_common.read_idef_parser_enabled_file(sys.argv[5])
|
2021-02-08 08:46:10 +03:00
|
|
|
tagregs = hex_common.get_tagregs()
|
|
|
|
tagimms = hex_common.get_tagimms()
|
|
|
|
|
2022-09-23 20:38:30 +03:00
|
|
|
output_file = sys.argv[-1]
|
2023-03-20 12:25:33 +03:00
|
|
|
with open(output_file, "w") as f:
|
2021-02-08 08:46:10 +03:00
|
|
|
f.write("#ifndef HEXAGON_TCG_FUNCS_H\n")
|
|
|
|
f.write("#define HEXAGON_TCG_FUNCS_H\n\n")
|
2022-09-23 20:38:30 +03:00
|
|
|
if is_idef_parser_enabled:
|
2023-03-20 12:25:33 +03:00
|
|
|
f.write('#include "idef-generated-emitter.h.inc"\n\n')
|
2021-02-08 08:46:10 +03:00
|
|
|
|
|
|
|
for tag in hex_common.tags:
|
|
|
|
## Skip the priv instructions
|
2023-03-20 12:25:33 +03:00
|
|
|
if "A_PRIV" in hex_common.attribdict[tag]:
|
2021-02-08 08:46:10 +03:00
|
|
|
continue
|
|
|
|
## Skip the guest instructions
|
2023-03-20 12:25:33 +03:00
|
|
|
if "A_GUEST" in hex_common.attribdict[tag]:
|
2021-02-08 08:46:10 +03:00
|
|
|
continue
|
|
|
|
## Skip the diag instructions
|
2023-03-20 12:25:33 +03:00
|
|
|
if tag == "Y6_diag":
|
2021-02-08 08:46:10 +03:00
|
|
|
continue
|
2023-03-20 12:25:33 +03:00
|
|
|
if tag == "Y6_diag0":
|
2021-02-08 08:46:10 +03:00
|
|
|
continue
|
2023-03-20 12:25:33 +03:00
|
|
|
if tag == "Y6_diag1":
|
2021-02-08 08:46:10 +03:00
|
|
|
continue
|
|
|
|
|
|
|
|
gen_def_tcg_func(f, tag, tagregs, tagimms)
|
|
|
|
|
|
|
|
f.write("#endif /* HEXAGON_TCG_FUNCS_H */\n")
|
|
|
|
|
2023-03-20 12:25:33 +03:00
|
|
|
|
2021-02-08 08:46:10 +03:00
|
|
|
if __name__ == "__main__":
|
|
|
|
main()
|