mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix cases of discarding result from list API functions

Browse Source 
Two cases violated list APIs by throwing away the return value.  While
the code was technically correct, it relied on internal knowledge of
the list implementation, and the code wasn't really gaining anything
that way.  It is planned to make this a compiler warning in the
future, so just fix these cases by assigning the return value
properly.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://www.postgresql.org/message-id/flat/e3753562-99cd-b65f-5aca-687dfd1ec2fc@2ndquadrant.com
This commit is contained in:
Peter Eisentraut 2020-10-17 08:38:39 +02:00
parent ec29427ce2
commit c77f6f50e4
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/commands/lockcmds.c
View File

@ -266,7 +266,7 @@ LockViewRecurse(Oid reloid, LOCKMODE lockmode, bool nowait,
LockViewRecurse_walker((Node *) viewquery, &context);
(void) list_delete_last(context.ancestor_views);
context.ancestor_views = list_delete_last(context.ancestor_views);
table_close(view, NoLock);
}

3
src/backend/parser/analyze.c
View File

@ -1475,8 +1475,7 @@ transformValuesClause(ParseState *pstate, SelectStmt *stmt)
Node *col = (Node *) lfirst(lc);
List *sublist = lfirst(lc2);
/* sublist pointer in exprsLists won't need adjustment */
(void) lappend(sublist, col);
sublist = lappend(sublist, col);
}
list_free(colexprs[i]);
}