From c77f6f50e4187bed38d1d36ae16b0c248e286d15 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut <peter@eisentraut.org> Date: Sat, 17 Oct 2020 08:38:39 +0200 Subject: [PATCH] Fix cases of discarding result from list API functions Two cases violated list APIs by throwing away the return value. While the code was technically correct, it relied on internal knowledge of the list implementation, and the code wasn't really gaining anything that way. It is planned to make this a compiler warning in the future, so just fix these cases by assigning the return value properly. Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://www.postgresql.org/message-id/flat/e3753562-99cd-b65f-5aca-687dfd1ec2fc@2ndquadrant.com --- src/backend/commands/lockcmds.c | 2 +- src/backend/parser/analyze.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/backend/commands/lockcmds.c b/src/backend/commands/lockcmds.c index 2846ef3b7b..098227656a 100644 --- a/src/backend/commands/lockcmds.c +++ b/src/backend/commands/lockcmds.c @@ -266,7 +266,7 @@ LockViewRecurse(Oid reloid, LOCKMODE lockmode, bool nowait, LockViewRecurse_walker((Node *) viewquery, &context); - (void) list_delete_last(context.ancestor_views); + context.ancestor_views = list_delete_last(context.ancestor_views); table_close(view, NoLock); } diff --git a/src/backend/parser/analyze.c b/src/backend/parser/analyze.c index 575e22ce0d..084e00f73d 100644 --- a/src/backend/parser/analyze.c +++ b/src/backend/parser/analyze.c @@ -1475,8 +1475,7 @@ transformValuesClause(ParseState *pstate, SelectStmt *stmt) Node *col = (Node *) lfirst(lc); List *sublist = lfirst(lc2); - /* sublist pointer in exprsLists won't need adjustment */ - (void) lappend(sublist, col); + sublist = lappend(sublist, col); } list_free(colexprs[i]); }