mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix copy-paste mistake in PQcancelCreate

Browse Source 
When an OOM occurred, this function was incorrectly setting a status of
CONNECTION_BAD on the passed in PGconn instead of on the newly created
PGcancelConn.

Mistake introduced with 61461a300c1c.  Backpatch to 17.

Author: Jelte Fennema-Nio <postgres@jeltef.nl>
Reported-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/20240630190040.26.nmisch@google.com
This commit is contained in:
Alvaro Herrera 2024-07-01 13:58:22 +02:00
parent 12227a1d5f
commit 3497c87b05
No known key found for this signature in database
GPG Key ID: 1C20ACB9D5C564AE
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/interfaces/libpq/fe-cancel.c
View File

@ -155,7 +155,7 @@ PQcancelCreate(PGconn *conn)
return (PGcancelConn *) cancelConn; return (PGcancelConn *) cancelConn;
oom_error: oom_error:
conn->status = CONNECTION_BAD; cancelConn->status = CONNECTION_BAD;
libpq_append_conn_error(cancelConn, "out of memory"); libpq_append_conn_error(cancelConn, "out of memory");
return (PGcancelConn *) cancelConn; return (PGcancelConn *) cancelConn;
} }