From 3497c87b05a6ba31e8d760591900d550b2ef98bc Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Mon, 1 Jul 2024 13:58:22 +0200 Subject: [PATCH] Fix copy-paste mistake in PQcancelCreate When an OOM occurred, this function was incorrectly setting a status of CONNECTION_BAD on the passed in PGconn instead of on the newly created PGcancelConn. Mistake introduced with 61461a300c1c. Backpatch to 17. Author: Jelte Fennema-Nio Reported-by: Noah Misch Discussion: https://postgr.es/m/20240630190040.26.nmisch@google.com --- src/interfaces/libpq/fe-cancel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/interfaces/libpq/fe-cancel.c b/src/interfaces/libpq/fe-cancel.c index 3b6206ea7f..9562a7fe44 100644 --- a/src/interfaces/libpq/fe-cancel.c +++ b/src/interfaces/libpq/fe-cancel.c @@ -155,7 +155,7 @@ PQcancelCreate(PGconn *conn) return (PGcancelConn *) cancelConn; oom_error: - conn->status = CONNECTION_BAD; + cancelConn->status = CONNECTION_BAD; libpq_append_conn_error(cancelConn, "out of memory"); return (PGcancelConn *) cancelConn; }