I've not been able to test this, but since Sprow was also the original
reporter, it seems safe to apply.
Bug #2336: Colours rendered incorrectly in 4k and 64k colour modes.
The translated message loading is dependant on configuration of
resource location in each frontend, additionally they should have the
ability to deal with errors in this loading in a implementation
specific manner.
This also extends the message loading API to be capable of loading
from an inline memory buffer instead of from a file.
This changes the LOG macro to be varadic removing the need for all
callsites to have double bracketing and allows for future improvement
on how we use the logging macros.
The callsites were changed with coccinelle and the changes checked by
hand. Compile tested for several frontends but not all.
A formatting annotation has also been added which allows the compiler
to check the parameters and types passed to the logging.
The RISC OS bitmap header was including several headers it simply did
not require. This removed those includes and also cleans up the
documentation comments to completely cover the exported interface.
The target url was previously being passed as a string derived from
nsurl_access which was asserting if the target_url was NULL. The nsurl
is now passed and a null check performed before attempting to access
it.
Closes#2298
Currently, when asked for clipboard data, Netsurf unconditionally closes the
menu tree of the requesting application. This occurs in the routine
ro_gui_send_datasave. There is no reason to close the menu tree: this function
is called in only one place, amd the code path is through Wimp user messages--
the highest priority type of message, so other interactions cannot interfere.
The fix removes the line which closes the menu tree in this particular function.
RISC OS apps take their creation date from the !RunImage apparently
and loose the data if the application directory gets copied without
one. Fixes#1970
The content thumbnailers for each frontend were being provided the
contents url. This was only ever used to call the urldb thumbnail
setting API.
This changes it so the single callsite that passed a valid url adds
the bitmap to that url itself in desktop_history.c instead of forcing
every frontend to require the urldb API.
Additionally the old API could pass the url as NULL which was causing
asserts where this was not an expected parameter value. Because of
this this fixes bug #2286 which was also present in the monkey
frontend as both called nsurl_access() on the url without the NULL
check and caused an assertion.
When the form entry changes were made the RISC OS implementation was
updated but the loop that counts entries was using an incorrect loop
iterator variable which was never incremented hence causing an
infinite loop.
By hiding all but the form selection menu option structure from code
outside of render this reduces the API to the absolute minimum to
support this feature.
