Commit Graph

59 Commits

Author SHA1 Message Date
John Mark Bell 732d940744 Stop ro_gui_get_icon_string() returning a pointer to a location on the stack.
Make explicit the semantics that strings returned from this call are transient
and will be invalidated by subsequent calls.

svn path=/trunk/netsurf/; revision=7645
2009-05-30 00:26:04 +00:00
John Mark Bell e240c200d5 Avoid potentially unsafe writes through a const pointer.
svn path=/trunk/netsurf/; revision=6974
2009-03-28 19:59:46 +00:00
John Mark Bell e97bc3b178 Squash warnings. Tidy code. Make last_sprite_found static and locally scoped.
svn path=/trunk/netsurf/; revision=6907
2009-03-27 01:14:42 +00:00
John Tytgat c40fc354b3 - Teached ro_gui_set_icon_string() and ro_gui_get_icon_string() about the difference between direct and indirect icons.
- ro_gui_get_icon_string(): 
    - Constify return value of ro_gui_get_icon_string() as you really shouldn't change its contents via this pointer.
    - Enfore NUL string termination as return value (instead of other control char termination) 
- Merged ro_gui_set_icon_string_le() into ro_gui_set_icon_string() by adding ro_gui_set_icon_string() and extra to_utf8 parameter.
- ro_gui_strncmp(): added

svn path=/trunk/netsurf/; revision=4907
2008-08-05 01:23:04 +00:00
John Tytgat 5f6c2cbff7 - Compiler warning squash
- Changed a lineending \n\r -> \n for a couple of files.
- More code style conformance.

svn path=/trunk/netsurf/; revision=4762
2008-07-26 22:29:15 +00:00
John Mark Bell 23fb72ea6b The core code has always assumed a locale of "C".
Do not change the locale globally, else things will break in weird and 
wonderful ways.

Introduce utils/locale.[ch], which provide locale-specific wrappers for various 
functions (currently just the <ctype.h> ones).

Fix up the few places I can see that actually require that the underlying 
locale is paid attention to.

Some notes:

  1) The GTK frontend code has not been touched. It is possible that reading of 
     numeric values (e.g. from the preferences dialogue) may break with this 
     change, particularly in locales that use something other than '.' as their
     decimal separator.
  2) The search code is left unchanged (i.e. assuming a locale of "C"). 
     This may break case insensitive matching of non-ASCII characters. 
     I doubt that ever actually worked, anyway. In future, it should use
     Unicode case conversion to achieve the same effect.
  3) The text input handling in the core makes use of isspace() to detect
     word boundaries. This is fine for western languages (even in the C locale,
     which it's currently assuming). It will, however, break for CJK et. al. 
     (this has always been the case, rather than being a new issue)
  4) text-transform uses locale-specific variants of to{lower,upper}. In future
     this should probably be performing Unicode case conversion. This is the
     only part of the core code that makes use of locale information.

In future, if you require locale-specific behaviour, do the following:

  setlocale(LC_<whatever>, "");
  <your operation(s) here>
  setlocale(LC_<whatever>, "C");

  The first setlocale will change the current locale to the native environment.
  The second setlocale will reset the current locale to "C".
  Any value other than "" or "C" is probably a bug, unless there's a really
  good reason for it.

In the long term, it is expected that all locale-dependent code will reside in 
platform frontends -- the core being wholly locale agnostic (though assuming 
"C" for things like decimal separators).


svn path=/trunk/netsurf/; revision=4153
2008-05-13 14:37:44 +00:00
Adrian Lees aefa03aed9 Save non-opaque images with a proper mask/full alpha channel
svn path=/trunk/netsurf/; revision=4047
2008-03-24 01:35:13 +00:00
John Tytgat 79022d8ec2 Foresee OSLib 7 and pre-OSLib 7 compatibility
svn path=/trunk/netsurf/; revision=3913
2008-03-10 00:51:51 +00:00
Richard Wilson 693051471b Check the RAM sprite pool before the ROM sprite pool (fix 1781184)
svn path=/trunk/netsurf/; revision=3628
2007-10-09 17:49:48 +00:00
Vincent Sanders 2f864eeecc Update all source code file headers to reflect GPL version 2 only and contain appropriate licence text
svn path=/trunk/netsurf/; revision=3486
2007-08-08 16:16:03 +00:00
John Mark Bell c1531c449f Fix string length measurement for strings in icons; if the string came from the templates file, it will be LF terminated, not NUL terminated. Therefore, use a strlen variant that terminates on control characters, rather than just \0. This prevents reading memory beyond the end of the string.
svn path=/trunk/netsurf/; revision=3475
2007-08-04 11:47:40 +00:00
Daniel Silverstone 6807b4208a Remove the netsurf/ from the include paths and rationalise use of <> vs "" in includes
NetSurf includes are now done with ""s and other system includes with <>s as C intended.
The scandeps tool has been updated to only look for ""ed includes, and to verify that the
files exist in the tree before adding them to the dependency lines. The depend rule has
therefore been augmented to make sure the autogenerated files are built before it is run.

This is untested under self-hosted RISC OS builds. All else tested and works.


svn path=/trunk/netsurf/; revision=3307
2007-05-30 22:39:54 +00:00
Richard Wilson b5a14773ff Correctly calculate maximised frame heights (fix 1644216)
svn path=/trunk/netsurf/; revision=3193
2007-03-03 20:49:49 +00:00
Michael Drake ba23e4b693 Update project URL.
svn path=/trunk/netsurf/; revision=3073
2006-11-27 15:35:18 +00:00
John Mark Bell 6c7323fded Squash memory leak.
Ensure that the icon string's always set to something, even if it's the 
UTF-8 text if we're unable to convert to the local encoding.

svn path=/trunk/netsurf/; revision=2965
2006-09-25 22:27:41 +00:00
James Bursa 8343f4f37a Move ro_gui_wimp_desktop_font() from wimp.c to font.c. Simplify code and add logging of result.
svn path=/trunk/netsurf/; revision=2876
2006-08-21 03:11:44 +00:00
John Mark Bell c6eeed815e Fix buffer overrun & squash compiler warning.
svn path=/trunk/netsurf/; revision=2864
2006-08-17 23:41:29 +00:00
Adrian Lees 748e38ab87 Use desktop font
svn path=/trunk/netsurf/; revision=2778
2006-07-18 01:51:19 +00:00
Richard Wilson 00d74fdd2d Allow the viewing of the entire SSL certificate chain.
svn path=/trunk/netsurf/; revision=2755
2006-07-16 00:21:15 +00:00
Richard Wilson 546bf17a7f Add relevent extensions to allow treeviews to be used as an embedded list component.
svn path=/trunk/netsurf/; revision=2753
2006-07-15 15:39:33 +00:00
Richard Wilson 3d6331efd7 Only check caret position for writable icons.
svn path=/trunk/netsurf/; revision=2667
2006-06-28 22:58:58 +00:00
John Mark Bell 5adef63ac5 Localise configure icon strings when appropriate.
Fix gright menu handling - now writes into display field without 
attempting to localise the selection string - it's already localised.
Update German Messages file appropriately.

svn path=/trunk/netsurf/; revision=2638
2006-06-20 21:35:33 +00:00
Richard Wilson 04147f020e [project @ 2006-04-06 22:39:53 by rjw]
Fix documentation.

svn path=/import/netsurf/; revision=2497
2006-04-06 22:39:53 +00:00
Adrian Lees dbfdafdf18 [project @ 2006-02-15 23:09:53 by adrianl]
Extend text selection, copying, saving and searching code to handle textplain contents; modified textplain code to accept other line terminators

svn path=/import/netsurf/; revision=2081
2006-02-15 23:09:55 +00:00
Adrian Lees bdbe7e8e51 [project @ 2006-02-07 16:32:47 by adrianl]
Added function to bring window to front

svn path=/import/netsurf/; revision=2062
2006-02-07 16:32:47 +00:00
Richard Wilson a3759ab0ef [project @ 2006-01-04 17:26:43 by rjw]
Optimise searching for sprites.

svn path=/import/netsurf/; revision=1979
2006-01-04 17:26:43 +00:00
Richard Wilson 8733cf9836 [project @ 2006-01-03 01:37:25 by rjw]
Move the caret from writable icons when shading.

svn path=/import/netsurf/; revision=1972
2006-01-03 01:37:25 +00:00
Richard Wilson be9c1c9409 [project @ 2006-01-02 22:05:53 by rjw]
Remove redundant code.

svn path=/import/netsurf/; revision=1958
2006-01-02 22:05:53 +00:00
Richard Wilson d1094d1238 [project @ 2005-12-31 04:40:48 by rjw]
Use new wimp_event system.

svn path=/import/netsurf/; revision=1916
2005-12-31 04:40:49 +00:00
Richard Wilson 57948a3746 [project @ 2005-12-01 01:22:23 by rjw]
Add function to check for specific window furniture

svn path=/import/netsurf/; revision=1889
2005-12-01 01:22:23 +00:00
Adrian Lees f8750d2d4d [project @ 2005-07-24 03:13:33 by adrianl]
Correct comment

svn path=/import/netsurf/; revision=1818
2005-07-24 03:13:33 +00:00
John Mark Bell f4ecaaed31 [project @ 2005-07-16 14:35:20 by jmb]
- Convert Messages files to UTF-8 encoding.
- Replace local_encoding_name() with platform specific
  utf8_[to,from]_local_encoding() functions - this allows mapping of 8bit
  characters 0x80->0x9f (inclusive).
- All text that is rendered by the RISC OS Wimp is now converted to the system
  local encoding prior to display.
- Lose the horrendous hack that was messages_get_key()
- Menu text is now translated to system local encoding on the fly (if necessary)
  rather than at menu creation time. This allows the system alphabet to change
  under us and our menus remain usable.
- The Languages menu now lists all languages that are present in the LangNames
  file. In the case of selecting the UI language, those languages which are not
  available are shaded.

svn path=/import/netsurf/; revision=1796
2005-07-16 14:35:25 +00:00
Adrian Lees 4a5dc6d5cc [project @ 2005-07-16 05:54:45 by adrianl]
Thumbnails displayed and dragged for full page save; spelling correction

svn path=/import/netsurf/; revision=1793
2005-07-16 05:54:45 +00:00
Richard Wilson e08d9e7263 [project @ 2005-04-12 19:09:09 by rjw]
Round value up when going from OS units to pixels.

svn path=/import/netsurf/; revision=1625
2005-04-12 19:09:09 +00:00
Richard Wilson bc43904af9 [project @ 2005-04-09 14:58:54 by rjw]
Don't expect the wimp to behave sensibly and return errors when it should.

svn path=/import/netsurf/; revision=1616
2005-04-09 14:58:54 +00:00
Richard Wilson b7d0f95486 [project @ 2005-04-09 13:23:55 by rjw]
Fallback to default window furniture sizes.

svn path=/import/netsurf/; revision=1612
2005-04-09 13:23:55 +00:00
Richard Wilson 610fca368b [project @ 2005-04-07 20:46:22 by rjw]
Update to the way menus are handled. Various GUI bug fixes.

svn path=/import/netsurf/; revision=1603
2005-04-07 20:46:22 +00:00
Richard Wilson 501da1c487 [project @ 2005-03-14 13:58:43 by rjw]
Minimise flicker when viewing non-HTML files.

svn path=/import/netsurf/; revision=1535
2005-03-14 13:58:43 +00:00
Richard Wilson 422df90089 [project @ 2005-01-23 16:09:05 by rjw]
Further work on theme installing

svn path=/import/netsurf/; revision=1463
2005-01-23 16:09:05 +00:00
Richard Wilson 32db7e04d0 [project @ 2004-12-09 10:30:43 by rjw]
Re-implementation of hotlist via general tree code. Animations can be stopped once more. Purged a few xcalloc() calls.

svn path=/import/netsurf/; revision=1394
2004-12-09 10:30:44 +00:00
Richard Wilson fceba6cbc6 [project @ 2004-09-01 16:48:25 by rjw]
Fix for previous stupidity.

svn path=/import/netsurf/; revision=1260
2004-09-01 16:48:25 +00:00
Richard Wilson 13ae21f22b [project @ 2004-08-31 19:51:29 by rjw]
Remove flicker from repeatedly setting icons as shaded.

svn path=/import/netsurf/; revision=1259
2004-08-31 19:51:29 +00:00
Richard Wilson a8661b3a64 [project @ 2004-08-31 18:01:22 by rjw]
Further theme related fixes

svn path=/import/netsurf/; revision=1257
2004-08-31 18:01:22 +00:00
Richard Wilson 98d17f19a6 [project @ 2004-08-30 21:57:47 by rjw]
Various small theme related fixes

svn path=/import/netsurf/; revision=1256
2004-08-30 21:57:47 +00:00
Richard Wilson bf57d852ae [project @ 2004-08-30 21:03:48 by rjw]
Reworking of themes and toolbars.

svn path=/import/netsurf/; revision=1254
2004-08-30 21:03:48 +00:00
John Mark Bell 07baa16e05 [project @ 2004-08-09 06:29:46 by jmb]
Ignore shaded text inputs when finding a place for the caret

svn path=/import/netsurf/; revision=1200
2004-08-09 06:29:46 +00:00
James Bursa 534b464bec [project @ 2004-07-27 15:49:28 by bursa]
Implement proxy authentication. Bring templates in line with style guide (icon sizes and fill display fields), and remove dead icons. Clean up choices dialog code. Fix persistent dialog code. Make browser choices the default pane.

svn path=/import/netsurf/; revision=1153
2004-07-27 15:49:28 +00:00
Richard Wilson d89753a11b [project @ 2004-07-21 20:02:13 by rjw]
Less compiler warnings. Fixed create_folder window title indirection from being too small. Support for help keys for greyed out menu items/icons.

svn path=/import/netsurf/; revision=1135
2004-07-21 20:02:13 +00:00
Richard Wilson abaa8a9093 [project @ 2004-07-16 16:33:44 by rjw]
Various fixes for the GUI. Persistant windows are closed when upon a change of content. Hotlist saves in the same format as !Browse. Neater login window. Support for interactive help from hotlist windows.

svn path=/import/netsurf/; revision=1081
2004-07-16 16:33:45 +00:00
Richard Wilson 6e3995cc65 [project @ 2004-07-11 21:45:51 by rjw]
Inversion of hotlist icon functionality. Automatic placement of caret for dialog windows. Escape closes dialog windows.

svn path=/import/netsurf/; revision=1071
2004-07-11 21:45:51 +00:00