* 4590_ext2attr_errno:
(copy_dir_dir): clarify get of mode and attributes of source directory.
file operations: rename actions and button names:
Clarify messages of get/set ext2 attributes errors.
Ticket #4590: clarify handling of ext2 attributes errors.
Don't show an error message if mc_fgetflags() and mc_fsetflags()
fails and errno set to ENOTSUP, EOPNOTSUPP, ENOSYS, and EINVAL.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
* 4598_tar_segfault:
tar: initialize variables passed to stoint().
(decode_num): simplify expression.
Ticket #4598: fix segfault on open TAR archive.
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
(decode_timespec): fix incorrect assignment of variable.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
Fix comparison of integer expressions of different signedness.
Reduce variable scope.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
* lib/intprops.h: new file.
* src/vfs/tar/tar-internal.h: include intprops.h, remove macros
defined there.
* src/vfs/tar/tar-sparse.c: remove macro, defined in intprops.h.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
Reduce variable scope. Get rid of extra NULL check: g_strdup() handles
NULL correctly. Remove intermediate variable.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Simplify the code by assuming C99 initializers.
* (base_64_digits): Remove; no longer needed.
* (base64_map): Now a constant. Initialized statically,
and with invalid entries being 0 not 64, and with valid
entries being 1 greater than before.
* (tar_base64_init): Remove; only use removed.
* (tar_from_header): Adjust to new values in base64_map.
Sync with GNU tar 43231ae554d0dacbcc32e2d0fe574c9d0e183258.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
* (tar_checksum): recode to avoid casts.
* (tar_from_header): likewise.
Sync with GNU tar 1521d3dae01f91606c639eb745ea565ef723e38d.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
When parsing numbers prefer using strtosysint() (renamed stoint)
to using strtoul() and its variants.
This is simpler and faster and likely more reliable than
relying on quirks of the system strtoul() etc,
and it standardizes how tar deals with parsing integers.
Among other things, the C standard and POSIX don't specify
what strtol() does to errno when conversions cannot be performed,
and it requires strtoul() to support "-" before unsigned numbers.
* (stoint): rename from strtosysint, move to tar-internal.c and add
a gboollean * argument for reporting overflow. All callers changed.
* (decode_num): prefer stoint() to strtol() etc. Don't rely on
errno == EINVAL as the standards don't guarantee it.
* (decode_signed_num): likewise.
* (decode_record): likewise.
* (sparse_map_decoder): likewise.
* (decode_timespec): Simplify by using ckd_sub() rather than checking
for overflow by hand.
* tar-sparse.c: remove include of errno.h, it's no lomger used.
* tar-xheader.c: likewise
Sync with GNU tar d1e72a536f26188230a147d948b9057714fd0b6b.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Don't limit blocking factor to INT_MAX.
Prefer signed type for record_size.
Do not exceed IDX_MAX or SSIZE_MAX for record_size;
the SSIZE_MAX limit is needed so that "read" calls behave sensibly.
Sync with GNU tar 3ffe2eb0738504aabee0d3b4d0c03e01739b9d6c.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
This shouldn't affect behavior; it's just a cleanup.
Sync with GNU tar eb9bb9bf8049522230a0654c3f32e6373b945254.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
This is part of the general trend to prefer signed integer types,
to allow better runtime checking with -fsanitize=undefined etc.
* (struct tar_stat_info): ue intmax_t, not unsigned, for sparse major
and minor.
* (tar_sparse_major): likewise.
* (tar_sparse_minor): likewise.
Sync with GNU tar 4642cd04edbd57414e004920fa4976d9f3be6206.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
