mirrors
/
mc
mirror of https://github.com/MidnightCommander/mc
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
15,137 Commits 49 Branches 83 Tags 88 MiB
Commit Graph

15137 Commits

Author SHA1 Message Date
Andrew Borodin 6b9a2bbd48 Update po/*.po files. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:46 +03:00
Andrew Borodin eb58d94341 src/filemanager/mountlist.c: recognize fuse.portal as dummy file system. 
Sync with gnulib 9a38d499ca16f2f4304992eb1ab0894cd0b478e1.

Add "fuse.portal" as a dummy file system (used in flatpak
implementations).

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:46 +03:00
Andrew Borodin 25e419ba08 (check_dir_is_empty): minor optimization. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin 437994eb80 (do_move_dir_dir): remove unused variable. 
Variable calc_total is set but isn't read.

Found by Andreas Mohr <and@gmx.li>.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin 106d95229f (sftpfs_open_file): don't destroy file handler here. 
Fix Coverity id #331814.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andreas Mohr db3b30ebea (mc_serialize_config): fix memory leak. 
Found by Coverity.
Coverity id #331818.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andreas Mohr 10c27b28a7 (load_group): fix use after free. 
Found by Coverity.
Coverity id #331812.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andreas Mohr c15b752fbf (exec_extension): fix memory leak. 
Found by Coverity.
Coverity id #331829.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andreas Mohr 4db80f3010 (dir_list_reload): fix resource leak. 
Found by Coverity.
Coverity id #331809.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin 5b7b48e1db mcedit: move macros-related stuff to editmacros.[ch]. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin 0df10f488b (extfs_open_archive): fix NULL dereferences. 
Fix passing NULL pointer "tmp" to g_strconcat().

Found by Coverity.
Coverity is #331840.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin 6efddd7380 (vfs_findgid): fix overrunning string. 
Fix out-of-boundary access to gname if it's shorter than 255 bytes.

Found by Coverity.
Coverity id #331844.

Fix macro name that is used for array size.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin 2dfdc6d690 (vfs_finduid): fix overrunning string. 
Fix out-of-boundary access to uname if it's shorter than 255 bytes.

Found by Coverity.
Coverity id #331835.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin 2d4008655e (exec_make_shell_string): simplify condition, reduce variable scope. 
Fix Coverity id #331832.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin 69b8927ec9 (panel_recursive_cd_to_parent): fix memory leak. 
Found by Coverity.
Coverity id #331846.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin b6a169cc24 (mc_skin_color_parse_ini_file): fix memory leak. 
Found by Coverity.
Coverity id #331849.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andreas Mohr 4070d7bee5 (apply_rules_going_right): fix deadcode.DeadStores warning. 
syntax.c:523:25: warning: Value stored to 'found_right' is never read [deadcode.DeadStores]
                        found_right = TRUE;
                        ^             ~~~~

Found by Clang-11 analyzer.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andreas Mohr 337da4491d (edit_replace_cmd): fix deadcode.DeadStores warning. 
editsearch.c:915:13: warning: Value stored to 'i' is never read [deadcode.DeadStores]
            i = edit->found_len = len;
            ^   ~~~~~~~~~~~~~~~~~~~~~

Found by Clang-11 analyzer.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andreas Mohr 9b752e3a2f (edit_draw_this_line): fix deadcode.DeadStores warning. 
editdraw.c:536:5: warning: Value stored to 'color' is never read [deadcode.DeadStores]
    color = edit_get_syntax_color (edit, b - 1);
    ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found by Clang-11 analyzer.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin 22a7ef782d (edit_do_search): search descriptor should not be NULL. 
Fix of Coverity id #110818.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin a7b8d00535 (background_attention): don't use bad file descriptor. 
Found by Coverity.
Coverity id #32593.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin 830d6c2d48 (editcmd_dialog_raw_key_query): move to editcmd.c. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin b77961a14d mcedit: move all completion-related stuff to editcomplete.[ch]. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin 21eefb3e36 mcedit: move all etags-related stuff to tags.[ch]. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 3a8f21166b (edit_buffer_find_word_start): rename from edit_find_word_start 
...and move to editbuffer.c.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 9094cdd1d3 mcedit: move content of choosesyntax.c to syntax.c. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin c6bdc7c1dc mcedit: move all spell-related stuff to spell.[ch]. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 3b34936b9f mcedit: move all search&replace-related stuff to editsearch.[ch]. 2021-06-20 15:14:56 +03:00
Andrew Borodin 9d4eb459da (edit_search_cmd): clarify handling of NULL item of history. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 7bc1b19676 (edit_search_cmd): get rid of code duplication. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 21feb38a8d mcedit: refactoring of search. 
(edit_search_init): new function: initialization of search handler.
(edit_search_deinit): new function: deinitialization of search handler.
(edit_replace_cmd): use edit_search_init().
(edit_search_cmd): likewise.
(editcmd_dialog_search_show): use edit_search_init() and
edit_search_deinit().
(edit_search_options): move definition from editcmd_dialogs.c to editsearch.c.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 288fe62987 (mcview_continue_search_cmd): clarify handling of NULL item of history. 2021-06-20 15:14:56 +03:00
Andrew Borodin 6adcd57859 (mcview_continue_search_cmd): get rid of string duplication. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 1fa327c5a1 (mcview_continue_search_cmd): get rid of code duplication. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 65ca3da3b2 mcviewer: refactoring of search. 
(mcview_search_init): new function: initialization of search handler.
(mcview_search_deinit): new function: deinitialization of search handler.
(mcview_dialog_search): use mcview_search_init() and mcview_search_deinit().
(mcview_continue_search_cmd): use mcview_search_init().
(mcview_dialog_search): use mcview_search_deinit().
(mcview_search_options) move definition from dialogs.c to search.c.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 37b86b2781 (extfs_open_and_read_archive): fix NULL dereference in mc_plose(). 
Found by Coverity.
Coverity id #331765.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 45a4d3f6d4 mcviewer: move content of inlines.h into internal.h. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 91b7101e06 (DOZ): new macro: difference or zero. 
Use DOZ where appropriate.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin d35df9ad60 Use argument names in function declarations. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 721048161c (extfs_get_plugins): use is_exe(). 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 07837de33b (is_exe): simple refactoring. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin de16ae9180 Use G_OPTION_ENTRY_NULL macro. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin f657d92e52 (execute_menu_command): fix memory leak. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Fredrik Fornwall ded5d37ff0 MidnightCommander/#113: replace S_IWRITE with S_IWUSR. 
S_IWRITE is an obsolete synonym provided for BSD compatibility.
It can be safely replaced with S_IWUSR.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 558fb350f8 (tar_fill_stat): fix signedness change. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 231c84caeb Widget: implement destroy callback. 
(dlg_destroy): remove. Use widget_destroy() to destroy any dialog.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin e7fab254f9 Rename variable: midnight_dlg -> filemanager. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 4ed3e4b0f6 Sync with gnulib 80a344e3237b878734295cbe696b7f1e4a8541f0. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 1e1cbb31d0 src/filemanager/chattr.c: minor refactoring. 
(chattrboxes_new): create WChattrBoxes widget entirely.
(chattr_dlg_create): move creation of checkboxes to chattrboxes_new().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00
Andrew Borodin 2cd33ad0d5 Convert widget coordinates from global to local and vice versa. 
Add two widget callbacks:
  * (make_global): convert widget coordinates from local (relative to
    owner) to global (screen).
  * (make_local): convert widget coordinates from global (screen) to
    local (relative to owner).

Such conversions are required when nested widgets and groups are added to
or removed from another groups.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:56 +03:00