Commit Graph

13021 Commits

Author SHA1 Message Date
Andrew Borodin
57e7e8f112 Save/load brief columns to/from panels.ini.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-24 17:51:39 +03:00
Andrew Borodin
fb474bc1c1 WPanel: support up to 9 columns in brief mode.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-24 17:51:39 +03:00
Andrew Borodin
b671a11388 Refactoring: use panel_lines() function instead of llines macro.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-24 17:51:39 +03:00
Andrew Borodin
3f968a50e0 (format_file): fix potential out-of-range and NULL dereference.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-24 17:51:39 +03:00
Andrew Borodin
8b5f618303 Minor refactoring of file panel draw.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-24 17:51:39 +03:00
Andrew Borodin
902246e4b8 Ticket #3212: support more than 2 columns in the file panel.
Initial commit: minor cleanup, refactoring and type accuracy in listing
format related code.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-24 17:51:39 +03:00
Andrew Borodin
4aa4b8224a Merge branch '3470_s3'
* 3470_s3:
  AUTHORS: add s3 VFS authors.
  Ticket #3470: VFS s3+ bugfixes & improvements.
2015-05-24 17:45:39 +03:00
Andrew Borodin
542cdae380 AUTHORS: add s3 VFS authors.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-24 17:45:03 +03:00
Dmitry Koterov
e09d64179e Ticket #3470: VFS s3+ bugfixes & improvements.
* Resolve "Please use  AWS4-HMAC-SHA256" error: enforce the new V4 authentication
method. It is required in many (if not all) locations nowadays.
* Now s3+ works with buckets in different regions: locations are auto-detected.
* Debug level specification support (MCVFS_EXTFS_S3_DEBUGLEVEL).

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-24 17:42:06 +03:00
Andrew Borodin
4167717e4c Merge branch '3456_sftp_segfault'
* 3456_sftp_segfault:
  Ticket #3456: SFTP VFS: fix segfault.
2015-05-24 17:34:03 +03:00
Andrew Borodin
17bbeb9791 Ticket #3456: SFTP VFS: fix segfault.
(mc_error_message): return error code for possible following use."
(sftpfs_cb_open_connection): fix dereference of null pointer.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-09 16:46:45 +03:00
Andrew Borodin
549661e50b src/diffviewer/ydiff.c: fix use of HAVE_CHARSET.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 20:25:34 +03:00
Andrew Borodin
6ab4643088 src/filemanager/filegui.c: fix use of STAT_STATVFS and STAT_STATVFS64.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 20:20:14 +03:00
Andrew Borodin
fd4d25ae27 (strip_ctrl_codes): add missing default case.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 20:12:18 +03:00
Andrew Borodin
c43d3420e6 Merge branch '3420_cleanup'
* 3420_cleanup: (24 commits)
  Ticket #3431: add missing default cases.
  Ticket #3440: (find_file): fix memory leak.
  Ticket #3439: (dir_list_reload): fix memory leak.
  Ticket #3438: (dir_list_load): fix memory leak.
  Ticket #3437: (custom_canonicalize_pathname): fix heap-buffer-overflow.
  (edit_find_line): use labs() instead of abs() for argument of type 'long'.
  (progress_update_one): fix variable initialization.
  (file_date): fix variable initialization.
  is_7bit_printable() is used only if support of charset selection and conversion is disabled.
  lib/strutil/strutil8bit.c: remove unused functions.
  Ticket #3435: clang compiler fixes/cleanups.
  Fixes in tests
  Ticket #3134: fix cflags check when using clang compiler.
  Add -Wundef compiler option for future compile checks.
  Use #ifdef for autoconf provided marcos (continue).
  Use #ifdef for autoconf provided marcos...
  Better use of S_IS* macros.
  Ticket #3430: introduce -Wundef check to catch macro typos.
  Ticket #3429: fix -Wstrict-prototypes compiler warnings...
  reset_hp_softkeys variable is used in S-Lang-based mc only.
  ...
2015-05-03 19:44:33 +03:00
Andrew Borodin
2789e6e390 Ticket #3431: add missing default cases.
Introduce -Wswitch-default check.

Some minor cosmetics.

Thanks Andreas Mohr <and at gmx dot li> for original patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:50 +03:00
Andreas Mohr
39fec422c2 Ticket #3440: (find_file): fix memory leak.
Find_parameter() allocate start_dir but object will never freed.

Testcase: search file.

(Found by LeakSanitizer.)

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Andreas Mohr
9fa3138377 Ticket #3439: (dir_list_reload): fix memory leak.
When dir_copy filling with fentry objects, dir_list_clean() on dir_copy
will never work because dir_copy->len is still zero.

Testcase: switch panels on/off.

(Found by LeakSanitizer.)

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Andreas Mohr
67408e5f24 Ticket #3438: (dir_list_load): fix memory leak.
When root directory found list->len is decrease but listobj->fname
object will never be freed.
Clear list instead of resetting list len only.

(Found by LeakSanitizer.)

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Andreas Mohr
4821259d85 Ticket #3437: (custom_canonicalize_pathname): fix heap-buffer-overflow.
Only use strncmp when path has enough room (greater then url_delim_len
size).
Overflow happen when path = './'.

(Found by AddressSanitizer.)

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Andreas Mohr
c9b07317c3 (edit_find_line): use labs() instead of abs() for argument of type 'long'.
(edit_block_copy_cmd): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Andreas Mohr
036499523f (progress_update_one): fix variable initialization.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Andreas Mohr
d74be13ef0 (file_date): fix variable initialization.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Andreas Mohr
e9e6868789 is_7bit_printable() is used only if support of charset selection and conversion is disabled. 2015-05-03 19:43:49 +03:00
Andreas Mohr
bd051e4095 lib/strutil/strutil8bit.c: remove unused functions.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Andrew Borodin
b698b7e834 Ticket #3435: clang compiler fixes/cleanups.
Since O_* macros are used in lib/global.h, include <fcntl.h> there.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Slava Zanko
517cc5cfe4 Fixes in tests
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2015-05-03 19:43:49 +03:00
Andreas Mohr
495b4d662f Ticket #3134: fix cflags check when using clang compiler.
With clang invalid cflags usage result in exit 0, we expect exit 1.

$ clang -c -Wmaybe-uninitialized conftest.c ; echo $?
warning: unknown warning option '-Wmaybe-uninitialized'; did you mean '-Wuninitialized'? [-Wunknown-warning-option]
1 warning generated.
0

solution with -Werror on cflags check

$ clang -c -Werror -Wmaybe-uninitialized conftest.c ; echo $?
error: unknown warning option '-Wmaybe-uninitialized'; did you mean '-Wuninitialized'? [-Werror,-Wunknown-warning-option]
1

(Tested with clang 3.6.)

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Andreas Mohr
850073cbbb Add -Wundef compiler option for future compile checks.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Andrew Borodin
e3a3424c28 Use #ifdef for autoconf provided marcos (continue).
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:49 +03:00
Andreas Mohr
57452f656b Use #ifdef for autoconf provided marcos...
...until autoconf switch from un/define marco logic to always existing
macro with 0/1 value.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:48 +03:00
Andreas Mohr
d0d7d412a7 Better use of S_IS* macros.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:48 +03:00
Andreas Mohr
8a2f9e253d Ticket #3430: introduce -Wundef check to catch macro typos.
Use always defined MC_HOMEDIR_XDG macro.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:48 +03:00
Andreas Mohr
1a5015aa87 Ticket #3429: fix -Wstrict-prototypes compiler warnings...
...and use compiler option for future compile checks.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:48 +03:00
Andrew Borodin
44bf7e8d80 reset_hp_softkeys variable is used in S-Lang-based mc only.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:48 +03:00
Andreas Mohr
ca95dec659 Ticket #3428: fix -Wredundant-decls compiler warnings...
...and use compiler option for future compile checks.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:48 +03:00
Andreas Mohr
e9b41e5215 Ticket #3427: fix -Wmissing-field-initializers compiler warnings...
...and use compiler option for future compile checks.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:48 +03:00
Andreas Mohr
24f0e19ac6 Ticket #3426: fix -Wmaybe-uninitialized compiler warnings...
...and use compiler option for future compiles.
Since gcc 4.7.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:48 +03:00
Andreas Mohr
7665a2a2e2 Ticket #3420: code cleanup before 3.4.15 release.
Ticket #3424: fix -Wdeclaration-after-statement compiler warnings.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 19:43:48 +03:00
Andrew Borodin
c23324013e Merge branch '3445_mcedit_status_filename'
* 3445_mcedit_status_filename:
  Ticket #3445: mcedit: choose filename format in the status line.
2015-05-03 19:00:13 +03:00
Andrew Borodin
587329a683 Ticket #3445: mcedit: choose filename format in the status line.
Add editor_state_full_filename option to choose full or base file name
in the mceditor status line. Option is hidden and accessible in the
mc.ini configuration file only. Disabled by default to be consistent
with the file name format in the mcviewer status line.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 18:59:09 +03:00
Andrew Borodin
f38a2f7775 Merge branch '3422_gmo'
* 3422_gmo:
  Ticket #3422: recognize .gmo files as well as .mo ones.
2015-05-03 18:52:43 +03:00
Andrew Borodin
0add36df23 Ticket #3422: recognize .gmo files as well as .mo ones.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 18:51:50 +03:00
Andrew Borodin
f391e31f27 Merge branch '3441_startup_segfault'
* 3441_startup_segfault:
  Ticket #3441: fix Linux kernel-specific segfault on startup.
2015-05-03 18:46:23 +03:00
Andrew Borodin
5ceb5e2bef Ticket #3441: fix Linux kernel-specific segfault on startup.
Sync with gnulib 3fb6e360363744462ce15c381f0b116c6fc4ce82.

src/filemanager/mountlist.c: remove dependency on libmount.
Parse /proc/self/mountinfo directly, rather than depending on libmount,
which has many dependencies due to its dependence on libselinux, as
detailed at:
http://lists.gnu.org/archive/html/bug-gnulib/2015-01/msg00063.html.
Note we restrict this to __linux__ as that's probably where this
interface will remain.  If ever porting, it would be best to first pull
the makedev() wrapper from coreutils to a gnulib module.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-05-03 18:45:02 +03:00
Marco Ciampa
17bdcfa8b0 Merge pull request #60 from volftomas/patch-1
Fixed typo in man page
2015-04-29 16:14:59 +02:00
Tomas Paladin Volf
99226f9e30 Fixed typo in man page 2015-04-29 15:47:56 +02:00
Andrew Borodin
ba9a5af10e Merge branch '3444_path_mc_popen'
* 3444_path_mc_popen:
  Revert "Clarify description of clipboard_store and clipboard_paste options."
  Ticket #3444: (mc_popen): use the PATH environment variable
2015-04-19 15:30:34 +03:00
Andrew Borodin
325e3a0c62 Revert "Clarify description of clipboard_store and clipboard_paste options."
This reverts commit ede5f9bad4.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-04-19 15:30:27 +03:00
Ben Woods
544a6b625e Ticket #3444: (mc_popen): use the PATH environment variable
...to search for the executable when opening pipe:
add the G_SPAWN_SEARCH_PATH flag to the g_spawn_async_with_pipes() call,
which cause mc to use the PATH environment variable to search for the
executable.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2015-04-19 15:29:39 +03:00