* 3149_move_compute_total: (21 commits)
Update po/*.po files.
Don't calculate totals for copy and erase operations on single file.
(file_is_symlink_to_dir): new API.
(panel_operate): add TODO for rename/move of several directories.
Don't calculate totals for move operation on single file.
(operate_single_file): don't calculate directory size before rename or move...
(operate_single_file): make src and dest file name unescaping
Refactor preparation of file/dir operation.
(transform_source): fix memory leak in error case.
(operate_one_file): refactoring, add extra variables.
(operate_single_file): refactoring, add extra variables.
(move_dir_dir): refactoring: move erase of copied directories to separate function.
Refactoring: move file remove to separate function.
Refactroing: move same file/dir check to separate function.
Refactoring: move of directory erase to separate function.
(panel_operate): refactoring: move file/dir operation to separate function.
(panel_operate): refactoring: move single file/dir operation to separate function.
(panel_operate): refactoring: move copy/move confirmation prompt to separate function.
(panel_operate): refactoring: move delete confirmation prompt to separate function.
(panel_operate): refactoring: move check of single entry to separate function.
...
...of single directory within same file system.
First try rename the single file/dir. If case of unsuccess, use
copy+delete with directory size calclulation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
...whitin same file system.
Initial commit: cleanup: WITH_FULL_PATHS is defined permanently.
Remove it.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
See gnulib a512e041120e9012e69afa2f5c3adc196ec4999a:
glibc 2.25 is deprecating the namespace pollution of <sys/types.h>
injecting major(), minor(), and makedev() into the compilation
environment, with a warning that insists that users include
<sys/sysmacros.h> instead. However, because the expansion of
AC_HEADER_MAJOR didn't bother checking sys/sysmacros.h until after
probing whether sys/types.h pollutes the namespace, it was not defining
MAJOR_IN_SYSMACROS, with the result that code compiled with -Werror
chokes on the deprecation warnings because it was not including
sysmacros.h.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
* 3406_sftp_error_31:
(panel_operate_init_totals): fix directory size calculation.
(panel_operate_init_totals): change the 'source' argument type...
sftpfs: handle file operation errors.
(sftpfs_close_file): return actual result of sftp file close operation.
(sftpfs_waitsocket): refactor and use it for file and directory operations.
Clarify usage of sftpfs_internal_stat() return value.
sftpfs: refactoring: move initialization of sftp stat operations to separate function.
sftpfs: refactoring: move initialization of sftp operation to separate function.
(sftpfs_waitsocket): handle socket errors.
sftpfs: refactoring: move handling of socket errors to separate function.
(sftpfs_fstat): use sftpfs_attr_to_stat().
sftpfs: refactoring: move obtaining of stat info from sftp attributes to separate function.
sftpfs: refactoring: move error check to separate function.
Fix sftp error 31 (proto 4 and 2)
sftp handle LIBSSH2_FX_PERMISSION_DENIED as EACCES.
Ticket #3406: sftpfs: fix -31 SFTP Protocol Error when transferring file via SFTP Link.
When libssh2_sftp_stat_ex(LIBSSH2_SFTP_STAT|LIBSSH2_SFTP_LSTAT) returns with
LIBSSH2_ERROR_SFTP_PROTOCOL (-31) and LIBSSH2_FX_PERMISSION_DENIED (3)
handle this error case like local stat/lstat() returns -EACCES.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Initial commit: extend error message with sftp session error.
When LIBSSH2_ERROR_SFTP_PROTOCOL (-31) occurs extend error message
with sftp last error for better failure tracking.
With #3269 patch further sftp protocol error message now looks like
SFTP Protocol Error 3 (-31).
Currently I have no nice solution for print relevant called libssh2 function too
I don't want pollute _to_gliberror() with contant strings all over.
sftp session error 3 means (file) permission denied.
From libssh2-1.5.0/include/libssh2_sftp.h
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Before the rewrite e7ed071be7, the files
`INSTALL`, `UPGRADE`, and `REBUILD` were just text files with fixed
length of 39 characters. After the rewrite, the corresponding `rpm`
commands (of variable length) have been added.
If one of these files is being opened with the internal viewer, only the
first 39 characters (hardcoded in `mcrpmfs_list()`) are shown, e.g.
`INSTALL` (before the previous commit):
# Run this script to install this RPM p
The word 'script' was added inconsistently (compare with `UPGRADE` and
`REBUILD`) and can be removed. The `rpm` commands can be also removed:
they may fail to work if there is a whitespace in the path, so they
cannot always be simply copy&pasted; it's is still possible to "run" the
script files with Enter.
Signed-off-by: Anatoly Borodin <anatoly.borodin@gmail.com>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
