* (create_panels_and_run_mc): rename to create_file_manager.
Move call of dlg_run() to do_nc().
* (create_panels): create file panels only. Move creation of
other widgets to create_file_manager().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Found by Clang 4.0.1.
edit.c:896:16: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return 0x80000000UL;
^~~~~~~~~~~~
(whole my_type_of() is suspect)
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Found by GCC 6.4.0.
panel.c: In function 'panel_reload':
panel.c:4188:40: warning: potential null pointer dereference [-Wnull-dereference]
if (IS_PATH_SEP (panel_cwd_path[0]) && panel_cwd_path[1] == '\0')
../../lib/global.h:132:26: note: in definition of macro 'IS_PATH_SEP'
#define IS_PATH_SEP(c) ((c) == PATH_SEP)
^
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Found by GCC 7.2.0
utilunix.c: In function 'my_systemv':
utilunix.c:455:13: error: this statement may fall through [-Werror=implicit-fallthrough=]
my_exit (127); /* Exec error */
^~~~~~~~~~~~~
utilunix.c:458:5: note: here
default:
^~~~~~~
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Remove SVR2 support
SVR2 was obsolete by 1986 and is no longer supported by anybody, and its
code was getting in the way of use of this module by Emacs, which has
its own 'read' function anyway.
* src/filemanager/mountlist.c: remove SVR2-specific code.
* m4.include/fsusage.m4: do not test for sys/filsys.h or set
STAT_READ_FILSYS.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
* 3149_move_compute_total: (21 commits)
Update po/*.po files.
Don't calculate totals for copy and erase operations on single file.
(file_is_symlink_to_dir): new API.
(panel_operate): add TODO for rename/move of several directories.
Don't calculate totals for move operation on single file.
(operate_single_file): don't calculate directory size before rename or move...
(operate_single_file): make src and dest file name unescaping
Refactor preparation of file/dir operation.
(transform_source): fix memory leak in error case.
(operate_one_file): refactoring, add extra variables.
(operate_single_file): refactoring, add extra variables.
(move_dir_dir): refactoring: move erase of copied directories to separate function.
Refactoring: move file remove to separate function.
Refactroing: move same file/dir check to separate function.
Refactoring: move of directory erase to separate function.
(panel_operate): refactoring: move file/dir operation to separate function.
(panel_operate): refactoring: move single file/dir operation to separate function.
(panel_operate): refactoring: move copy/move confirmation prompt to separate function.
(panel_operate): refactoring: move delete confirmation prompt to separate function.
(panel_operate): refactoring: move check of single entry to separate function.
...
...of single directory within same file system.
First try rename the single file/dir. If case of unsuccess, use
copy+delete with directory size calclulation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Andrew Borodin