14265 Commits

Author SHA1 Message Date
Robert Moore
bf2d9c4604 Logfile: Changes for version 20200214
Version 20200214.
2020-02-14 09:26:37 -08:00
Robert Moore
75b3e1cbe3
Merge pull request #561 from SchmErik/rafael-gpe
Introduce AcpiAnyGpeStatusSet ()
2020-02-13 14:30:15 -08:00
Rafael J. Wysocki
6d63ef8161 Introduce AcpiAnyGpeStatusSet ()
Introduce a new helper function, AcpiAnyGpeStatusSet(), for
checking the status bits of all enabled GPEs in one go.

It is needed to distinguish spurious SCIs from genuine ones when
deciding whether or not to wake up the system from suspend-to-idle.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-02-13 13:57:43 -08:00
Robert Moore
4d69cf57bb Add macro to get the byte width of a GAS structure.
In addition to existing macro to get the bit width.
From: Mika Westerberg.
2020-02-12 13:02:16 -08:00
Robert Moore
6c8a90601e
Merge pull request #560 from SchmErik/bz1500-fix
iASL: fix method parameter type list processing in external declarations
2020-02-12 10:21:01 -08:00
Erik Kaneda
95fe6414a2 iASL: fix method parameter type list processing in external declarations
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-02-12 09:27:55 -08:00
Robert Moore
424684b136 Fix a typecast warning, and one typo in a comment. 2020-02-11 09:45:08 -08:00
Robert Moore
2371426354
Merge pull request #558 from MiraySoftware/size-casts
Size casts
2020-02-11 09:33:01 -08:00
Robert Moore
fd58182034
Merge pull request #559 from SchmErik/bz1500
iASL: process return type and parameter types in external declaration
2020-02-11 09:31:11 -08:00
Robert Moore
e93a53d4d3 Fix some typos within comments
Submitted by: ehaouas@noos.fr
2020-02-11 09:28:02 -08:00
Erik Kaneda
adb3ecfc05 iASL: process return type and parameter types in external declaration
This change will process return type and parameter type information
found in method declaration in the same way as methods. This is done
by changing all object type parse nodes into PARSEOP_DEFAULT_ARG. By
doing so, external methods with return types and parameter type list
will be encoded correctly.

Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-02-10 13:44:58 -08:00
Erik Kaneda
c644963c63 iASL: change MtProcessTypeOp and MtProcessParameterTypeList to be non-static
This change also fixes the function comment for MtProcessParameterTypeList

Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-02-10 12:51:18 -08:00
Erik Kaneda
716d5a363c iASL: simplify External type analysis allowed by previous parse tree change
Previous parse tree change nested all return types and parameter type
lists inside of PARSEOP_DEFAULT_ARG. This change removes logic that
checks if the parse node is not a PARSEOP_DEFAULT_ARG because this
will always hold true.

In order to detect whether if these types exist, check for a child
node underneath the PARSEOP_DEFAULT_ARG. If it exists, it means that
a return type or a parameter list has been defined.

Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-02-10 11:27:09 -08:00
Sven Barth
0f64c317e7 * strlen() returns a size_t, so use ACPI_SIZE instead of UINT32 for PrefixPathLength 2020-02-10 14:45:37 +01:00
Sven Barth
d216e4c8d8 * AcpiNsBuildNormalizedPath() takes an UINT32 as length argument, so cast accordingly 2020-02-10 14:43:34 +01:00
Sven Barth
7280593660 * cast the result of the pointer difference to UINT32; altnatively we could declare AmlLength as ACPI_SIZE, but then one would need to cast at the assignment for MethodObj->Method.AmlLength 2020-02-10 14:40:49 +01:00
Robert Moore
88443d3d74 iASL: Fix a use of ACPI_RETURN_STATUS macro
LdAnalyzeExternals does not have a FUNCTION_TRACE (or FUNCTION_NAME) macro,
so ACPI_RETURN_STATUS cannot be used. simply use return() instead.
2020-02-07 13:03:03 -08:00
Robert Moore
3d30dcf31a
Merge pull request #557 from SchmErik/iasl-fix
iASL: use Op->Asl.Nameseg to prevent segfault during method analysis
2020-02-07 12:59:36 -08:00
Erik Kaneda
dad1539f87 iASL: use Op->Asl.Nameseg to prevent segfault during method analysis
At this point, some named objects may not have a namespace node and
cause the compiler to crash. Instead of using the namespace node to
find the NameSeg, this change uses the parse object's NameSeg
field.

Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-02-07 10:53:53 -08:00
Robert Moore
5deecf8bbb
Merge pull request #556 from SchmErik/bz1513
iASL: detect type mismatch between external declarations and named ob…
2020-02-06 14:34:34 -08:00
Erik Kaneda
91b8333ef0 iASL: detect type mismatch between external declarations and named object declarations
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-02-06 13:57:50 -08:00
Robert Moore
5dda9dcac9 iASL: Restrict emission of MSG_NAMED_OBJECT_CREATION for Switch()
Switch causes the compiler to emit a named object of the form "_T_x".
We don't want to emit the NAMED_OBJECT_CREATION remark for these.
2020-02-06 13:30:24 -08:00
Robert Moore
4f3a235cf0 Table Manager: Update comments in a function header
Update AcpiGetTableHeader to remove text stating that the
caller must unmap any returned memory.
2020-02-04 12:34:36 -08:00
Robert Moore
098583dc4d
Merge pull request #555 from SchmErik/iasl-refactor-method-analysis
iasl: refactor method analysis
2020-02-04 08:58:19 -08:00
Robert Moore
df52c57457 Fix a couple of typos
From ehaouas@noos.fr
2020-02-03 13:55:47 -08:00
Erik Kaneda
6223228458 iASL: extract function to process ParameterType list
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-02-03 13:52:35 -08:00
Erik Kaneda
8cc22631a5 iASL: extract function to process a parse object for a single Btype
This function is used to process a return type or a single parameter
type in method, function, or external declarations.

Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-02-03 13:11:54 -08:00
Erik Kaneda
52cfad7ee6 iASL: clean up code to count method parameter types
This change reflects previous parser changes that nests each type
under PARSEOP_DEFAULT_ARG.

Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-02-03 12:31:04 -08:00
Erik Kaneda
407cce76d2 iASL: nest each method parameter type under PARSEOP_DEFAULT_ARG
Previously, parameter types were only nested under
PARSEOP_DEFAULT_ARG if the parameter type is declared inside {} braces.

With this change, the following method declarations result in the
same parse tree:

Method (DS06,,Serialized,0, IntObj,   {IntObj,StrObj}){...}
Method (DS07,,Serialized,0, IntObj,   {{IntObj}, StrObj}){...}
Method (DS08,,Serialized,0, {IntObj}, {IntObj, {StrObj}}){...}
Method (DS09,,Serialized,0, {IntObj}, {{IntObj}, {StrObj}}){...}

Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-02-03 12:13:35 -08:00
Robert Moore
a3e829da1a MSVC Project files: Enable multiprocessor generation
According to MS, This flag enables the use of all cores
on the system.
2020-02-03 10:21:57 -08:00
Robert Moore
17244b890e
Merge pull request #554 from SchmErik/iasl-trivial
Iasl trivial fixes and code movement
2020-02-03 09:52:49 -08:00
Robert Moore
ed3462da8b iASL: Update some error messages (emit full namepath)
For these messages, emit the full namepath for the method in question:
NO_RETVAL
SOME_NO_RETVAL
NAMED_OBJECT_CREATION
SERIALIZED_REQUIRED
RETURN_TYPES
2020-01-31 13:15:59 -08:00
Erik Kaneda
bcd41c3754 iASL: use the correct btype to analyse External methods
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-01-30 15:08:30 -08:00
Robert Moore
52c3a6f541
Merge pull request #553 from SchmErik/iasl-trivial
iASL: use correct macro name for error message and other trivial fixes
2020-01-30 12:33:18 -08:00
Erik Kaneda
2662df195a iASL: rename and move XfGetParentMethod to UtGetParentMethodOp
XfGetParentMethod is used in namespace cross reference and method
analysis so this function should be a part of a aslutils.c rather
than aslxref.c. This function is similar to UtGetParentMethodNode but
returns an ACPI_PARSE_OBJECT so rename it to UtGetParentMethodOp for
clarity.

Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-01-30 12:26:35 -08:00
Erik Kaneda
9f0c54845a iASL: rename UtGetParentMethod to UtGetParentMethodNode
This function returns a namespace node so renaming it as
UtGetParentMethodNode adds more clarity to the usage of this
function.

Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-01-30 12:26:35 -08:00
Erik Kaneda
aacbd4b2ef iASL: use correct macro name for error message and other trivial fixes
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-01-30 10:37:03 -08:00
Robert Moore
88bd852880
Merge pull request #551 from SchmErik/static-operation-region-in-method
iASL: warn on static operation region declared in methods
2020-01-30 09:19:01 -08:00
Robert Moore
8929d10268
Merge pull request #552 from SchmErik/iasl-fix-param-count
iASL: fix method parameter counting when parameterType list is omitted
2020-01-28 13:34:40 -08:00
Erik Kaneda
6e96125009 iASL: fix method parameter counting when parameterType list is omitted
Previous commit broke parameter counting for methods that declared
the argument count but omitted the parameterType list.

Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-01-27 16:06:28 -08:00
Robert Moore
475ac106ed
Merge pull request #550 from SchmErik/bz399
iASL: check method numArgs against length of method parameter list
2020-01-27 14:38:36 -08:00
Robert Moore
cafab2dc54
Merge pull request #549 from SchmErik/legacy-wake
Enable sleep button on ACPI legacy wake
2020-01-27 14:38:19 -08:00
Robert Moore
3e5ec510ed
Merge pull request #546 from SchmErik/bz1514
BZ1514
2020-01-27 14:38:01 -08:00
ignacio ramirez piriz
87a0a713c6 iASL: warn on static operation region declared in methods
Signed-off-by: ignacio ramirez piriz <t-igra@microsoft.com>
[ ek several code changes ]
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-01-27 14:24:03 -08:00
Erik Kaneda
cd41a5a99b iASL: check method numArgs against length of method parameter list
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-01-27 11:31:15 -08:00
Robert Moore
3189f9e82d iASL: Issue remark for named objects created within a method
General "inefficiency" remark. ACPICA BZ 1486.
2020-01-22 13:55:12 -08:00
Anchal Agarwal
9383f5b010 Enable sleep button on ACPI legacy wake
Hibernation (S4) is triggered in a guest when it recieves a sleep
trigger from the hypervisor. When the guest resumes from this power
state, it does not see the SleepEnabled bit. In otherwords, the sleep
button is not enabled on waking from an S4 state. This causes
subsequent invocation of sleep state to fail in the guest.

Fix this problem by enabling the sleep button in ACPI legacy wake.

Signed-off-by: Anchal Agarwal <anchalag@amazon.com>
Reviewed-by: Balbir Singh <sblbir@amazon.com>
Reviewed-by: Frank van der Linden <fllinden@amazon.com>
[ ek: changelog]
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
2020-01-22 10:44:23 -08:00
Robert Moore
af4462c6f4 Fix a comment
"enable" fixed events -> "disable" all fixed events.
2020-01-22 10:07:43 -08:00
Robert Moore
c5ab5abcf8 iASL: Check for errors during timestring conversion
Also use ctime() instead of localtime().
2020-01-22 09:43:30 -08:00
Robert Moore
8d285e942c Remove some extra blank lines
Mostly in generate and tests.
2020-01-22 08:10:39 -08:00