LoadTable opcodes require acpiexec to build OEM tables in RSDT/XSDT.
However, during the EFI porting, OEM test table loading becomes an optional
behavior for acpiexec.
As ASLTS requires the OEM test tables, disabling this option by default
triggers the regression for ASLTS, causing LoadTable related cases to fail.
This patch fixes this regression by enabling this option for ASLTS.
Link: https://bugs.acpica.org/show_bug.cgi?id=1327
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
The MLC (Module Level Code) is an ACPICA terminology describing the AML
code out of any control method, its support is an indication of the
interpreter behavior during the table loading.
The original implementation of MLC in ACPICA had several issues:
1. Out of any control method, besides of the object creating opcodes, only
the code blocks wrapped by "If/Else/While" opcodes were supported.
2. The supported MLC code blocks were executed after loading the table
rather than being executed right in place.
============================================================
The demo of this order issue is as follows:
Name (OBJ1, 1)
If (CND1 == 1)
{
Name (OBJ2, 2)
}
Name (OBJ3, 3)
The original MLC support created OBJ2 after OBJ3's creation.
============================================================
Other than these limitations, MLC support in ACPICA looks correct. And
supporting this should be easy/natural for ACPICA, but enabling of this was
blocked by some ACPICA internal and OSPM specific initialization order
issues we've fixed recently. The wrong support started from the following
false bug fixing commit:
Commit: 80d7951177315f70b5ffd8663985fbf725d07799
Subject: Add support for module-level executable AML code.
We can confirm Windows interpreter behavior via reverse engineering means.
It can be proven that not only If/Else/While wrapped code blocks, all
opcodes can be executed at the module level, including operation region
accesses. And it can be proven that the MLC should be executed right in
place, not in such a deferred way executed after loading the table.
And the above facts indeed reflect the spec words around ACPI definition
block tables (DSDT/SSDT/...), the entire table and the Scope object is
defined by the AML specification in BNF style as:
AMLCode := DefBlockHeader TermList
DefScope := ScopeOp PkgLength NameString TermList
The bodies of the scope opening terms (AMLCode/Scope) are all TermList,
thus the table loading should be no difference than the control method
evaluations as the body of the Method is also defined by the AML
specification as TermList:
DefMethod := MethodOp PkgLength NameString MethodFlags TermList
The only difference is: after evaluating control method, created named
objects may be freed due to no reference, while named objects created by
the table loading should only be freed after unloading the table.
So this patch follows the spec and the de-facto standard behavior, enables
the new grammar (TermList) for the table loading.
By doing so, beyond the fixes to the above issues, we can see additional
differences comparing to the old grammar based table loading:
1. Originally, beyond the scope opening terms (AMLCode/Scope),
If/Else/While wrapped code blocks under the scope creating terms
(Device/PowerResource/Processor/ThermalZone) are also supported as
deferred MLC, which violates the spec defined grammar where ObjectList
is enforced. With MLC support improved as non-deferred, the interpreter
parses such scope creating terms as TermList rather ObjectList like the
scope opening terms.
After probing the Windows behavior and proving that it also parses these
terms as TermList, we submitted an ECR (Engineering Change Request) to
the ASWG (ACPI Specification Working Group) to clarify this. The ECR is
titled as "ASL Grammar Clarification for Executable AML Opcodes" and has
been accepted by the ASWG. The new grammar will appear in ACPI
specification 6.2.
2. Originally, Buffer/Package/OperationRegion/CreateXXXField/BankField
arguments are evaluated in a deferred way after loading the table. With
MLC support improved, they are also parsed right in place during the
table loading.
This is also Windows compliant and the only difference is the removal
of the debugging messages implemented before AcpiDsExecuteArguments(),
see Link 1 for the details. A previous commit should have ensured that
AcpiCheckAddressRange() won't regress.
Note that enabling this feature may cause regressions due to long term
Linux ACPI support on top of the wrong grammar. So this patch also prepares
a global option to be used to roll back to the old grammar during the
period between a regression is reported and the regression is
root-cause-fixed. Lv Zheng.
Link 1: https://bugzilla.kernel.org/show_bug.cgi?id=112911
Tested-by: Chris Bainbridge <chris.bainbridge@gmail.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
This patch adds module level code execution tests.
test collection: functional
test index in collection: 14
file index: scope.asl 180
object.asl 181
overall collection: TCLF
overall test index: W01a
overall file index: scope.asl z180
object.asl z181
The cases can reflect the current MLC support state - ACPICA currently
supports Type1Opcode at module level. All cases should pass with the
existing MLC support.
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Generate all of the possible output files (listings, etc.) in
order to sanity check that the features seem to be working
properly. These files are immediately deleted.
1) Warn if a Local is set but never used
2) Warn if a ArgX is never used (for non-predefined method names)
3) Warn if a ArgX that is used as a local is never used
Across all of ACPICA. Replace C library macros such as ACPI_STRLEN
with the standard names such as strlen. The original purpose for
these macros is long since obsolete.
The iASL constant folding is has been updated. Update ASLTS to reflect this.
We must force some operations to bypass the constant folding so that
there are no compile-time errors, and the runtime error checking is
tested instead. In other words, more errors are now caught during
the compile.
Update the main makefile to ensure that iASL compile failures are
correctly reported. Also fix a missing semicolon.
ACPICA BZ 1106. Reported by Dean Nelson <dnelson@redhat.com>,
fixed by Lv Zheng. Independently validated by David Box.
The AML debug object now outputs the value of the current ACPI Timer().
This broke the original script. This change makes the script independent
of the contents between the opening brackets.
David Box.
This patch makes corrections to serveral region tests that check operations on
GenericSerialBus and SMBus fields. These changes are required after commit
36a1179 corrected the size of the buffer that was calculated for each of the
different bus protocols.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Newly added portable OSLs are useful for EFI porting, but tests didn't
cover AAPITS, now AAPITS build is broken.
This patch re-enables AAPITS build. This patch also adds ACPI_APITS
definition so that if we have troubles in sharing code between AAPITS and
ACPI_EXEC_APP, we now have means to introduce differntiations. Lv Zheng.
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
This patch fixes the failure reported for the following ASLTS test:
exceptions:exc_result2:m692-Inc-Exc (32/64 bit slack mode)
exceptions:exc_result2:m692-Dec-Exc (32/64 bit slack mode)
The test cases expect exceptions generated for mismatched types during
implicit conversions happened to Increment/Decrement opcodes. And the
[Unitialized] object could never be converted into object with any other
types. But the "FAIL" is emitted due to the slack mode which converts
[Uninitialized] operand into 0-valued Integer, thus no type mismatch can be
examined for these test cases.
The command to confirm this test:
aslts.sh -m s32 -m s64 -c exc_result2 -t
The result in __STATUS_OF_TESTS before applying this fix:
":STST:exceptions:exc_result2:m692-Inc-Exc:FAIL:Errors # 02 00 00 00:"
":STST:exceptions:exc_result2:m692-Dec-Exc:FAIL:Errors # 02 00 00 00:"
The result in __STATUS_OF_TESTS after applying this fix:
":STST:exceptions:exc_result2:m692-Inc-Exc:PASS:"
":STST:exceptions:exc_result2:m692-Dec-Exc:PASS:"
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Corrected the expected value for Implicit Returns for
predicate operations (LNot, LEqual, etc).
Added Sleep operation cap for Timer verification test.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
