
Most SDL functions used to indicate success or failure using an int return code. These functions have been changed to return SDL_bool. Here is a coccinelle patch to change code that previously compared the return value to 0 and changes it to a boolean test: @ bool_return_type @ identifier func =~ "^(SDL_AddEventWatch|SDL_AddHintCallback|SDL_AddSurfaceAlternateImage|SDL_AddVulkanRenderSemaphores|SDL_BindAudioStream|SDL_BindAudioStreams|SDL_BlitSurface|SDL_BlitSurface9Grid|SDL_BlitSurfaceScaled|SDL_BlitSurfaceTiled|SDL_BlitSurfaceTiledWithScale|SDL_BlitSurfaceUnchecked|SDL_BlitSurfaceUncheckedScaled|SDL_CaptureMouse|SDL_ClearAudioStream|SDL_ClearClipboardData|SDL_ClearComposition|SDL_ClearError|SDL_ClearProperty|SDL_ClearSurface|SDL_CloseIO|SDL_CloseStorage|SDL_ConvertAudioSamples|SDL_ConvertEventToRenderCoordinates|SDL_ConvertPixels|SDL_ConvertPixelsAndColorspace|SDL_CopyFile|SDL_CopyProperties|SDL_CopyStorageFile|SDL_CreateDirectory|SDL_CreateStorageDirectory|SDL_CreateWindowAndRenderer|SDL_DateTimeToTime|SDL_DestroyWindowSurface|SDL_DetachVirtualJoystick|SDL_DisableScreenSaver|SDL_EnableScreenSaver|SDL_EnumerateDirectory|SDL_EnumerateProperties|SDL_EnumerateStorageDirectory|SDL_FillSurfaceRect|SDL_FillSurfaceRects|SDL_FlashWindow|SDL_FlipSurface|SDL_FlushAudioStream|SDL_FlushRenderer|SDL_GL_DestroyContext|SDL_GL_GetAttribute|SDL_GL_GetSwapInterval|SDL_GL_LoadLibrary|SDL_GL_MakeCurrent|SDL_GL_SetAttribute|SDL_GL_SetSwapInterval|SDL_GL_SwapWindow|SDL_GetAudioDeviceFormat|SDL_GetAudioStreamFormat|SDL_GetCameraFormat|SDL_GetClosestFullscreenDisplayMode|SDL_GetCurrentRenderOutputSize|SDL_GetCurrentTime|SDL_GetDXGIOutputInfo|SDL_GetDateTimeLocalePreferences|SDL_GetDisplayBounds|SDL_GetDisplayUsableBounds|SDL_GetGDKDefaultUser|SDL_GetGDKTaskQueue|SDL_GetGamepadSensorData|SDL_GetGamepadTouchpadFinger|SDL_GetHapticEffectStatus|SDL_GetJoystickBall|SDL_GetMasksForPixelFormat|SDL_GetPathInfo|SDL_GetRectUnion|SDL_GetRectUnionFloat|SDL_GetRenderClipRect|SDL_GetRenderColorScale|SDL_GetRenderDrawBlendMode|SDL_GetRenderDrawColor|SDL_GetRenderDrawColorFloat|SDL_GetRenderLogicalPresentation|SDL_GetRenderLogicalPresentationRect|SDL_GetRenderOutputSize|SDL_GetRenderSafeArea|SDL_GetRenderScale|SDL_GetRenderVSync|SDL_GetRenderViewport|SDL_GetSensorData|SDL_GetStorageFileSize|SDL_GetStoragePathInfo|SDL_GetSurfaceAlphaMod|SDL_GetSurfaceBlendMode|SDL_GetSurfaceClipRect|SDL_GetSurfaceColorKey|SDL_GetSurfaceColorMod|SDL_GetTextInputArea|SDL_GetTextureAlphaMod|SDL_GetTextureAlphaModFloat|SDL_GetTextureBlendMode|SDL_GetTextureColorMod|SDL_GetTextureColorModFloat|SDL_GetTextureScaleMode|SDL_GetTextureSize|SDL_GetWindowAspectRatio|SDL_GetWindowBordersSize|SDL_GetWindowMaximumSize|SDL_GetWindowMinimumSize|SDL_GetWindowPosition|SDL_GetWindowRelativeMouseMode|SDL_GetWindowSafeArea|SDL_GetWindowSize|SDL_GetWindowSizeInPixels|SDL_GetWindowSurfaceVSync|SDL_HideCursor|SDL_HideWindow|SDL_Init|SDL_InitHapticRumble|SDL_InitSubSystem|SDL_LoadWAV|SDL_LoadWAV_IO|SDL_LockAudioStream|SDL_LockProperties|SDL_LockSurface|SDL_LockTexture|SDL_LockTextureToSurface|SDL_MaximizeWindow|SDL_MinimizeWindow|SDL_MixAudio|SDL_OpenURL|SDL_OutOfMemory|SDL_PauseAudioDevice|SDL_PauseAudioStreamDevice|SDL_PauseHaptic|SDL_PlayHapticRumble|SDL_PremultiplyAlpha|SDL_PremultiplySurfaceAlpha|SDL_PushEvent|SDL_PutAudioStreamData|SDL_RaiseWindow|SDL_ReadStorageFile|SDL_ReadSurfacePixel|SDL_ReadSurfacePixelFloat|SDL_RegisterApp|SDL_ReloadGamepadMappings|SDL_RemovePath|SDL_RemoveStoragePath|SDL_RemoveTimer|SDL_RenamePath|SDL_RenameStoragePath|SDL_RenderClear|SDL_RenderCoordinatesFromWindow|SDL_RenderCoordinatesToWindow|SDL_RenderFillRect|SDL_RenderFillRects|SDL_RenderGeometry|SDL_RenderGeometryRaw|SDL_RenderLine|SDL_RenderLines|SDL_RenderPoint|SDL_RenderPoints|SDL_RenderPresent|SDL_RenderRect|SDL_RenderRects|SDL_RenderTexture|SDL_RenderTexture9Grid|SDL_RenderTextureRotated|SDL_RenderTextureTiled|SDL_RequestAndroidPermission|SDL_RestoreWindow|SDL_ResumeAudioDevice|SDL_ResumeAudioStreamDevice|SDL_ResumeHaptic|SDL_RumbleGamepad|SDL_RumbleGamepadTriggers|SDL_RumbleJoystick|SDL_RumbleJoystickTriggers|SDL_RunHapticEffect|SDL_SaveBMP|SDL_SaveBMP_IO|SDL_SendAndroidMessage|SDL_SendGamepadEffect|SDL_SendJoystickEffect|SDL_SendJoystickVirtualSensorData|SDL_SetAppMetadata|SDL_SetAppMetadataProperty|SDL_SetAudioDeviceGain|SDL_SetAudioPostmixCallback|SDL_SetAudioStreamFormat|SDL_SetAudioStreamFrequencyRatio|SDL_SetAudioStreamGain|SDL_SetAudioStreamGetCallback|SDL_SetAudioStreamInputChannelMap|SDL_SetAudioStreamOutputChannelMap|SDL_SetAudioStreamPutCallback|SDL_SetBooleanProperty|SDL_SetClipboardData|SDL_SetClipboardText|SDL_SetCursor|SDL_SetFloatProperty|SDL_SetGamepadLED|SDL_SetGamepadMapping|SDL_SetGamepadPlayerIndex|SDL_SetGamepadSensorEnabled|SDL_SetHapticAutocenter|SDL_SetHapticGain|SDL_SetJoystickLED|SDL_SetJoystickPlayerIndex|SDL_SetJoystickVirtualAxis|SDL_SetJoystickVirtualBall|SDL_SetJoystickVirtualButton|SDL_SetJoystickVirtualHat|SDL_SetJoystickVirtualTouchpad|SDL_SetLinuxThreadPriority|SDL_SetLinuxThreadPriorityAndPolicy|SDL_SetLogPriorityPrefix|SDL_SetMemoryFunctions|SDL_SetNumberProperty|SDL_SetPaletteColors|SDL_SetPointerProperty|SDL_SetPointerPropertyWithCleanup|SDL_SetPrimarySelectionText|SDL_SetRenderClipRect|SDL_SetRenderColorScale|SDL_SetRenderDrawBlendMode|SDL_SetRenderDrawColor|SDL_SetRenderDrawColorFloat|SDL_SetRenderLogicalPresentation|SDL_SetRenderScale|SDL_SetRenderTarget|SDL_SetRenderVSync|SDL_SetRenderViewport|SDL_SetScancodeName|SDL_SetStringProperty|SDL_SetSurfaceAlphaMod|SDL_SetSurfaceBlendMode|SDL_SetSurfaceColorKey|SDL_SetSurfaceColorMod|SDL_SetSurfaceColorspace|SDL_SetSurfacePalette|SDL_SetSurfaceRLE|SDL_SetTLS|SDL_SetTextInputArea|SDL_SetTextureAlphaMod|SDL_SetTextureAlphaModFloat|SDL_SetTextureBlendMode|SDL_SetTextureColorMod|SDL_SetTextureColorModFloat|SDL_SetTextureScaleMode|SDL_SetThreadPriority|SDL_SetWindowAlwaysOnTop|SDL_SetWindowAspectRatio|SDL_SetWindowBordered|SDL_SetWindowFocusable|SDL_SetWindowFullscreen|SDL_SetWindowFullscreenMode|SDL_SetWindowHitTest|SDL_SetWindowIcon|SDL_SetWindowKeyboardGrab|SDL_SetWindowMaximumSize|SDL_SetWindowMinimumSize|SDL_SetWindowModalFor|SDL_SetWindowMouseGrab|SDL_SetWindowMouseRect|SDL_SetWindowOpacity|SDL_SetWindowPosition|SDL_SetWindowRelativeMouseMode|SDL_SetWindowResizable|SDL_SetWindowShape|SDL_SetWindowSize|SDL_SetWindowSurfaceVSync|SDL_SetWindowTitle|SDL_SetiOSAnimationCallback|SDL_ShowAndroidToast|SDL_ShowCursor|SDL_ShowMessageBox|SDL_ShowSimpleMessageBox|SDL_ShowWindow|SDL_ShowWindowSystemMenu|SDL_StartTextInput|SDL_StartTextInputWithProperties|SDL_StopHapticEffect|SDL_StopHapticEffects|SDL_StopHapticRumble|SDL_StopTextInput|SDL_SyncWindow|SDL_TimeToDateTime|SDL_TryLockMutex|SDL_TryLockRWLockForReading|SDL_TryLockRWLockForWriting|SDL_TryWaitSemaphore|SDL_UnlockAudioStream|SDL_UpdateHapticEffect|SDL_UpdateNVTexture|SDL_UpdateTexture|SDL_UpdateWindowSurface|SDL_UpdateWindowSurfaceRects|SDL_UpdateYUVTexture|SDL_Vulkan_CreateSurface|SDL_Vulkan_LoadLibrary|SDL_WaitConditionTimeout|SDL_WaitSemaphoreTimeout|SDL_WarpMouseGlobal|SDL_WriteStorageFile|SDL_WriteSurfacePixel|SDL_WriteSurfacePixelFloat)$"; @@ ( func( ... ) - == 0 | - func( + !func( ... ) - < 0 | - func( + !func( ... ) - != 0 | - func( + !func( ... ) - == -1 )
333 lines
9.3 KiB
C
333 lines
9.3 KiB
C
/*
|
|
Copyright (C) 1997-2024 Sam Lantinga <slouken@libsdl.org>
|
|
|
|
This software is provided 'as-is', without any express or implied
|
|
warranty. In no event will the authors be held liable for any damages
|
|
arising from the use of this software.
|
|
|
|
Permission is granted to anyone to use this software for any purpose,
|
|
including commercial applications, and to alter it and redistribute it
|
|
freely.
|
|
*/
|
|
|
|
/* Simple test of the SDL semaphore code */
|
|
|
|
#include <signal.h>
|
|
|
|
#include <SDL3/SDL.h>
|
|
#include <SDL3/SDL_main.h>
|
|
#include <SDL3/SDL_test.h>
|
|
|
|
#define NUM_THREADS 10
|
|
/* This value should be smaller than the maximum count of the */
|
|
/* semaphore implementation: */
|
|
#define NUM_OVERHEAD_OPS 10000
|
|
#define NUM_OVERHEAD_OPS_MULT 10
|
|
|
|
static SDL_Semaphore *sem;
|
|
static int alive;
|
|
|
|
typedef struct Thread_State
|
|
{
|
|
SDL_Thread *thread;
|
|
int number;
|
|
SDL_bool flag;
|
|
int loop_count;
|
|
int content_count;
|
|
} Thread_State;
|
|
|
|
static void log_usage(char *progname, SDLTest_CommonState *state) {
|
|
static const char *options[] = { "[--no-threads]", "init_value", NULL };
|
|
SDLTest_CommonLogUsage(state, progname, options);
|
|
}
|
|
|
|
static void
|
|
killed(int sig)
|
|
{
|
|
alive = 0;
|
|
}
|
|
|
|
static int SDLCALL
|
|
ThreadFuncRealWorld(void *data)
|
|
{
|
|
Thread_State *state = (Thread_State *)data;
|
|
while (alive) {
|
|
SDL_WaitSemaphore(sem);
|
|
SDL_Log("Thread number %d has got the semaphore (value = %" SDL_PRIu32 ")!\n",
|
|
state->number, SDL_GetSemaphoreValue(sem));
|
|
SDL_Delay(200);
|
|
SDL_SignalSemaphore(sem);
|
|
SDL_Log("Thread number %d has released the semaphore (value = %" SDL_PRIu32 ")!\n",
|
|
state->number, SDL_GetSemaphoreValue(sem));
|
|
++state->loop_count;
|
|
SDL_Delay(1); /* For the scheduler */
|
|
}
|
|
SDL_Log("Thread number %d exiting.\n", state->number);
|
|
return 0;
|
|
}
|
|
|
|
static void
|
|
TestRealWorld(int init_sem)
|
|
{
|
|
Thread_State thread_states[NUM_THREADS] = { { 0 } };
|
|
int i;
|
|
int loop_count;
|
|
|
|
sem = SDL_CreateSemaphore(init_sem);
|
|
|
|
SDL_Log("Running %d threads, semaphore value = %d\n", NUM_THREADS,
|
|
init_sem);
|
|
alive = 1;
|
|
/* Create all the threads */
|
|
for (i = 0; i < NUM_THREADS; ++i) {
|
|
char name[64];
|
|
(void)SDL_snprintf(name, sizeof(name), "Thread%u", (unsigned int)i);
|
|
thread_states[i].number = i;
|
|
thread_states[i].thread = SDL_CreateThread(ThreadFuncRealWorld, name, (void *)&thread_states[i]);
|
|
}
|
|
|
|
/* Wait 10 seconds */
|
|
SDL_Delay(10 * 1000);
|
|
|
|
/* Wait for all threads to finish */
|
|
SDL_Log("Waiting for threads to finish\n");
|
|
alive = 0;
|
|
loop_count = 0;
|
|
for (i = 0; i < NUM_THREADS; ++i) {
|
|
SDL_WaitThread(thread_states[i].thread, NULL);
|
|
loop_count += thread_states[i].loop_count;
|
|
}
|
|
SDL_Log("Finished waiting for threads, ran %d loops in total\n\n", loop_count);
|
|
|
|
SDL_DestroySemaphore(sem);
|
|
}
|
|
|
|
static void
|
|
TestWaitTimeout(void)
|
|
{
|
|
Uint64 start_ticks;
|
|
Uint64 end_ticks;
|
|
Uint64 duration;
|
|
SDL_bool result;
|
|
|
|
sem = SDL_CreateSemaphore(0);
|
|
SDL_Log("Waiting 2 seconds on semaphore\n");
|
|
|
|
start_ticks = SDL_GetTicks();
|
|
result = SDL_WaitSemaphoreTimeout(sem, 2000);
|
|
end_ticks = SDL_GetTicks();
|
|
|
|
duration = end_ticks - start_ticks;
|
|
|
|
/* Accept a little offset in the effective wait */
|
|
SDL_Log("Wait took %" SDL_PRIu64 " milliseconds\n\n", duration);
|
|
SDL_assert(duration > 1900 && duration < 2050);
|
|
|
|
/* Check to make sure the return value indicates timed out */
|
|
if (result) {
|
|
SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "SDL_WaitSemaphoreTimeout returned: %d; expected: SDL_FALSE\n\n", result);
|
|
}
|
|
|
|
SDL_DestroySemaphore(sem);
|
|
}
|
|
|
|
static void
|
|
TestOverheadUncontended(void)
|
|
{
|
|
Uint64 start_ticks;
|
|
Uint64 end_ticks;
|
|
Uint64 duration;
|
|
int i, j;
|
|
|
|
sem = SDL_CreateSemaphore(0);
|
|
SDL_Log("Doing %d uncontended Post/Wait operations on semaphore\n", NUM_OVERHEAD_OPS * NUM_OVERHEAD_OPS_MULT);
|
|
|
|
start_ticks = SDL_GetTicks();
|
|
for (i = 0; i < NUM_OVERHEAD_OPS_MULT; i++) {
|
|
for (j = 0; j < NUM_OVERHEAD_OPS; j++) {
|
|
SDL_SignalSemaphore(sem);
|
|
}
|
|
for (j = 0; j < NUM_OVERHEAD_OPS; j++) {
|
|
SDL_WaitSemaphore(sem);
|
|
}
|
|
}
|
|
end_ticks = SDL_GetTicks();
|
|
|
|
duration = end_ticks - start_ticks;
|
|
SDL_Log("Took %" SDL_PRIu64 " milliseconds\n\n", duration);
|
|
|
|
SDL_DestroySemaphore(sem);
|
|
}
|
|
|
|
static int SDLCALL
|
|
ThreadFuncOverheadContended(void *data)
|
|
{
|
|
Thread_State *state = (Thread_State *)data;
|
|
|
|
if (state->flag) {
|
|
while (alive) {
|
|
if (!SDL_TryWaitSemaphore(sem)) {
|
|
++state->content_count;
|
|
}
|
|
++state->loop_count;
|
|
}
|
|
} else {
|
|
while (alive) {
|
|
/* Timeout needed to allow check on alive flag */
|
|
if (!SDL_WaitSemaphoreTimeout(sem, 50)) {
|
|
++state->content_count;
|
|
}
|
|
++state->loop_count;
|
|
}
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static void
|
|
TestOverheadContended(SDL_bool try_wait)
|
|
{
|
|
Uint64 start_ticks;
|
|
Uint64 end_ticks;
|
|
Uint64 duration;
|
|
Thread_State thread_states[NUM_THREADS] = { { 0 } };
|
|
char textBuffer[1024];
|
|
int loop_count;
|
|
int content_count;
|
|
int i, j;
|
|
size_t len;
|
|
|
|
sem = SDL_CreateSemaphore(0);
|
|
SDL_Log("Doing %d contended %s operations on semaphore using %d threads\n",
|
|
NUM_OVERHEAD_OPS * NUM_OVERHEAD_OPS_MULT, try_wait ? "Post/TryWait" : "Post/WaitTimeout", NUM_THREADS);
|
|
alive = 1;
|
|
/* Create multiple threads to starve the semaphore and cause contention */
|
|
for (i = 0; i < NUM_THREADS; ++i) {
|
|
char name[64];
|
|
(void)SDL_snprintf(name, sizeof(name), "Thread%u", (unsigned int)i);
|
|
thread_states[i].flag = try_wait;
|
|
thread_states[i].thread = SDL_CreateThread(ThreadFuncOverheadContended, name, (void *)&thread_states[i]);
|
|
}
|
|
|
|
start_ticks = SDL_GetTicks();
|
|
for (i = 0; i < NUM_OVERHEAD_OPS_MULT; i++) {
|
|
for (j = 0; j < NUM_OVERHEAD_OPS; j++) {
|
|
SDL_SignalSemaphore(sem);
|
|
}
|
|
/* Make sure threads consumed everything */
|
|
while (SDL_GetSemaphoreValue(sem)) {
|
|
/* Friendlier with cooperative threading models */
|
|
SDL_DelayNS(1);
|
|
}
|
|
}
|
|
end_ticks = SDL_GetTicks();
|
|
|
|
alive = 0;
|
|
loop_count = 0;
|
|
content_count = 0;
|
|
for (i = 0; i < NUM_THREADS; ++i) {
|
|
SDL_WaitThread(thread_states[i].thread, NULL);
|
|
loop_count += thread_states[i].loop_count;
|
|
content_count += thread_states[i].content_count;
|
|
}
|
|
SDL_assert_release((loop_count - content_count) == NUM_OVERHEAD_OPS * NUM_OVERHEAD_OPS_MULT);
|
|
|
|
duration = end_ticks - start_ticks;
|
|
SDL_Log("Took %" SDL_PRIu64 " milliseconds, threads %s %d out of %d times in total (%.2f%%)\n",
|
|
duration, try_wait ? "where contended" : "timed out", content_count,
|
|
loop_count, ((float)content_count * 100) / loop_count);
|
|
/* Print how many semaphores where consumed per thread */
|
|
(void)SDL_snprintf(textBuffer, sizeof(textBuffer), "{ ");
|
|
for (i = 0; i < NUM_THREADS; ++i) {
|
|
if (i > 0) {
|
|
len = SDL_strlen(textBuffer);
|
|
(void)SDL_snprintf(textBuffer + len, sizeof(textBuffer) - len, ", ");
|
|
}
|
|
len = SDL_strlen(textBuffer);
|
|
(void)SDL_snprintf(textBuffer + len, sizeof(textBuffer) - len, "%d", thread_states[i].loop_count - thread_states[i].content_count);
|
|
}
|
|
len = SDL_strlen(textBuffer);
|
|
(void)SDL_snprintf(textBuffer + len, sizeof(textBuffer) - len, " }\n");
|
|
SDL_Log("%s\n", textBuffer);
|
|
|
|
SDL_DestroySemaphore(sem);
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
int arg_count = 0;
|
|
int i;
|
|
int init_sem = 0;
|
|
SDL_bool enable_threads = SDL_TRUE;
|
|
SDLTest_CommonState *state;
|
|
|
|
/* Initialize test framework */
|
|
state = SDLTest_CommonCreateState(argv, 0);
|
|
if (!state) {
|
|
return 1;
|
|
}
|
|
|
|
/* Enable standard application logging */
|
|
SDL_SetLogPriority(SDL_LOG_CATEGORY_APPLICATION, SDL_LOG_PRIORITY_INFO);
|
|
|
|
/* Parse commandline */
|
|
for (i = 1; i < argc;) {
|
|
int consumed;
|
|
|
|
consumed = SDLTest_CommonArg(state, i);
|
|
if (consumed == 0) {
|
|
consumed = -1;
|
|
if (SDL_strcasecmp(argv[i], "--no-threads") == 0) {
|
|
enable_threads = SDL_FALSE;
|
|
consumed = 1;
|
|
} else if (arg_count == 0) {
|
|
char *endptr;
|
|
init_sem = SDL_strtol(argv[i], &endptr, 0);
|
|
if (endptr != argv[i] && *endptr == '\0') {
|
|
arg_count++;
|
|
consumed = 1;
|
|
}
|
|
}
|
|
}
|
|
if (consumed <= 0) {
|
|
log_usage(argv[0], state);
|
|
return 1;
|
|
}
|
|
|
|
i += consumed;
|
|
}
|
|
|
|
if (arg_count != 1) {
|
|
log_usage(argv[0], state);
|
|
return 1;
|
|
}
|
|
|
|
/* Load the SDL library */
|
|
if (!SDL_Init(0)) {
|
|
SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "Couldn't initialize SDL: %s\n", SDL_GetError());
|
|
return 1;
|
|
}
|
|
(void)signal(SIGTERM, killed);
|
|
(void)signal(SIGINT, killed);
|
|
|
|
if (enable_threads) {
|
|
if (init_sem > 0) {
|
|
TestRealWorld(init_sem);
|
|
}
|
|
|
|
TestWaitTimeout();
|
|
}
|
|
|
|
TestOverheadUncontended();
|
|
|
|
if (enable_threads) {
|
|
TestOverheadContended(SDL_FALSE);
|
|
|
|
TestOverheadContended(SDL_TRUE);
|
|
}
|
|
|
|
SDL_Quit();
|
|
SDLTest_CommonDestroyState(state);
|
|
|
|
return 0;
|
|
}
|