Armin Novak
b362b61a1a
Added libsoxr based resampling.
2018-11-14 13:27:20 +01:00
Armin Novak
ab15e34032
Refactored freerdp_dsp_resample, checks now done internally.
2018-11-14 13:27:20 +01:00
Armin Novak
60025dde8e
Fixed unused function warnings when FFMPEG backend is used.
2018-11-14 13:27:20 +01:00
Armin Novak
e8e4800c5e
Added resampling to freerdp_dsp_encode.
2018-11-14 13:27:20 +01:00
Armin Novak
98a537d05d
Better description and formatting for update_read_icon_info
2018-11-14 11:57:57 +01:00
Armin Novak
7e12955c55
Made all internal functions static.
2018-11-14 11:57:57 +01:00
ilammy
7a2b6e1301
libfreerdp-core: fix reading TS_ICON_INFO
...
The spec says that CbColorTable field is present when Bpp is 1, 4, 8.
Actually, bpp == 2 is not supported by TS_ICON_INFO according to the
spec (though, DIB definitely supports 16-color images).
MS-RDPERP 2.2.1.2.3 Icon Info (TS_ICON_INFO)
CbColorTable (2 bytes):
This field is ONLY present if the bits per pixel (Bpp)
value is 1, 4, or 8.
Omitting 8-bit value breaks 256-color icons which are incorrectly
read with color and alpha data mixed up.
2018-11-14 10:53:45 +01:00
Armin Novak
138eb13fea
Updated RDP_VERSION definitions.
2018-11-14 10:14:48 +01:00
Armin Novak
ecac998340
Fixed rdg bio cleanup.
...
When attaching the RDG BIO to the TLS BIO also transfer ownership.
2018-11-13 12:22:09 +01:00
Armin Novak
3c35a098f5
Fixed direct rdg front bio access.
2018-11-13 11:24:04 +01:00
Armin Novak
e070bbea8d
Fixed leaks in rdg_send_channel_create
2018-11-13 11:22:37 +01:00
Armin Novak
342ff8cf0b
Fixed broken server name packet size
2018-11-13 11:22:37 +01:00
Armin Novak
15a41586a8
Don't read content length in VIRTUAL_CONNECTION_STATE_OUT_CHANNEL_WAIT
2018-11-13 11:22:37 +01:00
Armin Novak
90d2e42600
Fixed ntlm_authenticate, split return from continue flag.
2018-11-13 11:22:37 +01:00
Armin Novak
4e0b4d7096
Fixed static INT_MAX checks, replaced with assert.
2018-11-13 11:22:37 +01:00
Armin Novak
398a33af63
Fixed all warnings in rdg module
...
Fix all missing range checks and warnings.
2018-11-13 11:22:37 +01:00
Armin Novak
9078b0deb9
Fixed extern declaration of rpc_bind p_uuid_t variables.
2018-11-13 11:22:37 +01:00
Armin Novak
b4fc0c75ce
Made rdpRdp opaque
2018-11-13 11:22:37 +01:00
David Fort
b6e6575bf6
license: support CAL license
...
This patch simplifies the licensing code mutualizing encryption / decryption
routines. It also adds the support for client_info packet that allows to send a
previously saved CAL file.
2018-11-13 09:42:19 +01:00
Martin Fleisz
097ac0ee13
Merge pull request #4997 from akallabeth/use_bio_free_all
...
Replaced BIO_free with BIO_free_all
2018-11-12 13:55:36 +01:00
Bernhard Miklautz
c5c1bac31a
Merge pull request #4960 from akallabeth/interleaved_fix
...
Fixed #4954 : Check destination buffer bounds.
2018-11-09 12:25:55 +00:00
Armin Novak
fff2454ae6
Make VS2010 happy, reworked UNROLL defines.
2018-11-09 12:18:51 +01:00
Armin Novak
6e61dd9d9f
Unroll bBits loops as well.
2018-11-09 12:12:19 +01:00
Armin Novak
7e932bbfa2
Readded loop unrolling.
2018-11-09 11:32:28 +01:00
Armin Novak
cf8bc72dc4
Fixed profiler naming in tests.
2018-11-08 17:43:50 +01:00
Armin Novak
9e2c203771
Fixed various issues with freerdp_bitmap_compress and interleaved_compress
2018-11-08 17:21:28 +01:00
Armin Novak
c0c1d064be
Added a unit test for interleaved codec compression.
2018-11-08 17:20:31 +01:00
Martin Fleisz
9400bdccdb
Merge pull request #4996 from bmiklautz/tls_security_level
...
new [crypto/tls]: add support to set tls security level
2018-11-08 15:33:40 +01:00
Armin Novak
5f4843191b
Replaced BIO_free with BIO_free_all
...
There is no point in using BIO_free with a custom recursion
to free up stacked BIOs if there is already BIO_free_all.
Using it consistently avoids memory leaks due to stacked BIOs
not being recursively freed.
2018-11-08 12:09:49 +01:00
Bernhard Miklautz
1222e7060b
new [crypto/tls]: add support to set tls security level
...
The newly introduced option /tls-seclevel can be used to set the tls
security level on systems with openssl >= 1.1.0 or libressl.
As default level 1 is used as higher levels might prohibit connections
to older systems.
2018-11-08 11:13:15 +01:00
Armin Novak
5eca5ebde8
Fixed #4993 : Allow uninitialized bio socket in transport_bio_simple_uninit
...
When the TLS connection is aborted early (certificate issues, ...)
the bio simple socket might not have been initialized.
Do not access the NULL pointer on cleanup.
2018-11-07 17:02:07 +01:00
akallabeth
cf43406dc3
Merge pull request #4982 from bmiklautz/ctest_asan_fixes
...
Fix issues with multiple tests if address sanitation is on
2018-11-07 16:11:02 +01:00
Armin Novak
a544776bd8
Simplified code, moved bounds check out of loops.
2018-11-07 13:10:23 +01:00
Armin Novak
10d3ee131e
Fixed #4954 : Check destination buffer bounds.
2018-11-07 12:18:08 +01:00
Pascal J. Bourguignon
6f2caef778
Fix Issue #4983 : Increased size of buffer to encrypt hash with kerberos.
2018-11-06 11:20:02 +01:00
Bernhard Miklautz
37f8181735
fix [libfreerdp/codec]: heap buffer overflow in TestFreeRDPCodecClear
...
The examples and the allocated buffers assume that the destination
starts with x 0 and y 0 and not 1/1.
2018-11-05 15:43:12 +01:00
Bernhard Miklautz
649404dd29
fix [libfreerdp/crypto]: memory leak in Test_x509_cert_info
2018-11-05 13:46:05 +01:00
Bernhard Miklautz
aecc77cd77
Merge pull request #4969 from akallabeth/covscan_fix
...
Covscan fixes
2018-11-05 10:44:01 +00:00
David Fort
1a50a48332
fix uninitialised variable
...
Otherwise we can run in troubles when sending logon_info_v2 packets
2018-11-01 11:07:36 +01:00
David Fort
548025bcc3
nego: add new flags
...
Reading the new spec there's some new flags
2018-10-31 10:43:59 +01:00
David Fort
af195864e5
remotefx: fix rlgr last bits of encoder
...
The last bits of the bitstream were not flushed in the output, this patch fixes it.
2018-10-31 10:42:04 +01:00
Martin Fleisz
7b0f4f5dc4
Merge pull request #4907 from akallabeth/transport_write_leak_fix
...
Transport write leak fix
2018-10-29 14:54:55 +01:00
Armin Novak
423d54d752
Fixed signedness casts.
2018-10-25 14:08:20 +02:00
Armin Novak
6339c43c80
Fixed sockfd/socketBio resource leak.
2018-10-25 13:41:47 +02:00
Armin Novak
42014e80d0
Fixed sockfd/socketBio resource leak.
2018-10-25 13:38:31 +02:00
Armin Novak
f269a0ce5b
Fixed sockfd/socketBio resource leak.
2018-10-25 13:19:45 +02:00
Armin Novak
847ee233f4
Fixed resource leak in rpc_ntlm_http_request
2018-10-25 12:49:42 +02:00
Armin Novak
987ca5ec6a
Fixed another bunch of warnings.
2018-10-24 14:36:12 +02:00
Armin Novak
2a4b47aaac
Changed size iterator variables to size_t
2018-10-24 13:24:25 +02:00
Armin Novak
6ccaafe2d9
Fixed default return value for fastpath_send_multiple_input_pdu
2018-10-23 12:33:13 +02:00
akallabeth
d3c1db1746
Merge pull request #4947 from akallabeth/http_gw_fix
...
Fixed http gateway body length read.
2018-10-23 12:03:03 +02:00
Armin Novak
900abb61f7
Fixed memory leak in update_recv_surfcmd_surface_bits
2018-10-22 14:41:59 +02:00
akallabeth
c251bdc11a
Merge pull request #4952 from eledoux/master
...
gateway HTTP transport - fixed partial reads
2018-10-19 17:13:21 +02:00
akallabeth
b8ff18f37f
Merge pull request #4951 from nfedera/nf-fix-fnobjnew-fnstylecasts
...
fix issue with fnObjectFree and related casts
2018-10-19 14:00:14 +02:00
Armin Novak
b9933e7af4
Read byte by byte, the alignment may otherwise be broken.
2018-10-19 12:52:14 +02:00
Armin Novak
5a747b118d
Read http request in 4byte chunks until '\r\n\r\n' is found
...
Avoid reading too much data in a single call to BIO_read as some
implementations may return a lot more data than is part of the response.
2018-10-19 12:16:04 +02:00
Emmanuel Ledoux
33c7f6590a
fixed partial reads
2018-10-19 11:56:56 +02:00
Armin Novak
d05684a50a
Properly parse ContentType to find length.
2018-10-19 11:47:11 +02:00
Norbert Federa
0572572eb9
fix issue with fnObjectFree and related casts
...
- remove unnecessary/dangerous OBJECT_xxx function-style casts
- fix -Wstrict-prototypes issue with OBJECT_NEW_FN definition
2018-10-19 11:30:01 +02:00
Bernhard Miklautz
7290e3f2b0
fix [cache/pointer]: add missing callback checks
2018-10-19 11:13:21 +02:00
Bernhard Miklautz
e114ee44e4
new [cache/pointer]: don't require pointer functions to be set
...
This as cleanup/rework of PR #4581 .
2018-10-19 10:14:24 +02:00
Armin Novak
7e397d0f1c
Fixed http gateway body length read.
2018-10-19 09:31:55 +02:00
akallabeth
6f14018a22
Merge pull request #4945 from mmattes/fix/transferEncoding
...
transferEncoding can be NULL, correct if happens in line 348
2018-10-18 15:37:24 +02:00
Norbert Federa
850d2dbda9
Merge pull request #4942 from akallabeth/rail_fixes_2.0
...
Fix ORDER_TYPE_WINDOW reading
2018-10-18 14:11:18 +02:00
Norbert Federa
5ef243f91f
Merge pull request #4941 from nfedera/nf-remove-stale-valgrind-macro
...
gateway/rpc: remove stale valgrind macro
2018-10-18 14:08:23 +02:00
Markus Mattes
6d5b88cda6
transferEncoding can be NULL, verification happens in line 348
2018-10-18 13:59:49 +02:00
Armin Novak
5b70142ec4
Fixed read_altsec_order ORDER_TYPE_WINDOW
2018-10-18 12:34:10 +02:00
Armin Novak
8bdb5d771a
Fixed order to string format string.
2018-10-18 12:33:06 +02:00
Norbert Federa
d201deede8
gateway/rpc: remove stale valgrind macro
2018-10-18 11:45:18 +02:00
Armin Novak
2e3832af94
Fixed TSG stream alignment (4 or 8)
2018-10-18 10:41:03 +02:00
Armin Novak
dc197d4dd1
Fixed tsg abort condition.
2018-10-18 10:15:51 +02:00
Armin Novak
88d310ff2c
Fixed compiler warnings (casts, ...)
2018-10-18 09:09:30 +02:00
Martin Fleisz
e46d1d95ff
Merge pull request #4926 from akallabeth/primary_order_checks
...
Order data validation and correction
2018-10-17 16:02:28 +02:00
Armin Novak
991f051a63
Fixed stream release for transport_write
2018-10-17 14:55:55 +02:00
MartinHaimberger
6f6581cdd6
Merge pull request #4933 from akallabeth/planar_alpha_fix
...
Planar alpha fix
2018-10-17 14:40:00 +02:00
Armin Novak
aefb7728f6
Removed debug log entries, simplified order support check.
2018-10-17 14:16:16 +02:00
Armin Novak
f91590ecbf
Fixed bugs detected during scanbuild run
2018-10-17 13:19:33 +02:00
akallabeth
8fe3ac5d26
Merge pull request #4902 from akallabeth/gw_refactor_3
...
Gateway refactoring
2018-10-17 12:23:10 +02:00
Armin Novak
7b860ce96a
Add command line option /relax-order-checks
2018-10-17 12:16:58 +02:00
Armin Novak
a432a297ca
Fixed division by 0 if invalid formats are used.
2018-10-17 11:37:51 +02:00
Armin Novak
c0d38778f1
Fixed length sanity check.
2018-10-17 10:09:37 +02:00
Armin Novak
4d124cf5d1
Fixed order requirements.
2018-10-17 10:09:27 +02:00
Armin Novak
777bfe5c40
Fixed const correctness of arguments.
2018-10-16 17:29:10 +02:00
Armin Novak
75517c06fb
Added parameter checks.
2018-10-16 17:26:57 +02:00
Armin Novak
bbcba568f4
Added parameter checks.
2018-10-16 17:23:24 +02:00
Armin Novak
d2e08c0aa8
Fixed missing argument check.
2018-10-16 17:14:56 +02:00
Armin Novak
3629a84d3f
Fixed missing input validation.
2018-10-16 17:10:03 +02:00
Armin Novak
cab2e28576
Fixed missing value check
2018-10-16 17:09:29 +02:00
Armin Novak
c51ca89d9b
Fixed glyph cache
2018-10-16 16:10:17 +02:00
Armin Novak
5ea4a7d3b0
Proper order checks.
2018-10-16 15:56:17 +02:00
Armin Novak
16d553a75f
Check if incoming secondary alternate orders have been activated.
2018-10-16 13:59:37 +02:00
Armin Novak
711da861e8
Check if incoming secondary orders have been activated.
2018-10-16 13:48:43 +02:00
Armin Novak
88bd262134
Send brush support level from settings.
2018-10-16 13:48:29 +02:00
Armin Novak
c99434691e
For every order check if it is activated in settings before processing.
2018-10-16 13:13:01 +02:00
Armin Novak
fb87f6d0bd
Added a warning that the server sent an unsupported order
2018-10-16 12:46:44 +02:00
Armin Novak
e4b24aa31e
Fixed arguments to *adust
2018-10-16 12:36:08 +02:00
Armin Novak
91107beb67
Separate alpha handling for planar codec
...
If the destination does not support an alpha channel ignore it
when decoding and prevent data to be copied unnecessarily
2018-10-16 12:17:25 +02:00
Armin Novak
a29bc16af4
Siplified planar alpha / non alpha paths
2018-10-16 10:05:33 +02:00
Armin Novak
7d8e6377df
Fixed a memory leak in cleaning up brushes.
2018-10-16 09:31:30 +02:00
Armin Novak
14321a2d52
Adjust rectangles where appropriate.
2018-10-15 16:34:44 +02:00