mirrors
/
FreeRDP
mirror of https://github.com/FreeRDP/FreeRDP
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed sockfd/socketBio resource leak.

This commit is contained in:
Armin Novak 2018-10-25 13:08:00 +02:00
parent 847ee233f4
commit f269a0ce5b
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
libfreerdp/core/transport.c
View File

@ -224,22 +224,30 @@ wStream* transport_send_stream_init(rdpTransport* transport, int size)
BOOL transport_attach(rdpTransport* transport, int sockfd)
{
BIO* socketBio;
BIO* socketBio = NULL;
BIO* bufferedBio;
socketBio = BIO_new(BIO_s_simple_socket());
if (!socketBio)
return FALSE;
goto fail;
BIO_set_fd(socketBio, sockfd, BIO_CLOSE);
bufferedBio = BIO_new(BIO_s_buffered_socket());
if (!bufferedBio)
return FALSE;
goto fail;
bufferedBio = BIO_push(bufferedBio, socketBio);
transport->frontBio = bufferedBio;
return TRUE;
fail:
if (socketBio)
BIO_free_all(socketBio);
else
close(sockfd);
return FALSE;
}
BOOL transport_connect_rdp(rdpTransport* transport)
@ -1093,7 +1101,7 @@ BOOL transport_disconnect(rdpTransport* transport)
else
{
if (transport->frontBio)
BIO_free(transport->frontBio);
BIO_free_all(transport->frontBio);
}
if (transport->tsg)