Commit Graph

14515 Commits

Author SHA1 Message Date
akallabeth
ff14073182 Removed invalid check
(cherry picked from commit e019ed6566)
2021-02-25 09:51:41 +01:00
akallabeth
812233e180 Implemented 2.2.1.17.1 Persistent Key List PDU Data, added checks
* Implemented missing server side version of PDU (just skip data)
* Refactored read/write functions to properly check stream
  length/capacity and handle return values.

(cherry picked from commit ec3c333656)
2021-02-25 09:51:41 +01:00
akallabeth
db1287ddad Fixed rdp_capability_set_start checks
(cherry picked from commit a13e0f1a08)
2021-02-25 09:51:41 +01:00
akallabeth
104f3f043e Check stream capacity in rdp_capability_set_finish
(cherry picked from commit 6b0d2a2c3e)
2021-02-25 09:51:41 +01:00
akallabeth
5b7841cdf3 Fixed missing stream length checks.
(cherry picked from commit f7f8c3907d)
2021-02-25 09:51:41 +01:00
akallabeth
51bf892909 Added data_pdu_type_to_string
(cherry picked from commit b6b8d74521)
2021-02-25 09:51:41 +01:00
akallabeth
b55664d7c1 Fixed sending of clipboard format request response
If a request was pending and new formats were announced the response
to a ServerFormatDataRequest was never sent.

(cherry picked from commit 2efb7d9274)
2021-02-25 09:51:41 +01:00
akallabeth
47d8505bd0 Fixed primitiveYUV unit test.
(cherry picked from commit f357b9325f)
2021-02-25 09:51:41 +01:00
akallabeth
9eeb64ed9f Ignore alpha channel during color conversion.
Most GFX graphics do not carry alpha data. Keep the original
alpha value unless specified otherwise.

(cherry picked from commit 115532ef5a)
2021-02-25 09:51:41 +01:00
akallabeth
e45621fed6 Fixed SCardGetAttrib pbAttr=NULL argument
If fpbAttrIsNULL!=0 set pbAttr NULL on call to SCardGetAttrib

(cherry picked from commit 61b785a89b)
2021-02-25 09:51:41 +01:00
Armin Novak
d62e679821 [MAC] Keep original return value for client termination
(cherry picked from commit 9e63f35cc5)
2021-02-25 09:51:41 +01:00
akallabeth
bd0558c47f Fixed missing check for fastpath input messages
Input events are only allowed after a connection was established
(connection state is active)
This check aborts input sending when done before that.

(cherry picked from commit 102869f6a8)
2021-02-25 09:51:41 +01:00
akallabeth
87db6078f0 Do not eliminate original error status.
(cherry picked from commit 050a68fec9)
2021-02-25 09:51:41 +01:00
akallabeth
2dbd33b5bb Refactored freerdp_client_settings_command_line_status_print_ex
Now returns 0 if help or version information was requested.

(cherry picked from commit 531dd81836)
2021-02-25 09:51:41 +01:00
Ondrej Holy
cf3ba75673 client: Fix exit codes for /help and similar option
Currently, non-zero exit code is returned for /version, /buildconfig, /help,
/monitor-list, /kbd-list and /kbd-lang-list command-line options for several
clients. This is against conventions because 0 is usually returned in
such cases. Also, there is potentially another problem that the returned
codes overflow on UNIX systems (where the exit code is a number between 0
and 255). Let's fix the clients to return 0 in the mentioned cases to honor
conventions and 1 for the command-line parsing errors (or -1 for clients
who already use that value).

Fixes: https://github.com/FreeRDP/FreeRDP/issues/6686
(cherry picked from commit 3ee4cabcfa)
2021-02-25 09:51:41 +01:00
Martin Fleisz
4d409b7c4b channels/smartcard: Fix race in channel cleanup
(cherry picked from commit 1155aade7f)
2021-02-25 09:51:41 +01:00
Armin Novak
8d62ec233d Fixed const correctness of RECTANGLE_16 variable
(cherry picked from commit 9549d090ab)
2021-02-25 09:51:41 +01:00
Armin Novak
5ea5980b10 Fixed pcap capture function const correctness
(cherry picked from commit 87e89bc719)
2021-02-25 09:51:41 +01:00
Armin Novak
847de7f4ae Fix ColorFidelity use
(cherry picked from commit 8187ab7732)
2021-02-25 09:51:41 +01:00
akallabeth
2ce5f6f17c Check drive to hotplug for already being redirected
some hotplug implementations report the same drive multiple times.
to avoid redirecting the same drive multiple times check if it is
already in the list before adding.

(cherry picked from commit 9e8d3fbbf5)
2021-02-25 09:51:41 +01:00
Armin Novak
605e89a38d Fix color fidelity issues with windows 7
(cherry picked from commit 57b58df806)
2021-02-25 09:51:41 +01:00
Armin Novak
a4048b7d11 Fixed problematic cast of integer mask to bool
(cherry picked from commit 8c353e9292)
2021-02-25 09:51:41 +01:00
Martin Fleisz
d3202497ba primitives: Respect alpha values in YUV444 SSE pixel routine
(cherry picked from commit 9eaa820818)
2021-02-25 09:51:41 +01:00
Martin Fleisz
ce61bc41cb core: Remove error code from string returned by rpc_error_to_string
This PR removes the error code from the error string returned by
rpc_error_to_string. The error code is passed into the function so it is
not necessary to append it to the returned string as well.

The PR also fixes the screwed formatting of the error code tables.

(cherry picked from commit c78566d2a2)
2021-02-25 09:51:41 +01:00
Pascal Nowack
a864f0a529 winpr/clipboard: Also save lastWriteTime for FILEDESCRIPTORW
Currently, when a local uri-list is converted into a FILEDESCRIPTORW
list, WinPR doesn't submit the last write time for each file.
The result of this is that the last write time of each file on the
other peer will have the current time and not the actual last write
time that is present on the peer, where the files were copied from.

Fix this by also writing the last write time in addition to the
FD_WRITESTIME flag.

(cherry picked from commit 9ba614a1e3)
2021-02-25 09:51:41 +01:00
kubistika
9d8d5e5969 x11: use correct contact flag names in xf_input_touch_state_string
(cherry picked from commit a94fe816a4)
2021-02-25 09:51:41 +01:00
Martin Fleisz
76923c7890 Fix parsing of current keyboard locale
(cherry picked from commit 2e59baa33c)
2021-02-25 09:51:41 +01:00
akallabeth
f8075d59c5 Fixed definition of FILEDESCRIPTORW
(cherry picked from commit 33df98f204)
2021-02-25 09:51:41 +01:00
Martin Fleisz
270e40e92f
Merge pull request #6623 from akallabeth/stable-2.0-backports
stable backports
2021-01-11 10:47:45 +01:00
Martin Fleisz
d280caa053
Merge pull request #6671 from akallabeth/stable-2.0-progressive
Backported #6670: Progressive decoding of subbanddiff
2021-01-11 10:36:52 +01:00
akallabeth
db20214c1f Backported #6670: Progressive decoding of subbanddiff
Properly decode tiles without subbanddiff so connections with
xfreerdp /gfx /v:<foo> work with ogon and the required progressive
codec is correct.
2020-12-15 17:00:22 +01:00
akallabeth
6522361760 Fixed #6656: invalid read of proxy port.
(cherry picked from commit 3c237fd687)
2020-12-10 07:39:41 +01:00
akallabeth
98ba0c09ea Moved clipboard hasHugeFileSupport to end of struct
(cherry picked from commit 0c96c3a71c)
2020-12-04 14:11:35 +01:00
akallabeth
77b178f327 Fixed #6632
(cherry picked from commit ceb0e8b4f1)
2020-12-03 09:34:37 +01:00
Keith Johnston
04d2db2730 Fix for mac mousewheel.
(cherry picked from commit 87a4a8484e)
(cherry picked from commit c0ecee9d69)
2020-12-02 14:23:19 +01:00
Armin Novak
e4b30a5cb6 Removed obsolete connectErrorCode
(cherry picked from commit 3b63903d3f)
2020-12-02 14:17:54 +01:00
akallabeth
cb8af3271e Allow autoreconnect for ERRINFO_GRAPHICS_SUBSYSTEM_FAILED
As discussed in #4717 allow autoreconnect to succeed if that
specific error code was returned as disconnection reason.

(cherry picked from commit 552a7ca25f)
2020-12-02 14:12:33 +01:00
Martin Fleisz
63aa57b939 channels/audin: Request correct media type in audin channel on Mac
(cherry picked from commit 4a952977c1)
2020-12-02 14:10:45 +01:00
Armin Novak
aa6d116446 Added permission checks for mac audio backend.
(cherry picked from commit 0e0eb5f41f)
2020-12-02 14:10:01 +01:00
Armin Novak
4a148e8704 Fixed mac app termination and warnings
(cherry picked from commit a2e9f5efcb)
2020-12-02 14:09:54 +01:00
akallabeth
67d404c783 Fixed remarks.
(cherry picked from commit c0284239a7)
2020-12-02 09:43:22 +01:00
Bernhard Miklautz
c94e9ea14b new [orders]: BMF_24BPP support and some comments
* cached brush orders missed the BMF_24BPP documented case
  ([MS-RDPEGDI] 2.2.2.2.1.2.7)
* add some comments on secondary (brush) order details

(cherry picked from commit efdc99528f)
2020-12-02 09:43:22 +01:00
Christian Plattner
cbdb48c0bb Disable building OpenH264 in Andriod CI builds
(cherry picked from commit f4b3ba92fc)
2020-12-02 09:06:10 +01:00
Christian Plattner
c73b7edf34 Fix Android release target API level
(cherry picked from commit 199e38c9b4)
2020-12-02 09:06:10 +01:00
Christian Plattner
fddde5bdc2 Fix Android build paths
(cherry picked from commit 00173a0ef3)
2020-12-02 09:06:10 +01:00
Christian Plattner
0b8cf6ce1d Fix #6565: streamline android build configuration
(cherry picked from commit 0270932d96)
2020-12-02 09:06:10 +01:00
akallabeth
aca1866fc9 Added support for xwayland keyboard grab
(cherry picked from commit 896b7bc711)
2020-12-02 09:00:52 +01:00
akallabeth
f00d7aa644 Fix warning #6515
(cherry picked from commit 6d8f355633)
2020-12-02 08:57:00 +01:00
kubistika
39f56443f2 reset codecs in gdi_pipeline_init
(cherry picked from commit 42e63cbf98)
2020-12-01 15:10:23 +01:00
Fabio Fantoni
99ebaacda6 remove unwanted log level set to debug in rfx
I saw on debian packages (that have -DWITH_DEBUG_ALL=ON) remotefx logs always to
debug without respect log-level and log-filters settings making diffult
debugging of issue on other parts.
After a search I found this that set loglevel to debug that akallabeth confirmed
is unwanted, this patch remove it.

Closes #6606

(cherry picked from commit f3e5ebe315)
2020-12-01 15:10:23 +01:00