Commit Graph

12334 Commits

Author SHA1 Message Date
Armin Novak
c3a26b0d6a Removed +async-transport options
The async transport option is broken by design.
If used the main loop is called from the transport thread and the
main thread of the application.
Unless the transport layer is refactored to just work on queues
(input and output) this option will never work, therefore remove it.
2018-08-22 13:56:37 +02:00
Ondrej Holy
36960e97a4 codec/nsc: Fix leak found by covscan
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
99c15e5339 cache: Fix wrong condition found by covscan
copy_paste_error: "xorMaskData" in "pointer_color->xorMaskData" looks like a copy-paste error.
2018-08-22 13:35:43 +02:00
Ondrej Holy
f36054b379 client/cmdline: Fix leak found by covscan
leaked_storage: Variable "base64" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
e9549a3bdc client/common: Fix leak found by covscan
leaked_storage: Variable "file" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
e7d5aae514 client/x11: Silence false positive warnings from covscan
Add code annotation to silence false positive warnings from covscan
due to omitting termination \0.

buffer_size: Calling strncpy with a source string whose length (13 chars) is greater than or equal to the size argument (13) will fail to null-terminate "&tmp[cs]".
2018-08-22 13:35:43 +02:00
Ondrej Holy
baeb29a7e0 client/x11: Fix leak found by covscan
leaked_storage: Variable "actionScript" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
dde4c38382 client/x11: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
2018-08-22 13:35:43 +02:00
Ondrej Holy
97f25e8ab4 channels/smartcard: Fix leak found by covscan
leaked_storage: Variable "operation" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
3baa716706 channels/smartcard: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
2018-08-22 13:35:43 +02:00
Ondrej Holy
ab7ab7a7ce channels/server: Silence false positive warnings from covscan
Change the code a bit to silence false positive warnings from covscan.

leaked_storage: Ignoring storage allocated by "audin_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpsnd_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "cliprdr_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "echo_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpdr_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "drdynvc_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpei_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "remdesk_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "encomsp_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpgfx_server_context_new(NULL)" leaks it.
2018-08-22 13:35:43 +02:00
Ondrej Holy
4ba3c46cd0 channels/server: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
2018-08-22 13:35:43 +02:00
Ondrej Holy
170d5859d2 channels/serial: Fix leak found by covscan
leaked_storage: Variable "ids" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
d3ab04d786 channels/remdesk: Fix leak found by covscan
leaked_storage: Variable "pass" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
405c133381 channels/rdpgfx: Fix leak found by covscan
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
36a68b4eae channels/rdpgfx: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
2018-08-22 13:35:43 +02:00
Ondrej Holy
1001807c5f channels/rdpdr: Prevent buffer overflow found by covscan
buffer_size_warning: Calling strncpy with a maximum size argument of 256 bytes on destination array "irp->PathName" of size 256 bytes might leave the destination string unterminated.
buffer_size_warning: Calling strncpy with a maximum size argument of 256 bytes on destination array "irp->ExtraBuffer" of size 256 bytes might leave the destination string unterminated.
2018-08-22 13:35:43 +02:00
Ondrej Holy
472576e6e0 channels/rdpdr: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
2018-08-22 13:35:43 +02:00
Ondrej Holy
10bddb9fd9 channels/rdpdr: Fix leak found by covscan
leaked_storage: Variable "newbuf" going out of scope leaks the storage it points to.
leaked_storage: Variable "keys" going out of scope leaks the storage it points to.
leaked_storage: Variable "pKeys" going out of scope leaks the storage it points to.
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
leaked_storage: Variable "computerNameW" going out of scope leaks the storage it points to.
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
865ee84ab5 channels/rail: Fix leak found by covscan
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
4b8f2d5137 channels/drive: Fix leak found by covscan
leaked_storage: Variable "outStr" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
7b740f152f channels/addin: Fix leak found by covscan
leaked_handle: Handle variable "hFind" going out of scope leaks the handle.
2018-08-22 13:35:43 +02:00
Ondrej Holy
926ac4f938 channels/audin: Fix leak found by covscan
leaked_storage: Variable out going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Armin Novak
b77dc13b5f Implemented linked list compare and value copy functions. 2018-08-22 12:39:11 +02:00
Armin Novak
02dc6ab3f7 Fixed single monitor fullscreen resolution update. 2018-08-21 13:00:39 +02:00
Martin Fleisz
560552ce19
Merge pull request #4808 from akallabeth/tls_extract_pem_fix
Fixed #4806 broken bounds check.
2018-08-21 10:01:47 +02:00
Armin Novak
026ff00e7d Fixed #4806 broken bounds check. 2018-08-21 09:08:33 +02:00
Armin Novak
2109399880 Removed comments with variables and (previously added) buggy suse conditionals 2018-08-13 15:51:33 +02:00
David Fort
735ab2e8b2
Merge pull request #4795 from akallabeth/rpm_build_fix
Deactivated FFMPEG support for redhat systems (deps not in repo)
2018-08-13 15:21:49 +02:00
Armin Novak
aad5c45b63 Deactivated FFMPEG support for redhat systems (deps not in repo) 2018-08-13 14:34:43 +02:00
Norbert Federa
2353287e0a
Merge pull request #4794 from akallabeth/drive_find_first_file_fix
Drive find first file fix
2018-08-13 14:33:49 +02:00
Armin Novak
dbd630a38c drive_file_query_information: Use GetFileAttributesExW 2018-08-13 13:40:59 +02:00
Armin Novak
8b8e85271c Fixed #4793: Return correct file handle for existing directory 2018-08-13 13:17:56 +02:00
akallabeth
dd26659ab0
Merge pull request #4789 from akallabeth/nightly_ffmpeg_rpm
Enabled ffmpeg support on RPM based systems.
2018-08-09 10:41:56 +02:00
David Fort
fd1c94bfbf
Merge pull request #4788 from akallabeth/multimon_fullscreen
Fixed #4786: Added fullscreen handling for dynamic resolution.
2018-08-09 10:22:24 +02:00
Armin Novak
2b5b7cb3c5 Added requirement check for WITH_DSP_FFMPEG 2018-08-09 09:58:56 +02:00
Armin Novak
f78794b729 Enabled ffmpeg support on RPM based systems. 2018-08-08 14:50:41 +02:00
akallabeth
b18f9ee862
Merge pull request #4783 from akallabeth/nightly_audio
Enabled FFMPEG for nightly builds.
2018-08-08 13:10:07 +02:00
Armin Novak
a334aa9657 Fixed #4786: Added fullscreen handling for dynamic resolution. 2018-08-08 13:04:26 +02:00
Armin Novak
13564dbb41 Allow redirect address override with a list of values. 2018-08-08 12:30:47 +02:00
Armin Novak
cc5e402cda Added command line option /redirect-prefer:<fqdn|ip|netbios>
Since redirection sometimes happens with internal DNS names that
are resolved different by outside DNS it must be possible to override
the preferred redirection hint.
2018-08-08 11:24:13 +02:00
Armin Novak
f6b6eba0ab Try redirection FQDN first, but check if it is resolvable. 2018-08-08 10:25:09 +02:00
Armin Novak
98ddde0cc3 Enabled FFMPEG dependency. 2018-08-06 08:25:04 +02:00
akallabeth
92c2d83a40
Merge pull request #4778 from akallabeth/2_0_0_dev_4
Started next development cycle
2018-08-01 15:59:34 +02:00
Armin Novak
97e7eca30c Started next development cycle 2018-08-01 15:29:17 +02:00
akallabeth
a4f147683d
Merge pull request #4777 from akallabeth/changelog_2_0_0-rc3
release: version 2.0.0-rc3
2018-08-01 15:27:31 +02:00
Martin Fleisz
1c75854a3a
Merge pull request #4776 from akallabeth/fixes_cleanups_etc
Mac audin Fixes and cleanups
2018-08-01 15:16:07 +02:00
Armin Novak
ec0a0fef2a Added const to function buffer pointers 2018-08-01 12:56:18 +02:00
Armin Novak
2a3a66b18b Fixed expression ambiguity 2018-08-01 12:56:18 +02:00
Armin Novak
98c254ffa0 Fixed invalid return value type. 2018-08-01 12:56:18 +02:00