Armin Novak
35d7e896ae
Fix GFX cache eviction, use 1 based indexing.
2020-03-04 11:01:23 +01:00
Martin Fleisz
6942669f32
Merge pull request #5941 from akallabeth/clang_fixes
...
Fixed clang scanbuild warnings.
2020-03-04 09:34:51 +01:00
Martin Fleisz
174832150e
Merge pull request #5932 from nfedera/fix_gfx_bitmapcache_indexing
...
Fix RDPEGFX bitmap cache indexing
2020-03-04 09:31:52 +01:00
Armin Novak
1fd51d9183
Fixed clang scanbuild warnings.
2020-03-04 09:17:35 +01:00
Norbert Federa
17e0d25104
dynvc/client: fix and improve channel closing code
...
- fixed and consolitate the duplicated code for sending the
CLOSE_REQUEST_PDU to the server into dvcman_close_channel
- call dvcman_close_channel if a dynamic channel plugin fails
to process the received channel data
- rdpegfx: don't try to remove a non-existing cache entry,
return an error instead which now will close the channel, as
expected by Microsoft's windows protocols test suite
2020-03-04 08:03:56 +01:00
Armin Novak
34498d4064
URBDRC: Only mark closed if control is closed.
2020-03-03 11:15:34 +01:00
Armin Novak
30990089b8
Implemented del_device by vid/pid
2020-03-02 11:40:05 +01:00
Armin Novak
1b1ab01e43
Cleaned up USB redirection
...
* Removed obsolete searchman
* Unified device add and virtual channel add
* Unified device id generation
2020-03-02 11:40:05 +01:00
Armin Novak
acb77391a2
Fix #5910 : USB hotplug added device wrong
...
When a USB device was added via hotplug add_device was called
with wrong arguments.
2020-03-02 11:40:05 +01:00
Norbert Federa
39e12990e8
rdpegfx: rename MaxCacheSlot to MaxCacheSlots
...
Although Microsoft uses 1-based numbering on the wire for indexing the
GFX bitmap cache entries, the code in FreeRDP uses 0-based numbering and
therefore the name MaxCacheSlots is less confusing.
2020-03-02 09:55:25 +01:00
Norbert Federa
f4d5ec776f
rdpegfx: use 1-based indexing for bitmap cache
...
Weird but Microsoft uses 1-based indexing in the RDPGFX bitmap
cache PDU's.
This does not seem to be documented but can be deducted from the
RDP client test code in Microsoft's "Windows Protocol Test Suites"
GitHub repository and the observation that mstsc aborts with a
protocol error if the cacheSlot index value 0 is used in e.g. a
GFX surface to cache PDU.
2020-03-02 09:55:25 +01:00
Martin Fleisz
3318d1574f
Fix possible NULL pointer access crash
2020-02-28 12:53:39 +01:00
Armin Novak
4eb4f58fbb
Updated CMake channel detection
...
* Now both, dynamic and static channel entries can be defined by
a single channel.
* Added better logging to distinguish between static and dynamic
channel messages.
2020-02-28 12:53:39 +01:00
Martin Fleisz
da354feed0
Add dynamic channel part for rdpsnd channel
2020-02-28 12:53:39 +01:00
Martin Fleisz
347055492e
Merge pull request #5920 from akallabeth/rdpsnd_crash_fix
...
Fix #5885 : Check for division by zero
2020-02-28 11:50:40 +01:00
Armin Novak
5e4603d0b7
Fix #5885 : Check for division by zero
2020-02-27 13:56:53 +01:00
Armin Novak
95bf87a063
Replaced CMake list find with loop to fix build issues.
2020-02-27 11:18:54 +01:00
Martin Fleisz
f484b20787
Merge pull request #5907 from akallabeth/cmake_channel_dependency_fix
...
Cmake channel dependency fix
2020-02-26 16:18:46 +01:00
Armin Novak
829497b313
Made CHANNEL_TSMF optional and deprecated.
2020-02-26 13:56:43 +01:00
Armin Novak
53c15e3e90
Deactivate USB redirection for IOS and ANDROID by default.
2020-02-26 13:53:25 +01:00
Armin Novak
d8c3ccb375
drdynvc: reorder filepaths when adding channels
2020-02-26 10:19:12 +01:00
Armin Novak
d633195879
Promoted usb, printer and smartcard dependencies to recommended
2020-02-25 17:36:17 +01:00
Armin Novak
00f5f014c6
Fixed CMake channel dependencies for variables.
2020-02-25 16:56:42 +01:00
Armin Novak
0154d3ceb8
audin pulse log states by name
2020-02-25 14:57:42 +01:00
Armin Novak
436b68e416
Fixed #5895 : cast warnings.
2020-02-19 10:21:43 +01:00
Armin Novak
f77b3daaa0
Fix channel linking for built in channels
2020-02-18 11:14:05 +01:00
Armin Novak
f933cafa93
Added some callbacks to dynamic channel
...
* Allow listener removal of channel during runtime
* Allow retrieval of channel name
2020-02-18 11:14:05 +01:00
Vic Lee
25eb6b6cdd
rdpsnd: implement buffer overrun detection.
2020-02-14 20:49:18 +08:00
Martin Fleisz
e304428a5f
Merge pull request #5857 from akallabeth/scanbuild_fixes
...
Scanbuild fixes
2020-02-12 10:16:54 +01:00
Armin Novak
b004e01fc8
Exporting URBDRC symbols used by helper library
...
When building the usb channel with different shared libraries some
necessary symbols were not exported.
2020-02-11 12:42:45 +01:00
David Fort
7c26d7d9ad
Merge pull request #5875 from akallabeth/smartcard_missing_null_check
...
Fix #5847 : Missing length check to trace smartcard buffers.
2020-02-10 14:57:46 +01:00
Armin Novak
11d3ea3b43
Fix #5847 : Missing length check to trace smartcard buffers.
2020-02-10 14:28:38 +01:00
Martin Fleisz
ebe0fc59b5
Merge pull request #5865 from akallabeth/write_cancelled_leak
...
Fix #5852 : handle CHANNEL_EVENT_WRITE_CANCELLED
2020-02-10 12:08:55 +01:00
Martin Fleisz
1366abfbff
Merge pull request #5869 from llyzs/winmm_fixes
...
rdpsnd/winmm: fix some memory issues.
2020-02-10 10:40:55 +01:00
David Fort
245fc6014d
Merge pull request #5830 from akallabeth/smartcard_updates
...
Smartcard updates
2020-02-07 14:11:00 +01:00
Vic Lee
847fe0f919
rdpsnd/winmm: fix some memory issues.
2020-02-04 17:56:45 +08:00
Armin Novak
d2aef75004
Fix #5852 : handle CHANNEL_EVENT_WRITE_CANCELLED
...
When channels are cleaned up OpenHandle is most of the time
already 0. Ignore the argument checks for
CHANNEL_EVENT_WRITE_CANCELLED and CHANNEL_EVENT_WRITE_COMPLETE
only check where actually required (CHANNEL_EVENT_DATA_RECEIVED)
2020-01-29 08:52:25 +01:00
Armin Novak
11f2532242
Added unified NDR pointer reading.
2020-01-24 13:52:43 +01:00
Armin Novak
7b50ed887e
Fixed missing length checks for smartcard IRP read.
2020-01-24 13:23:40 +01:00
Armin Novak
9128e441c6
Fixed rdpei unused function warning.
2020-01-23 10:50:37 +01:00
Armin Novak
f4ee8d92a7
Fixed smartcard type mismatches.
2020-01-23 10:39:43 +01:00
Armin Novak
087f290d8d
Fixed type of index variable.
2020-01-23 10:12:12 +01:00
Armin Novak
8996fdc797
Fixed unused variable warning.
2020-01-23 10:12:12 +01:00
Armin Novak
f0db6f2ead
Unified smartcart multistring conversion.
2020-01-23 10:07:54 +01:00
Armin Novak
ee7950c95c
Fixed type mismatches on allocation.
2020-01-23 09:48:20 +01:00
Armin Novak
ec5881e3f2
Fixed smartcard_SetAttrib_Decode call type
2020-01-23 09:32:34 +01:00
Martin Fleisz
706e32982e
rdpsnd: Add synchronization to winmm backend
2020-01-17 13:56:30 +01:00
Armin Novak
afaee324bb
Fixed #5843 wrong header length for pdu
...
@boom1 reported encomsp_send_change_participant_control_level_pdu
fails due to wrong length.
2020-01-16 15:30:33 +01:00
Armin Novak
03e2106f25
Fixed accidental reorder of surface delete and disconnect
2020-01-16 15:24:55 +01:00
Martin Fleisz
369c696b23
rdpsnd: Fix possible crash and deadlock in winmm backend
2020-01-16 10:23:17 +01:00