Armin Novak
19e4eb5d09
Added /buildconfig command line for shadow.
2019-10-04 16:19:23 +02:00
Armin Novak
e09f739b90
Cleaned up NSC API
2019-10-04 10:33:41 +02:00
kubistika
f4d169fb75
server: proxy: register input and update callbacks in post connect
...
To avoid a race in which the server received an input event before
proxy's client is initialized, we now only register input and update
callbacks after client is initialized and safe to use.
2019-09-30 10:08:28 +02:00
kubistika
4d175f6008
server: proxy: refactor pf_context_create_client_context
2019-09-30 10:08:28 +02:00
kubistika
b6730ea31e
server: proxy: support auto reconnect
2019-09-30 10:08:28 +02:00
kubistika
32913850d5
server: proxy: separate client and server security settings
2019-09-30 10:07:43 +02:00
Bernhard Miklautz
02a65840e8
Merge pull request #5578 from kubistika/proxy/refactor
...
sever: proxy: code refactor
2019-09-19 10:55:08 +02:00
kubistika
53a92421b1
server: proxy: config: fix mem leak
2019-09-11 14:29:04 +03:00
Armin Novak
8c17d2fa41
Add MOUSEEVENTF_HWHEEL define if not found in windows.h
2019-09-10 09:35:32 +02:00
Armin Novak
b1d42b17f6
Fix windows shadow server issues reported in #5577
2019-09-10 09:18:55 +02:00
kubistika
867843eef7
server: proxy: client: only try NLA if credentials available
2019-09-10 10:11:00 +03:00
kubistika
a87065ed67
server: proxy: get rid of unnecessary casts
2019-09-09 17:42:18 +03:00
kubistika
0b340b784c
server: proxy: drop local unix socket listen option
2019-09-09 17:42:18 +03:00
kubistika
8a75e8f54e
server: proxy: refactor
2019-09-09 17:42:18 +03:00
kubistika
f5d32f4617
server: proxy: refactor usage of pf_context_copy_settings
2019-09-09 17:35:07 +03:00
kubistika
7ed39ce724
server: proxy: make sure module's pre connect only called once
2019-09-08 15:08:15 +03:00
kubistika
8cf8da3e41
server: proxy: config: remove duplicate declaration of config macros
2019-09-08 15:06:22 +03:00
Martin Fleisz
c90b7a9714
Merge pull request #5563 from akallabeth/scanbuild_fixes
...
Scanbuild fixes
2019-09-03 10:57:24 +02:00
kubistika
62b32fbab9
server: proxy: only wait for server dynvc when needed
2019-09-03 09:09:27 +02:00
Armin Novak
4ff24d074b
Fixed memory leak in error branch
2019-09-03 08:56:36 +02:00
kubistika
e135106731
server: proxy: rdpsnd support
2019-08-29 14:39:17 +02:00
kubistika
dc11bcc9f0
server: proxy: fix nla fallback (introuduced in #5522 )
2019-08-28 17:03:40 +02:00
kubistika
067b7dfd1c
server: proxy: disp: fix copyright
2019-08-23 11:58:08 +02:00
kubistika
04e1708df1
server: proxy: use new hooks api
2019-08-23 11:58:08 +02:00
kubistika
32fff644da
server: proxy: improve modules api
2019-08-23 11:58:08 +02:00
kubistika
d1c5862f54
server: proxy: sync cliprdr opening
2019-08-19 17:03:13 +02:00
kubistika
0ad87d98ca
server: proxy: load proxy clipboard config
2019-08-19 09:30:40 +02:00
kubistika
7dc70b86d6
server: proxy: cliprdr support
2019-08-19 09:30:40 +02:00
kubistika
ef306fbff6
server: proxy: pf_context.c: Fix nla crash
...
Because the proxy uses freerdp_settings_copy to do re-negotiation after
first connection to remote server, all redirection information
(RedirectionPassword, RedirectionDomain, etc.) pointers were duplicated
(to both client and server settings structs). Then, at disconnection, a
double-free occured.
2019-08-14 19:39:34 +02:00
Martin Fleisz
e16d559f70
Merge pull request #5517 from akallabeth/winmm_latency
...
Added proper latency estimation for winmm sound backend.
2019-08-14 12:48:21 +02:00
kubistika
ddb811cbc8
server: proxy: client: before loading client addins, wait for serve's dynvc to be in ready state
2019-08-13 16:28:05 +02:00
kubistika
1da91444c0
server: proxy: client: set glyph support level to NONE
2019-08-13 16:28:05 +02:00
Armin Novak
ddb209445a
Fix server compile against _WIN32_WINNT=0x601
2019-08-13 10:55:12 +02:00
kubistika
cb833ed45c
server: proxy: print configuration on startup
2019-08-05 11:01:31 +03:00
kubistika
595f23b8fe
server: proxy: channels: only open allowed channels
2019-08-05 11:01:31 +03:00
kubistika
0b6864a273
server: proxy: filters: demo: log instead of dropping the connection
2019-08-05 11:01:31 +03:00
kubistika
c5e6e0ba31
server: proxy: filters: make sure filter_init is exported in filters compilation
2019-08-05 11:01:31 +03:00
kubistika
31cd7b844f
server: proxy: refactor configuration loader
2019-08-05 10:54:07 +03:00
kubistika
3051a4b4b4
server: proxy: ensure client termination
2019-08-02 10:17:45 +02:00
kubistika
038c933f98
server: proxy: sync server and client channels
...
when disconnections/redirections occured, sometimes server/client
channels were not synced, meaning that for example the gfx server
received a message, then tried to use gfx client that was already freed.
2019-08-02 10:17:45 +02:00
kubistika
a9758a8c0c
server: proxy: fix rdpgfx close race
2019-07-30 09:56:06 +02:00
kubistika
908d6ebe1e
server: proxy: Add logs, call client->Close to send disconnection ultimatum
2019-07-16 16:20:06 +03:00
kubistika
d0065ee9a1
server: proxy: remove unnecessary function handle_client_disconnection
2019-07-16 16:20:06 +03:00
kubistika
b12ee3288c
server: proxy: adjust log levels
2019-07-16 16:20:06 +03:00
kubistika
95851b25e7
server: proxy: set nla fallback flag flag only if NLASecurity is enabled
2019-07-16 16:20:06 +03:00
kubistika
e9e1c5d748
server: proxy: naming refactor
2019-07-16 16:20:06 +03:00
kubistika
70ca028453
server: proxy: remove unnecessary files
2019-07-16 16:12:12 +03:00
kubistika
1b4371ed22
server: proxy: use freerdp_settings_copy
2019-07-16 13:47:35 +02:00
kubistika
ab00d90f03
server: proxy: implement NLA fallback
2019-07-15 11:52:30 +02:00
kubistika
02a65b8867
Declare support for multimon in proxy server.
...
It was broken in the DISP PR.
2019-07-08 11:09:29 +03:00
kubistika
8954e1646b
server/proxy: Add check after calling p_client_context_create
2019-06-26 14:25:07 +02:00
kubistika
8fbee28dd7
server/proxy: Logging and comments improvements
2019-06-26 14:25:07 +02:00
kubistika
fb3f7f3908
server/proxy: pf_update: Update ps->settings in DesktopResize
2019-06-26 14:25:07 +02:00
kubistika
74a66f6651
server/proxy: set ps->thread to NULL on disconnect
...
freerdp_abort_connect calls the proxy's client stop function,
that closes the thread handle. if it already closed by the server,
a segfault will occur because CloseHandle will try to access free()'ed
memory.
2019-06-26 14:25:07 +02:00
kubistika
8a115f2020
server/proxy: Refactor pdata_set_connection_info
...
Connection info must be set after the proxy's client connection
established, because if the client didn't provide credentials in .rdp
file, we don't know its username yet.
2019-06-26 14:25:07 +02:00
kubistika
98973dd0da
server/proxy: pf_filters: Update filter_free to accept NULL
2019-06-26 14:25:07 +02:00
kubistika
f795fc2670
server/proxy: Fix race-condition
...
The client's `ClientStop` callback wasn't set, therefore calling
freerdp_client_stop wasn't really blocking until it has stopped, and a
race condition occured. Fixed by registring to `ClientStop` callback and
waiting for the client thread to finish.
2019-06-26 14:25:07 +02:00
kubistika
255fab201a
server/proxy: Fix rdpgfx and events leak
2019-06-26 14:25:07 +02:00
kubistika
c0cece1064
server/proxy: Fix double-call to disconnect
2019-06-26 14:25:07 +02:00
David Fort
2da425aa03
Merge pull request #5424 from kubistika/rdpgfx
...
rdpgfx: CacheImportOffer implementation
2019-06-13 11:35:15 +02:00
David Fort
1f128b6142
Merge pull request #5423 from kubistika/feat/bitmap-auto-flag-calculate
...
rdpUpdate: add autoBitmapDataCalculate
2019-06-12 21:15:59 +02:00
Kobi
d9366df448
RDPEDISP server side implementation ( #5414 )
...
* libfreerdp: Add RDPEDISP server implementation
* server/proxy: Add RDPEDISP support
2019-06-11 16:13:42 +02:00
kubistika
896ba119d1
server/proxy: Proxy CacheImportOffer & QoeFrameAck
2019-06-06 07:53:34 +03:00
kubistika
c8b38fb66e
server/proxy: Fix bitmap update crash when target is win7
2019-06-04 17:33:48 +03:00
David Fort
5d1fc68629
Merge pull request #5405 from m4ntis/proxy/filters-api
...
Proxy: Filters API
2019-06-03 15:45:24 +02:00
kubistika
6224109a1d
server/proxy: Add multimon support
2019-06-03 14:33:15 +03:00
kubistika
cd135ceacb
libfreerdp/core: Export monitor layout PDU
...
* Move update notification related functions to new display.c: Not
related to `rdp.c`.
* Rename `rdp_write_monitor_layout_pdu` to `display_write_monitor_layout_pdu`.
* Add internal `display_convert_rdp_monitor_to_monitor_def` instead of
doing the conversion inside `display_write_monitor_layout_pdu`.
2019-06-03 14:30:17 +03:00
kubistika
340d877cce
server/proxy: Proxy pointer updates
...
* Moved update callbacks of client to pf_update.h
2019-05-29 10:06:18 +03:00
kubistika
72952c679f
fix vs2010 errors
2019-05-28 09:30:39 +03:00
kubistika
52e4baa949
server/proxy: Code refactor
2019-05-28 09:30:38 +03:00
kubistika
aa262d341d
server/proxy: Use winpr library in proxy/filters
2019-05-26 15:32:49 +03:00
kubistika
7477ac19a7
server/proxy: Fix free invalid memory when pf_server_parse_target_from_routing_token fails
2019-05-26 10:48:10 +03:00
kubistika
76012fb5d6
server/proxy: Fix mem leak in pf_server_parse_target_from_routing_token
2019-05-26 10:48:10 +03:00
kubistika
20e503421e
server/proxy: Remove unnecessary wrap for connection info
2019-05-26 10:48:10 +03:00
kubistika
2126024321
server/proxy: Add docs in filters_api.h
2019-05-26 10:48:10 +03:00
kubistika
8e642c9d00
server/proxy: Add return statement in demo_filter.c
2019-05-26 10:48:10 +03:00
kubistika
98f698cf2b
Add README for filters API
2019-05-26 10:48:10 +03:00
kubistika
7237624b37
bugfix: segfault when calling an event which is not implemented by filter
2019-05-26 10:48:10 +03:00
kubistika
96616bb18c
server/proxy: Use new parse_string_array_from_str implementation (using ArrayList)
2019-05-26 10:48:10 +03:00
kubistika
3a750810f7
server/proxy: Refactor pf_server.c
2019-05-26 10:48:10 +03:00
kubistika
c4d72c6ad2
server/proxy: Refactor pf_server_parse_target_from_routing_token
2019-05-26 10:48:10 +03:00
kubistika
a39658fc2a
server/proxy: Add external filters support
2019-05-26 10:48:10 +03:00
kubistika
6bb5a1d579
server/proxy: Proxy errors back to client
2019-05-19 14:42:27 +03:00
Mati Shabtay
b907324009
First version of an RDP proxy ( #5372 )
...
* server: Add proxy dir with barebones server
* sever/proxy: Remove licensing
* server/proxy: Add client files
* server/proxy: rm binary
* server/proxy: Formatting
* server/proxy: Fixed includes and added basic client creation functionality
* server/proxy: Remove licensing and fix ifndef
* proxy/server: Fix cmake indentation
* server/proxy: Fix licensing
* server/proxy: Forward connection on peer_post_connect
* server/proxy: Fix function signature
* server/proxy: Changed function signature of proxy_client_start
* server/proxy: Now peer_post_connect calls proxy_client_start in a new thread
* pfreerdp.c: Clean up useless comments and logs
* server/proxy: Fix license
* server/proxy: Remove all non-connection related data from proxy_context
* server/proxy: Move Log Tag definition to pf_log.h
* server/proxy: Move context definition to pf_context
* server/proxy: Delete pfreerdp.h
* pfreerdp.c: Move context callbacks to pf_context.c
* server/proxy: Update CMakeLists.txt
* pf_channels: Use new proxy context API
* pf_client: Move context to pf_context
* pf_client.c: Remove unnessecary event handling
* server/proxy: Formatting
* proxy/server: Move server logic to pf_server.c
* server/proxy: Handle client disconnection
* Merge stash
* pf_server.c: Open GFX Connection to client
* server: CMakeLists: build proxy along with other servers
* server: proxy: get target server from rdpNego->RoutingToken
Iv'e omitted a check from which im not sure is right. Should check in docs
* server/proxy: Handle remote server -> client disconnection
* server/proxy: Move common function to pf_common.c
* server/proxy: Move common function to pf_common.c
* rdpgfx.h: Add reference to freerdp.h for rdpContext
* pf_channels: Pipe GFX on channel connection
* server/proxy: Add pf_rdpgfx for proxy gfx callbacks
* pf_client: Declare dynvc and gfx capabilities on connection
* server/proxy: Add graphics callbacks
* server/proxy: Add graphics callbacks
* pf_server: Listen to channel events
* Pass user settings to server
* pf_server: Proxy mouse events
* fixup! server/proxy: Add graphics callbacks
* pf_client: Fix setting initialization
* Merge feat/proxy-gfx to feat/proxy
* pf_server: Fix double freed credentials
* server/proxy: Remove unnecessary call to freerdp_client_settings_parse_command_line
* server/proxy: Refactor re-activation code
* server/proxy: Run format scripts
* server/proxy: Fix segfault when post_disconnect return FALSE
* server/proxy: Refactor proxy_settings_mirror
* server/proxy: Redirect credentials
* server/proxy: move proxy_settings_mirror to pf_common.c
* server/proxy: Redirect desktop_resize event
* pf_client: Remove interactive CLI auth methods
* fixup! server/proxy: Redirect credentials
* server/proxy: Rename proxy_mirror_settings to pf_common_copy_settings
* pf_server.c: Fixed non-freed context
When the disconnection is forced by the target server, the function
`pf_server_handle_client_disconnection` isn't called. Therefore, the
context of the connection between the proxy to tagrget isn't freed.
* fixup! pf_server.c: Fixed non-freed context
* pf_client: Prefix all client methods with pf_client
* pf_context: Add init client to proxy context method
* pf_server: Confirm all GFX caps regardless of settings
* pf_server: Prefix all methods with pf_server
* pf_server: Move variable decleration to start of method
* pf_server: Fix client setting
* pf_server: Fix GFX init method
* pf_server: Move variable decleration to start of methods
* server/proxy: Formatting
* Merge feat/proxy
* pf_server: Proxy synchronize event
* pf_server: Proxy refresh rect update events
* pf_server: Proxy suppress output messages
* server/proxy: Fix licensing
* server/proxy: Move client input callbacks to pf_input
* server/proxy: Move client update callbacks to pf_update
* server/proxy: Fix non-terminated target host string
* Feat/proxy config (#2 )
* server/proxy: Add config loading support
* server/proxy: Add config file
* server/proxy: Format code
* server/proxy: Code refactor, rename update_register_callbacks and input_register_callbacks
* server/proxy: Update config file
* server/proxy: Remove config.ini from root directory
* Remove comment from config file
* server/proxy: Fix leak in pf_server_load_config
* server/proxy: Add rdpServerProxy struct and embed it in proxyContext
* server/proxy: Load configuration and pass it inside every proxyContext instance
* server/proxy: Move rdpProxyServer to proxy.h
* server/proxy: Use configuration while proxying input events
* server/proxy: Update CMakeLists
* server/proxy: Refactor pf_input.c
* server/proxy: Add AllowedChannels, DeniedChannels in configuration
* server/proxy: Remove unnecessary variable from parse_channels_from_str
* server/proxy: Update config file
* server/proxy: config: Rename to
* server/proxy: config: Add mode - blacklist/whitelist
* server/proxy: Refactor, fix NULL deref
* server/proxy: Add license to proxy.h
* server/proxy: Fix newline in pf_config.c
* server/proxy: config: Rename Mode to WhitelistMode
* Add target in config. Add checks for configuration validity (#3 )
* Add target in config. Add checks for configuration validity
* Update config file
* libfreerdp: nego: revert commented out check of routingToken length
* pf_server: Fix target host info from RoutingToken
* pf_server: Remove hardcoded lenght of routing token prefix
* Feat/refactor context (#8 )
* Refactor main structs
* Update CMakeLists.txt
* pf_server.c: Free pdata at the end of the connection
* Run format scripts
* Rename tf to pc
* Fix licenses
* pf_server: Refactor names of structs and functions
* proxy: gfx: sync caps (#4 )
* proxy: gfx: sync caps
* proxy: gfx: sync caps, hook gfx client's OnClose() call and close server resources
* fixup! Feat/refactor context (#8 )
* fixup! fixup! Feat/refactor context (#8 )
* rdpgfx/client: Fix rdpgfx_recv_caps_confirm_pdu caps set length parsing
* Run format scripts
* proxy config.ini: Change default port to 3389
* pf_rdpgfx: Limit caps version to freerdp's supported versions
* Gfx OnOpen() wait for dynvc ready (#10 )
* proxy/gfx: Wait for dynvc ready state before open
* pf_channels: Initialize pc->gfx
* pf_rdpgfx: Add log and fix comments
* rdpgfx: Fix GFX v10.6 PDUs parsing and naming according to the spec
* pf_rdpgfx: Proxy rdpgfx v10.6 PDUs
* gfx client: Publish FrameAck sending and add auto ack flag
* proxy/gfx: Forward frame ack messages
* pf_context: Forward domain on connection
* pf_rdpgfx: Change max supported caps to 10.6
* proxy: Update config
* server/proxy: Use configuration in pf_server_handle_client
* rdpgfx/client: Fix size of surface_to_scaled_window, surface_to_window
* pf_rdpgfx: Fix formatting
* pf_server.c: Fix comments
* Move pf_server_rdpgfx_init to pf_rdpgfx
* server/proxy/CMakeLists.txt: Fix formatting
* pf_client.c: Add comment in proxy_server_reactivate
* Fixed const correctness of gfx function pointer
Signed-off-by: Mati Shabtay <matishabtay@gmail.com>
* server: proxy: update copyright
* server: proxy: wrap rdpNego and add a getter for routing token
* Refactor routing token getter (#14 )
* Refactor routing token getter
* pf_server_parse_target_from_routing_token change routing_token_length to be DWORD
* libfreerdp/core/nego.c: Run format script
* pf_server: Run format script
* server/proxy: Fix os msbuild tests
* pf_channels.c: Remove unused channels
* pf_client: Remove unused callbacks
* proxy: Remove encomsp callbacks from proxy's client
* client/rdpgfx_main.c: Fix msbuild test
* pf_config.c: Use StrSep instead of strsep for Windows builds
* Removed nego struct from direct access.
Signed-off-by: Mati Shabtay <matishabtay@gmail.com>
* proxy: Rename binary to freerdp-proxy
* rdpgfx_main.c: Revert unwanted double change to send_supported_caps
* Cleaned up proxy server code.
* All internal functions static
* Added simple command line argument to supply a config file
* Silence compiler warnings
Signed-off-by: kubistika <kmizrachi18@gmail.com>
2019-05-17 14:32:54 +02:00
Armin Novak
93bf375686
Refactored settings getter/setter to stay compatible.
2019-05-08 14:35:25 +02:00
Armin Novak
d7ca2db62e
Fixed doulbe semicolon in C files.
2019-05-08 12:58:01 +02:00
Armin Novak
7b2608a938
Added gfx capability filter option.
...
With this new option it is possible to selectively disable certain
GFX capability versions. This way buggy behaviour can be addressed
at runtime.
2019-05-08 11:43:22 +02:00
Armin Novak
3b7e46fb0e
Updated GFX to 10.6 spec
2019-05-07 12:10:13 +02:00
Armin Novak
841cb70f91
Fixed const correctness of gfx function pointer
...
Signed-off-by: Mati Shabtay <matishabtay@gmail.com>
2019-05-05 16:17:15 +03:00
Armin Novak
27d2a9e040
Fixed unused argument warnings.
2019-04-05 09:14:35 +02:00
Armin Novak
e76b5d442b
Silenced unused parameter warnings, added log messages.
2019-04-05 09:14:35 +02:00
Armin Novak
8b5ef6f41f
Silenced unused parameter warnings, added log messages.
2019-04-05 09:14:35 +02:00
Armin Novak
f4de82c242
Fixed sign-compare warnings
2019-04-05 09:13:24 +02:00
Armin Novak
e8c8e7b6d0
Updated EGFX support to 10.6
2019-02-27 16:36:15 +01:00
Armin Novak
53b018bfef
Fix callback function return types.
2018-12-04 09:34:22 +01:00
Armin Novak
edd6d49f23
Fix #4909 : Do not initialize HOME environment variable as it is no longer used.
...
GetKnownPath does not require this environment variable to be
available for windows builds.
2018-11-29 13:44:21 +01:00
Armin Novak
c8908c8be6
Updated windows shadow server assistance usage.
2018-11-22 11:11:31 +01:00
Armin Novak
26b83ea74e
Reenabled and fixed windows server compile.
2018-11-15 09:01:53 +01:00
Armin Novak
02f68c35b9
Fixed -Wextra sign warnings
2018-10-24 13:25:31 +02:00
Armin Novak
88d310ff2c
Fixed compiler warnings (casts, ...)
2018-10-18 09:09:30 +02:00