Commit Graph

14595 Commits

Author SHA1 Message Date
Martin Fleisz
dc88b19d18
Merge pull request #6558 from akallabeth/drdynvc_lock_fix
Clean up drdynvc channels porperly locked.
2020-11-09 09:25:27 +01:00
odednoam
88102275f0
Bugfix: when freerdp_assistance_parse_file_buffer was called from external code, it did not copy the access password to the rdpAssistanceFile struct. (#6550)
* Fixed bug with assistance buffer parsing: `freerdp_assistance_parse_file_buffer` may be called directly, not necessarily from `freerdp_assistance_parse_file`, so password should be saved to the `rdpAssistanceFile` in `freerdp_assistance_parse_file_buffer`.
2020-11-09 09:19:53 +01:00
akallabeth
7f1cca78aa Clean up drdynvc channels porperly locked. 2020-11-06 13:38:47 +01:00
Martin Fleisz
c5f746d71a
Merge pull request #6556 from akallabeth/autoreconnect_fix
Fixed reset of MessageQueue in Clear
2020-11-06 13:13:18 +01:00
akallabeth
59ef9a7e8b Fixed reset of MessageQueue in Clear 2020-11-06 13:02:01 +01:00
akallabeth
6e3c00725a Cleaned up collections:
ArrayList, MessageQueue, Queue, PubSub, BipBuffer
ObjectPool and BufferPool
2020-11-06 12:30:13 +01:00
Martin Fleisz
96bb569674
Merge pull request #6551 from akallabeth/queue_fix
Reset Queue_Event when Queue_Clear is called.
2020-11-05 15:43:48 +01:00
akallabeth
a5989429f7 Reset Queue_Event when Queue_Clear is called. 2020-11-05 15:32:17 +01:00
Martin Fleisz
b5fa928311 core: Fix race when deleting channel manager
This PR fixes a possible crash when the channel manager was freed and
there were pending messages in the message queue.
The problem was that even though the message queue already received the
WMQ_QUIT message, it was still possible to enqueue messages after this
point. This resulted in unprocessed messages in the queue when it was
deleted. The delete handler then called into channel handlers which
where aleady freed/deleted.
With this PR adding messages after WMQ_QUIT was posted to the message
queue returns an error and all channel messages are now processed before
the channels are closed/terminated.
2020-11-03 17:08:58 +01:00
Martin Fleisz
81e79a8bac
Merge pull request #6543 from akallabeth/pool_fix
Fixed locking issue, removed broken functions
2020-11-02 11:09:23 +01:00
akallabeth
516fc9b910 Fixed locking issue, removed broken functions 2020-11-02 09:23:11 +01:00
Martin Fleisz
e72c35447c
Merge pull request #6541 from akallabeth/streampool_lock_fix
Unify StreamPool locking.
2020-10-30 10:42:04 +01:00
akallabeth
0f2a8f214a Unify StreamPool locking. 2020-10-30 10:17:27 +01:00
Martin Fleisz
cec261c4db Cleanup internal channel management
This PR gets rid of some unneeded/unused field and functions in the
channel handling code. It also makes it possible to call
VirtualChannelWrite from any thread like the Windows API allows. The
only restriction is that the channel must be initialized
(VirtualChannelInit) from the same thread that called freerdp_connect.
2020-10-29 15:53:32 +01:00
Martin Fleisz
c47b15945b
Merge pull request #6499 from akallabeth/leak_fixes
Fixed leak on cursor update.
2020-10-29 12:08:16 +01:00
Martin Fleisz
80cba204c0
Merge pull request #6521 from akallabeth/mac_fixes
Mac fixes
2020-10-28 09:55:20 +01:00
Martin Fleisz
e1d7f6111c
Merge pull request #6535 from akallabeth/mac_mouse
Fix for mac mousewheel.
2020-10-28 09:47:16 +01:00
Martin Fleisz
7be04e212b
Merge pull request #6466 from akallabeth/memsan
Memsan: fixes (most) unit tests for use with memory sanitizer
2020-10-28 09:46:12 +01:00
Keith Johnston
c0ecee9d69 Fix for mac mousewheel.
(cherry picked from commit 87a4a8484e)
2020-10-28 08:17:53 +01:00
akallabeth
6e5f5de439 Do not abort disc hotplug if no access to mount tab. 2020-10-27 15:45:56 +01:00
akallabeth
896b7bc711 Added support for xwayland keyboard grab 2020-10-27 15:45:44 +01:00
Armin Novak
11ca443aaf Fixed NtStatus2Tag return. 2020-10-27 07:41:04 +01:00
akallabeth
55b95769d0 Fixed #6518 2020-10-21 19:48:27 +02:00
Armin Novak
a2e9f5efcb Fixed mac app termination and warnings 2020-10-21 19:44:09 +02:00
Armin Novak
0e0eb5f41f Added permission checks for mac audio backend. 2020-10-21 19:44:09 +02:00
Martin Fleisz
e18597f5eb
Merge pull request #6516 from akallabeth/tumbleweed
Fix warning #6515
2020-10-16 08:27:25 +02:00
akallabeth
6d8f355633 Fix warning #6515 2020-10-16 08:14:13 +02:00
Martin Fleisz
65ee6e3280
Merge pull request #6509 from akallabeth/glyph_parser_fix
Fixed parsing of FastGlyph order.
2020-10-15 14:08:24 +02:00
akallabeth
c0284239a7 Fixed remarks. 2020-10-15 11:03:46 +02:00
akallabeth
ef8f1fd9f0 Refactored reading of optional order bytes 2020-10-15 11:03:46 +02:00
akallabeth
0456fc307c Fixed parsing of FastGlyph order. 2020-10-15 11:03:46 +02:00
Martin Fleisz
fa0d77e779
Merge pull request #6513 from akallabeth/fd_flags
Corrected name for FD_WRITESTIME
2020-10-15 10:51:57 +02:00
akallabeth
f3c2985249 Disable ios client until maintained. 2020-10-15 10:31:05 +02:00
akallabeth
a7b210d448 Increased minimum ios deployment target. 2020-10-15 09:49:02 +02:00
akallabeth
5133c4e424 Corrected name for FD_WRITESTIME 2020-10-15 08:33:14 +02:00
Martin Fleisz
0eec7c0e90
Merge pull request #6501 from kubistika/server_wts_api_extended
server: add WTSVirtualChannelManagerCheckFileDescriptorEx API
2020-10-14 11:14:00 +02:00
Martin Fleisz
bf2abac8db
Merge pull request #6511 from akallabeth/fd_flags
Updated FD_FLAGS definition.
2020-10-14 09:47:07 +02:00
Armin Novak
a22f264189 Added backward compatibility define 2020-10-14 09:19:57 +02:00
Armin Novak
ef1c8a3b50 Updated FD_FLAGS definition. 2020-10-14 09:19:00 +02:00
Peter Harris
63ef97a2b3 core/nla: fix order of operations
The order of evaluation of the two sides of addition is undefined in C.
Since there is no sequence point between ber_write_contextual_tag and
ber_write_octet_string, these two functions can be called in any order.

Force the correct order by breaking the two function calls into two
separate statements.
2020-10-06 17:19:38 +02:00
kubistika
437bfeb588 include: rdpgfx: add extern C for public API 2020-10-06 13:22:17 +03:00
Kobi Mizrachi
e0fa47f3b3 server: add WTSVirtualChannelManagerCheckFileDescriptorEx API 2020-10-06 13:17:38 +03:00
Martin Fleisz
b37081a35c
Merge pull request #6497 from akallabeth/clip_flag_fix
Corrected clipboard capability mask
2020-10-05 10:32:30 +02:00
akallabeth
488ffe31fc Fixed leak on cursor update. 2020-10-05 09:45:45 +02:00
akallabeth
e4243bb33c Corrected clipboard capability mask 2020-10-02 13:17:00 +02:00
Ilya Shipitsin
b62da2cbcc channels/disp/client/disp_main.c: fix possible null pointer dereference
found by cppcheck

channels/disp/client/disp_main.c:340:7: warning:
Either the condition 'if(disp&&disp->listener_callback)' is redundant or
there is possible null pointer dereference: disp. [nullPointerRedundantCheck]
2020-10-02 09:58:03 +02:00
Martin Fleisz
1e0f41f3a3
Merge pull request #6491 from akallabeth/clip_file_flags
Added clipboard CB_HUGE_FILE_SUPPORT_ENABLED flag
2020-09-29 09:14:37 +02:00
akallabeth
f282c55c7a Added clipboard CB_HUGE_FILE_SUPPORT_ENABLED flag 2020-09-29 09:03:49 +02:00
Armin Novak
45a1f9cc19 Fix #6461: Generate config.h after all subdirectories are parsed. 2020-09-23 13:16:48 +02:00
Kobi
3317aa154a
Merge pull request #6486 from akallabeth/loop_fix
Fixed variable declaration in loop
2020-09-23 14:03:25 +03:00