akallabeth
c2f1562a4b
Removed freerdp_peer::input
2021-09-09 08:36:01 +02:00
Martin Fleisz
c2819a00c9
nla: Remove incorrect check when using NLA with a NULL identity
...
When using NLA with a NULL identity (in AcquireCredentialsHandle) on
Windows the client sends the first NLA package with cbBuffer set to 0.
In that case the client currently incorrectly kills the connection. With
this PR the check is removed and the client correctly connects to the server.
2021-09-08 14:02:00 +02:00
akallabeth
64403d9d40
Refactored rdpFastpath
...
* Structure now opaque
* Added WINPR_ASSERT where appropriate
2021-09-06 10:11:14 +02:00
akallabeth
c17ba281a3
Fixed default return for missing SurfaceBits callback
2021-09-06 10:11:14 +02:00
akallabeth
d7d7c45b0e
Cleaned CONNECT_STATE transition function
2021-09-06 10:11:14 +02:00
akallabeth
c2a7a78d94
Changed transport IO functions to take rdpContext
2021-09-06 10:11:14 +02:00
akallabeth
32b3f54bb3
Expose CONNECTION_STATE via public API
...
* Expose type CONNECTION_STATE
* Add getter freerdp_get_state
* Add helper freerdp_state_string
2021-09-06 10:11:14 +02:00
akallabeth
ad86192ac6
Fixed TestConnect
...
* Due to a typo (and missing argument checks in sample-server) the
command line for the test was invalid.
2021-09-06 10:11:14 +02:00
akallabeth
af8d1e5690
Updated settings
...
* Generator script now WINPR_ASSERT if invalid arguments are
supplied
* Updated settings with new generated getter/setter
2021-09-06 10:11:14 +02:00
akallabeth
df3d58bab3
Fixed rdp_set_io_callbacks
...
* Cache transport default callbacks in rdp_new
* Cache and update transport callbacks in rdp_set_io_callbacks
2021-09-06 10:11:14 +02:00
akallabeth
00ac11524e
Wrapped rpdRdp:state access in getter/setter
...
* Only access state via getter/setter
* Better state debuggind with log messages on state transition
2021-09-06 10:11:14 +02:00
akallabeth
595a40a1e0
Transport add getter, add checks
...
* Added transport_get_context to get rdpContext in IO callbacks.
* Added WINPR_ASSERT where possible.
* Fixed handle count mismatch in transport_get_event_handles
2021-09-06 10:11:14 +02:00
Armin Novak
3170f4cfd4
Update TestConnect to generate certificates
...
After removing the default certificates from the repo now generate
temporary ones for TestConnect
2021-09-04 18:01:30 +02:00
Armin Novak
50e9d3adf9
Implemented new AuthenticateEx callbacks.
2021-09-04 18:01:30 +02:00
Armin Novak
fbae9ba88c
Added LoadLibraryX and LoadLibraryExX
...
These functions take a UTF8 string and load a library with
LoadLibraryW under windows.
2021-09-03 08:29:15 +02:00
Armin Novak
737f5a2036
Fixed argument const correctness
2021-08-27 13:21:02 +02:00
akallabeth
f1bde376b1
Raw channel send ( #7255 )
...
* Added raw channel data write function
* Use nego_set_state
* Added ArrayList_ForEachAP
* Provide va_copy for older VS compilers
2021-08-26 16:17:51 +02:00
Armin Novak
68f24477f6
Fixed compilation warnings on mac
2021-08-26 15:08:28 +02:00
Armin Novak
13f54fc0dd
Improved fingerprint hash comparison
...
* Allow new hash format 11bbccdd along already supported 11:22:aa:BB
2021-08-26 09:38:12 +02:00
Armin Novak
06c883a709
Fix #7249 : Endless loop in NLA
2021-08-26 09:26:34 +02:00
Armin Novak
c073ca8ac8
Use MAXIMUM_WAIT_OBJECTS
2021-08-25 13:41:38 +02:00
Armin Novak
054f0ea260
Use defines instad of channel names
2021-08-25 10:54:24 +02:00
Armin Novak
d9ea91361c
Fixed freerdp_peer_free
...
* Close socket on free
* Added WINPR_ASSERT for all dereferenced pointers
2021-08-24 15:05:36 +02:00
akallabeth
617293e0d3
Cleanups ( #7239 )
...
* Use freerdp_settings_* for shadow and sample server
* Added freerdp_peer_set_local_and_hostname
* Code cleanups and WINPR_ASSERT
* Code cleanups
* Use CHANNEL_NAME_LEN where appropriate
* Use temporary variables in loop instead of direct array access
2021-08-24 14:09:40 +02:00
Armin Novak
5afa592244
Fixed cast-qual warnings
2021-08-24 11:10:51 +02:00
Armin Novak
5eea7fc12d
WINPR_UNUSED argc, argv for unit tests
2021-08-24 10:45:57 +02:00
Armin Novak
f515bd4560
Fixed shadowing and type errors
2021-08-24 10:45:57 +02:00
Simon Nivault
e42696bb2e
Some fixes for audin redirection ( #7231 )
...
* Fixed research for native PCM format
* Fixed compatibility detection for resampling
* dsp: Makes channel mix and encoding process use separated buffers
* Give FramesPerPacket to freerdp_dsp_context_reset function
* dsp: Fix DVI_ADPCM codec by respecting the required packet size
* Forbid mono channel in macos
* Fix audin command line channel option
* Disable ADPCM codec as it does not work
* Refactor valid native codec research
* Native codec research: Try different channels number
* Fix dsp channel mix
* Fix dsp resample
2021-08-23 14:49:28 +02:00
akallabeth
a7cdd03809
Fixed check of orderLength for secondary orders ( #7233 )
...
The orderLength field of [MS-RDPEGDI] 2.2.2.2.1.2.1.1 might be
negative if not adjusted for the 13byes of the header.
2021-08-23 12:08:35 +02:00
Armin Novak
610396e197
Fixed compilation warnings
...
Try to get the number of warnings down
2021-08-02 10:28:06 +02:00
Armin Novak
4b7aa61abd
Fixed tls_write_all, abort if blocked
...
If data to be read is blocking the socket abort.
2021-07-29 15:09:53 +02:00
Armin Novak
61b46adaf1
Fixed WITH_WINPR_VERBOSE_ASSERT compile flag
...
* Compile flag was not always set
* Fix broken WINPR_ASSERT usages detected
2021-07-29 15:09:53 +02:00
Armin Novak
d65d4ee4fb
Allow variable arguments to setChannelError
2021-07-29 15:09:53 +02:00
Martin Fleisz
ca8f7d7174
rdg: Fix mem leak and oob write in rdg websocket close reply ( #7173 )
2021-07-14 11:22:41 +02:00
Armin Novak
6e075a6a7d
Fixed #7158 : detection of arm neon.
2021-07-08 07:54:26 +02:00
akallabeth
2ac12c558a
Added option to allow planar topdown encoding.
2021-07-02 09:53:24 +02:00
akallabeth
77a7e4010f
Added bounds checks to ExtractRunLength
2021-07-02 09:53:24 +02:00
akallabeth
5a85a824d2
Used settings getter/setter for NSCodec
2021-07-01 11:56:17 +02:00
akallabeth
6deb65175f
Added GFX planar and rfx encoder to shadow
2021-07-01 11:56:17 +02:00
akallabeth
bd256b91bc
Fixed disabling of AVC444 mode if requested
2021-07-01 11:56:17 +02:00
akallabeth
242f1734ec
Fixed dpkg-buildpackage warnings
2021-06-30 11:57:23 +02:00
akallabeth
457b198c11
Properly reset gfx->codecs after free.
2021-06-30 09:08:49 +02:00
Armin Novak
42df492450
Progressive compress cleanup
2021-06-28 18:29:47 +02:00
Armin Novak
98ed05ff5c
Added PROGRESSIVE codec to shadow
2021-06-28 16:51:27 +02:00
Armin Novak
fd08c77f7f
Fixed definition of config.h symbols
2021-06-28 15:06:30 +02:00
Armin Novak
a7f7de549a
Added SuspendInput setting
...
Allows to disable all keyboard/mouse/multitouch input from the
client side.
2021-06-28 14:35:26 +02:00
Armin Novak
e5eb6368e5
Added missing GFX sanity check
2021-06-28 13:25:33 +02:00
akallabeth
534d30beb3
No deprecated ( #7107 )
...
* Removed cmake options disabling compiler warnings
* Added deprecation compile options
* Fixed android client use of deprecated symbols
* Removed obsolete callback
2021-06-22 14:39:10 +02:00
Armin Novak
8ef57bf296
Replaced CMAKE_[SOURCE|BINARY]_DIR with PROJECT_[SOURCE|BINARY]_DIR
...
Thanks @Pollux42 for the hint in #7096
2021-06-22 08:54:18 +02:00
akallabeth
b453d5e40e
Fixed rdtk, uwac and winpr standalone builds
2021-06-22 08:54:18 +02:00
Armin Novak
f1dc3a0494
Fixed use of deprecated function
2021-06-21 13:27:39 +02:00
Armin Novak
6eab6391c7
Fixed invalid return value conversion
2021-06-21 13:27:39 +02:00
Armin Novak
09111c9270
libfreerdp: Fixed warnings, added assertions
2021-06-18 11:32:16 +02:00
Armin Novak
09cf11ecf0
WinPR: Fixed warnings, added assertions
2021-06-18 11:32:16 +02:00
akallabeth
6726772d8d
Fixed integer warnings
2021-06-18 09:41:02 +02:00
akallabeth
8d82adb28a
Fixed warnings
2021-06-17 10:35:22 +02:00
Armin Novak
2e0d1cc33c
Fixed integer warnings, fixed data types
2021-06-17 10:35:22 +02:00
Armin Novak
d9a8083ddf
Added WINPR_NORETURN, fixed warnings
2021-06-17 10:35:22 +02:00
Armin Novak
e71760a710
Fixed lots of compilation warnings and type mismatches
2021-06-17 10:35:22 +02:00
akallabeth
112400ca66
Removed stub for x264, not implemented
2021-06-16 15:21:56 +02:00
Armin Novak
5fb59a23a9
Fixed lots of compilation warnings and type mismatches
2021-06-16 15:21:56 +02:00
Armin Novak
ccfe0c129e
Removed checks already done by WINPR_ASSERT
2021-06-16 11:46:42 +02:00
Armin Novak
31862e60f9
Added missing return checks
2021-06-16 11:46:42 +02:00
Armin Novak
c2bef2bfa9
Fixed return value checks for ArrayList_Append and HashTable_Insert
2021-06-16 11:46:42 +02:00
Armin Novak
ea8858c705
Renamed planar ALIGN macro to avoid name collission on osx
2021-06-16 11:46:42 +02:00
Armin Novak
d6c84c28fb
Renamed ArrayList_Add to ArrayList_Append
...
* Do not break API silently
2021-06-16 11:46:42 +02:00
Armin Novak
a1c8e4cf85
Refactored ArrayList_Add to conform to other functions
2021-06-16 11:46:42 +02:00
Armin Novak
880c603c26
Renamed HashTable_Add to HashTable_Insert
...
* Since the changes break HashTable_Add rename it so that it will
not fail silently
2021-06-16 11:46:42 +02:00
Armin Novak
d36d94766e
Replaced assert with WINPR_ASSERT
2021-06-14 09:37:07 +02:00
akallabeth
460fef545d
Refactored NLA
...
* Simplified client/server state machine
* Encapsulated steps in functions
* Added proper debug logging so that state changes are easy to
follow
2021-06-09 11:03:37 +02:00
akallabeth
bfbe6b62b5
Removed GSS_API error code hacks
2021-06-09 11:03:37 +02:00
Armin Novak
959923c633
Fixed codeQL warnings
2021-06-08 08:21:47 +02:00
Armin Novak
c5fded2d83
Improved runtime of unit tests
2021-06-08 08:21:47 +02:00
Armin Novak
2a91afb0cf
Added adjustable tcp connect timeout
2021-06-08 08:21:47 +02:00
Armin Novak
7586ffd913
Fixed issues with planar codec buffer alignment
...
Align width and height to next multiple of 4 to avoid issues with
internal buffer sizes.
2021-06-02 13:11:24 +02:00
Armin Novak
7f5f91766a
Increased TestSuccess startup delay
...
jenkins run tests are really slow :/
2021-06-01 14:18:01 +02:00
Armin Novak
4f4e546cd4
Fixed initial alpha values for codec buffers
2021-06-01 14:18:01 +02:00
Biswapriyo Nath
06315d0c5c
codec/h264: Remove unused IMFDXGIDeviceManager and GUIDs declarations.
2021-05-31 13:38:19 +02:00
Biswapriyo Nath
173ab04b59
Use same data types as calling function prototypes.
2021-05-31 13:38:19 +02:00
akallabeth
6b36c6d417
Replace fopen and path functions with wrappers ( #7043 )
...
Functions like fopen, PathFileExists, PathMakePath need to call
the wide character versions on windows for utf-8 support.
2021-05-31 11:42:03 +02:00
akallabeth
8e43f90590
Fixed #7045 : allow NULL isser and subjects in certificates
2021-05-28 09:25:33 +02:00
akallabeth
fa73a2ba55
Fixed const correctness warning
2021-05-28 09:25:33 +02:00
Pascal Nowack
e8d146be71
codec/progressive: Allow the usage of multithreading for decoding
...
While decoding RemoteFX encoded frames is multithreaded, decoding
RemoteFX Progressive frames is not, although both codecs work
relatively similarly.
This is especially noticeable with frames, that have a resolution
larger than 1920x1080 pixels.
decompress_tile_first() and decompress_tile_upgrade() can both run in
different threads at the same time for different tiles without necessary
adjustments.
So, do exactly that using the ThreadPool that already exists in the
RFX_CONTEXT to decrease the decoding time and therefore increase the
performance.
On a 3K display (2880x1620 pixels) this makes out of a choppy
experience a fluid experience.
2021-05-25 10:16:36 +02:00
Pascal Nowack
11248b18c1
codec/progressive: Fix a memory leak
...
When checking whether tiles and updatedTileIndices are both non-NULL,
one of them might be NULL, while the other struct member might not
be NULL and progressive_surface_context_new() leaks then the non-NULL
struct member.
Fix this by freeing both struct members, when aborting in
progressive_surface_context_new().
free() will take no action on pointers that are NULL, so no additional
check is needed.
2021-05-25 10:16:36 +02:00
Theo Buehler
9914dbc770
Fix build for upcoming LibreSSL version
...
SSL will become opaque in LibreSSL 3.4.x, hence the code reaching inside
it will result in build breakage. This was done at the time for lack of
BIO_up_ref() support, which has been available since LibreSSL 2.7.0, so
adjust the relevant #ifdefs accordingly.
2021-05-25 10:06:32 +02:00
Biswapriyo Nath
37bbf9d218
CMake: Install DLLs in bin folder.
...
In Win32 platform, executables and runtime libraries need to be in one folder.
2021-05-25 09:41:44 +02:00
akallabeth
ddfdbb1300
Added rdg_read_http_unicode_string error messages
...
Added log entries in case something in the packet is wrong
2021-05-25 08:54:09 +02:00
Armin Novak
6f2c6625e4
Added FREERDP/WINPR prefix to define GIT_REVISION
2021-05-18 13:37:34 +02:00
Armin Novak
2b19576fc7
Fixed compiler warnings, function arguments and const parameter
2021-05-18 13:37:34 +02:00
akallabeth
80d7f206af
Refactored settings string setter ( #7014 )
...
* Common function to clear strings
* Set string memory to '\0' before free
2021-05-18 11:22:27 +02:00
akallabeth
3765a9fe35
Fixed AAC encoding for microphone
...
* Fixed b-frame interval for FFMPEG
* Fixed sample size for FAAC
2021-05-11 15:33:23 +02:00
akallabeth
c10a030ec6
Fixed use fo crypto_rsa_public_encrypt in license module
2021-05-11 08:00:18 +02:00
akallabeth
d4ebf8546f
Cleaned up crypto API
2021-05-11 08:00:18 +02:00
akallabeth
b494a193db
Refactored certificate API:
...
* Proper encapsulation
* known_hosts2 backend extended (storing PEM)
* New backend storing each host certificate in a file
2021-05-11 08:00:18 +02:00
akallabeth
c3171b90cb
Removed unit tests for legacy known_hosts file
2021-05-11 08:00:18 +02:00
akallabeth
384f997aa7
Removed support for obsolete known_hosts file.
2021-05-11 08:00:18 +02:00
akallabeth
ab49694101
Added new RDP file options
2021-05-11 07:59:05 +02:00
akallabeth
9e466abe6f
Fixed #6989 : Use X509_STORE_set_default_paths
2021-05-03 13:37:26 +02:00
Armin Novak
bad528d36b
Added version check for deprecated ffmpeg symbols
2021-05-03 10:38:35 +02:00
Biswapriyo Nath
a3a89a43f7
Fix intialization, remove some unused variables.
2021-04-28 17:11:31 +02:00