Commit Graph

19549 Commits

Author SHA1 Message Date
akallabeth
c7efbf5b8e
[core,proxy] fix nonblocking BIO reads
* In case of non-blocking BIO layers the proxy read functions bailed
  out with an error. Retry reading in that case unless the
  TcpConnectTimeout is exceeded
* Terminate proxy read operations if rdpContext::abortEvent is set
2024-09-17 10:37:19 +02:00
akallabeth
6c88d89566
Merge pull request #10616 from hardening/rail_text_scale
rails: add missing functions client implementation
2024-09-16 19:56:30 +02:00
David Fort
8cc9e5f4e9 rails: add missing functions client implementation
The client side callbacks for textScale and CaretBlinkRate were not implemented.
2024-09-16 18:55:25 +02:00
akallabeth
8e1a2e3645
Merge pull request #10610 from akallabeth/vcapitype
[windows,32bit] fix VCAPITYPE consistency
2024-09-16 15:35:17 +02:00
akallabeth
f2e90eca34
[windows,32bit] fix VCAPITYPE consistency
Fixes #10581
2024-09-16 14:15:59 +02:00
akallabeth
073f1ee642
Merge pull request #10609 from akallabeth/warn
Fix unused return values
2024-09-16 12:03:31 +02:00
akallabeth
befa4233ad
[warnings] fixed bugprone-not-null-terminated-result 2024-09-16 08:22:42 +02:00
akallabeth
a19305569d
[assert] fix ULONG_MAX use
most of the time this was used to check ULONG limits. Replace with
correct UINT32_MAX
2024-09-16 08:22:40 +02:00
akallabeth
bb242b9a89
[return checks] fix use of WaitForSingleObject 2024-09-16 08:22:37 +02:00
akallabeth
965d231e49
[return checks] fix use of CloseHandle 2024-09-16 08:22:31 +02:00
akallabeth
cd18dea174
[return checks] fix use of unicode functions 2024-09-16 06:48:26 +02:00
akallabeth
f655843260
[return checks] fix use of rdpSettings getter/setter 2024-09-16 06:48:23 +02:00
akallabeth
c0d06c782b
[return checks] fix missing checks
* Stream_EnsureRemainingCapacity
* rdp_client_transition_to_state
2024-09-16 06:48:19 +02:00
akallabeth
07ea37d1d7
[return checks] fix use of CommandLineParseArgumentsA 2024-09-16 06:48:16 +02:00
akallabeth
4c8f6383ae
[return checks] fix use of freerdp_interruptible_getc 2024-09-16 06:48:13 +02:00
akallabeth
4d2197eab0
[return checks] fix use of TerminateThread 2024-09-16 06:48:11 +02:00
akallabeth
94020c183c
[return checks] fix use of ResetEvent 2024-09-16 06:48:09 +02:00
akallabeth
7c8c14294f
[return checks] fix use of ReleaseMutex 2024-09-16 06:48:06 +02:00
akallabeth
7d67b8e204
[return checks] fix use of SetEvent 2024-09-16 06:47:58 +02:00
akallabeth
80e0c68dca
Merge pull request #10608 from akallabeth/warn
Warnings fix apple related stuff
2024-09-15 20:39:38 +02:00
akallabeth
0d5bc92a2b
[warnings] fix apple iOS/macos 2024-09-15 19:47:13 +02:00
akallabeth
869bfd5e86
[client,android] mark includes SYSTEM 2024-09-15 19:47:03 +02:00
akallabeth
039e24bf48
Merge pull request #10607 from akallabeth/warn
Warnings fixed
2024-09-15 10:43:54 +02:00
akallabeth
0de75b305c
[warnings] fix unchecked return 2024-09-15 10:19:56 +02:00
akallabeth
1bd6d70057
[warnings] fix some warnings on mac os 2024-09-15 10:06:22 +02:00
akallabeth
a4a7019f97
[channels,rdpdr] fix uninitialized warnings 2024-09-15 09:58:41 +02:00
akallabeth
f7726ed7b6
[server,shadow] improve command line error logging
print an error message indicating where the parsing failed.
2024-09-15 09:21:38 +02:00
akallabeth
ba41d5e532
[warnings] fix unchecked return 2024-09-15 09:08:02 +02:00
akallabeth
687f946999
[channels,rdpear] fix length checks for 32bit size_t 2024-09-15 09:07:53 +02:00
akallabeth
f1be630637
[server,proxy] fix unchecked return 2024-09-15 09:07:49 +02:00
akallabeth
8a3f2be769
[rdtk] improve rdtk_font_load_descriptor_file
do simpler and better error handling
2024-09-15 09:07:38 +02:00
akallabeth
ca1791cfe8
Merge pull request #10606 from akallabeth/warn-fix
Warn fix
2024-09-14 21:44:34 +02:00
akallabeth
8b6091a007
[winpr,wtsapi] improve API usage
* Mark WTSVirtualChannelOpen and WTSVirtualChannelOpenEx with
  WINPR_ATTR_MALLOC to enforce compiler checks for resource cleanup
* Fix unused result warnings, use the result or cast to (void) where not
  requierd
2024-09-14 21:29:31 +02:00
akallabeth
a1cef8dd85
[warnings] silence and fix unused results 2024-09-14 21:29:28 +02:00
akallabeth
65de25205b
[winpr,env] add missing WINPR_ATTR_MALLOC 2024-09-14 21:29:26 +02:00
akallabeth
9cfd748b63
[core,nla] nla_read_TSRemoteGuardPackageCred
* fix maybe uninitialized arguments
* fix return in case of invalid packet
2024-09-14 21:29:24 +02:00
akallabeth
3460f64f57
[client,common] fix possible NULL dereference 2024-09-14 21:29:21 +02:00
akallabeth
2bcf2c50eb
[channels,rdpear] fix krb5 inclusion
* do not expose the krb5 include path in interface library, it is
  private to the object library
* fix include krb5.h instead of krb5/krb5.h
2024-09-14 21:29:18 +02:00
akallabeth
6327b77461
[winpr,crypto] fix type warnings in test case 2024-09-14 17:39:38 +02:00
akallabeth
7295f8a3b8
Merge pull request #10601 from akallabeth/warn-fix
[warnings] fix a bunch of them
2024-09-14 12:21:36 +02:00
akallabeth
0b9d35235b
[channels,rdpear] fix leak in rdpear_prepare_response 2024-09-14 08:31:29 +02:00
akallabeth
dbe92795e3
[winpr,kerberos] fix possible NULL argument to strdup 2024-09-14 08:31:01 +02:00
akallabeth
d5b41bb8a0
[warnings] fix casts
* Add macro WINPR_REINTERPRET_CAST to cast (checked) from type A to B
* Fix cast warnings
2024-09-14 08:24:51 +02:00
akallabeth
01c6447963
[clang-tidy] disable clang-analyzer-optin.performance.Padding
this is not a bug but a performance suggestion test. We don´t want these
mixed in with actual issues
2024-09-14 08:24:48 +02:00
akallabeth
5a711f5ae4
[winpr,collections] fix cast to float 2024-09-14 08:24:45 +02:00
akallabeth
d7f6cf90b4
[core,nla] add missing static for function 2024-09-14 08:24:43 +02:00
akallabeth
5f2ed9b8ce
[crypto,tls] explicitly cast function pointer 2024-09-14 08:24:40 +02:00
akallabeth
f0a73e3e9c
[channels,rdpear] fix inconsistencies in ndr.c/h 2024-09-14 08:24:38 +02:00
akallabeth
1c161b0270
[channels,rdpear] elimiate warnings 2024-09-14 08:24:35 +02:00
akallabeth
70b597ce1e
[utils,passphrase] fix unused result warning 2024-09-14 08:24:32 +02:00