David FORT
a53cb8190b
Added missing checks
2016-02-16 22:24:51 +01:00
Hardening
2a3e9996b3
Merge pull request #2710 from akallabeth/cert_temp_accept_v2
...
Extended certificate callbacks.
2016-02-15 13:52:47 +01:00
Nathan Kidd
d68e58a9dc
libfreerdp-codec: Make region16_rects() handle NULL nbRects
...
Now matches header documentation. Also cleans up related doc grammar.
2016-02-12 10:11:51 -05:00
Hardening
cbd1ffa571
Merge pull request #3110 from akallabeth/mac_os_ssl_warning_fix
...
Mac os ssl warning fix
2016-02-11 22:21:33 +01:00
Armin Novak
f4568295e9
Fixed API for old openssl versions < 1.0.0
2016-02-05 11:52:07 +01:00
Armin Novak
0e2208e942
Fixed warning.
2016-02-05 02:04:57 +01:00
Armin Novak
cbf2892ccc
Implemented temporary certificate accept.
...
Certificates can now be accepted temporarily.
The callbacks for certificate validation have been
modified to extend the information presented to the user.
2016-02-05 02:04:57 +01:00
Armin Novak
16699000c4
Fixed allocation issue with common_name.
2016-02-05 02:04:00 +01:00
Martin Fleisz
56a0c4c336
Merge pull request #3097 from akallabeth/android_api_upgrade_v4
...
Android api upgrade and restructuring
2016-02-04 16:20:59 +01:00
Armin Novak
3b0f5b5b48
Removed obsolete APPLE preprocessor switch.
2016-02-04 12:55:11 +01:00
Armin Novak
1b3ac98582
rdp_print_errinfo now uses INFO log level.
2016-02-04 11:41:54 +01:00
Armin Novak
cdadb58f93
Function freerdp_set_error_info fix
...
The public function did not wrap rdp_set_error_info.
2016-02-04 11:40:42 +01:00
Armin Novak
ad36a5c10f
Disconnect log message now uses debug level.
2016-02-04 11:39:57 +01:00
Christian Plattner
c0226d686c
Enable support for SNI on client side
2016-02-04 08:34:51 +01:00
Armin Novak
10956f3179
Fixed constant definition.
2016-02-03 11:51:31 +01:00
Armin Novak
22f704c0a8
Fixed _socket error check.
2016-02-03 11:45:22 +01:00
Vic Lee
73f895fd55
gcc: assigned string must not be freed.
2016-02-03 13:34:58 +08:00
Armin Novak
9b0ef3a4ec
Fixed stdint.h and stdbool.h detection.
2016-02-02 18:28:15 +01:00
Armin Novak
cd05ea7452
Fixed error checks for command line parser.
2016-02-01 15:18:34 +01:00
Bernhard Miklautz
8ec39039e5
Merge pull request #3076 from akallabeth/remove_fixed_size_heap_strings
...
Removed fixed size strings.
2016-02-01 13:02:38 +01:00
MartinHaimberger
e83f97b64a
Merge pull request #3093 from hardening/last_write_checks
...
Check more Stream_EnsureCapacity results when writing capabilities
2016-01-28 15:26:04 +01:00
MartinHaimberger
83b706c4be
Merge pull request #3092 from akallabeth/get_build_config
...
Added get_build_config functions.
2016-01-28 15:23:24 +01:00
David FORT
b6dd7bbb88
Check more Stream_EnsureCapacity results when writing capabilities
2016-01-28 15:12:26 +01:00
Hardening
a2aa56ee28
Merge pull request #3067 from akallabeth/reset_abort_event
...
Resetting abort event on freerdp_connect.
2016-01-28 14:28:51 +01:00
Armin Novak
035f127081
Added get_build_config functions.
2016-01-28 14:26:50 +01:00
Hardening
d458bc2e06
Merge pull request #3073 from davewheel/cert_key_in_memory
...
Allow to specify the raw content of crypto materials
2016-01-27 10:50:38 +01:00
Hardening
7af1ec85f0
Merge pull request #3083 from akallabeth/capability_set_fix
...
Fix #3081 , set client string encoding.
2016-01-27 10:45:54 +01:00
Armin Novak
974d2ef433
Fix #3081 , client string encoding.
2016-01-27 10:34:01 +01:00
Martin Fleisz
a9e4ba0118
Merge pull request #3069 from davewheel/4upstream-1
...
Improve monitor support
2016-01-27 10:18:30 +01:00
David FORT
708d0cb3c0
Check server and client capabilities
...
Most of the capabilities are sent by both the client and the server. But for some
the specs specify that they are only supposed to be only send by the server or the client.
This patch ensures this. Without this patch a malicious client can change server settings
and a malicious server can modify client settings.
2016-01-26 16:14:48 +01:00
Armin Novak
106479d6f2
Fixed clientNameLen initialization.
2016-01-26 09:34:22 +01:00
David FORT
137825ed9f
Stream_EnsureCapacity return value aren't checked in capabilities_write
2016-01-25 19:11:35 +01:00
Giovanni Panozzo
c5a4ce7893
Improve error logging after calling some BIO_ functions
2016-01-23 11:39:38 +01:00
Armin Novak
73ec3d6aca
Removed fixed size strings.
2016-01-21 15:45:21 +01:00
davewheel
d5b8585a39
Allow to specify the raw content of crypto materials
...
Sometime it's possible that your server application doesn't have access to files
(when running in a very restricted environment for example). This patch allows
to ship the private key and certificate as a string.
Sponsored by: Wheel Systems (http://www.wheelsystems.com )
2016-01-21 11:27:06 +01:00
davewheel
121a234866
Add better handling of monitors
...
This patch makes FreeRDP announce the support for monitor layout PDU. It also
adds support for servers to announce the monitors layout.
2016-01-20 16:56:04 +01:00
davewheel
ca9e908f3c
Fix a security issue in monitors packet handling
...
The number of announced monitors was not checked, so if a client was announcing
a big number, it could override other fields in settings and more...
2016-01-20 16:56:04 +01:00
Armin Novak
5542fef75d
Resetting abort event on freerdp_connect.
2016-01-18 10:08:12 +01:00
Armin Novak
93f3c060d2
Fixed memory overlap check.
2016-01-18 09:32:34 +01:00
Armin Novak
123cd523e0
Fixed SRCCOPY, using memmove now.
...
memcpy is not defined, if source and destination overlap.
2016-01-18 09:18:42 +01:00
Armin Novak
a0d6a1f77f
Fixed memory leak.
2016-01-15 09:33:21 +01:00
Hardening
1210421b62
Merge pull request #3046 from bmiklautz/tls12
...
tls: enable tls 1+
2016-01-12 20:46:53 +01:00
Bernhard Miklautz
aa80f63b4a
tls: enable tls 1+
...
Currently TLS version 1.0 is used implicitly by using the TLSv1_method.
To be able to also use TLS 1.1 and later use SSLv23_client_method
instead. To make sure SSLv2 or SSLv3 isn't used disable them.
2016-01-12 17:43:14 +01:00
Bernhard Miklautz
6fa3608111
cleanup cmake exports and pkg-config files
...
With this commit the "exported" components (usable with pkg-config and
cmake find module package)
* winpr - winpr library and headers
* freerdp - core library and headers
* freerdp-client - client specific library
* freerdp-server - server specific library
* rdtk - rdtk headers and library
To allow the installation of multiple different version (different major
number) the include files were moved into the respective sub folder:
freerdp -> freerdp{MAJOR}/freerdp (currently freerdp2/freerdp/)
winpr -> winpr{MAJOR}/winpr (currently winrp1/winpr/)
rdtk -> rdpk{MAJOR}/rdtk (currently rdtk0/rdtk/
The generated pkg-config and cmake find modules now also include the major
version number. Currently the following pkg-config are generated and
installed.
* winpr1
* freerdp2
* freerdp-server2
* freerdp-client2
* rdtk0
As cmake is able to handle multiple versions out of the box the
following can be used to find a specific module:
find_package(WinPR)
find_package(FreeRDP)
find_package(FreeRDP-Server)
find_package(FreeRDP-Client)
find_package(RdTk)
As cmake doesn't automatically resolve dependencies for packages it is
necessary to manually include the requirements. For example if
FreeRDP-Client is required WinPR and FreeRDP need to be included
(find_package) as well.
This commit also fixes the installation when STATIC_CHANNELS are built.
WITH STATIC_CHANNELS all channels are linked into libfreerdp-client, for
this all channels are generated as linker archive and linked together in
the final step. Before the intermediate linker archives were, although
not required and useful, installed. Same applies for server side
channels.
2016-01-12 17:32:33 +01:00
Hardening
df81e842a5
Merge pull request #2932 from realjiangms/fix_gdi_brush
...
GDI: Fix usage of gdi_get_brush_pointer.
2015-12-18 10:50:51 +01:00
Bernhard Miklautz
97edeca204
Merge pull request #2874 from akallabeth/stdtypes
...
Using stdint.h and stdbool.h for type definitions
2015-12-17 16:37:54 +01:00
Hardening
b35d0aa8aa
Merge pull request #2779 from RolKau/2779_ptrbtn
...
Send correct buttons when using a left-handed mouse
2015-12-17 00:04:53 +01:00
Bernhard Miklautz
d03b38765a
Merge pull request #2816 from akallabeth/known_hosts_locking
...
Known hosts locking
2015-12-16 19:03:15 +01:00
Roland Kaufmann
600d3c5ccb
Add option to disable pointer button mapping
...
In case the old behaviour of not reverse-mapping the mouse buttons is
desirable, a command-line option is added to disable the mapping. This
option is made experimental for the time being.
The default is to do the reverse mapping, as this is the intuitive
behaviour (the mouse then works as it would on the console).
2015-12-15 17:42:57 +01:00
Armin Novak
6ed43cd6ec
Updated pdb file locations.
...
Now supporting generators NMake and Visual Studio.
2015-12-15 12:08:35 +01:00
Armin Novak
cb958ba9c6
Added pdb files to package target.
...
Fixed name collision with freerdp-shadow targets.
2015-12-15 12:07:21 +01:00
Binyamin Sagal
23fea1615f
Fix horizontal scrolling direction and capability detection
2015-12-14 21:48:31 +02:00
Armin Novak
a5db7117c8
Implemented horizontal wheel support.
...
Horizontal mouse wheel input capabilities are now checked
and if available mouse buttons 6 and 7 are mapped to the
horizontal wheel for the X11 client.
2015-12-14 18:29:23 +01:00
Bernhard Miklautz
7f7ef1a464
Merge pull request #2831 from akallabeth/gdi_fix
...
Fixed GDI_BITMAP, now using custom deallocation function.
2015-12-14 17:58:25 +01:00
Armin Novak
00b8d802d2
Fixed callback function return
2015-12-14 14:18:50 +01:00
Armin Novak
74c15a6309
Fixed freerdp_assistance_file_new argument declaration
2015-12-14 14:18:50 +01:00
Bernhard Miklautz
b02943ae98
Merge pull request #2928 from akallabeth/non_verbose_VerifyX509Certificate
...
Silenced VerifyX509Certificate logging.
2015-12-11 12:09:33 +01:00
Armin Novak
65062633c2
Fixed memory leak.
2015-12-10 13:57:05 +01:00
Armin Novak
df528cefc5
Using locking winpr file functions for known hosts.
2015-12-09 18:29:41 +01:00
Hardening
17a1127341
Merge pull request #2976 from akallabeth/mac_audin_support
...
Added audin support for mac os.
2015-12-09 14:56:56 +01:00
Hardening
57fe581b16
Merge pull request #2824 from bjcollins/nla_auth_exit_code
...
Return FREERDP_ERROR_AUTHENTICATION_FAILED on an authentication failure
2015-12-08 22:46:29 +01:00
Nito Martinez
2d5c78849e
Fix formatting: else if in its own line and no brackets for single statements
2015-11-26 09:50:03 +01:00
Nito Martinez
89d8a68f4a
Disable setting socket options for preexisting socket like: keepalive and tcp_nodelay, these should be set extenally if needed. Do not close the socket if the clientaddress could not be set
2015-11-25 08:36:49 +01:00
Nito Martinez
428cbd802d
Fixes #2982 . The idea is to be able to create the socket externally and pass that socket FD to FreeRDP so that it can be used there.
...
The idea suggested is to use the following interface:
settings->ServerHostname = "|"
settings->ServerPort = SocketFD
2015-11-20 02:44:35 +01:00
Armin Novak
f6e17ec65c
Added audin support for mac os.
2015-11-12 16:10:39 +01:00
Hardening
be8f8f7238
Merge pull request #2970 from bmiklautz/prep_2.0
...
2.0 preparations
2015-11-11 12:54:34 +01:00
Hardening
bf147f71ba
Merge pull request #2930 from dbungert/glyph
...
Clamp ultra-wide glyph opRight vals to desktop width
2015-11-10 10:12:21 +01:00
Bernhard Miklautz
0cdb4f7924
Fix compiler warnings
...
gcc (Debian 4.9.2-10) 4.9.2
winpr/libwinpr/thread/argv.c: In function ‘CommandLineToArgvA’:
winpr/libwinpr/thread/argv.c:94:6: warning: unused variable ‘index’ [-Wunused-variable]
int index;
winpr/libwinpr/file/test/TestFileGetStdHandle.c: In function ‘TestFileGetStdHandle’:
winpr/libwinpr/file/test/TestFileGetStdHandle.c:44:2: warning: implicit
declaration of function ‘CloseHandle’ [-Wimplicit-function-declaration]
CloseHandle(stdout);
^
libfreerdp/codec/test/TestFreeRDPRegion.c: In function ‘test_norbert2_case’:
libfreerdp/codec/test/TestFreeRDPRegion.c:697:6: warning: unused variable ‘i’ [-Wunused-variable]
int i;
channels/cliprdr/server/cliprdr_main.c: In function ‘cliprdr_server_receive_format_list’:
channels/cliprdr/server/cliprdr_main.c:636:24: warning: unused variable ‘cliprdr’ [-Wunused-variable]
CliprdrServerPrivate* cliprdr = (CliprdrServerPrivate*) context->handle;
^
channels/cliprdr/server/cliprdr_main.c: In function ‘cliprdr_server_init’:
channels/cliprdr/server/cliprdr_main.c:1097:24: warning: unused variable ‘cliprdr’ [-Wunused-variable]
CliprdrServerPrivate* cliprdr = (CliprdrServerPrivate*) context->handle;
2015-11-09 19:26:34 +01:00
Bernhard Miklautz
d73c4898c1
Add build-config.h
...
build-config.h should contain configure/compile time settings that are
relevant for projects that use FreeRDP.
For example the compiled in plugin search paths.
2015-11-09 15:54:22 +01:00
Norbert Federa
0f1cedcbb8
codec/color: fix segfault in freerdp_image32_copy
...
Code path for dstBytesPerPixel == 3 moved src and dst pointers
beyond their respective buffers.
2015-11-03 12:05:47 +01:00
LookBehind
95fe9ecfab
Fix rdp_recv_logon_error_info
...
As https://msdn.microsoft.com/en-us/library/cc240641.aspx says - first is going errorNotificationType then errorNotificationData.
2015-10-20 18:05:09 +04:00
Martin Fleisz
d0cda5a5c7
Merge pull request #2933 from realjiangms/fix_gdi_bitmap_update
...
GDI: Fix gdi_bitmap_update to check dest buffer size.
2015-10-20 08:44:52 +02:00
zihao.jiang
e8fb821be7
GDI: Fix gdi_bitmap_update to check dest buffer size.
2015-10-18 17:53:22 +08:00
zihao.jiang
83d58ccfe8
GDI: Fix usage of gdi_get_brush_pointer.
...
Currently we get color from brush according to the offset in the paint region.
According to MSDN https://msdn.microsoft.com/en-us/library/dd183396(v=vs.85).aspx , it should get color according to dest position instead of offset in paint region.
2015-10-17 02:49:45 +08:00
Armin Novak
75ae38dff2
Silenced VerifyX509Certificate logging.
...
Now only writing log entries if something was an actual
error, otherwise stay silent.
2015-10-16 11:04:42 +02:00
Daniel Bungert
32e2f81cc5
Clamp ultra-wide glyph opRight vals to desktop width
2015-10-14 14:16:19 -06:00
Marc-André Moreau
029cbf3aca
libfreerdp-gdi: fix egfx multimon support
2015-10-13 15:50:39 -04:00
Marc-André Moreau
4ab373aced
xfreerdp: fix multiple egfx context support in X11 GFX
2015-10-13 14:49:30 -04:00
Marc-André Moreau
863939fd58
Merge pull request #2919 from realjiangms/fix_allow_empty_password
...
Sec/NLA: Support passwordless (blank password) login with NLA.
2015-10-13 10:40:28 -04:00
Marc-André Moreau
87780a850d
Merge branch 'master' of github.com:FreeRDP/FreeRDP into mbedtls
2015-10-09 15:58:50 -04:00
zihao.jiang
a7f4685c09
Sec/NLA: Support passwordless (blank password) login with NLA.
...
It was supported in freerdp 1.0.2 but not supported in lastest master.
We should take empty password if it is explicitly specified with /v option.
If a password is not specified, we could first try SAM file. If the user entry does not exist, prompt for password.
2015-10-10 01:48:41 +08:00
Sriram Raghunathan
1c1e215ed9
Remove warning: HANDLE event variable unused
2015-10-05 22:42:59 +05:30
David FORT
ff92a12ceb
Fix a bug in region_union_rect()
...
When region_union_rect() was called with a rect that was above the region without
intersecting it, the first band was created too large. This patch fixes this and
add a unitary test.
All credits go to @nfedera that:
* found the bug;
* find a dataset to reproduce;
* code the unitary test;
* spotted a suspicious line that was the faulty one.
2015-09-30 21:14:43 +02:00
Samuel Sieb
812e14af04
Don't fail the redirect if padding wasn't sent before disconnecting
2015-09-24 10:37:21 -07:00
Hardening
62da9d28c6
Merge pull request #2899 from awakecoding/master
...
Standard RDP security server redirection fix
2015-09-21 23:42:32 +02:00
Marc-André Moreau
a91506161d
libfreerdp-core: fix redirection with standard RDP security
2015-09-21 15:36:19 -04:00
Marc-André Moreau
d1cb3410de
Merge pull request #2896 from awakecoding/master
...
Win32 Gateway Fix, iOS TCP connection infinite loop fix
2015-09-18 11:57:01 -04:00
Marc-André Moreau
9c35b73fb6
libfreerdp-core: fix gateway connectivity on Windows
2015-09-17 14:32:40 -04:00
Martin Fleisz
affe82cae8
Merge pull request #2890 from realjiangms/shadow_fix_memory_leak
...
server: Fix several memory leak found while running valgrind on freerdp-shadow
2015-09-17 10:33:43 +02:00
zihao.jiang
f21749ac07
server: Fix several memory leak while running valgrind on freerdp-shadow
2015-09-17 01:02:22 +08:00
Marc-André Moreau
48c7a8dc1d
Merge pull request #2889 from dvincent-devolutions/gateway
...
Fix RDP8 gateway disconnections
2015-09-16 10:41:07 -04:00
Denis Vincent
3ea0fe0c01
Small corrections to BIO implementation.
2015-09-16 09:54:03 -04:00
Marc-André Moreau
8e3baed882
cmake: add mbed TLS detection
2015-09-15 20:52:46 -04:00
Marc-André Moreau
c0a887da17
libfreerdp-crypto: add locking of operations dealing with SSL*
2015-09-15 19:59:41 -04:00
bjcollins
ee3b39d70f
Remove unnecessary variable to keep track of nlaFailure, instead just set the NLA authentication error in the callback
...
where it is detected.
2015-09-15 14:17:13 -05:00
bjcollins
be47c6f782
Remove unused functions from initial code to handle NLA authentication failures.
2015-09-15 14:07:14 -05:00
bjcollins
7fbc7e45a7
Clean up NLA authentication failure handling code
...
1. Make use of freerdp_set_last_error to set authentication failure without the helper functions
2. Rename ssl callback function
3. Break out AuthenticationOnly exit handling from bad connect handling
2015-09-15 14:07:14 -05:00
bjcollins
32a1406dc4
Return FREERDP_ERROR_AUTHENTICATION_FAILED on an authentication failure
...
when using NLA with xfreerdp.
2015-09-15 14:07:14 -05:00
Marc-André Moreau
3f2915eb78
libfreerdp-core: alternative RDG BIO fix
2015-09-15 13:03:11 -04:00
Marc-André Moreau
12ce635b34
libfreerdp-core: fix code style
2015-09-15 10:37:57 -04:00
MartinHaimberger
2b2af6c9ea
Merge pull request #2886 from clangm/master
...
Fix Network Characteristics Autodetect [RDPBCGR 2.2.14]
2015-09-15 15:16:37 +02:00
Denis Vincent
6d55635ed0
libfreerdp-core: Gateway RDP8 BIO correction. Fixes connection losses.
2015-09-15 09:03:39 -04:00
MartinHaimberger
db2ce49a98
Merge pull request #2763 from akallabeth/nla_null_auth
...
Fixed server and client NLA state machine for NULL identity.
2015-09-15 14:53:55 +02:00
MartinHaimberger
d4d360f6a4
Merge pull request #2859 from akallabeth/resource_leak_fix
...
Fixes API misuse and logic errors
2015-09-15 14:45:42 +02:00
clangm
ac089f8a3f
Removed if statement that was causing network characteristics autodetect to not work
2015-09-11 15:01:31 -06:00
Bernhard Miklautz
4626f17cf2
Merge pull request #2868 from nfedera/fix-inverted-pointer-colors
...
improve handling of inverted pointer colors
2015-09-07 11:42:07 +02:00
MartinHaimberger
d971116457
Merge pull request #2765 from akallabeth/connect_abort
...
Connect abort and unified TCP connect
2015-09-07 10:05:24 +02:00
Armin Novak
4d77f2a4c8
Fixed CreateProcess argument initialisation.
2015-09-05 18:55:08 +02:00
Armin Novak
91d318ba7b
Enable RFX for test connection, now required by sample server.
2015-09-05 17:00:27 +02:00
Armin Novak
f7a11a0ed8
Resetting abortEvent on disconnect to avoid race during connect.
2015-09-05 16:26:46 +02:00
Armin Novak
01496f474f
Fixed error handling for rdp_client_connect fail.
2015-09-05 16:26:29 +02:00
Armin Novak
7d8ab23877
WSAEvent fixes ported from realjiangms pull 2870.
2015-09-05 15:18:01 +02:00
Armin Novak
188fe4ed2b
Removed rdp disconnect, using unified abortEvent instead.
2015-09-05 14:57:30 +02:00
Norbert Federa
1791d42a5d
improve handling of inverted pointer colors
2015-09-03 16:50:41 +02:00
Norbert Federa
72d901454c
Merge pull request #2865 from akallabeth/h264_ignore_errors
...
[H264] ignore decoder errors
2015-09-03 14:42:36 +02:00
Armin Novak
3b8043264f
Resetting channel error on connect.
2015-09-03 13:46:17 +02:00
Armin Novak
551eca246b
Ignoring H264 decompression failures.
...
When connecting to windows 8.1 machines the remote RDP server
implementation sometimes sends invalid H264 data. To avoid client
disconnections ignore the broken updates.
2015-09-03 12:11:15 +02:00
MartinHaimberger
74817efbdb
Merge pull request #2852 from bmiklautz/process_env
...
Update CreateProcess and rfx
2015-09-02 10:09:11 +02:00
Armin Novak
08f61e60ca
Fixed zero length allocation.
2015-09-01 12:25:44 +02:00
Norbert Federa
2d5e249eff
Merge pull request #2825 from akallabeth/pointer_decoding_fix
...
Fixed color pointer decoding.
2015-09-01 11:09:42 +02:00
Armin Novak
89227b97f0
Ignore AND mask for 32 bit pointer.
2015-09-01 10:53:45 +02:00
Bernhard Miklautz
1f13781fe1
Merge pull request #2855 from akallabeth/memleak_fixes
...
Memleak fixes
2015-08-31 09:50:21 +02:00
Armin Novak
893e7a35a8
Fixed broken cleanup code.
2015-08-31 09:13:15 +02:00
Bernhard Miklautz
05c02da742
settings: update settings/help to match
...
* wallpaper was off but help said "default: on"
* compression is on but help said "default: off"
Fixes #2853
2015-08-28 11:09:38 +02:00
Armin Novak
dd9d66a3e6
Fixed NONNULL argument warnings.
2015-08-28 10:59:48 +02:00
Armin Novak
07bba9b623
Fixed NONNULL argument warnings.
2015-08-28 10:58:20 +02:00
Armin Novak
a8cd9e0138
Fixed resource leak.
2015-08-28 10:53:43 +02:00
Bernhard Miklautz
c0d1f5bac1
codec/rfx: update comment and remove WLog_ERR
...
With revision 17.0 of [MS-RDPRFX] the behavior when numRects == 0 is
documented.
This commit updates the comment and removes the error logging.
2015-08-28 10:36:56 +02:00
Marc-André Moreau
f7ea8d1832
Merge pull request #2829 from akallabeth/mf_compile_option
...
media foundation support now a compile time option.
2015-08-27 10:00:47 -04:00
Armin Novak
c3a1f56f77
Resetting signals on freerdp_connect.
2015-08-27 15:53:37 +02:00
Armin Novak
fda56c0dbb
Added missing NULL pointer checks.
2015-08-27 15:33:06 +02:00
Armin Novak
7ebf4879f0
Fixed uninitialised events.
2015-08-27 15:33:06 +02:00
Armin Novak
4cfd7a48cd
Aborting transport layer now if requested.
2015-08-27 15:33:06 +02:00
Armin Novak
134a16d522
Fixed WSAEventSelect mode reset.
2015-08-27 15:33:06 +02:00
Armin Novak
1cbeb10074
Added unit test for freerdp_connect
...
* Tests connection to not existing host (timeout)
* Tests connection to not exising host with abort.
* Tests connection to sfreerdp-server on localhost.
2015-08-27 15:33:06 +02:00
Armin Novak
e6c23cb534
Implemented Async TCP connect with abort event
...
* Implemented unified freerdp_tcp_connect_timeout with connect abort.
* Implemented unified freerdp_tcp_connect_multi with connect abort.
* Added connect abort to freerdp_tcp_connect.
* Added freerdp_abort_connect and abortEvent.
2015-08-27 15:33:06 +02:00
Marc-André Moreau
223e0c7900
Merge pull request #2785 from MartinHaimberger/mh-channel-fix
...
Channel hardening and fixing
2015-08-27 09:24:10 -04:00
Martin Haimberger
52405a3e79
Remove WIN32ERROR type
...
All return values are UINT now.
2015-08-27 05:38:20 -07:00
Hardening
9101135e52
Merge pull request #2846 from llyzs/monitor
...
Read and write desktop and monitor data.
2015-08-27 11:42:45 +02:00
Vic Lee
6f639c1e34
gcc: read and write desktop scale settings in core data.
2015-08-27 16:19:40 +08:00
Armin Novak
dfa7ac6434
Ensure output of crypto_base64_decode is NULL terminated.
2015-08-27 09:34:33 +02:00
Vic Lee
8394d8c677
gcc: read and write monitor extended data.
2015-08-27 15:26:37 +08:00
Armin Novak
db3fa9a0d2
Added gdi_CreateBitmapEx function.
2015-08-26 12:14:46 +02:00
Martin Haimberger
420a86e1c7
Merge remote-tracking branch 'upstream/master' into mh-channel-fix
...
Conflicts:
channels/drdynvc/client/drdynvc_main.c
channels/rdpgfx/client/rdpgfx_main.c
client/X11/xf_gfx.c
2015-08-25 00:07:04 -07:00
Armin Novak
e8554a51b8
Selecting correct bitmap in hdc now.
2015-08-12 12:53:35 +02:00
Armin Novak
8024a086cd
Updated tests for new gdi_CreateBitmap API.
2015-08-12 11:15:07 +02:00
Armin Novak
253a60aaf3
Fixed GDI_BITMAP, now using custom deallocation function.
...
gdi_surface_bits: Now properly discarding old bitmap before creating a new one.
2015-08-12 11:01:05 +02:00
Armin Novak
4ed701bf35
media foundation support now a compile time option.
2015-08-11 07:58:43 +02:00
Armin Novak
4a62e6bee4
Added length arguments and checks.
2015-08-06 11:24:42 +02:00
Armin Novak
4df5e2b998
Fixed argument checks.
2015-08-05 17:32:38 +02:00
Armin Novak
0cbc46dc34
Fixed pointer update decoding with NULL mask.
2015-08-05 17:21:10 +02:00
Marc-André Moreau
d7329194fc
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-08-04 11:55:38 -04:00
Marc-André Moreau
162411dc67
libfreerdp-codec: fix Windows XP build for H.264 decoder
2015-08-04 11:55:03 -04:00
Marc-André Moreau
8fb9535e4a
libfreerdp-codec: fix leaks in H.264 Media Foundation decoder
2015-08-04 10:26:13 -04:00
Marc-André Moreau
d952502285
libfreerdp-codec: initial Media Foundation H.264 decoder support
2015-08-03 16:21:48 -04:00
Marc-André Moreau
32d1053abe
libfreerdp-codec: add more Media Foundation H.264 code
2015-07-30 14:07:35 -04:00
Martin Haimberger
2862109337
Merge remote-tracking branch 'upstream/master' into mh-channel-fix
...
Conflicts:
channels/smartcard/client/smartcard_main.c
channels/smartcard/client/smartcard_operations.c
2015-07-30 07:29:12 -07:00
Marc-André Moreau
4dc47d4867
libfreerdp-codec: start H.264 MediaFoundation support
2015-07-29 16:33:04 -04:00
Bernhard Miklautz
a22dc21c15
remdesk,encomps: misc fixes
...
* only free stream when an error occurs
* ignore unhanded messages instead of throwing an error
* fix memory leak in settings
2015-07-29 17:32:09 +02:00
Clive Stevens
99228ee254
Fix race condition in freerdp_channels_client_load
...
If g_pInterface is set to NULL outside the critical section in one thread
while another thread is in the critical section, the channel client context
allocated in the VirtualChannelEntry won't end up getting freed.
The channel client context is normally loaded from g_pInterface in
FreeRDP_VirtualChannelInit and stored in the pChannelInitData, then copied
from there onto the pChannelOpenData structure in FreeRDP_VirtualChannelOpen
and finally freed in freerdp_channels_free.
2015-07-29 14:26:33 +01:00
Marc-André Moreau
9400ccb4bc
libfreerdp-codec: add x264 stubs
2015-07-28 16:01:34 -04:00
Marc-André Moreau
5cb06ecc68
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-07-28 09:21:33 -04:00
Bernhard Miklautz
a342d40158
core/listner: fix possible problem in _free
2015-07-27 11:24:21 +02:00
Bernhard Miklautz
458d3b1593
transport: fix regression introduced with PR #2770
...
When the event is reset in transport_check_fds xfreerdp doesn't work and
consumes 100% CPU (see #2790 ). On windows this is require otherwise the
CPU consumption is 100% there.
This quick fix only resets the event on windows. It's a working approach
but definitely not the final solution.
2015-07-17 12:06:41 +02:00
Vic Lee
042cb250f3
Merge pull request #2770 from akallabeth/bio_event_reset
...
Resetting frontBio after read now.
2015-07-16 06:57:46 -07:00
Martin Haimberger
6ab0187d84
Merge remote-tracking branch 'upstream/master' into mh-channel
...
Conflicts:
channels/audin/client/oss/audin_oss.c
channels/drive/client/drive_main.c
channels/printer/client/printer_cups.c
channels/printer/client/printer_main.c
channels/rail/client/rail_main.c
channels/rdpgfx/client/rdpgfx_main.c
channels/rdpsnd/client/oss/rdpsnd_oss.c
channels/remdesk/client/remdesk_main.c
channels/remdesk/server/remdesk_main.c
channels/tsmf/client/tsmf_media.c
2015-07-15 01:57:07 -07:00
Martin Haimberger
b8c110d19b
introduced channel error reporting system
...
The rdpContext gets an event which will
get set if an error occoured in a channel.
If a thread or a void callback has to report an
error it will get signaled by this system.
2015-07-15 00:50:35 -07:00
Bernhard Miklautz
68e8569110
winpr/synch: remove the dependency on winsock.h
...
winsock.h pulls in a lot of defines and dependencies that are not
required and partially unwanted in winpr's core (for parts that are not
related to network). In order to get rid of this dependency and have an
independent defines for extended winpr functions the WINPR_FD_* defines
are used internally (and for exposed functions). Where required, like in
WSAEventSelect, the FD_* is mapped to WINPR_FD_*.
2015-07-14 11:39:41 +02:00
Armin Novak
fc929fbc7f
Using lowercase hostname for comparison now.
...
fixed argument mixup.
2015-07-13 15:52:06 +02:00
Armin Novak
ca7c34ff35
Fixed comparison bug, cleanup and error handling.
2015-07-13 14:16:04 +02:00
Armin Novak
098eda9873
Error checks for BIO_get_event
...
ResetEvent before reading data from transport BIO.
2015-07-09 12:20:22 +02:00
Armin Novak
18cea1c9ba
Replaced cbMaxSignature with cbSecurityTrailer
...
The token buffer size during authentication was constructed
from the wrong buffer size. These sizes are equal in case of
local account logins but differ with domain accounts.
2015-07-09 10:09:18 +02:00
Armin Novak
ecf6ffdcce
Fixed CompleteAuthToken return check.
2015-07-09 09:57:45 +02:00
Armin Novak
cb01e540ba
Fixed CompleteAuthToken return check.
2015-07-09 09:49:12 +02:00
Armin Novak
2fe5ecfc1b
Fixed wrong output in log messages.
2015-07-08 17:41:23 +02:00
Martin Fleisz
9a2d33af12
Fixed missing encrypt / decrypt success check.
...
The return of EncryptMessage and DecryptMessage was unchecked.
This lead to PLAINTEXT to be sent over the wire, a major security
issue.
2015-07-08 17:41:23 +02:00
Armin Novak
48ccf73a36
More SSPI logging.
2015-07-08 17:41:22 +02:00
Armin Novak
5b0ee9b7ab
Error checks and readable log messages.
2015-07-08 17:41:22 +02:00
Martin Fleisz
3b87cc0c07
Fixed server and client NLA state machine.
...
When using NULL credentials (current context)
the server state machine did not send back the
required authentication token.
On client side erroneous checks prevented sending
the appropriate public key.
2015-07-08 17:41:21 +02:00
Armin Novak
0120ee75ca
Resetting frontBio after read now.
2015-07-07 14:48:27 +02:00
Armin Novak
d18b0fbeb4
Handle API updated.
2015-07-03 09:52:52 +02:00
Hardening
ac93b26ba8
Merge pull request #2750 from realjiangms/fix_win32_wsaevent
...
Fix event created for WSAEventSelect
2015-07-02 09:26:13 +02:00
Armin Novak
3a9db563fd
NLA: Fixed length check.
2015-07-01 16:05:11 +02:00
Armin Novak
8479c824fd
Fixed handling of optional TSPasswordCreds field.
2015-07-01 15:30:38 +02:00
Armin Novak
6c0e1af4af
NLA decrypt credentials fixed.
2015-07-01 14:31:55 +02:00
Norbert Federa
1c43a6e115
Merge pull request #2738 from bmiklautz/ffuncs
...
hardening: check fread and fwrite return values
2015-07-01 13:02:32 +02:00
Bernhard Miklautz
798df32fd9
Integrate pull request feedback
...
* unify fwrite usage - set nmemb to 1 and the size to the size to write.
2015-07-01 12:22:32 +02:00
zihao.jiang
75407edf37
Fix event created for WSAEventSelect: The event we pass to WSAEventSelect should be WSAEVENT instead of normal event.
...
From MSDN, it looks same as CreateEvent(NULL, FALSE, FALSE, NULL):
The WSACreateEvent function creates a manual-reset event object with an initial state of nonsignaled. The event object is unnamed.
However they are not really equivalent. When we use normal event, the WSAEventSelect still works but the event appears to be 'auto-reset'.
2015-07-01 01:52:59 +08:00
Marc-André Moreau
161359f6ec
libfreerdp-core: fix receiving of logon error info during capability exchange
2015-06-29 12:43:18 -04:00
Marc-André Moreau
a8e62e938a
libfreerdp-codec: fix egfx artifacts resulting from incorrect handling of rects inside the same egfx frame
2015-06-28 13:57:46 -04:00
Bernhard Miklautz
1cee185e3c
hardening: check fread and fwrite return values
2015-06-26 20:38:30 +02:00
Marc-André Moreau
5ec19d2045
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-06-26 14:00:03 -04:00
Marc-André Moreau
24ed6b06cc
channels/rdpgfx: update debug output
2015-06-26 13:59:41 -04:00
Norbert Federa
20878e50fe
Merge pull request #2724 from bmiklautz/leak_fix
...
Fix leaks in certificate and identity handling
2015-06-26 15:30:00 +02:00
Marc-André Moreau
cf2f4bf9cf
Merge pull request #2737 from nfedera/nf-fix-gdi-return-value-weirdness
...
libfreerdp/gdi: fixed gdi return value madness
2015-06-26 09:24:08 -04:00
Bernhard Miklautz
77ef5a80de
nla: clear identity memory before releasing
2015-06-26 15:12:33 +02:00
Norbert Federa
ac95b7274e
Merge pull request #2727 from akallabeth/leak_fixes_reformat
...
Fixed leaks, NULL dereferences and broken init.
2015-06-26 15:01:08 +02:00
Norbert Federa
bb9536b867
libfreerdp/gdi: fixed gdi return value madness
...
Mostly booleanization to comply with the MS API
2015-06-26 14:32:38 +02:00
Marc-André Moreau
ddf2519f1e
Merge pull request #2719 from bmiklautz/pull/2481
...
OSS, tsmf, usb and BSD fixes and improvements
2015-06-26 08:27:22 -04:00
Norbert Federa
5281070045
Merge pull request #2734 from giox069/master
...
Fixes for software GDI issues #2732 and #2137
2015-06-26 13:15:56 +02:00
Hardening
b411c11f6e
Merge pull request #2729 from akallabeth/win_reg_key_by_vendor_product_define
...
Replaced hard coded registry keys with cmake defines.
2015-06-26 11:15:09 +02:00
Giovanni Panozzo
8a45b567fc
Returing OK when there is nothing to draw after clipping, fixes #2732
2015-06-25 16:54:08 +02:00
Giovanni Panozzo
85b5c5f890
Signed glyph offset calculation, fixes #2137
2015-06-25 16:49:29 +02:00
Bernhard Miklautz
28e63786cd
Integrate pull request feedback
...
Use while instead of for with additional variable where appropriate.
2015-06-25 10:33:54 +02:00
Armin Novak
80ba4643dc
Fixed cleanup of resources, only in error case now.
2015-06-24 14:59:59 +02:00
Armin Novak
e8bfa29bd2
Replaced registry keys with cmake defines.
2015-06-24 14:02:48 +02:00
Bernhard Miklautz
9f6fa7ef4c
Fix possible endless loops on cleanup.
...
Some cleanup code possibly create endless loops because an unsigned
type was used as run variable but the check was >= 0 in the for loop.
2015-06-24 12:26:13 +02:00
Armin Novak
c78b6f38ab
Fixed cleanup of MachineAddresses and MachinePorts.
2015-06-24 12:14:06 +02:00
Armin Novak
ee221315db
Fixed loop condition.
2015-06-24 10:08:04 +02:00
Armin Novak
a809b87362
Fixed memory leak.
2015-06-24 10:02:42 +02:00
Armin Novak
4c9ee07eb6
Fixed sizeof misuse.
2015-06-24 10:02:30 +02:00
Armin Novak
2ff1205dde
Fixed a resource leak.
2015-06-24 09:45:40 +02:00
Armin Novak
2e762c881c
Fixed a resource leak.
2015-06-24 09:33:20 +02:00
Armin Novak
6698e24228
Fixed leaks, NULL dereferences and broken init.
2015-06-23 21:29:21 +02:00
Bernhard Miklautz
2e87d0ee52
Fix leaks in certificate and identity handling
2015-06-23 15:40:37 +02:00
Armin Novak
24fed46cda
Fixed grabage return value.
2015-06-23 12:08:47 +02:00
Armin Novak
212db120e0
Fixed NULL pointer dereference.
2015-06-23 12:07:38 +02:00
Bernhard Miklautz
ff8d172a12
core: use error instead of debug
...
When the function would return with an error print an error message
instead of a debug message
2015-06-23 11:15:13 +02:00
Bernhard Miklautz
09445c2b0e
nla and cmdline: integrated feedback
...
* fix possible problems with 0 size lengths
* add return value checks
2015-06-23 10:14:11 +02:00
Bernhard Miklautz
af81a91ea7
windows: fix compilation and warnings
2015-06-22 19:31:25 +02:00
Bernhard Miklautz
06502e6a91
misc: integrate pull request feedback
2015-06-22 19:24:30 +02:00
Bernhard Miklautz
421b74e85e
client/locale: properly check popen return value
...
popen returns NULL if an error occurs and not < 0.
2015-06-22 19:23:58 +02:00
Bernhard Miklautz
1b8dd139a9
cmd line: add missing checks
...
* strdup
* some allocs
2015-06-22 19:23:57 +02:00
Bernhard Miklautz
5de0e02c61
cache: fix regression
...
Fix a regression in cache_new introduced in commit
b4f147e242ea396ef92082d29866e5ab7d041b4e
2015-06-22 19:21:47 +02:00
David FORT
7c3f8f33ab
Fixes for malloc / calloc + other fixes
...
This patch contains:
* checks for malloc return value + treat callers;
* modified malloc() + ZeroMemory() to calloc();
* misc fixes of micro errors seen during the code audit:
** some invalid checks in gcc.c, also there were some possible
integer overflow. This is interesting because at the end the data are parsed
and freed directly, so it's a vulnerability in some kind of dead code (at least
useless);
** fixed usage of GetComputerNameExA with just one call, when 2 were used
in misc places. According to MSDN GetComputerNameA() is supposed to return
an error when called with NULL;
** there were a bug in the command line parsing of shadow;
** in freerdp_dynamic_channel_collection_add() the size of array was multiplied
by 4 instead of 2 on resize
2015-06-22 19:21:47 +02:00
Bernhard Miklautz
77927c213e
android: fix misc compiler warnings
...
with gcc version arm-linux-androideabi-gcc (GCC) 4.8
2015-06-22 19:09:59 +02:00
Bernhard Miklautz
bf73f4e4f1
Fix unchecked strdups
...
* add missing checks
* adapt function return values where necessary
* add initial test for settings
2015-06-22 19:09:59 +02:00
Marc-André Moreau
3b3ffce042
Merge pull request #2705 from akallabeth/sspi_fix_v2
...
Sspi fix v2 - Fixes static build
2015-06-22 10:19:22 -04:00
Marc-André Moreau
20f78405c8
Merge pull request #2684 from Skool/master
...
Add bépo layout
2015-06-22 09:31:15 -04:00
Marc-André Moreau
9aabec73f5
Merge pull request #2713 from bmiklautz/divbyzero
...
core/metrics: prevent division by zero
2015-06-22 08:53:36 -04:00
Marc-André Moreau
1e39d7728c
Merge pull request #2702 from akallabeth/nla_null_identity_support
...
NLA Use current users credentials if none provided.
2015-06-22 08:53:05 -04:00
Bernhard Miklautz
41ef7ca17c
core/metrics: prevent division by zero
2015-06-19 17:21:16 +02:00
Norbert Federa
91a9b23b91
core: message channel pdu broken with rdp security
...
rdp_recv_message_channel_pdu always read the rdp security header
even if it was already previously read (which is the case if rdp
security is active)
This caused malfunctions and disconnects when heartbeat or bandwidth
autodetect packets were sent/received in rdp security mode.
Credit goes to @MartinHaimberger for identifying the broken code
part.
2015-06-19 14:49:17 +02:00
Martin Haimberger
6e4e1c2773
Merge remote-tracking branch 'upstream/master' into mh-stream-fix
...
Conflicts:
client/Windows/wf_cliprdr.c
2015-06-18 03:06:40 -07:00
Martin Haimberger
dc68bdfce5
channel rdpgfx hardend
2015-06-18 03:04:32 -07:00
Martin Haimberger
d06da4f1bd
hardend drdynvc channel
2015-06-18 03:04:28 -07:00
Vic Lee
2e11eac79a
Merge pull request #2675 from akallabeth/path_make_path
...
Added PathMakePath function.
2015-06-18 02:43:47 +00:00
Armin Novak
3c329aa207
Using InitSecurityInterfaceEx(0) now.
2015-06-17 13:23:44 +02:00
Armin Novak
34253f2664
Let SSPI module choose which implementation to use.
2015-06-15 15:21:21 +02:00
Armin Novak
219ca1c02b
NLA identity now a pointer, allowing NULL.
...
When NLA identity is NULL, the current user context
is used on windows.
2015-06-15 15:03:13 +02:00
Vic Lee
145fc10412
Merge pull request #2687 from akallabeth/known_hosts_v2
...
Store SSL fingerprints with host and port
2015-06-12 12:52:53 +00:00
Armin Novak
b43c9f9060
Renamed file to known_hosts2.
2015-06-12 09:30:01 +02:00
Norbert Federa
20aa10e6ae
codec/color: support for 8bpp color pointer
2015-06-11 16:34:42 +02:00
Norbert Federa
86d398f0a3
codec/color: support for 16bpp color pointer
2015-06-11 13:12:21 +02:00
Armin Novak
9dd9c35cee
Updated tests.
2015-06-11 11:34:36 +02:00
Armin Novak
3dda4eb0cf
Added NULL pointer checks, fixed warnings.
2015-06-11 11:34:22 +02:00
Armin Novak
7fc1c65165
Added subject and issuer to saved data.
...
When a certificate has changed, display not only the
fingerprint but also subject and issuer of old certificate.
2015-06-11 11:21:23 +02:00
Armin Novak
7786cf1376
Fixed fingerprint comparison, return value was inverted.
2015-06-11 09:59:04 +02:00
Armin Novak
90d836193c
Fixed formatting.
2015-06-11 09:58:58 +02:00
Armin Novak
3d27055539
Added test for fingerprint read.
2015-06-11 09:24:55 +02:00