Martin Fleisz
c16e5ffcc2
Merge pull request #10631 from akallabeth/warn-fixes-cov
...
Warn fixes cov
2024-09-18 14:16:10 +02:00
Armin Novak
fbbda2259d
[clang-tidy] deactivate cppcoreguidelines-pro-type-reinterpret-cast
...
we do noeed these casts for compatibility with C void* usage. Deactivate
this check to reduce noise.
2024-09-18 13:14:19 +02:00
Armin Novak
fdd8a5cedd
[codec,progressive] fix result cast in progressive_rfx_srl_read
2024-09-18 13:14:19 +02:00
Armin Novak
769b225278
[utils,smartcard] fix size checks
2024-09-18 11:47:02 +02:00
Armin Novak
bed6e7968e
[winpr,utils] fix plausibility checks in IniFile_Load_File
2024-09-18 11:47:01 +02:00
Armin Novak
65f6541f67
[server,proxy] fix plausibility checks in pf_config_get_uint32
2024-09-18 11:47:01 +02:00
Armin Novak
7b8ddb89c7
[codec,planar] fix parameter type of functions
2024-09-18 11:47:01 +02:00
Armin Novak
d55dfa316f
[server,proxy] fix unchecked return
2024-09-18 11:47:01 +02:00
Armin Novak
58ea63fd84
[winpr,path] fix comparison of unsigned < 0
2024-09-18 11:47:01 +02:00
Armin Novak
deec4df8c0
[proxy,module] move list in dyn-channel-dump instead of copy
2024-09-18 11:46:56 +02:00
Martin Fleisz
e6b4bb0e76
Merge pull request #10627 from llyzs/rpc
...
[core,gateway] migrate rpc gateway to use new transport layer.
2024-09-18 09:58:07 +02:00
akallabeth
e2fbab750b
Merge pull request #10625 from akallabeth/bsd-fix
...
[winpr,library] implement GetModuleFileNameA
2024-09-18 09:45:23 +02:00
Vic Lee
5f37b54847
[core,gateway] migrate rpc gateway to use new transport layer.
2024-09-18 15:39:34 +08:00
akallabeth
b738cf01b9
Merge pull request #10626 from akallabeth/mac-bundle-fix
...
[build,mac] require cJSON
2024-09-17 21:13:49 +02:00
akallabeth
b62249402a
[build,mac] require cJSON
...
we build with cJSON, so enforce it during build. Prevents other
installed libraries to be considered.
2024-09-17 20:23:11 +02:00
akallabeth
347ac5a941
[winpr,library] implement GetModuleFileNameA
2024-09-17 18:01:10 +02:00
akallabeth
4d8a3a22e2
Merge pull request #10622 from akallabeth/warn-fx
...
[warnings] fix shorten-64-to-32
2024-09-17 17:13:33 +02:00
akallabeth
586f40631f
[warnings] fix shorten-64-to-32
2024-09-17 16:13:48 +02:00
akallabeth
6fb3120c0b
[clang-tidy] disable modernize-avoid-c-arrays
...
same as with similar hicpp and cppcoreguidelines check disable for our
project
2024-09-17 16:13:33 +02:00
akallabeth
accb4eae75
Merge pull request #10621 from akallabeth/warn-fx
...
Warn fixes
2024-09-17 13:24:00 +02:00
akallabeth
9278a0adb8
[clang-tidy] fix typo in deactivated check
2024-09-17 12:58:13 +02:00
akallabeth
0e97a51181
[build,mac] disable CHANNEL_RDPEAR
...
we don't have a MIT-KRB5 library ready on mac os, disable for the time
being.
2024-09-17 12:57:45 +02:00
akallabeth
618e02a65e
[cmake] fix SWScale library variable name
2024-09-17 12:57:43 +02:00
akallabeth
7f52be7d75
[codec,dsp] fix build WITH_FAAC
2024-09-17 12:57:40 +02:00
akallabeth
b388739a0c
[build,mac] fix ignore paths
...
Use CMAKE_IGNORE_PREFIX_PATH to ignore macports/homebrew/... libraries
when building a mac os bundle
2024-09-17 12:57:37 +02:00
akallabeth
328b7433a4
[server,proxy] fix unchecked return values
2024-09-17 12:57:34 +02:00
akallabeth
84c7fbe922
Merge pull request #10620 from akallabeth/clang-tidy-refine
...
[clang-tidy] disable cppcoreguidelines-pro-bounds-pointer-arithmetic
2024-09-17 12:24:58 +02:00
akallabeth
b66bc796f4
Merge pull request #10612 from hardening/sdl3_fix
...
SDL3 client: improve the treatment of clipboard data requests
2024-09-17 12:09:25 +02:00
Martin Fleisz
d3f284505d
Merge pull request #10618 from akallabeth/proxy-nonblock-fix
...
[core,proxy] fix nonblocking BIO reads
2024-09-17 11:57:21 +02:00
akallabeth
5281b7a320
[clang-tidy] disable cppcoreguidelines-pro-bounds-pointer-arithmetic
...
the check is not really helpful as all it points out is use of argc/argv
or some handling of C API stuff
2024-09-17 11:47:29 +02:00
David Fort
688f450fc2
SDL3 client: improve the treatment of clipboard data requests
...
This patch adds a success flag on clipboard data requests, so that we can react
correctly in the SDL handler. I've also made some errors non fatal like if you requests
a kind of data that doesn't exist the client should not terminateit's for that.
2024-09-17 11:37:48 +02:00
David Fort
6c05b54e4f
Merge pull request #10619 from akallabeth/clang-tidy-refine
...
[clang-tidy] deactivate some C++ checks not fitting
2024-09-17 11:12:24 +02:00
Martin Fleisz
cd70c73e39
Merge pull request #10615 from akallabeth/asn1-int
...
[winpr,asn1] fix sign extraction for ASN1 integer
2024-09-17 11:08:53 +02:00
akallabeth
a3b658f677
[clang-tidy] deactivate some C++ checks not fitting
...
* cppcoreguidelines-avoid-c-arrays: most of our code is in C, so the C++
components must use these to call the library functions
* modernize-pass-by-value: not compatible with the lowest supported C++
standard of the project
2024-09-17 10:46:21 +02:00
akallabeth
c7efbf5b8e
[core,proxy] fix nonblocking BIO reads
...
* In case of non-blocking BIO layers the proxy read functions bailed
out with an error. Retry reading in that case unless the
TcpConnectTimeout is exceeded
* Terminate proxy read operations if rdpContext::abortEvent is set
2024-09-17 10:37:19 +02:00
akallabeth
ca260e13bb
[winpr,asn1] fix sign extraction for ASN1 integer
...
ASN1 integer might not be full 32bit integers, so extract the sign from
the first byte and append 0x80000000 after the rest of the integer was
successfully read.
2024-09-17 10:03:50 +02:00
akallabeth
6c88d89566
Merge pull request #10616 from hardening/rail_text_scale
...
rails: add missing functions client implementation
2024-09-16 19:56:30 +02:00
David Fort
8cc9e5f4e9
rails: add missing functions client implementation
...
The client side callbacks for textScale and CaretBlinkRate were not implemented.
2024-09-16 18:55:25 +02:00
akallabeth
8e1a2e3645
Merge pull request #10610 from akallabeth/vcapitype
...
[windows,32bit] fix VCAPITYPE consistency
2024-09-16 15:35:17 +02:00
akallabeth
f2e90eca34
[windows,32bit] fix VCAPITYPE consistency
...
Fixes #10581
2024-09-16 14:15:59 +02:00
akallabeth
073f1ee642
Merge pull request #10609 from akallabeth/warn
...
Fix unused return values
2024-09-16 12:03:31 +02:00
akallabeth
befa4233ad
[warnings] fixed bugprone-not-null-terminated-result
2024-09-16 08:22:42 +02:00
akallabeth
a19305569d
[assert] fix ULONG_MAX use
...
most of the time this was used to check ULONG limits. Replace with
correct UINT32_MAX
2024-09-16 08:22:40 +02:00
akallabeth
bb242b9a89
[return checks] fix use of WaitForSingleObject
2024-09-16 08:22:37 +02:00
akallabeth
965d231e49
[return checks] fix use of CloseHandle
2024-09-16 08:22:31 +02:00
akallabeth
cd18dea174
[return checks] fix use of unicode functions
2024-09-16 06:48:26 +02:00
akallabeth
f655843260
[return checks] fix use of rdpSettings getter/setter
2024-09-16 06:48:23 +02:00
akallabeth
c0d06c782b
[return checks] fix missing checks
...
* Stream_EnsureRemainingCapacity
* rdp_client_transition_to_state
2024-09-16 06:48:19 +02:00
akallabeth
07ea37d1d7
[return checks] fix use of CommandLineParseArgumentsA
2024-09-16 06:48:16 +02:00
akallabeth
4c8f6383ae
[return checks] fix use of freerdp_interruptible_getc
2024-09-16 06:48:13 +02:00
