Bernhard Miklautz
bff63b3ee2
wlog: cleanup API includes
...
Only include necessary header files.
2015-11-10 16:29:09 +01:00
Bernhard Miklautz
be0845b46c
wlog/journald: don't set a default identifier
...
Don't set the identifier to "winpr" as default value because journald
will use the programs name as default if no identifier is set.
This way a program using WLog doesn't need to set an identifier (except
it want something different then it's name).
2015-11-10 13:40:52 +01:00
Bernhard Miklautz
34c707304b
wlog: change variable naming and fix documentation
...
* change State to active and make it BOOL since it's only got two
used values
* fix some typos in the documentation
2015-11-10 12:05:23 +01:00
Bernhard Miklautz
59cc6c4117
wlog: add some rudimentary documentation
2015-11-09 20:30:23 +01:00
Bernhard Miklautz
25137988fe
wlog: fix build on windows
2015-11-09 19:47:51 +01:00
Bernhard Miklautz
57f952bbbc
wlog: fix android build
2015-11-09 19:37:02 +01:00
Bernhard Miklautz
0cdb4f7924
Fix compiler warnings
...
gcc (Debian 4.9.2-10) 4.9.2
winpr/libwinpr/thread/argv.c: In function ‘CommandLineToArgvA’:
winpr/libwinpr/thread/argv.c:94:6: warning: unused variable ‘index’ [-Wunused-variable]
int index;
winpr/libwinpr/file/test/TestFileGetStdHandle.c: In function ‘TestFileGetStdHandle’:
winpr/libwinpr/file/test/TestFileGetStdHandle.c:44:2: warning: implicit
declaration of function ‘CloseHandle’ [-Wimplicit-function-declaration]
CloseHandle(stdout);
^
libfreerdp/codec/test/TestFreeRDPRegion.c: In function ‘test_norbert2_case’:
libfreerdp/codec/test/TestFreeRDPRegion.c:697:6: warning: unused variable ‘i’ [-Wunused-variable]
int i;
channels/cliprdr/server/cliprdr_main.c: In function ‘cliprdr_server_receive_format_list’:
channels/cliprdr/server/cliprdr_main.c:636:24: warning: unused variable ‘cliprdr’ [-Wunused-variable]
CliprdrServerPrivate* cliprdr = (CliprdrServerPrivate*) context->handle;
^
channels/cliprdr/server/cliprdr_main.c: In function ‘cliprdr_server_init’:
channels/cliprdr/server/cliprdr_main.c:1097:24: warning: unused variable ‘cliprdr’ [-Wunused-variable]
CliprdrServerPrivate* cliprdr = (CliprdrServerPrivate*) context->handle;
2015-11-09 19:26:34 +01:00
Bernhard Miklautz
67368b2ec7
Adapt error level for debug messages
...
When using xfreerdp a regular invocation should really only report grave
problems as error. "Regular" messages should be either info or even
debug.
2015-11-09 18:27:38 +01:00
Bernhard Miklautz
07417599ce
wlog: rework, cleanup and stabilize API
...
* only expose necessary functions and types in header
* don't expose appender internals
* add generic function WLog_ConfigureAppender to have the possibility
to configure appender specific settings
* detect appender availability if WLog_SetLogAppenderType or
WLog_Appender_New return FALSE or NULL respectively the appender isn't
available or the initialization failed. This is very useful for the
use with optional appenders.
* add Free to the appender interface. At the time of the Free the
appender is known and available so it can be called directly (instead
of calling the right function according to the type)
* make all appender internal function static
* all appenders return the generic wLogAppender type now. Typecasts
are internally done where necessary this abstracts the appenders more
cleanly
2015-11-09 18:25:45 +01:00
Bernhard Miklautz
d73c4898c1
Add build-config.h
...
build-config.h should contain configure/compile time settings that are
relevant for projects that use FreeRDP.
For example the compiled in plugin search paths.
2015-11-09 15:54:22 +01:00
Bernhard Miklautz
8206ae440f
Pump version to 2.0.0
2015-11-09 15:54:22 +01:00
Norbert Federa
2ac195e8eb
Merge pull request #2964 from hardening/udp_appender
...
Add an UDP appender to wLog
2015-11-09 13:42:02 +01:00
David FORT
458aaa1213
Take in account @nfedera's remarks
2015-11-06 23:17:11 +01:00
Norbert Federa
13f710b55e
Merge pull request #2954 from mfleisz/cliprdr_fix
...
cliprdr/server: Server-side file content receiving used wrong callback
2015-11-06 13:43:44 +01:00
Norbert Federa
3eee70b164
Merge pull request #2926 from bjcollins/rail_fixes
...
Rail fixes
2015-11-06 13:34:42 +01:00
Hardening
f06556ce38
Merge pull request #2963 from nfedera/fix-fullscreen-multimon
...
client/X11: multimon/fullscreen fixes
2015-11-06 10:21:47 +01:00
Hardening
248dcbe211
Merge pull request #2968 from nfedera/fix-commandlinetoargv
...
winpr/argv: fix CommandLineToArgvA memory access
2015-11-06 10:19:40 +01:00
Norbert Federa
d6b5b906f4
winpr/argv: fix CommandLineToArgvA memory access
...
- fixed access of unitialized memory beyond terminating null
- minor simplifications
2015-11-05 18:10:05 +01:00
David FORT
5fbf26acf2
Add an UDP appender to wLog
...
This appender allows to receive the logs over a network connection using UDP packets.
You can see the logs using a listening netcat, for example: nc -ul 127.0.0.1 20000.
2015-11-04 18:11:19 +01:00
Norbert Federa
7ddd15d8de
client/X11: fix post fullscreen repositioning
2015-11-04 17:58:21 +01:00
Norbert Federa
48be0815c1
client/X11: multimon/fullscreen fixes
...
- fixed wrong calculation of xfc->fullscreenMonitors.[right|bottom]
- only use _NET_WM_FULLSCREEN_MONITORS if at least 2 monitors are involved
- call XMoveWindow before setting the _NET_WM_STATE_FULLSCREEN property
2015-11-04 15:01:31 +01:00
Bernhard Miklautz
b83356a0b3
Merge pull request #2961 from nfedera/nf-fix-image-copy-segfault
...
codec/color: fix segfault in freerdp_image32_copy
2015-11-03 12:22:22 +01:00
Norbert Federa
0f1cedcbb8
codec/color: fix segfault in freerdp_image32_copy
...
Code path for dstBytesPerPixel == 3 moved src and dst pointers
beyond their respective buffers.
2015-11-03 12:05:47 +01:00
Hardening
3d6e1fb418
Merge pull request #2951 from bmiklautz/friday
...
Misc fixes
2015-11-02 10:50:16 +01:00
Bernhard Miklautz
8b3ed92584
Merge pull request #2957 from hardening/journald
...
Adds a systemd journal appender
2015-11-02 10:45:35 +01:00
David FORT
2a8de84342
Take in account @bmiklautz remarks
...
* I have added a function to set the journal identifier
* the appender name has been changed from SYSTEMD to JOURNALD
2015-11-01 21:34:03 +01:00
David FORT
e3915b66b7
Fix the env var leak
2015-10-30 20:22:25 +01:00
David FORT
89156e53b7
Use unbuffered output
2015-10-30 20:20:42 +01:00
David FORT
9ea301983d
Adds a systemd journal appender
2015-10-30 14:50:14 +01:00
Bernhard Miklautz
a011719831
Merge pull request #2940 from hardening/syslog_appender
...
Add a wLog syslog appender
2015-10-29 18:44:14 +01:00
David FORT
8d2aadfccd
Fixed a warning
2015-10-29 18:33:42 +01:00
David FORT
c2a322f4d0
Support syslog type for the WLOG_APPENDER env var
2015-10-29 18:31:22 +01:00
Martin Fleisz
25b1e39460
cliprdr/server: Server-side file content receiving used wrong callback
2015-10-29 12:45:12 +01:00
David FORT
0cf2a0e50b
Don't include config.h in public headers
...
In fact we don't need the ifdefery in public headers, so don't include unneeded
config.h file.
2015-10-29 10:32:58 +01:00
Bernhard Miklautz
9520017b51
Merge pull request #2952 from mfleisz/server_cliprdr_config
...
cliprdr/server: Provide the server with a possibility to configure capabilities
2015-10-28 15:55:17 +01:00
Martin Fleisz
ab6485b3bf
cliprdr/server: Add comment
2015-10-28 12:28:14 +01:00
David FORT
382993d4d5
Include config.h file when needed
2015-10-27 21:45:26 +01:00
Martin Fleisz
730f43a380
cliprdr/server: Provide the server with a possibility to configure capabilities
2015-10-27 17:12:33 +01:00
Bernhard Miklautz
c70559d128
winpr API: add EnvironmentBlockToEnvpA
...
* expose EnvironmentBlockToEnvpA
* cleanup includes in process.c
* removed unused "flag" variable in _CreateProcessExA
* make ProcessHandleCloseHandle static
2015-10-23 18:38:42 +02:00
Bernhard Miklautz
ab05a79c21
winpr/stream: don't allow 0-size streams
2015-10-23 18:38:41 +02:00
Bernhard Miklautz
a9d81ad083
winpr: fix compiler warning
...
winpr/libwinpr/utils/wlog/wlog.c: In function ‘WLog_PrintMessageVA’:
winpr/libwinpr/utils/wlog/wlog.c:234:7: warning: ‘status’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
BOOL status;
^
gcc 4.9.2
2015-10-23 18:37:39 +02:00
Bernhard Miklautz
fa2c39f808
Merge pull request #2945 from mfleisz/wlog_compile_fix
...
wlog: Fix variable definitions
2015-10-23 12:38:13 +02:00
Martin Fleisz
08cbcb3577
wlog: Fix variable definitions
2015-10-23 12:08:20 +02:00
Vic Lee
39195bdacb
Merge pull request #2929 from mfleisz/cliprdr_fix
...
cliprdr/server: Don't call CloseHandle on ChannelEvent
2015-10-23 15:59:07 +08:00
Martin Fleisz
2d99f76667
cliprdr/server: Fix memory leak
2015-10-23 08:49:24 +02:00
David FORT
d9080312bc
Adapt to last wLog changes
2015-10-22 10:54:21 +02:00
David FORT
720c879661
Add a wLog syslog appender
2015-10-22 10:37:49 +02:00
Hardening
94d107c75f
Merge pull request #2927 from MartinHaimberger/mh-log-returnvalues
...
wlog: fixed return values
2015-10-22 10:35:43 +02:00
MartinHaimberger
16069e69e5
Merge pull request #2939 from nfedera/fix-x11-clip-id
...
xfreerdp/clipr: fix self owned test and hardening
2015-10-21 12:57:12 +02:00
Martin Haimberger
b2398b3a9a
wlog: fixed return values
...
wlog used to return an int but the only meaning
of the return value was:
* negative ... error
* 0 or positive ... success
but the positve returned value was 1 or some id of some
subsystem, nothing meaningful for the caller.
For a more meaningful returnvalue we now use BOOL.
If something goes wrong FALSE is returned.
2015-10-21 01:11:06 -07:00