Commit Graph

20013 Commits

Author SHA1 Message Date
akallabeth
8e33854c62
[tests] improve TestCommonAssistance
Compare encrypted passwords against reference values to ensure the
encryption routines work as expected
2024-10-30 13:22:59 +01:00
akallabeth
555d46f7e2
[winpr,crypto] deactivate key and IV lenght checks
OpenSSL does not support that in older versions, deactivate for the time
being.
2024-10-30 13:22:57 +01:00
akallabeth
2a41730f70
[common,assistance] replace winpr_Cipher_New
* use winpr_Cipher_NewEx where possible
* use winpr_RC4_New where RC4 is used
2024-10-30 13:22:55 +01:00
akallabeth
3ae0a10142
[core] replace usage of winpr_Cipher_New
prefer winpr_CipherNewEx to be on the safe side.
2024-10-30 13:22:52 +01:00
akallabeth
2b0b52be9e
[core,rdp] adjust warning for RC4
RC4 is not supported by winpr_Cipher_New but only by explicitly calling
winpr_RC4_New. Adjust the availability test to use the correct
functions.
2024-10-30 13:22:50 +01:00
akallabeth
1eac8fa15e
[winpr,crypto] deprecate winpr_Cipher_New
Deprecate function in favor of new winpr_CipherNewEx with explict key
and IV length parameters, adjust test cases to test both.
2024-10-30 13:22:45 +01:00
akallabeth
a7638bb0e4
Merge pull request #10798 from akallabeth/kbd-remap-fix
[utils,string] fix freerdp_extract_key_value
2024-10-29 17:20:52 +01:00
akallabeth
24ab4b297f
[utils,string] fix freerdp_extract_key_value
reset errno before strtoul to avoid aborting due to a previous errno
value from a different function call
2024-10-29 16:50:00 +01:00
akallabeth
e9b942f612
Merge pull request #10791 from akallabeth/vmconnect
[client,common] tighten /vmconnect checks
2024-10-28 10:04:54 +01:00
akallabeth
f0d0105d50
[client,common] tighten /vmconnect checks
Fixes #5300:
* abort if +/-nego is used, /vmconnect overrides these.
* only set custom port if no /port or /v:host:port is in use allowing
  overriding default port
2024-10-28 09:44:21 +01:00
Martin Fleisz
fa71cb18f0
Merge pull request #10793 from akallabeth/ntlm-fixes
[winpr,sspi] fix NULL NTLM password handling
2024-10-28 09:44:20 +01:00
akallabeth
882060031f
Merge pull request #10787 from akallabeth/proxy-arg-check
[server,proxy] stricter argument parsing
2024-10-28 09:32:30 +01:00
akallabeth
98335b7dde
Merge pull request #10792 from akallabeth/cov-assert-silence
[ci,assert] silence coverity on WINPR_ASSERT
2024-10-28 09:22:54 +01:00
akallabeth
c9a946f272
[winpr,sspi] fix NULL NTLM password handling
* Pass through the NULL, but fail as the hash matches the NULL hash
2024-10-28 09:09:56 +01:00
Martin Fleisz
56786ea606
Merge pull request #10786 from akallabeth/ntlm-fixes
Ntlm fixes
2024-10-28 09:04:57 +01:00
akallabeth
c513886914
[ci,assert] silence coverity on WINPR_ASSERT
silence covertiy NO_EFFECT with _Pragma when using WINPR_ASSERT.
We´ve got a lot of situations where a check is mostly useless when
functions are called correctly, but the check triggers on common errors.
So silence this warning on our perfectly fine usage situations
2024-10-28 08:36:23 +01:00
akallabeth
259b4f40c8
Merge pull request #10790 from akallabeth/ci
[compiler,macros] fix pragma by compiler support
2024-10-27 22:36:35 +01:00
akallabeth
a60ac2321d
[compiler,macros] fix pragma by compiler support 2024-10-27 21:58:58 +01:00
akallabeth
42178b6191
Merge pull request #10789 from akallabeth/ci
Ci
2024-10-27 20:35:11 +01:00
akallabeth
fd1c850c62
[ci,preloads] fix CMAKE_BUILD_TYPE 2024-10-27 20:07:41 +01:00
akallabeth
7adb9517fc
[ci,alt-arch] use v2.8.1 of alt-architecture build 2024-10-27 20:07:33 +01:00
akallabeth
a0cb7ce166
Merge pull request #10788 from akarl10/websocket-negotiate-non-plain-ntlm-fix
[rdg,websockets] Fix Http Negotiate for Websocket
2024-10-27 19:17:09 +01:00
akarl10
1ea08b776f Fix Http Negotiate for Websocket
When using negotiate in non direct NTLM mode the success response
contains an aditional token for the authentication layer.
Add HTTP_STATUS_SWITCH_PROTOCOLS to the list of valid HTTP status codes
where to extract the last auth token
2024-10-26 23:43:37 +02:00
akallabeth
940d067f52
[server,proxy] stricter argument parsing
* Check number of arguments is valid (don't allow additional ones)
* Replace exit() with normal return for helper functions
2024-10-26 19:53:36 +02:00
akallabeth
d2ec568d39
[winpr,sspi] improve NTLM unit test
* Test empty passwords as well
* Improve return value checks
2024-10-26 15:18:29 +02:00
akallabeth
91a5f06ba3
[winpr,sspi] allow empty NTLM passwords 2024-10-26 15:18:26 +02:00
akallabeth
e560733f8e
[winpr,sspi] fix NTLM debug message
dump only hex of received data, the symbols might not be printable.
2024-10-26 14:42:12 +02:00
akallabeth
d19b7fa5d0
Merge pull request #10768 from akallabeth/stream-write-assert
[winpr,stream] assert Stream_Write_(U)INT[8|16|32] ranges
2024-10-26 14:40:43 +02:00
akallabeth
11570395bc [winpr,stream] updated function documentation 2024-10-25 14:36:28 +02:00
akallabeth
0a6679b793
Merge pull request #10783 from akallabeth/rpm-fix
[ci,nightly] fix missing files in RPM spec
2024-10-25 14:11:37 +02:00
akallabeth
75c2e9f6a5
[ci,nightly] add a script to build an RPM nightly 2024-10-25 14:09:40 +02:00
akallabeth
e7414ef635
[ci,nightly] fix missing files in RPM spec 2024-10-25 13:47:13 +02:00
Martin Fleisz
9a21b81422
Merge pull request #10465 from akallabeth/desktop-files
[client,common] add WITH_INSTALL_CLIENT_DESKTOP_FILES
2024-10-25 12:33:27 +02:00
akallabeth
c377b0ce86
[client,common] add WITH_INSTALL_CLIENT_DESKTOP_FILES
This new CMake option allows installing .desktop files and application
icons if turned on.
2024-10-25 12:11:54 +02:00
akallabeth
e4e6e254a2
Merge pull request #10781 from akallabeth/nightly-update
Nightly update
2024-10-25 12:08:08 +02:00
akallabeth
0a02afc225
[winpr,assert] silence -Wtautological-value-range-compare
assertions sometimes check for values that are not possible (checks in
defines that are used on different types, ...) so silence these
warnings.
2024-10-25 12:04:06 +02:00
akallabeth
88d9b1f110
[crypto,per] abort on invalid parameters 2024-10-25 11:48:16 +02:00
akallabeth
5f86284663
[core,orders] fix update_write_coord
* Add value range checks
* Add proper log message
* Add failure return
2024-10-25 11:48:14 +02:00
akallabeth
738cbd54b2
[core] fix issues with value ranges written 2024-10-25 11:48:12 +02:00
akallabeth
04a5bbed4a
[winpr,stream] unify Stream_Fill and Stream_Zero 2024-10-25 11:48:09 +02:00
akallabeth
941c36f4f6
[winpr,stream] assert Stream_Write_(U)INT[8|16|32] ranges
* Every function takes a (U)INT64 as argument to avoid shortening the
  original value
* The limits are asserted so invalid values can be found during runtime
2024-10-25 11:48:07 +02:00
Armin Novak
8c9f83a12f
[ci,nightly] update rpm spec 2024-10-25 11:40:48 +02:00
akallabeth
edde0f542e
[ci,nightly] update debian nightly
* Use keyboard layouts from installed JSON
* Use timezones from installed JSON
* Run unit tests during package build
* Enable internal RC4/MD4/MD5
2024-10-25 11:40:46 +02:00
akallabeth
a27d9508e2
[cmake] unify CFLAGS to string
* move to common CMake function
* escape CFLAGS
2024-10-25 11:40:43 +02:00
akallabeth
a3aa01214c
[resource root] unify locations
unify resource locations in case WITH_BINARY_VERSIONING is set.
2024-10-25 11:40:40 +02:00
akallabeth
5538681fc3
Merge pull request #10780 from akallabeth/window-fake-monitor
Window fake monitor
2024-10-24 14:24:18 +02:00
akallabeth
392a085728
[core,settings] enforce fullscreen monitor requirements
* Monitor must start at 0/0
* Monitor must be primary
2024-10-24 11:32:10 +02:00
akallabeth
7ab30a1b18
[client,common] const correct pointer array arguments 2024-10-24 11:32:08 +02:00
akallabeth
14c4cd8dc3
[client,sdl] ignore window properties if not fullscreen/multimon 2024-10-24 11:32:05 +02:00
akallabeth
401f81683c
[core,settings] fake monitor in window mode
RDP requires sending monitor information to the server. If we are in
windowed mode fake that information with the windows size
2024-10-24 11:32:03 +02:00