Commit Graph

9794 Commits

Author SHA1 Message Date
Armin Novak
8917a3da95 Fix CB_FILECONTENTS_REQUEST message decoding.
Do not require optional fields to be present as required by
[MS-RDPECLIP] 2.2.5.3 File Contents Request PDU (CLIPRDR_FILECONTENTS_REQUEST)
2016-04-19 16:47:44 +02:00
Norbert Federa
8110435b90 Merge pull request #3294 from bmiklautz/misc_build
Misc build and test fixes
2016-04-19 15:32:56 +02:00
Norbert Federa
a4cec9f7fc Merge pull request #3287 from bmiklautz/linking_fixes2
build: add missing dependencies
2016-04-19 15:21:49 +02:00
Hardening
d4b73018a1 Merge pull request #3293 from nfedera/mitigate-cbclientaddress-verification
core: allow TS Gateway protocol violation
2016-04-19 14:55:26 +02:00
Bernhard Miklautz
0ebc6f1f54 build: disable -Wl,--no-undefined per default
As building with -Wl,--no-undefined might cause issues when
combined with other linker flags (e.g. with -fsanitize=address see #3289)
it is now disabled per default but can be re-enabled with
-DWITH_NO_UNDEFINED=ON.

It is enabled for ci builds on linux to find undefined symbols.
2016-04-19 14:33:26 +02:00
Norbert Federa
9f148e6712 core: allow TS Gateway protocol violation
According to [MS-RDPBCGR 2.2.1.11.1.1.1] the TS_EXTENDED_INFO_PACKET
structure's cbClientAddress field must include the _mandatory_ NULL
terminator of the clientAddress field in its byte count.
However, connections proxied via Microsoft's TS Gateway set the
cbClientDir value to 0.
2016-04-19 14:09:58 +02:00
Bernhard Miklautz
4a9da95b0d Tests: Disable TESTS_WTSAPI_EXTRA per default
TESTS_WTSAPI_EXTRA was mistakenly always enabled if BUILD_TESTING
was enabled.
2016-04-19 12:46:54 +02:00
Bernhard Miklautz
470e1474e4 Merge pull request #3285 from rjcorrig/kb3148851
winpr: KB3148851: Updates to Russian Time Zones for 2016
2016-04-15 14:48:46 +02:00
Bernhard Miklautz
62cb5fac44 build: add missing dependencies
Add all missing dependencies found when building with
STATIC_CHANNELS=OFF.

Fixes #3281
2016-04-15 14:32:40 +02:00
Robert Corrigan
f8c42da561 KB3148851: Updates to Russian Time Zones for 2016 2016-04-13 14:44:30 -04:00
Hardening
11d113872f Merge pull request #3274 from bmiklautz/linking_fixes
Fix build regressions
2016-04-11 20:47:53 +02:00
Hardening
c9f4485e2c Merge pull request #3276 from nfedera/nf-fix-ms-android-protocol-violation
core: allow ms android client protocol violation
2016-04-11 11:10:08 +02:00
Norbert Federa
4ae77b8273 core: allow ms android client protocol violation
According to [MS-RDPBCGR 2.2.1.11.1.1.1] the TS_EXTENDED_INFO_PACKET
structure's cbClientDir field must include the _mandatory_ NULL
terminator of the ClientDir field.
However, since version 8.1.31.44, the Microsoft Remote Desktop Client
for Android sets cbClientDir to 0.
2016-04-11 10:50:27 +02:00
akallabeth
45ab97904f Merge pull request #3275 from nfedera/fix-server-establish-keys-typo
core: fix broken rdp security (server side)
2016-04-08 15:28:40 +02:00
Norbert Federa
6ee445339b core: fix broken rdp security (server side)
- fixed typo in rdp_server_establish_keys
2016-04-08 14:47:35 +02:00
Bernhard Miklautz
783807229d build: add missing dependencies
Add all missing dependencies found with --no-undefined. Since
dependencies aren't exported anymore (if not required) it is no necessary
to explicitly list all required libraries.
2016-04-07 15:10:00 +02:00
Bernhard Miklautz
0e2c4f2d69 Merge pull request #3273 from realjiangms/fix_android_crash_rotate_3258
Fix android rotation crash
2016-04-07 14:52:52 +02:00
Bernhard Miklautz
8fe88acbf3 build: use --no-undefined if available 2016-04-07 14:35:57 +02:00
zihao.jiang
748982c94b Fix android rotation crash 2016-04-07 20:19:22 +08:00
Bernhard Miklautz
a0d9969a30 Merge pull request #3254 from akallabeth/avc444_cmd_arg
Added advanced gfx command line options.
2016-03-31 11:43:38 +02:00
Armin Novak
81450dd37c Cleaned up empty if. 2016-03-31 11:01:45 +02:00
akallabeth
445059b76e Merge pull request #3259 from bmiklautz/overlinking
Fix overlinking
2016-03-30 15:20:53 +02:00
Bernhard Miklautz
bafe1aa17e usbdrc: remove unused dependencies 2016-03-29 18:14:34 +02:00
Bernhard Miklautz
9e8c6c99b6 First shot on fixing over linking
If a target is linked against libraries with cmake
(target_link_libraries) and the libraries are not marked as PRIVATE
they are "exported" and in case a other target is linked against this
target it is also linked against *all* (not private) libraries.

Without declaring private libraries PRIVATE a lot of over linking
(linking against unneeded libraries) was done.
2016-03-29 18:14:34 +02:00
Bernhard Miklautz
b184f58c1b winpr/TestFileGetStdHandle: rename variable stdout
stdout shouldn't be used as variable name (can't even be used on
windows).
2016-03-29 18:14:16 +02:00
Armin Novak
50873be062 Added advanced gfx command line options. 2016-03-24 16:36:43 +01:00
akallabeth
75ae3f58df Merge pull request #3243 from hardening/typofix
Fixed a typo in debug messages
2016-03-17 11:06:39 +01:00
Bernhard Miklautz
14daecf293 Merge pull request #3240 from akallabeth/drive_fixes
Small Drive fixes
2016-03-17 11:02:51 +01:00
David FORT
2cb3717d65 Fixed a typo in debug messages 2016-03-17 10:44:11 +01:00
Armin Novak
43b13ffcd2 Replace SetFilePointerEx with SetFilePointer. 2016-03-17 09:34:24 +01:00
Armin Novak
f45be8dab0 Print device name when loading channel. 2016-03-17 09:33:39 +01:00
Martin Fleisz
80cd64732f Merge pull request #3164 from akallabeth/windows_UnixChangeFileMode
Implemented UnixChangeFileMode for windows.
2016-03-16 15:19:11 +01:00
Bernhard Miklautz
eb5e303328 Merge pull request #3215 from akallabeth/avc_444
Avc 444 support
2016-03-16 14:05:55 +01:00
Bernhard Miklautz
90b3bf4891 Merge pull request #3204 from akallabeth/rdp_file_preference_fix
Rdp file preference fix
2016-03-16 13:56:39 +01:00
Armin Novak
7faff04ec0 Assume the update rectangle is inclusive. 2016-03-16 13:46:47 +01:00
Armin Novak
dfdc4c38f9 Fixed comments. 2016-03-16 13:43:18 +01:00
Armin Novak
9ab3532bf8 Renamed GFX defines to conform to spec. 2016-03-16 13:43:18 +01:00
Armin Novak
5bc333c626 Implemented GFX AVC444 support. 2016-03-16 13:43:18 +01:00
Armin Novak
3309bf8f9c Implemented YUV444 related primitives. 2016-03-16 13:43:17 +01:00
Armin Novak
3a3ec85898 Unified RDPGFX_RECT16 and RECTANGLE_16 2016-03-16 13:43:17 +01:00
akallabeth
0c99d6a4fe Merge pull request #3226 from rjcorrig/#3198
winpr: Updates time zones and fixes bias values
2016-03-16 13:32:51 +01:00
akallabeth
2ea56c6515 Merge pull request #3234 from bmiklautz/rdkt_version
Increase rdtk version to 2.0.0
2016-03-16 13:32:29 +01:00
Robert Corrigan
a4f0089d45 winpr_detect_windows_time_zone should have void argument 2016-03-16 08:29:21 -04:00
Armin Novak
fd26624bcb Parse RDP and assistance files in parser.
The command line parser is now populating the settings with
the RDP or assistance file content before parsing the rest
of the arguments.
2016-03-16 13:20:11 +01:00
Armin Novak
fb44b6880b Removed windows extra handling for RDP files. 2016-03-16 13:20:08 +01:00
Bernhard Miklautz
babbc4b83f Increase rdtk version to 2.0.0
rdtk was initially 1.0.0 then changed to 0.0.1.
To have a clean cut and prevent problems on systems which already have
FreeRDP in a version where rdtk was 1.0.0 increase it to 2.0.0
2016-03-16 13:15:24 +01:00
Armin Novak
3d23a772f6 Updated ConvertToUnicode return check. 2016-03-16 13:08:06 +01:00
Bernhard Miklautz
228f6b116b Merge pull request #3207 from akallabeth/mic_crash_fix
Fixed error handling for channel load failures.
2016-03-16 13:03:33 +01:00
Armin Novak
059c754b0d Fixed double free. 2016-03-16 12:39:36 +01:00
Bernhard Miklautz
1b1563658e Merge pull request #3214 from hardening/fix_systemd_appender
Make systemd appender honor layout and logs off
2016-03-16 11:58:31 +01:00