Commit Graph

1821 Commits

Author SHA1 Message Date
Norbert Federa af992f4ce1 channels/client: fix alsa/pulse warning and checks
- pa_stream_writable_size() returns (size_t) -1 on error
- fix missing cast in alsa client sound channel code
2018-10-23 09:45:20 +02:00
Armin Novak fe7a37dcbd Cleaned up resource cleanup for rdpsnd alsa backend. 2018-10-22 14:53:46 +02:00
Armin Novak 3ed50aaca2 Implemented rdpsnd_pulse_get_volume 2018-10-22 13:17:25 +02:00
Armin Novak 9ff17dc0f4 fixed return value check in rdpsnd_recv_volume_pdu 2018-10-22 12:27:19 +02:00
Armin Novak e2e1071ff5 Seal length in wave pdu alignment. 2018-10-22 12:16:18 +02:00
Armin Novak 1a015612a6 Align wave pdu size 2018-10-22 12:00:07 +02:00
Armin Novak fb76f88cac Added missing length check and log message information. 2018-10-22 11:59:42 +02:00
Armin Novak 3d49697d19 Improved debug logging for sound device handling. 2018-10-22 10:27:16 +02:00
Armin Novak ff7e91fed0 Removed unnecessary pulse context check. 2018-10-22 10:18:17 +02:00
Armin Novak 03dcfaf8db Unified sound device reopen in a single function. 2018-10-22 10:04:02 +02:00
Norbert Federa 0572572eb9 fix issue with fnObjectFree and related casts
- remove unnecessary/dangerous OBJECT_xxx function-style casts
- fix -Wstrict-prototypes issue with OBJECT_NEW_FN definition
2018-10-19 11:30:01 +02:00
Norbert Federa d35470f8af rdpsnd: always call rdpsnd_server_send_formats
Since the rdpsnd_server_send_formats function is no longer exported
we must always call it, even if the rdpsnd server application uses
its own thread.
2018-10-18 10:21:15 +02:00
Armin Novak 3920c570dd Fixed memory leak with audio formats. 2018-10-15 16:33:56 +02:00
Martin Fleisz 00af869cd3
Merge pull request #4889 from akallabeth/shadow_server_audin_refactor
Shadow server audin refactor
2018-10-08 12:56:09 +02:00
Martin Fleisz ea5a0adfcf
Merge pull request #4913 from akallabeth/audin_opensles
Fixed audio recording with opensles.
2018-10-08 10:13:51 +02:00
Armin Novak ac14763564 [audin] Abort version exchange if server version is not supported. 2018-10-04 13:53:18 +02:00
Armin Novak 47f8804073 Fixed audio recording with opensles. 2018-10-04 13:18:06 +02:00
Armin Novak a8a6accc15 Fixed compiler warnings. 2018-10-03 15:16:59 +02:00
Armin Novak 2cf0662559 Unified format support for rdpsnd. 2018-09-26 12:49:52 +02:00
Armin Novak d56efaae8b Fixed server format selection. 2018-09-26 12:49:09 +02:00
Armin Novak 16531e1437 Fixed server audin callback, provide more information. 2018-09-26 12:49:09 +02:00
Armin Novak a83c805ade Fixed format debug message. 2018-09-26 12:49:09 +02:00
Armin Novak 18f97d03e7 Cleaned up defaults. 2018-09-26 12:49:09 +02:00
Armin Novak 106dde9571 Working mic redirection for shadow server. 2018-09-26 12:49:09 +02:00
Armin Novak 28efbbc01f Refactored audio_format* functions. 2018-09-26 12:49:09 +02:00
Martin Fleisz c3ec6d293b
Merge pull request #4862 from akallabeth/printer_warning_fix
Fixed a warning in printer channel.
2018-09-26 09:37:23 +02:00
Martin Fleisz 1d64a24647
Merge pull request #4888 from akallabeth/shadow_server_audin
Added microphone support to shadow server.
2018-09-25 14:38:09 +02:00
Armin Novak dab5770fed Added microphone support to shadow server. 2018-09-25 11:14:10 +02:00
Armin Novak 93846c801a Allow empty rail strings. 2018-09-25 09:54:47 +02:00
David Fort ba69925b8d
Merge pull request #4501 from akallabeth/drive_file_size_fix
Removed xrdp workarounds.
2018-09-24 16:00:27 +02:00
Armin Novak baee520e3d Fix for #4866: Added additional length checks 2018-09-20 09:06:01 +02:00
Armin Novak f63286dbea Fixed smartcard filter for empty arguments. 2018-09-19 11:13:02 +02:00
Armin Novak a744378110 Fixed a warning in printer channel. 2018-09-18 14:45:25 +02:00
Martin Fleisz 5686a0f907
Merge pull request #4840 from akallabeth/smartcard_filter
Added multi filter for smartcard. (based on #4837 by @informatimago)
2018-09-17 09:08:32 +02:00
Armin Novak 5819946b84 Fixed rail unicode string conversion and const correctness. 2018-09-14 10:04:16 +02:00
Armin Novak 4596588e0f Set freed pointer to NULL avoiding double free. 2018-09-04 15:22:06 +02:00
Armin Novak b2ce309b28 Added multi filter for smartcard. (based on #4837 by @informatimago) 2018-09-04 14:34:32 +02:00
Armin Novak 5bc3993e3f Fixed buffer size and function name 2018-08-27 14:34:42 +02:00
Armin Novak fad20be6e6 Fixed missing includes. 2018-08-27 14:34:42 +02:00
Armin Novak 62c1696d4c Removed use of unchecked sprintf 2018-08-27 14:34:42 +02:00
Armin Novak 114abad767 Removed use of strcpy. 2018-08-27 14:34:09 +02:00
Armin Novak d90e5da865 Fixed unused label warning. 2018-08-24 13:40:36 +02:00
Martin Fleisz 8248dcb3bb
Merge pull request #4816 from akallabeth/drive_cmd_fix
Fix #4680: Return proper directory name.
2018-08-24 09:45:26 +02:00
Armin Novak ab18f8f222 Fix #4680: Return proper directory name. 2018-08-23 10:04:26 +02:00
Ondrej Holy 97f25e8ab4 channels/smartcard: Fix leak found by covscan
leaked_storage: Variable "operation" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy 3baa716706 channels/smartcard: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
2018-08-22 13:35:43 +02:00
Ondrej Holy ab7ab7a7ce channels/server: Silence false positive warnings from covscan
Change the code a bit to silence false positive warnings from covscan.

leaked_storage: Ignoring storage allocated by "audin_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpsnd_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "cliprdr_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "echo_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpdr_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "drdynvc_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpei_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "remdesk_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "encomsp_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpgfx_server_context_new(NULL)" leaks it.
2018-08-22 13:35:43 +02:00
Ondrej Holy 4ba3c46cd0 channels/server: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
2018-08-22 13:35:43 +02:00
Ondrej Holy 170d5859d2 channels/serial: Fix leak found by covscan
leaked_storage: Variable "ids" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy d3ab04d786 channels/remdesk: Fix leak found by covscan
leaked_storage: Variable "pass" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00