Commit Graph

12482 Commits

Author SHA1 Message Date
Armin Novak 847ee233f4 Fixed resource leak in rpc_ntlm_http_request 2018-10-25 12:49:42 +02:00
akallabeth d3c1db1746
Merge pull request #4947 from akallabeth/http_gw_fix
Fixed http gateway body length read.
2018-10-23 12:03:03 +02:00
akallabeth 76e81c6157
Merge pull request #4958 from nfedera/nf-fix-alsapulse-wrn-err
channels/client: fix alsa/pulse warning and checks
2018-10-23 10:40:09 +02:00
Norbert Federa af992f4ce1 channels/client: fix alsa/pulse warning and checks
- pa_stream_writable_size() returns (size_t) -1 on error
- fix missing cast in alsa client sound channel code
2018-10-23 09:45:20 +02:00
Norbert Federa a7022e9a57
Merge pull request #4957 from akallabeth/wave_2_pdu_fix
Wave 2 pdu fix
2018-10-23 09:28:00 +02:00
akallabeth 16d37b1a17
Merge pull request #4932 from hardening/stream_static
winpr: add some functions to use wStream in a static way
2018-10-22 21:16:36 +02:00
Armin Novak fe7a37dcbd Cleaned up resource cleanup for rdpsnd alsa backend. 2018-10-22 14:53:46 +02:00
Bernhard Miklautz 0e9b26c1d2
Merge pull request #4796 from akallabeth/groegera_fixes
Update X11-modifier key state on focus_in
2018-10-22 12:50:21 +00:00
Armin Novak 900abb61f7 Fixed memory leak in update_recv_surfcmd_surface_bits 2018-10-22 14:41:59 +02:00
Armin Novak 3ed50aaca2 Implemented rdpsnd_pulse_get_volume 2018-10-22 13:17:25 +02:00
Armin Novak 9ff17dc0f4 fixed return value check in rdpsnd_recv_volume_pdu 2018-10-22 12:27:19 +02:00
Armin Novak e2e1071ff5 Seal length in wave pdu alignment. 2018-10-22 12:16:18 +02:00
Armin Novak 1a015612a6 Align wave pdu size 2018-10-22 12:00:07 +02:00
Armin Novak fb76f88cac Added missing length check and log message information. 2018-10-22 11:59:42 +02:00
Armin Novak 3d49697d19 Improved debug logging for sound device handling. 2018-10-22 10:27:16 +02:00
Armin Novak ff7e91fed0 Removed unnecessary pulse context check. 2018-10-22 10:18:17 +02:00
Armin Novak 03dcfaf8db Unified sound device reopen in a single function. 2018-10-22 10:04:02 +02:00
akallabeth c251bdc11a
Merge pull request #4952 from eledoux/master
gateway HTTP transport - fixed partial reads
2018-10-19 17:13:21 +02:00
akallabeth b8ff18f37f
Merge pull request #4951 from nfedera/nf-fix-fnobjnew-fnstylecasts
fix issue with fnObjectFree and related casts
2018-10-19 14:00:14 +02:00
akallabeth 1929e3d1e1
Merge pull request #4949 from bmiklautz/floatbar_warning
fix [x11]: compiler warnings in floatbar
2018-10-19 13:47:42 +02:00
akallabeth a263da002d
Merge pull request #4950 from bmiklautz/cleanup_pr_4581p2
fix [cache/pointer]: add missing callback checks
2018-10-19 13:00:51 +02:00
Armin Novak b9933e7af4 Read byte by byte, the alignment may otherwise be broken. 2018-10-19 12:52:14 +02:00
Armin Novak 5a747b118d Read http request in 4byte chunks until '\r\n\r\n' is found
Avoid reading too much data in a single call to BIO_read as some
implementations may return a lot more data than is part of the response.
2018-10-19 12:16:04 +02:00
Emmanuel Ledoux 33c7f6590a fixed partial reads 2018-10-19 11:56:56 +02:00
Armin Novak d05684a50a Properly parse ContentType to find length. 2018-10-19 11:47:11 +02:00
Bernhard Miklautz 9b353202a5 fix [x11]: compiler warnings in floatbar
client/X11/xf_floatbar.c:530:27: warning: use of logical '&&' with constant
      operand [-Wconstant-logical-operand]
        if (event->xmotion.state && Button1Mask && mode > XF_FLOATBAR_MODE_DRAGGING)
                                 ^  ~~~~~~~~~~~
client/X11/xf_floatbar.c:534:32: warning: use of logical '&&' with constant
      operand [-Wconstant-logical-operand]
        else if (event->xmotion.state && Button1Mask && mode == XF_FLOATBAR_MODE_DRAGGING)
                                      ^  ~~~~~~~~~~~
clang 8.0.0-svn344413-1~exp1+0~20181012203207.819~1.gbpc91f27
2018-10-19 11:33:28 +02:00
Norbert Federa 0572572eb9 fix issue with fnObjectFree and related casts
- remove unnecessary/dangerous OBJECT_xxx function-style casts
- fix -Wstrict-prototypes issue with OBJECT_NEW_FN definition
2018-10-19 11:30:01 +02:00
Bernhard Miklautz 7290e3f2b0 fix [cache/pointer]: add missing callback checks 2018-10-19 11:13:21 +02:00
MartinHaimberger 1dc3c91a19
Merge pull request #4948 from bmiklautz/cleanup_pr_4581
new [cache/pointer]: don't require pointer functions to be set
2018-10-19 11:10:23 +02:00
Bernhard Miklautz e114ee44e4 new [cache/pointer]: don't require pointer functions to be set
This as cleanup/rework of PR #4581.
2018-10-19 10:14:24 +02:00
Armin Novak 7e397d0f1c Fixed http gateway body length read. 2018-10-19 09:31:55 +02:00
akallabeth 3d0ccb3f5d
Merge pull request #4946 from mmattes/fix/floatbar_app_check_missing
added missing check for remote app where no floatbar exists
2018-10-18 16:40:22 +02:00
akallabeth 6f14018a22
Merge pull request #4945 from mmattes/fix/transferEncoding
transferEncoding can be NULL, correct if happens in line 348
2018-10-18 15:37:24 +02:00
Markus Mattes a235b44f61 added missing check for remote app where no floatbar exists 2018-10-18 15:33:01 +02:00
Norbert Federa 850d2dbda9
Merge pull request #4942 from akallabeth/rail_fixes_2.0
Fix ORDER_TYPE_WINDOW reading
2018-10-18 14:11:18 +02:00
Norbert Federa 5ef243f91f
Merge pull request #4941 from nfedera/nf-remove-stale-valgrind-macro
gateway/rpc: remove stale valgrind macro
2018-10-18 14:08:23 +02:00
Norbert Federa d9a4ae8310
Merge pull request #4938 from akallabeth/warning_fixes_master
Warning fixes and TSG abort condition fix
2018-10-18 14:08:01 +02:00
Markus Mattes 6d5b88cda6 transferEncoding can be NULL, verification happens in line 348 2018-10-18 13:59:49 +02:00
Armin Novak 5b70142ec4 Fixed read_altsec_order ORDER_TYPE_WINDOW 2018-10-18 12:34:10 +02:00
Armin Novak 8bdb5d771a Fixed order to string format string. 2018-10-18 12:33:06 +02:00
Norbert Federa d201deede8 gateway/rpc: remove stale valgrind macro 2018-10-18 11:45:18 +02:00
Martin Fleisz eea5e2085e
Merge pull request #4939 from nfedera/nf-fix-rdpsnd_server_send_formats
rdpsnd: always call rdpsnd_server_send_formats
2018-10-18 11:12:59 +02:00
Armin Novak 2e3832af94 Fixed TSG stream alignment (4 or 8) 2018-10-18 10:41:03 +02:00
Norbert Federa d35470f8af rdpsnd: always call rdpsnd_server_send_formats
Since the rdpsnd_server_send_formats function is no longer exported
we must always call it, even if the rdpsnd server application uses
its own thread.
2018-10-18 10:21:15 +02:00
Armin Novak dc197d4dd1 Fixed tsg abort condition. 2018-10-18 10:15:51 +02:00
Armin Novak 88d310ff2c Fixed compiler warnings (casts, ...) 2018-10-18 09:09:30 +02:00
Armin Novak 554e18780b USe const compare function pointer arguments 2018-10-18 09:06:55 +02:00
David Fort 13e2a8834d winpr: add some functions to use wStream in a static way
It's sometime useful to create a stream aliasing a buffer on the stack, and
it's nice if we don't need some extra malloc for this.

Example use:
   BYTE buffer[20];
   wStream s;

   Stream_StaticInit(&s, buffer, sizeof(buffer));
   Stream_Write_UINT16(&s, 0xff01);
   Stream_Free(&s, FALSE);
2018-10-17 19:07:48 +02:00
akallabeth 305f5d1bd5
Merge pull request #4600 from andreesteve/xfullscreen
X11: Fix fullscreen toggle
2018-10-17 17:27:29 +02:00
MartinHaimberger 558a03f60c
Merge pull request #4937 from akallabeth/server_rdpsnd_get_formats
Fix Server rdpsnd get formats
2018-10-17 17:16:28 +02:00