Pascal J. Bourguignon
79d2294a23
Put back deprecated function names crypto_cert_get_alt_names and crypto_cert_alt_names_free for FREERDP_API compatibility.
2018-08-24 15:20:03 +02:00
Pascal J. Bourguignon
98b8602663
Use C comment syntax instead of C++; added static declaration for local functions.
2018-08-24 15:05:50 +02:00
Pascal J. Bourguignon
469f9bf488
Smartcard Logon: restructured x509 certificate info extraction; added extracting the UPN.
2018-08-24 14:03:04 +02:00
Martin Fleisz
f9e52c1850
Merge pull request #4815 from akallabeth/async_transport_remove
...
Removed +async-transport options
2018-08-24 09:48:51 +02:00
Martin Fleisz
3381ca46e6
Merge pull request #4787 from akallabeth/redirect_fqdn_fix
...
Redirect fqdn fix
2018-08-23 16:07:48 +02:00
Ondrej Holy
0b7d0c2002
crypto/tls: Prevent usage of freed pointer found by coverity
...
pass_freed_arg: Passing freed pointer "pemCert" as an argument to "WLog_PrintMessage".
2018-08-22 14:34:02 +02:00
Ondrej Holy
47595a857f
core/transport: Fix leak found by covscan
...
0 is valid return value from socket().
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
2018-08-22 14:34:02 +02:00
Ondrej Holy
1a413b5b4e
core/tcp: Prevent buffer overflow found by covscan
...
buffer_size_warning: Calling strncpy with a maximum size argument of 108 bytes on destination array "addr.sun_path" of size 108 bytes might leave the destination string unterminated.
2018-08-22 14:34:02 +02:00
Ondrej Holy
26bc52f79c
core/tcp: Format code by astyle
...
Run ./scripts/format_code.sh before the following changes.
2018-08-22 14:34:02 +02:00
Ondrej Holy
7e4fa67026
core/proxy: Fix leak found by covscan
...
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
2018-08-22 14:34:02 +02:00
Ondrej Holy
2417a6a16c
core/nla: Fix leak found by covscan
...
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
2018-08-22 14:34:02 +02:00
Ondrej Holy
6e0f05cbdb
core/nego: Fix leak found by covscan
...
leaked_storage: Variable "wszPCB" going out of scope leaks the storage it points to.
2018-08-22 14:34:02 +02:00
Ondrej Holy
8f8d91e361
core/listener: Prevent buffer overflow found by covscan
...
buffer_size_warning: Calling strncpy with a maximum size argument of 108 bytes on destination array "addr.sun_path" of size 108 bytes might leave the destination string unterminated.
2018-08-22 14:34:02 +02:00
Ondrej Holy
23c3c188c9
core/info: Silence false positive warnings from covscan
...
Change the code a bit to silence false positive warnings from covscan.
pass_freed_arg: Passing freed pointer "wString" as an argument to "Stream_Write".
pass_freed_arg: Passing freed pointer "wString" as an argument to "Stream_Write".
2018-08-22 14:34:02 +02:00
Ondrej Holy
4a7bb18428
core/info: Fix leak found by covscan
...
leaked_storage: Variable "wString" going out of scope leaks the storage it points to.
2018-08-22 14:34:02 +02:00
Ondrej Holy
83e966d9e2
core/gateway/rpc: Fix leak found by covscan
...
0 is valid return value from socket().
leaked_storage: Variable "auth_3_pdu" going out of scope leaks the storage it points to.
leaked_storage: Variable "response" going out of scope leaks the storage it points to.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
2018-08-22 14:34:02 +02:00
Ondrej Holy
6de583e137
core/gateway/rpc: Format code by astyle
...
Run ./scripts/format_code.sh before the following changes.
2018-08-22 14:34:02 +02:00
Ondrej Holy
409e192334
core/gateway/rdg: Fix leak found by covscan
...
leaked_storage: Variable "request" going out of scope leaks the storage it points to.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
2018-08-22 14:34:02 +02:00
Ondrej Holy
79d0725a80
codec/planar: Fix leak found by covscan
...
The patch changes API of functions instead of fixing unused and broken code.
leaked_storage: Returning without freeing "outPlane" leaks the storage that it points to.
2018-08-22 14:34:02 +02:00
Armin Novak
c3a26b0d6a
Removed +async-transport options
...
The async transport option is broken by design.
If used the main loop is called from the transport thread and the
main thread of the application.
Unless the transport layer is refactored to just work on queues
(input and output) this option will never work, therefore remove it.
2018-08-22 13:56:37 +02:00
Ondrej Holy
36960e97a4
codec/nsc: Fix leak found by covscan
...
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Ondrej Holy
99c15e5339
cache: Fix wrong condition found by covscan
...
copy_paste_error: "xorMaskData" in "pointer_color->xorMaskData" looks like a copy-paste error.
2018-08-22 13:35:43 +02:00
Armin Novak
026ff00e7d
Fixed #4806 broken bounds check.
2018-08-21 09:08:33 +02:00
Armin Novak
13564dbb41
Allow redirect address override with a list of values.
2018-08-08 12:30:47 +02:00
Armin Novak
cc5e402cda
Added command line option /redirect-prefer:<fqdn|ip|netbios>
...
Since redirection sometimes happens with internal DNS names that
are resolved different by outside DNS it must be possible to override
the preferred redirection hint.
2018-08-08 11:24:13 +02:00
Armin Novak
f6b6eba0ab
Try redirection FQDN first, but check if it is resolvable.
2018-08-08 10:25:09 +02:00
Armin Novak
ec0a0fef2a
Added const to function buffer pointers
2018-08-01 12:56:18 +02:00
Armin Novak
2a3a66b18b
Fixed expression ambiguity
2018-08-01 12:56:18 +02:00
Armin Novak
3a30844db8
Added default return value.
2018-07-31 10:45:04 +02:00
MartinHaimberger
2d7499b7c0
Merge pull request #4758 from akallabeth/dsp_fix
...
Audio/microphone fixes
2018-07-31 10:22:22 +02:00
Martin Fleisz
143a2b149a
Merge pull request #4755 from akallabeth/dyn_resize_fix
...
Fixed #4679 , #4753 dynamic resizing
2018-07-30 12:28:38 +02:00
Armin Novak
3b187ef321
Code Cleanup
2018-07-19 16:21:03 +02:00
Armin Novak
a984dd7f56
Updated experimental list.
2018-07-19 15:38:44 +02:00
Armin Novak
d40daedb9c
Fixed FFMPEG backend: Do not drop samples for package alignment.
2018-07-19 15:17:54 +02:00
Armin Novak
c192c17c8c
Fixed mixed declaration.
2018-07-19 12:20:14 +02:00
Martin Fleisz
5a154dccbd
Merge pull request #4754 from akallabeth/expose_cert_redirection_flag
...
Expose redirection flag for certificate.
2018-07-18 16:32:53 +02:00
Armin Novak
3d6c41746d
Expose redirection flag for certificate.
2018-07-18 16:06:20 +02:00
Armin Novak
328eba7fe9
Fix #4752 : Provide message free function for channel queue.
2018-07-18 15:31:07 +02:00
Armin Novak
00b073adda
Fixed DVI_ADPCM mapping.
2018-07-18 12:33:39 +02:00
Armin Novak
6029a411e2
Fixed ima_adpcm encoder bug.
2018-07-17 12:57:57 +02:00
Armin Novak
7260a4fd8f
Fixed override of stream data in dsp_encode methods.
2018-07-17 10:30:35 +02:00
Armin Novak
7a6b8a04b9
Fixed channel reconnect after redirect.
2018-07-13 13:11:38 +02:00
Armin Novak
7ebc899516
Fixed PEM certificate reading.
2018-07-10 15:21:53 +02:00
Armin Novak
f617d0d3c1
Moved automatic reconnect after timeout to freerdp_connect.
2018-07-10 14:09:43 +02:00
Armin Novak
77eb93b4b7
Made internal functions static to help compiler optimize.
2018-07-10 12:21:38 +02:00
Armin Novak
7a39dcd7e2
Updated reconnect to handle cases where PostConnect was not called
...
freerdp_reconnect might be called after a freerdp_connect failed due
to a TCP timeout waiting for user input.
In such cases we need to know if PostConect was already called and
do that if not.
2018-07-10 12:04:27 +02:00
Armin Novak
c9cebf6ed6
Remember accepted PEM cert to avoid unnecessary user input.
2018-07-10 11:27:58 +02:00
Armin Novak
0d1895e4e7
Fixed async input return value check.
2018-07-09 17:45:50 +02:00
Armin Novak
398da7340b
Added no or missing credentail error.
2018-07-05 16:12:52 +02:00
Armin Novak
8f7dbe5051
Fix #4725 : Need to copy data.
2018-07-05 08:44:42 +02:00