mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core/gateway/rdg: Fix leak found by covscan

Browse Source 
leaked_storage: Variable "request" going out of scope leaks the storage it points to.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
This commit is contained in:
Ondrej Holy 2018-08-17 15:47:46 +02:00
parent 79d0725a80
commit 409e192334
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libfreerdp/core/gateway/rdg.c
View File

@ -322,7 +322,7 @@ static BOOL rdg_set_ntlm_auth_header(rdpNtlm* ntlm, HttpRequest* request)
static wStream* rdg_build_http_request(rdpRdg* rdg, const char* method,
const char* transferEncoding)
{
wStream* s;
wStream* s = NULL;
HttpRequest* request = NULL;
assert(method != NULL);
request = http_request_new();
@ -334,12 +334,12 @@ static wStream* rdg_build_http_request(rdpRdg* rdg, const char* method,
http_request_set_uri(request, rdg->http->URI);
if (!request->Method || !request->URI)
return NULL;
goto out;
if (rdg->ntlm)
{
if (!rdg_set_ntlm_auth_header(rdg->ntlm, request))
return NULL;
goto out;
}
if (transferEncoding)
@ -348,6 +348,7 @@ static wStream* rdg_build_http_request(rdpRdg* rdg, const char* method,
}
s = http_request_write(rdg->http, request);
out:
http_request_free(request);
if (s)
@ -680,7 +681,7 @@ static BOOL rdg_tls_connect(rdpRdg* rdg, rdpTls* tls, const char* peerAddress, i
peerAddress ? peerAddress : peerHostname,
peerPort, timeout);
if (sockfd < 1)
if (sockfd < 0)
{
return FALSE;
}
@ -698,6 +699,7 @@ static BOOL rdg_tls_connect(rdpRdg* rdg, rdpTls* tls, const char* peerAddress, i
if (!bufferedBio)
{
closesocket(sockfd);
BIO_free(socketBio);
return FALSE;
}