Armin Novak
7839091f8b
Skip redirection resolve test if we're connecting via gateway.
2018-11-16 15:48:10 +01:00
Armin Novak
870b7025b7
Improved error mapping and tightened checks in rdg_process_packet
2018-11-16 15:41:19 +01:00
Bernhard Miklautz
fe1a79759e
Merge pull request #5018 from hardening/windowpos
...
cmdline: add window-position argument to set initial window position
2018-11-15 16:46:57 +00:00
Bernhard Miklautz
b8cf70b13a
Merge pull request #4964 from akallabeth/rdg_fixes
...
Rdg/RPC and gateway fixes
2018-11-15 13:48:22 +00:00
David Fort
e118d14f6a
cmdline: add window-position argument to set initial window position
...
This is useful if you want the window to be at a given position. The patch also mutualizes
the parsing of <xpos>x<ypos> or <width>x<height> arguments.
2018-11-15 14:40:03 +01:00
Bernhard Miklautz
d915491717
Merge pull request #5012 from akallabeth/rail_app_icons
...
Rail app icons
2018-11-15 08:50:56 +00:00
akallabeth
268a2c0cf8
Merge pull request #4979 from hardening/CAL
...
license: support CAL license
2018-11-14 13:45:31 +01:00
Armin Novak
98a537d05d
Better description and formatting for update_read_icon_info
2018-11-14 11:57:57 +01:00
Armin Novak
7e12955c55
Made all internal functions static.
2018-11-14 11:57:57 +01:00
ilammy
7a2b6e1301
libfreerdp-core: fix reading TS_ICON_INFO
...
The spec says that CbColorTable field is present when Bpp is 1, 4, 8.
Actually, bpp == 2 is not supported by TS_ICON_INFO according to the
spec (though, DIB definitely supports 16-color images).
MS-RDPERP 2.2.1.2.3 Icon Info (TS_ICON_INFO)
CbColorTable (2 bytes):
This field is ONLY present if the bits per pixel (Bpp)
value is 1, 4, or 8.
Omitting 8-bit value breaks 256-color icons which are incorrectly
read with color and alpha data mixed up.
2018-11-14 10:53:45 +01:00
Armin Novak
138eb13fea
Updated RDP_VERSION definitions.
2018-11-14 10:14:48 +01:00
Armin Novak
ecac998340
Fixed rdg bio cleanup.
...
When attaching the RDG BIO to the TLS BIO also transfer ownership.
2018-11-13 12:22:09 +01:00
Armin Novak
3c35a098f5
Fixed direct rdg front bio access.
2018-11-13 11:24:04 +01:00
Armin Novak
e070bbea8d
Fixed leaks in rdg_send_channel_create
2018-11-13 11:22:37 +01:00
Armin Novak
342ff8cf0b
Fixed broken server name packet size
2018-11-13 11:22:37 +01:00
Armin Novak
15a41586a8
Don't read content length in VIRTUAL_CONNECTION_STATE_OUT_CHANNEL_WAIT
2018-11-13 11:22:37 +01:00
Armin Novak
90d2e42600
Fixed ntlm_authenticate, split return from continue flag.
2018-11-13 11:22:37 +01:00
Armin Novak
4e0b4d7096
Fixed static INT_MAX checks, replaced with assert.
2018-11-13 11:22:37 +01:00
Armin Novak
398a33af63
Fixed all warnings in rdg module
...
Fix all missing range checks and warnings.
2018-11-13 11:22:37 +01:00
Armin Novak
9078b0deb9
Fixed extern declaration of rpc_bind p_uuid_t variables.
2018-11-13 11:22:37 +01:00
Armin Novak
b4fc0c75ce
Made rdpRdp opaque
2018-11-13 11:22:37 +01:00
David Fort
b6e6575bf6
license: support CAL license
...
This patch simplifies the licensing code mutualizing encryption / decryption
routines. It also adds the support for client_info packet that allows to send a
previously saved CAL file.
2018-11-13 09:42:19 +01:00
Martin Fleisz
097ac0ee13
Merge pull request #4997 from akallabeth/use_bio_free_all
...
Replaced BIO_free with BIO_free_all
2018-11-12 13:55:36 +01:00
Martin Fleisz
9400bdccdb
Merge pull request #4996 from bmiklautz/tls_security_level
...
new [crypto/tls]: add support to set tls security level
2018-11-08 15:33:40 +01:00
Armin Novak
5f4843191b
Replaced BIO_free with BIO_free_all
...
There is no point in using BIO_free with a custom recursion
to free up stacked BIOs if there is already BIO_free_all.
Using it consistently avoids memory leaks due to stacked BIOs
not being recursively freed.
2018-11-08 12:09:49 +01:00
Bernhard Miklautz
1222e7060b
new [crypto/tls]: add support to set tls security level
...
The newly introduced option /tls-seclevel can be used to set the tls
security level on systems with openssl >= 1.1.0 or libressl.
As default level 1 is used as higher levels might prohibit connections
to older systems.
2018-11-08 11:13:15 +01:00
Armin Novak
5eca5ebde8
Fixed #4993 : Allow uninitialized bio socket in transport_bio_simple_uninit
...
When the TLS connection is aborted early (certificate issues, ...)
the bio simple socket might not have been initialized.
Do not access the NULL pointer on cleanup.
2018-11-07 17:02:07 +01:00
Pascal J. Bourguignon
6f2caef778
Fix Issue #4983 : Increased size of buffer to encrypt hash with kerberos.
2018-11-06 11:20:02 +01:00
Bernhard Miklautz
aecc77cd77
Merge pull request #4969 from akallabeth/covscan_fix
...
Covscan fixes
2018-11-05 10:44:01 +00:00
David Fort
1a50a48332
fix uninitialised variable
...
Otherwise we can run in troubles when sending logon_info_v2 packets
2018-11-01 11:07:36 +01:00
David Fort
548025bcc3
nego: add new flags
...
Reading the new spec there's some new flags
2018-10-31 10:43:59 +01:00
Martin Fleisz
7b0f4f5dc4
Merge pull request #4907 from akallabeth/transport_write_leak_fix
...
Transport write leak fix
2018-10-29 14:54:55 +01:00
Armin Novak
423d54d752
Fixed signedness casts.
2018-10-25 14:08:20 +02:00
Armin Novak
6339c43c80
Fixed sockfd/socketBio resource leak.
2018-10-25 13:41:47 +02:00
Armin Novak
42014e80d0
Fixed sockfd/socketBio resource leak.
2018-10-25 13:38:31 +02:00
Armin Novak
f269a0ce5b
Fixed sockfd/socketBio resource leak.
2018-10-25 13:19:45 +02:00
Armin Novak
847ee233f4
Fixed resource leak in rpc_ntlm_http_request
2018-10-25 12:49:42 +02:00
Armin Novak
987ca5ec6a
Fixed another bunch of warnings.
2018-10-24 14:36:12 +02:00
Armin Novak
6ccaafe2d9
Fixed default return value for fastpath_send_multiple_input_pdu
2018-10-23 12:33:13 +02:00
akallabeth
d3c1db1746
Merge pull request #4947 from akallabeth/http_gw_fix
...
Fixed http gateway body length read.
2018-10-23 12:03:03 +02:00
Armin Novak
900abb61f7
Fixed memory leak in update_recv_surfcmd_surface_bits
2018-10-22 14:41:59 +02:00
Armin Novak
b9933e7af4
Read byte by byte, the alignment may otherwise be broken.
2018-10-19 12:52:14 +02:00
Armin Novak
5a747b118d
Read http request in 4byte chunks until '\r\n\r\n' is found
...
Avoid reading too much data in a single call to BIO_read as some
implementations may return a lot more data than is part of the response.
2018-10-19 12:16:04 +02:00
Emmanuel Ledoux
33c7f6590a
fixed partial reads
2018-10-19 11:56:56 +02:00
Armin Novak
d05684a50a
Properly parse ContentType to find length.
2018-10-19 11:47:11 +02:00
Armin Novak
7e397d0f1c
Fixed http gateway body length read.
2018-10-19 09:31:55 +02:00
akallabeth
6f14018a22
Merge pull request #4945 from mmattes/fix/transferEncoding
...
transferEncoding can be NULL, correct if happens in line 348
2018-10-18 15:37:24 +02:00
Norbert Federa
850d2dbda9
Merge pull request #4942 from akallabeth/rail_fixes_2.0
...
Fix ORDER_TYPE_WINDOW reading
2018-10-18 14:11:18 +02:00
Norbert Federa
5ef243f91f
Merge pull request #4941 from nfedera/nf-remove-stale-valgrind-macro
...
gateway/rpc: remove stale valgrind macro
2018-10-18 14:08:23 +02:00
Markus Mattes
6d5b88cda6
transferEncoding can be NULL, verification happens in line 348
2018-10-18 13:59:49 +02:00