Commit Graph

12764 Commits

Author SHA1 Message Date
Armin Novak
66e71ef963 Added missing define for _wcsnlen for windows. 2018-12-10 14:02:57 +01:00
Armin Novak
d198f73081 Fix #5121: Determine actual string length for input data
ConvertFromUnicode ignores '\0' sequences when the length of the input
string is given. Clipboard strings may be larger than the actual string
length and padded with random data leading to decoding errors.
Limit the length to the first occurrence of a '\0'.
2018-12-10 12:41:04 +01:00
Armin Novak
1e644fc37e Added _wcsnlen function for WCHAR string length. 2018-12-10 12:39:32 +01:00
Martin Fleisz
97c5210dbc
Merge pull request #5096 from akallabeth/dsp_channel_mix
Fix #5019: Added channel up/downmixing code for mono/stereo.
2018-12-10 11:58:43 +01:00
akallabeth
2927114e7b
Merge pull request #5117 from hardening/rail_hash
rails: allow a window with id == 0
2018-12-10 10:26:52 +01:00
David Fort
88e361fa00 rails: allow a window with id == 0 2018-12-08 00:32:00 +01:00
Martin Fleisz
fc12b9336f
Merge pull request #5109 from akallabeth/gw_logging
Added additional gateway error logging.
2018-12-07 15:45:59 +01:00
Armin Novak
aa12026ef0 Added additional gateway error logging. 2018-12-07 14:21:27 +01:00
Bernhard Miklautz
6c88c21736
Merge pull request #5099 from akallabeth/floatbar_close_window
Fixed #5098: Abort connection and let the application clean up resour…
2018-12-07 13:03:46 +00:00
Bernhard Miklautz
62515cfd4f
Merge pull request #5118 from akallabeth/pem_warn_fix
Fix #5115: Cast PEM data from BYTE* to char* to silence warnings.
2018-12-07 12:30:55 +00:00
Armin Novak
d05217454f Fix #5115: Cast PEM data from BYTE* to char* to silence warnings. 2018-12-07 12:36:18 +01:00
David Fort
696fa22fb4
Merge pull request #5116 from akallabeth/drive_ts_fix
Fixed #5113: The timestamps for FileFullDirectoryInformation were inverted
2018-12-07 11:30:58 +01:00
Martin Fleisz
d0688f058b
Merge pull request #5102 from akallabeth/rail_cleanups
Cleaned up xf_rail_server_handshake
2018-12-07 11:28:22 +01:00
Armin Novak
fdf9ca3273 Fixed #5113: The timestamps for FileFullDirectoryInformation were inverted. 2018-12-07 10:59:52 +01:00
Martin Fleisz
8c7f8eb395
Merge pull request #5085 from akallabeth/cert_callbacks_update
Refactored Certificate callbacks (but keep compatible)
2018-12-06 10:08:17 +01:00
Armin Novak
0aaf14bed7 Fixe accidental removal of certificate_data_replace 2018-12-06 09:39:50 +01:00
Martin Fleisz
f678a91d6a
Merge pull request #5106 from hardening/wayland_seat7
Wayland seat version 7 and useful script
2018-12-05 16:27:05 +01:00
David Fort
b9ceb13058 uwac: handle wl_seat with version >= 7
Starting at version 7, the wayland client is supposed to mmap the keymap as MAP_PRIVATE
to prevent accidental or intentional modifications.
2018-12-05 15:21:00 +01:00
David Fort
42c083eaea script: add a usefull script to create code snippets from specification blobs 2018-12-05 15:20:11 +01:00
akallabeth
5e0fef582a
Merge pull request #5104 from hardening/license_2k3
license: fix licencing against windows 2003 server
2018-12-05 11:24:51 +01:00
Martin Fleisz
7db6ac063a
Merge pull request #5036 from akallabeth/auth_fixes
Refactor NEGO NLA and redirection to use opaque handles
2018-12-05 11:20:34 +01:00
Martin Fleisz
bb187d8ea2
Merge pull request #5103 from akallabeth/android_timezone
Fixed #5093: Try to read timezone from java TimeZone first
2018-12-05 11:19:53 +01:00
Martin Fleisz
30b31b7fb0
Merge pull request #5062 from akallabeth/init_freerdp_image_copy_from_pointer_data
Fix #5061: Initialize output buffer transparent.
2018-12-05 10:57:43 +01:00
Armin Novak
e49adfc51a Updated error info from spec. 2018-12-05 10:55:06 +01:00
Armin Novak
8110c391bf Fixed requested protocol define names according to spec. 2018-12-05 10:55:06 +01:00
Armin Novak
b1d2a4767b Fixed warnings in nego. 2018-12-05 10:55:06 +01:00
Armin Novak
82863a8518 Refactored NLA to be self contained. 2018-12-05 10:55:06 +01:00
Armin Novak
80d2462833 Hide redirection implementation details. 2018-12-05 10:55:06 +01:00
Armin Novak
5ca8eca18e Made nego self contained. 2018-12-05 10:55:06 +01:00
David Fort
635b17d0a1 license: fix licencing against windows 2003 server
The spec says:

"For Windows Server 2008, Windows Server 2008 R2, and Windows Server
2012, the EncryptedLicenseInfo variable (part of the Server Upgrade License PDU) sent by the server
to the client has the wBlobType parameter set to value BB_ENCRYPTED_DATA_BLOB (0x0009). For
Windows Server 2003, the value of wBlobType is not defined."

So don't enforce the message type.
2018-12-05 10:50:47 +01:00
Armin Novak
3d487d0718 Fixed #5093: Try to read timezone from java TimeZone first
persist.sys.timezone property might not exist, try to get the
timezone identifier from the java class first.
2018-12-05 10:41:14 +01:00
Armin Novak
f5e449a4f8 Cleaned up xf_rail_server_handshake 2018-12-05 09:13:04 +01:00
akallabeth
1b4ee6594e
Merge pull request #5100 from wintersandroid/master
Add jni interface for get_last_error_string
2018-12-05 08:58:08 +01:00
David Fort
46ffa611cc
Merge pull request #5097 from hualet/master
Fixed RAIL window can't show again once hidden
2018-12-04 22:42:25 +01:00
Mathew Winters
bd7ff9b10f Add jni interface for get_last_error_string 2018-12-05 07:56:05 +13:00
Armin Novak
0c13c3199e Follow up to #4959: Lock gdi_UpdateSurfaces like xf_UpdateSurfaces 2018-12-04 16:56:22 +01:00
Armin Novak
d260d4e29e Fixed #5098: Abort connection and let the application clean up resources before exit. 2018-12-04 16:42:28 +01:00
Martin Fleisz
df6d045f45
Merge pull request #5087 from hardening/remotefx_chunks
remotefx: don't require data messages to come all in one chunk
2018-12-04 16:40:44 +01:00
David Fort
a1c2033226
Merge pull request #5094 from akallabeth/suppress_output_setting
Make "suppress output" setting available on command line
2018-12-04 14:38:11 +01:00
Martin Fleisz
5510f9304b
Merge pull request #4959 from akallabeth/gfx_lock_fix
Implemented GFX mutex locking and enforce return value checks.
2018-12-04 14:29:59 +01:00
Hualet Wang
e33efccf48 Fixed RAIL window can't show again once hidden
The cause is very simple: we didn't map the xwindow on receiving
WINDOW_SHOW. but doing that causes another problem that you can't
hide a window anymore, and that is because whlie window hiding, the
_NET_WM_STATE and WM_STATE properies of the xwindow may change, in
the function `xf_event_PropertyNotify` we just assume that windows
not maximized, not minimized, yet not showing normally should be
corrected to be shown, we just need to consider the situation that
the window is hidden here.

fix: #5078
2018-12-04 20:37:37 +08:00
Armin Novak
e46575671c Fix #5019: Added channel up/downmixing code for mono/stereo. 2018-12-04 11:38:42 +01:00
David Fort
579a13b054 remotefx: don't require data messages to come all in one chunk
The spec doesn't require that FRAME_BEGIN, REGION, TILESET, and FRAME_END come all in one
chunk. This patch adds the necessary state saving.
A unitary test is also added.
2018-12-04 11:38:01 +01:00
Martin Fleisz
4108fc51a9
Merge pull request #5077 from akallabeth/win_client_fixes
Win client fixes
2018-12-04 10:31:01 +01:00
Armin Novak
b27470405c Duplicate PEM when accepted. 2018-12-04 09:35:24 +01:00
Armin Novak
e04c319d21 Added new default certificate callbacks with extended information.
The extended information provided by VerifyCertificateEx and
VerifyChangedCertificateEx is now exploited by the new functions
client_cli_verify_certificate_ex and client_cli_verify_changed_certificate_ex.

The old callbacks now print out deprecation warnings to inform the
user and developer about this deprecation.
2018-12-04 09:35:24 +01:00
Armin Novak
a8823fdf95 Cleaned up certificate verification code. 2018-12-04 09:35:24 +01:00
Armin Novak
7ab07ab980 Added certificate callbacks with source indications. 2018-12-04 09:35:24 +01:00
Armin Novak
dd3276d664 Prefer VerifyX509Certificate and fixed const arguments
If VerifyX509Certificate is set use it also when doing internal
certificate management. Added flags to ensure it is possible to
find out which type of connection is being made.
2018-12-04 09:35:24 +01:00
Armin Novak
1398fa5b27 Fixed missing NULL check for thread handle. 2018-12-04 09:34:22 +01:00