Commit Graph

3184 Commits

Author SHA1 Message Date
David Fort 96aeb8512d keyboard: don't catch Ctrl+Alt-C if encomsp is not activated 2019-08-23 12:57:10 +02:00
Armin Novak fdf1715213 Unified DriveStoreRedirect parsing. 2019-08-23 12:06:21 +02:00
Armin Novak d8bf05367b Added support for drivestoreredirect:s:<path>(<path>) syntax 2019-08-23 11:18:32 +02:00
Armin Novak 0af53bff9b Allow DynamicDrives as special option for /drive 2019-08-23 10:27:01 +02:00
Armin Novak 35cb729f31 Added drivestoredirect option value parser 2019-08-23 10:27:01 +02:00
Armin Novak 3dec88f5e3 added BandwidthAutoDetect parsing. 2019-08-22 16:13:04 +02:00
Armin Novak f0ee2cbb97 Automatically activate GFX and RFX codec support on autodetect. 2019-08-22 16:13:04 +02:00
Martin Fleisz 0a4bc1ff94
Merge pull request #5523 from akallabeth/rdp_parser_null_checks
Rdp parser null checks
2019-08-20 16:50:55 +02:00
Louis Sautier 60152291b3 client: proxy: allow passing SOCKS5 proxies as env. vars 2019-08-20 14:06:38 +02:00
Martin Fleisz 81cb0a7ee5 client/common: Remove incorrect prompt for creds parsing (#5528)
"prompt for credentials on client" was incorrectly merged together with
"prompt for credentials" into a single setting. However the first option
determines if the client should prompt for credentials if the remote
server does not support server authentication. "prompt for credentials"
on the other hand determines if the client should use any previously
stored credentials or if it should always prompt for them.
2019-08-20 10:07:10 +02:00
Armin Novak 14dfb99a6f Fixed NULL buffer access and alignment warnings. 2019-08-14 09:49:02 +02:00
rbarnett 8fee295733 Do not try to free a colormap that FreeRDP did not create. 2019-08-13 09:03:19 +02:00
kubistika 4503684736 client: xf_channels: remove unused settings variable 2019-08-02 20:10:56 +03:00
Martin Fleisz 8e7386a57d
Merge pull request #5506 from akallabeth/scale_desktop_and_device
With /scale:<value> scale desktop and device.
2019-07-30 12:53:13 +02:00
Armin Novak b4e1e9a1bd Fixed loading of microphone channel
Ensure microphone channel is loaded if settings require it in freerdp_client_load_addins
2019-07-30 12:32:55 +02:00
Armin Novak 70712cd821 With /scale:<value> scale desktop and device. 2019-07-30 12:03:23 +02:00
Armin Novak fe6a4c5648 Fixed loading of sound channel
Ensure sound channel is loaded if settings require it in freerdp_client_load_addins
2019-07-30 11:29:17 +02:00
Armin Novak 4128c6741d Fixed a bunch of conversion warnings. 2019-07-30 11:23:33 +02:00
Kenny Levinsen d27ad43093 uwac: Do not memcpy when we swap drawing buffers
The compositor only samples rects that we damage (and have therefore
been overwritten). As we are doing damage tracking and reporting,
memcpy of our old drawing buffer serves no purpose.
2019-07-30 09:46:57 +02:00
Martin Fleisz c8d0d50610 common: Fix parsing of devicestoredirect setting in rdp files
If devicestoredirect was found in an rdp file we incorrectly enabled
drive redirection (which has nothing to do with device redirection).
2019-07-30 09:20:58 +02:00
Martin Fleisz 5e672d474e
Merge pull request #5480 from akallabeth/xfreerdp_clip_fix
Fix broken clipboard after file copy
2019-07-18 12:20:28 +02:00
Martin Fleisz 73c90e6e72 Fix rdp file writer
The RDP file writer was based on previously parsed lines from an
existing rdp file. If you created a new rdpFile, populated it from
settings and tried to write it to a file you just got an error. This PR
fixes this issue by creating the data from the rdpFile properties rather
than the parsed lines.
2019-07-18 11:56:27 +02:00
Martin Fleisz 397db534d2 Reformatting 2019-07-18 11:56:27 +02:00
Armin Novak 2394c987ee Added alternate full address to rdp file parser. 2019-07-18 10:44:23 +02:00
Armin Novak cbb9354641 Fix broken clipboard after file copy 2019-07-17 15:13:50 +02:00
Armin Novak 70ba57caee Fixed freerdp_client_rdp_file_set_integer standard flag set. 2019-07-15 12:01:30 +02:00
Armin Novak 607a3e35f4 Fixed rdp file parser tests. 2019-07-15 12:01:30 +02:00
Armin Novak 1deb78f211 Implemented rdp file parser functions with a callback for custom settings. 2019-07-15 12:01:30 +02:00
Armin Novak 3b38479ec5 Added PromptForCredentials setting. 2019-07-15 12:01:30 +02:00
Martin Fleisz 445764100b
Merge pull request #5396 from widgetii/master
Artur Zaprzala's rdp2tcp channel driver
2019-07-09 16:17:29 +02:00
Martin Fleisz c2fa671dda client: populate settings didn't update NetworkAutoDetect 2019-07-09 15:23:17 +02:00
Armin Novak fef086359b Fix #5427: Dispatch updates to main thread.
thank you @Harrywang55666
2019-06-25 10:49:53 +02:00
Armin Novak 1856093016 Fixed #5406: Ensure mouse wheel rotation step is never zero
thank you @victorking528
2019-06-25 10:31:17 +02:00
Armin Novak 42ba19dd98 Added rail workdir parameter 2019-05-22 16:37:47 +02:00
Dmitry Ilyin eee7d4b783 proper code format 2019-05-15 20:12:33 +03:00
Dmitry Ilyin 2cfb2839f4 Artur Zaprzala's rdp2tcp channel driver 2019-05-14 21:04:39 +03:00
Martin Fleisz b8d931241e
Merge pull request #5314 from akallabeth/setting_getter_setter_generator
Added python generator for freerdp_[g|s]et_param*
2019-05-09 14:23:31 +02:00
Armin Novak 4d4e7a69d7 Fixed remaining getter/setter return checks. 2019-05-09 14:04:40 +02:00
Martin Fleisz ff036e0198
Merge pull request #5386 from akallabeth/rails_spec_update
Rails spec update
2019-05-09 12:49:55 +02:00
Armin Novak 2cc714a57d Updated RAILS implementation
* Implement new messages and callbacks
* Announce most recent channel features
* Added settings to configure flags to announce
2019-05-08 17:25:15 +02:00
akallabeth 9011ef1b75
Merge pull request #5387 from mfleisz/image_from_icon
core: Move image conversion of icon data into the library
2019-05-08 17:19:27 +02:00
Martin Fleisz 30c3b86655 core: Move image conversion for icon data into the library 2019-05-08 17:06:17 +02:00
Armin Novak d49adfcf59 Fixed warnings and cleaned up gfx related xfreerdp code. 2019-05-08 17:01:36 +02:00
Martin Fleisz 3e2be308eb
Merge pull request #5266 from akallabeth/file_list_synth
Added a proper synthesizer for FileGroupDescriptorW to text/uri-list
2019-05-08 15:05:05 +02:00
Armin Novak 93bf375686 Refactored settings getter/setter to stay compatible. 2019-05-08 14:35:25 +02:00
Armin Novak 6ac91924d5 Fixed use of settings getter/setter 2019-05-08 14:17:23 +02:00
Armin Novak d7ca2db62e Fixed doulbe semicolon in C files. 2019-05-08 12:58:01 +02:00
Armin Novak 3d1cec894c Fixed alignment requirements for surface sizes. 2019-05-08 10:36:00 +02:00
Armin Novak 3b7e46fb0e Updated GFX to 10.6 spec 2019-05-07 12:10:13 +02:00
Armin Novak 6a8755a763 Added image scaling api for software drawing.
For future GFX channel functions an image scaling function is required.
This moves the implementation from wayland client to core library
and adds support for the much faster SWScale library.
2019-05-07 08:56:29 +02:00
amratsingh 84e50582b7 android_freerdp.c: fixed wrong registered signature (#5371) 2019-05-02 05:59:52 +02:00
Martin Fleisz 25fc56a625
Merge pull request #5260 from akallabeth/rail_spec_update
Rail spec update
2019-04-29 11:27:26 +02:00
sgtatham 236c7918cb xf_cliprdr: detect null terminators more reliably. (#5353)
Clipboard formats containing plain text are specified to be terminated
by a \0 character in MS's documentation on standard clipboard formats:
https://docs.microsoft.com/en-us/windows/desktop/dataxchg/standard-clipboard-formats

xf_cliprdr_server_format_data_response receives pasted data from the
server to transfer to the client, in a sufficiently raw form that the
\0 terminator is still present, so it has to remove it. It does so by
checking only at the very end of the data. But I've observed that when
pasting out of at least one Windows program (namely Outlook 1903 on
Windows 10), the intended paste data arrives in this function followed
by \0 and then a spurious \n. In that situation the null-terminator
removal will fail to notice the \0, and will leave both bogus
characters on the end of the paste.

Fixed by using memchr to find the _first_ \0 in the paste data, which
should not lose any actually intentional data because it's in
accordance with the spec above.
2019-04-25 10:54:10 +02:00
Fabrice Fontaine 7dbb64cb62 xf_floatbar.c: fix build without Xfixes
Remove unneeded include on Xfixes.h as it is not always available and
not used in xf_floatbar.c

Fixes:
 - http://autobuild.buildroot.org/results/69245e574787bada718c52c805ec137041dc233d

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
2019-04-18 23:56:16 +02:00
Armin Novak 05901280fe Fixed unused argument warnings. 2019-04-05 09:14:35 +02:00
Armin Novak 281dd22061 Fixed unicode key down and up messages. 2019-04-05 09:14:35 +02:00
Armin Novak c18b30af96 Fixed dead store warnings 2019-04-05 09:14:35 +02:00
Armin Novak e009a62f06 Fixed sign-compare warnings 2019-04-05 09:14:35 +02:00
Armin Novak 8bb83f2526 Fixed sign-compare warnings 2019-04-05 09:14:35 +02:00
Armin Novak 1762cd1acb Fixed unchecked return warning. 2019-04-05 09:14:35 +02:00
Armin Novak 54098ab0b5 Fixed unused variable warnings. 2019-04-05 09:14:34 +02:00
Armin Novak 1c24450fe0 Fixed sign-compare warnings, removed internal functions from API 2019-04-05 09:14:34 +02:00
David Fort 058ae0db57
Merge pull request #5273 from akallabeth/mac_compile_warning_fix
Fixed mac compilation warnings.
2019-04-04 18:03:50 +02:00
David Fort 52bce4745f
Merge pull request #5249 from akallabeth/mac_timer_crash_fix
Mac timer crash fix
2019-03-28 19:05:48 +01:00
Ilya Shipitsin 7f97574501 client/Windows/wf_event.c: add missing "break" (#5293)
found by cppcheck

[client/Windows/wf_event.c:464] -> [client/Windows/wf_event.c:468]: (warning) Variable 'xNewPos' is reassigned a value before the old one has been used. 'break;' missing?
2019-03-04 09:17:10 +01:00
DraganNSDK f002c7429b potential fix for ENTER (modifiers) stuck after CTRL-ALT-ENTER (toggle fullscreen), clearing the buffer in xk_keyboard_update_modifier_keys. (#5280)
* xk_keyboard_update_modifier_keys fixed to clear the buffer.

* removed the xf_keyboard_clear(xfc) fix comments
2019-02-25 12:44:51 +01:00
Armin Novak 9566ae0e90 Fixed mac compilation warnings. 2019-02-21 17:30:12 +01:00
Armin Novak 32ea44c037 Added a proper synthesizer for FileGroupDescriptorW to text/uri-list
The file clipboard delegate needs a base URI to operate on for
systems that are not WIN32. Added that to the context and abort
conversion, if that is not set. (currently not fully implemented)
2019-02-21 16:44:40 +01:00
Armin Novak 3680d9f7d2 Fixed cast warnings from freerdp_load_channel_addin_entry 2019-02-21 13:54:25 +01:00
anbukart b192171434 Embedded window local fix
Client width and height getting set as 0 when embedded using ParentWindowId setting
2019-02-21 11:03:52 +05:30
Armin Novak 0a95e4aa78 Fixed #5262: Vertical mouse wheel direction and whell step
* Vertical wheel uses the inverted direction of horizontal wheel.
* The wheel step is now calculated from the value provided by wayland.
2019-02-20 08:56:36 +01:00
Armin Novak aacf5bddc4 Updated rail channel, supporting all new messages. 2019-02-19 15:04:11 +01:00
Armin Novak 2a06366de3 Added autoreconnect for wayland. 2019-02-19 14:12:25 +01:00
David Fort f0e9c95f44
Merge pull request #5248 from akallabeth/naming_fixes
Replace hard coded xfreerdp program name
2019-02-13 18:45:17 +01:00
Armin Novak 2d4f53ed41 Fixed #5234: Added timer invalidate on application willresignactive 2019-02-12 11:23:56 +01:00
Armin Novak e758e848a2 Replaced hardcoded xfreerdp program name 2019-02-12 10:58:37 +01:00
Armin Novak 92dfa34619 Replaced hardcoded xfreerdp program name 2019-02-12 10:58:36 +01:00
Mathew Winters dc5efab715 Resolve Gfx mode missing surface updates from cache. 2019-02-12 14:27:11 +13:00
Armin Novak fe6296a25f Added support for /smart-sizing:<width>x<height> syntax in wayland client. 2019-02-08 12:49:32 +01:00
Armin Novak f06b31358f Fixed duplicate log tag definition in wayland client. 2019-02-08 12:11:15 +01:00
Armin Novak cc050f1413 Fixed conversion range checks and cast for use with cairo 2019-02-08 12:08:30 +01:00
Armin Novak bb755f1944 Removed unused variables. 2019-02-08 12:08:30 +01:00
Armin Novak 4a3f4ad340 Fixed color format for wayland mouse pointer. 2019-02-08 12:08:30 +01:00
Armin Novak 7413370783 Added mouse pointer scaling. 2019-02-08 12:08:30 +01:00
Armin Novak 8d6a6df48a Implements #5215: Smart sizing using libcairo 2019-02-08 12:08:30 +01:00
Armin Novak 81d7e62642 Fixed broken checks in X11 event (RAIL mode) 2019-02-08 10:46:26 +01:00
Martin Fleisz 6415cfec48
Merge pull request #5131 from akallabeth/cmd_line_error_logging
Added extended error logging for assistance, rdp file and command line parser
2019-02-08 09:11:35 +01:00
Armin Novak 753b9c7ce9 Enable server heartbeat PDU by default. 2019-02-07 10:10:57 +01:00
Armin Novak 7610917a48 Disabled offscreen and bitmap cache by default. 2019-02-07 10:10:57 +01:00
Ilya Shipitsin fb002574c3 client/common/cmdline.c: remove redundant check
found by cppcheck

[client/common/cmdline.c:390] -> [client/common/cmdline.c:399]: (warning) Identical inner 'if' condition is always true.
2019-02-02 10:22:19 +05:00
Ilya Shipitsin d1939cfc4f client/Wayland/wlf_cliprdr.c: resolve possible null pointer dereference
found by cppcheck

[client/Wayland/wlf_cliprdr.c:143] -> [client/Wayland/wlf_cliprdr.c:158]: (warning) Either the condition 'clipboard' is redundant or there is possible null pointer dereference: clipboard.
[client/Wayland/wlf_cliprdr.c:163] -> [client/Wayland/wlf_cliprdr.c:178]: (warning) Either the condition 'clipboard' is redundant or there is possible null pointer dereference: clipboard.
2019-02-01 03:50:51 +05:00
David Fort 85161c718f
Merge pull request #5223 from akallabeth/scanbuild_null_fixes
Scanbuild null fixes
2019-01-30 18:22:45 +01:00
Bernhard Miklautz acebd43acf
Merge pull request #5147 from jphein/master
Clarified defaults of /floatbar flag
2019-01-30 16:26:41 +01:00
Armin Novak 2dab778101 Fixed NULL dereferences and uninitialized values 2019-01-30 16:11:10 +01:00
Armin Novak 87c7ddeda6 Asserting arg->Value to silence clang analyzer NULL argument checks. 2019-01-29 17:24:29 +01:00
Armin Novak 6a1ff5c485 Fixed compiler warnings #5210 2019-01-29 16:22:46 +01:00
Armin Novak 5c930dc4aa Fixed compiler warnings #5210 2019-01-29 16:15:33 +01:00
David Fort 72ad4af356
Merge pull request #5221 from akallabeth/wayland_mouse_cursor
Added wayland mouse cursor
2019-01-29 15:11:38 +01:00
akallabeth 0a8ebcfcac
Merge pull request #5187 from astrand/mingw-part1
Mingw build fixes part1
2019-01-29 10:46:21 +01:00
Armin Novak 2418c43cac Fixed pointer image update. 2019-01-29 09:34:30 +01:00
Armin Novak 23fa6b9182 Added mouse cursor callback stubs. 2019-01-29 09:34:30 +01:00
David Fort 05d9d89796
Merge pull request #5149 from akallabeth/cert_deny
New option to disable user certificate dialog
2019-01-25 16:59:33 +01:00
akallabeth 7d226ca596
Merge pull request #5218 from ckelsel/master
May crash if GetCommandLineW failed
2019-01-25 12:19:56 +01:00
David Fort 343bc8c6e4
Merge pull request #5213 from akallabeth/wayland_and_warning_fixes
Wayland and warning fixes
2019-01-25 11:42:38 +01:00
xie.kunming b8c64b6bf3 May crash if GetCommandLineW failed 2019-01-25 17:54:25 +08:00
Armin Novak 823411c2f3 Fixed wayland buffer updates
The wayland buffer size always matches the current window size.
That might be different from the actual remote framebuffer size,
to when copying always use the correct strides to avoid distorted
screen content.
2019-01-25 10:49:03 +01:00
akallabeth 8ed0b92928
Merge pull request #5216 from ckelsel/master
change SetTimer elapse from 10 to USER_TIMER_MINIMUM
2019-01-25 10:01:30 +01:00
xie.kunming 84493d0039 If uElapse is less than USER_TIMER_MINIMUM (0x0000000A), the timeout is set to USER_TIMER_MINIMUM. 2019-01-25 16:45:52 +08:00
Armin Novak 86e20d7647 Removed buffer damage tracking in client, let UWAC handle that. 2019-01-24 12:44:21 +01:00
Armin Novak 0cf898e722 Fixed warnings found by compiler and static analysis. 2019-01-24 11:53:52 +01:00
Armin Novak 728cdfd689 Fixed warnings found by compiler and static analysis. 2019-01-24 11:53:52 +01:00
Armin Novak 087390b303 Refactored client clipboard function callbacks for const data pointers. 2019-01-23 16:55:13 +01:00
Armin Novak 891d9760dc Ignore clipboard events if channel not loaded. 2019-01-23 16:01:36 +01:00
Armin Novak d5b3558402 Added log messages for unusual error events. 2019-01-23 15:56:11 +01:00
Armin Novak 9cdddb7722 Fixed some log messages / missing asserts. 2019-01-23 15:56:11 +01:00
Armin Novak 1cec0e0346 Fixed NULL dereference. 2019-01-23 15:56:11 +01:00
Armin Novak ca2e8e4bc2 Implemented wayland clipboard. 2019-01-23 15:56:11 +01:00
David Fort 2843f1ad60
Merge pull request #5159 from akallabeth/wayland_display
Implemented wayland display resize channel.
2019-01-23 15:41:42 +01:00
David Fort 4c465e7f16
Merge pull request #5209 from akallabeth/wayland_protocol_update_and_keyboard_inhibit
Wayland protocol update and keyboard inhibit support
2019-01-23 10:02:07 +01:00
Armin Novak 97dfa07578 Fixed duplicated check. 2019-01-22 17:27:17 +01:00
Armin Novak 42ad7a8846 Implemented wayland display resize channel. 2019-01-22 17:27:17 +01:00
Armin Novak 81f1fb934c Implemented keyboard shortcut inhibit support. 2019-01-22 14:27:12 +01:00
Armin Novak 5ef6b71974 Implemented DesktopResize callback for wayland client. 2019-01-22 10:29:08 +01:00
Armin Novak 0b17406eec Unified buffer update and screen refresh on focus 2019-01-18 14:38:51 +01:00
Armin Novak 4f99c2946f Unified mouse coordinate scaling. 2019-01-17 13:44:04 +01:00
Armin Novak 864ad5e681 Ignore unknown keywords for windows and posix type detection.
Eliminates wrong detection in case of an unknown keyword used.
2019-01-16 14:32:19 +01:00
Armin Novak fc9e88d64f Added flag to silence command line parser logging during detection. 2019-01-16 14:32:19 +01:00
Armin Novak 89f3f7d837 Added extended error logging for assistance, rdp file and command line parser. 2019-01-16 14:32:19 +01:00
Armin Novak a3cfef4e07 Implemented full mouse support for mac client. 2019-01-10 11:30:36 +01:00
Peter Åstrand (astrand) 6619de070a freerdp_client_set_window_size should not be static
Avoid GCC error, since it is not static according to wf_client.h.
2019-01-09 09:54:31 +01:00
Peter Åstrand (astrand) fcf59b9c4f Add msimg32 library through CMake
MinGW does not support libs through #pragma comments.
2019-01-09 09:52:27 +01:00
Peter Åstrand (astrand) 30cd1ba1ab Use lowercase for includes and libs
Makes build possible on case sensitive systems such as MinGW on Linux.
2019-01-09 09:36:28 +01:00
Ilya Shipitsin 4403448a77 client/Windows/wf_cliprdr.c: remove redundant check
found by cppcheck

[client/Windows/wf_cliprdr.c:2556] -> [client/Windows/wf_cliprdr.c:2561]: (warning) Identical condition '!clipboard', second condition is always false
2019-01-07 22:55:08 +05:00
Martin Fleisz aa442de059
Merge pull request #5174 from chipitsine/master
resolve several issues found by cppcheck
2019-01-07 15:21:46 +01:00
Armin Novak b2ef3e69ca Fixed Wayland horizontal mouse wheel direction. 2019-01-07 10:02:04 +01:00
Armin Novak 2dcc2614d4 Fixed X11 horizontal mouse wheel direction. 2019-01-07 10:01:46 +01:00
Ilya Shipitsin bdc039e719 resolve several issues found by cppcheck
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:796]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:797]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:798]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[libfreerdp/codec/dsp.c:1156] -> [libfreerdp/codec/dsp.c:1154]: (warning) Either the condition '!srcFormat' is redundant or there is possible null pointer dereference: srcFormat.
[channels/drdynvc/client/drdynvc_main.c:1453] -> [channels/drdynvc/client/drdynvc_main.c:1450]: (warning) Either the condition '!drdynvc' is redundant or there is possible null pointer dereference: drdynvc.
[channels/audin/client/opensles/audin_opensl_es.c:98] -> [channels/audin/client/opensles/audin_opensl_es.c:94]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
[channels/audin/client/opensles/audin_opensl_es.c:159] -> [channels/audin/client/opensles/audin_opensl_es.c:153]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
2019-01-02 20:35:24 +05:00
kunming.xie 3ef6dd2f7c fix button_set_locked no return statement 2018-12-24 14:52:59 +08:00
Armin Novak 1984f73db8 Implemented horizontal mouse wheel for wayland. 2018-12-18 13:49:13 +01:00
Armin Novak f647e5cc3f Implemented mouse buttons 4 and 5 for wayland. 2018-12-18 13:49:08 +01:00
Armin Novak b60045af27 New option to disable user certificate dialog
The new option +cert-deny aborts a connection automatically if
the certificate can not be validated by OpenSSL or via known hosts.
2018-12-14 10:17:52 +01:00
Jeffrey Hein d316e7fa1e
Clarified defaults of /floatbar flag 2018-12-13 14:02:38 -08:00
Jeffrey Hein 1e84f00ef8
Added help description for /drive:hotplug,* 2018-12-12 11:29:58 -08:00
Armin Novak 717b0eac9e Enable smooth fonts by default. 2018-12-11 13:02:26 +01:00
Bernhard Miklautz 6f6c8473a1
Merge pull request #5126 from akallabeth/x11_button_mapping
X11 extended button remapping support.
2018-12-11 08:53:39 +00:00
Armin Novak 0fa9f06565 Modified flag checks to avoid invalid flag sets. 2018-12-11 09:34:07 +01:00
Martin Fleisz 29e2e2221d
Merge pull request #5083 from akallabeth/mac_client_fixes
Mac client fixes
2018-12-11 09:19:46 +01:00
Bernhard Miklautz b3ff75b594 fix [client/Mac]: UI API needs to be called in main thread
With recent SDKs the view won't update it the UI API is called
from a different thread.
2018-12-11 08:33:14 +01:00
Armin Novak 2ce04069cb Fixed crashes in rail mode after merge of floatbar fixes. 2018-12-10 15:41:20 +01:00
Armin Novak 7102927548 X11 extended button remapping support.
Up until now X11 mouse button remapping was only possible for the
default buttons 1 to 3.
With this pull any X11 mouse button can be mapped to any RDP mouse
event and all X11 remappings are respected.
2018-12-10 15:03:29 +01:00
Martin Fleisz b82c4f779a
Merge pull request #5020 from akallabeth/floatbar_fixes
Floatbar fixes and windows support
2018-12-10 14:45:10 +01:00
Armin Novak 15011b478d Fixed variable hiding by not redeclaring it in subscope. 2018-12-10 14:31:38 +01:00
Armin Novak 0d3192b9f7 Fixed rail window key hash function to work with UINT32 2018-12-10 11:16:43 +01:00
akallabeth 2927114e7b
Merge pull request #5117 from hardening/rail_hash
rails: allow a window with id == 0
2018-12-10 10:26:52 +01:00
David Fort 88e361fa00 rails: allow a window with id == 0 2018-12-08 00:32:00 +01:00
Armin Novak 9166df355b Fixed windows floatbar title. 2018-12-07 15:50:24 +01:00
Armin Novak 4fd8987f5d Unified windows client window title settings. 2018-12-07 15:22:28 +01:00
Armin Novak 594d10620e Fixed #5040: Unified xfreerdp window title setting. 2018-12-07 15:22:28 +01:00
Armin Novak 6a9fa3dcbd Refactored floatbar, extended command line settings. 2018-12-07 15:22:28 +01:00
Don Caton 68c34d5ab0 Windows client: Suppress minimize and restore buttons in float bar when toggle-fullscreen is false, added window title to float bar, improved overall appearance with gradients, shadow and transparent icons.
# Conflicts:
#	client/Windows/wf_client.c
#	client/Windows/wf_event.c
#	client/Windows/wf_floatbar.c
2018-12-07 15:22:28 +01:00
Armin Novak 5343f6931d Fixed monitor width and height checks. 2018-12-07 15:22:28 +01:00
Armin Novak 56156d217e Floatbar self contained. 2018-12-07 15:22:28 +01:00
Bernhard Miklautz 6c88c21736
Merge pull request #5099 from akallabeth/floatbar_close_window
Fixed #5098: Abort connection and let the application clean up resour…
2018-12-07 13:03:46 +00:00
Martin Fleisz d0688f058b
Merge pull request #5102 from akallabeth/rail_cleanups
Cleaned up xf_rail_server_handshake
2018-12-07 11:28:22 +01:00
Armin Novak ace9bfffdb Moved to extended certificate verification API 2018-12-06 10:17:05 +01:00
Armin Novak ec8cc65a1c Fixed compile issue 2018-12-06 10:17:05 +01:00
Armin Novak 730b6f02c4 Fixed glitches with certificate dialog. 2018-12-06 10:17:05 +01:00
Armin Novak ec34657ff1 Added certificate dialog. 2018-12-06 10:17:05 +01:00
Armin Novak 4dd6e75779 Added client callbacks. 2018-12-06 10:17:05 +01:00
Armin Novak c8938c357a Updated mac build. 2018-12-06 10:17:05 +01:00
Martin Fleisz 8c7f8eb395
Merge pull request #5085 from akallabeth/cert_callbacks_update
Refactored Certificate callbacks (but keep compatible)
2018-12-06 10:08:17 +01:00
Armin Novak f5e449a4f8 Cleaned up xf_rail_server_handshake 2018-12-05 09:13:04 +01:00
akallabeth 1b4ee6594e
Merge pull request #5100 from wintersandroid/master
Add jni interface for get_last_error_string
2018-12-05 08:58:08 +01:00
David Fort 46ffa611cc
Merge pull request #5097 from hualet/master
Fixed RAIL window can't show again once hidden
2018-12-04 22:42:25 +01:00
Mathew Winters bd7ff9b10f Add jni interface for get_last_error_string 2018-12-05 07:56:05 +13:00
Armin Novak 0c13c3199e Follow up to #4959: Lock gdi_UpdateSurfaces like xf_UpdateSurfaces 2018-12-04 16:56:22 +01:00
Armin Novak d260d4e29e Fixed #5098: Abort connection and let the application clean up resources before exit. 2018-12-04 16:42:28 +01:00
David Fort a1c2033226
Merge pull request #5094 from akallabeth/suppress_output_setting
Make "suppress output" setting available on command line
2018-12-04 14:38:11 +01:00
Martin Fleisz 5510f9304b
Merge pull request #4959 from akallabeth/gfx_lock_fix
Implemented GFX mutex locking and enforce return value checks.
2018-12-04 14:29:59 +01:00
Hualet Wang e33efccf48 Fixed RAIL window can't show again once hidden
The cause is very simple: we didn't map the xwindow on receiving
WINDOW_SHOW. but doing that causes another problem that you can't
hide a window anymore, and that is because whlie window hiding, the
_NET_WM_STATE and WM_STATE properies of the xwindow may change, in
the function `xf_event_PropertyNotify` we just assume that windows
not maximized, not minimized, yet not showing normally should be
corrected to be shown, we just need to consider the situation that
the window is hidden here.

fix: #5078
2018-12-04 20:37:37 +08:00
Armin Novak e04c319d21 Added new default certificate callbacks with extended information.
The extended information provided by VerifyCertificateEx and
VerifyChangedCertificateEx is now exploited by the new functions
client_cli_verify_certificate_ex and client_cli_verify_changed_certificate_ex.

The old callbacks now print out deprecation warnings to inform the
user and developer about this deprecation.
2018-12-04 09:35:24 +01:00
Armin Novak 1398fa5b27 Fixed missing NULL check for thread handle. 2018-12-04 09:34:22 +01:00
Armin Novak c5512de269 Fix #4999: Increase reference count 2018-12-04 09:34:22 +01:00
Alessandro Muggianu 9b1c9da6a2 Make "suppress output" setting available on command line 2018-12-04 09:31:30 +01:00
Armin Novak edd6d49f23 Fix #4909: Do not initialize HOME environment variable as it is no longer used.
GetKnownPath does not require this environment variable to be
available for windows builds.
2018-11-29 13:44:21 +01:00
Armin Novak 2e019b2fd1 Implemented GFX locking and enforce return value checks.
To fix #4825 GFX functions must now aquire a lock before accessing surfaces.
This prevents simultaneous update of internal data by client and gfx threads.
Also enforce return value checks, where not already done.
2018-11-29 11:55:27 +01:00
Armin Novak 7d89ea22d4 Unified initialization of OrderSupport
Added a library internal function freerdp_settings_set_default_order_support
which initializes the OrderSupport array of settings.
Now clients no longer need to set this up on their own, if they
do not implement their own hardware accelerated order processing.
2018-11-23 10:11:50 +01:00
Martin Fleisz 394bc62869
Merge pull request #5035 from akallabeth/better_cmdline_format
Improved formatting of terminal help messages.
2018-11-23 10:03:56 +01:00
Martin Fleisz 9684a06f87
Merge pull request #5053 from akallabeth/sample_client_update
Fix #5052: Updated client sample
2018-11-23 09:48:08 +01:00
Armin Novak e6e87eb3b3 Unified strto[u]l in cmdline.c
To clean up code all integer conversions are now done by
a helper function with proper checks in place.
2018-11-22 16:28:30 +01:00
Armin Novak 2f8737d973 Improved formatting of terminal help messages. 2018-11-22 15:56:37 +01:00
David Fort 8d62ced6a4
Merge pull request #5056 from akallabeth/direct_fb_remove
Removed DirectFB client as it is unmaintained
2018-11-22 15:50:52 +01:00
Armin Novak fff22f027b Removed DirectFB client as it is unmaintained
DirectFB support was in search of a maintainer for ages and
no longer compiles.
Since nobody stepped up get rid of this unused code once and for all.
2018-11-22 14:40:19 +01:00
Armin Novak a471fc5939 Spelling fix in log message.
Integrate spelling fix from debian patch from
Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
2018-11-22 12:06:30 +01:00
Armin Novak f79eeb7446 Fixed NULL access checks. 2018-11-22 11:19:12 +01:00
Armin Novak c8908c8be6 Updated windows shadow server assistance usage. 2018-11-22 11:11:31 +01:00
Armin Novak a531930f36 Disable NLA for remote assistance. 2018-11-22 11:11:31 +01:00
Armin Novak 6de2129a90 assistance v2 support 2018-11-22 11:11:31 +01:00
Armin Novak 6ab3d3e8fc Fix #5052: Updated client sample 2018-11-22 10:38:26 +01:00
Martin Fleisz 947aa80033
Merge pull request #5016 from akallabeth/windows_server_build_fix
Windows server build fix
2018-11-21 16:02:47 +01:00