14538 Commits

Author SHA1 Message Date
Armin Novak
5dbf2cc7eb Added backward compatibility define
(cherry picked from commit a22f264189b112ac1b334ef33cd2a2615b0b8140)
2021-02-25 09:51:41 +01:00
Armin Novak
8379eaf982 Updated FD_FLAGS definition.
(cherry picked from commit ef1c8a3b506a2e039faa92b435d326ca3f29385a)
2021-02-25 09:51:41 +01:00
akallabeth
b9f00a97e3 Refactored RDG chunked data struct
(cherry picked from commit eafb4b8d5f4dd081606b4e6a69d92089993aae4b)
2021-02-25 09:51:41 +01:00
akallabeth
971341dd37 Fixed RDP gateway types and use after free
(cherry picked from commit 8c78e6742569936cb2bff59649888c93f3f3437f)
2021-02-25 09:51:41 +01:00
akarl10
b3be5e49b3 Implement chunked encoding for RDG_OUT_DATA
(cherry picked from commit cfb1a878a3b1c2c469c3d15e135f21f388c177b8)
2021-02-25 09:51:41 +01:00
odednoam
d9ca7c09f9 free previous value of password field from freerdp_assistance_parse_file_buffer
(cherry picked from commit 73dd40275fca9d009bcb07d4a734af146578f414)
2021-02-25 09:51:41 +01:00
odednoam
a8326f9d4a Fixed bug with assistance buffer parsing: freerdp_assistance_parse_file_buffer may be called directly, not necessarily from freerdp_assistance_parse_file, so password should be saved to the rdpAssistanceFile in freerdp_assistance_parse_file_buffer.
(cherry picked from commit 0dc9b18cdea8dce172fdc34be067b07a846594d0)
2021-02-25 09:51:41 +01:00
akallabeth
2d84387fcd Conservative keyboard state sync, refactored input API
(cherry picked from commit b679f3a0ebbbedf039e735523087c58e3b3920e2)
2021-02-25 09:51:41 +01:00
akallabeth
1b06f38041 Fixed display channel anounce race
* The display resolution change message was prone to a race condition
* Check for actual fullscreen state instead of settings
* Assume 75dpi for display resolution to mm conversion

(cherry picked from commit 13c8a60b7095c141321cd2d09f3e36466d54a748)
2021-02-25 09:51:41 +01:00
Armin Novak
7612054de4 Properly discard xfc->appWindow on focus loss
(cherry picked from commit 34e5504bcc1734fd767572a262dec94e551e4c30)
2021-02-25 09:51:41 +01:00
akallabeth
21ba0d2b54 Fixed #6635: Use correct window handle for pointer operations
(cherry picked from commit e8fe552ed4759327d63abf637f464839b2d6306a)
2021-02-25 09:51:41 +01:00
akallabeth
eb4dca0015 Fixed #6518
(cherry picked from commit 38a79be33f429b5e556f8185eb94a73c8aa45bb9)
2021-02-25 09:51:41 +01:00
Armin Novak
99e5a89b81 Cleaned up rdpei channel, updated to current spec.
(cherry picked from commit bd061fc291108bad67ce94dd92e1fdb31e0c0cae)
2021-02-25 09:51:41 +01:00
akallabeth
fb213a2336 Fixed possible out of bound access in usb channel.
(cherry picked from commit 2e5280feecc3cd692f9930f9b7ed26129423a1a1)
2021-02-25 09:51:41 +01:00
Nathan Loewen
5b2f35747b X11: Scale cursor when SmartSizing is on
(cherry picked from commit f4f795f3233c56fe7f4cd579777115b77f49da1e)
2021-02-25 09:51:41 +01:00
Nathan Loewen
d2b684ff40 let freerdp_image_scale() determine step size
(cherry picked from commit cba618115471a7072902aa137af5962f0e0c4c1e)
2021-02-25 09:51:41 +01:00
akallabeth
0195aac2ea Respect invalidRegion in progressive_compress
(cherry picked from commit 4a7ec674e601e3680161a0dfbda67dc07477eb8b)
2021-02-25 09:51:41 +01:00
akallabeth
1a4c1de6a8 Fixed progressive decoding without subbanddiff
(cherry picked from commit e3445eefab77c6666d760fa042f141c0a2d2965a)
2021-02-25 09:51:41 +01:00
akallabeth
84693e93b6 Cleaned up rfx API
(cherry picked from commit 25a8abc4eb0a6d6a115169b5f0f762e3308b4026)
2021-02-25 09:51:41 +01:00
akallabeth
7bec222d85 Clean up drdynvc channels porperly locked.
(cherry picked from commit 7f1cca78aa9e4cf65cb38c9b741566fbf7dce2d0)
2021-02-25 09:51:41 +01:00
Armin Novak
0615135c24 Fixed primitives test
(cherry picked from commit b6f392215225a9aae9d257551505c169ac23e9ef)
2021-02-25 09:51:41 +01:00
Armin Novak
bee863521a Fixed _aligned_recalloc
(cherry picked from commit cad1dd39e23f45b36e4815129bdc3d99fcbd8c2b)
2021-02-25 09:51:41 +01:00
Armin Novak
cbf2a59dd9 Fixed unit tests run under memory sanitizer
(cherry picked from commit 816e792e3f468eebf3c82416b9ef33637c9bd5cc)
2021-02-25 09:51:41 +01:00
akallabeth
ff14073182 Removed invalid check
(cherry picked from commit e019ed65668b260542ee51b096585abb77354881)
2021-02-25 09:51:41 +01:00
akallabeth
812233e180 Implemented 2.2.1.17.1 Persistent Key List PDU Data, added checks
* Implemented missing server side version of PDU (just skip data)
* Refactored read/write functions to properly check stream
  length/capacity and handle return values.

(cherry picked from commit ec3c333656b4d8a00ff278a70b52c11b18e2d643)
2021-02-25 09:51:41 +01:00
akallabeth
db1287ddad Fixed rdp_capability_set_start checks
(cherry picked from commit a13e0f1a08c44a4c6a6f037c9b849904a0a6c30e)
2021-02-25 09:51:41 +01:00
akallabeth
104f3f043e Check stream capacity in rdp_capability_set_finish
(cherry picked from commit 6b0d2a2c3e05828248ef0286e764b9e578989ddf)
2021-02-25 09:51:41 +01:00
akallabeth
5b7841cdf3 Fixed missing stream length checks.
(cherry picked from commit f7f8c3907d1c2e45c3545111ad3f3790e5037629)
2021-02-25 09:51:41 +01:00
akallabeth
51bf892909 Added data_pdu_type_to_string
(cherry picked from commit b6b8d74521364bcf9c3ba2296d43e9fd3413e429)
2021-02-25 09:51:41 +01:00
akallabeth
b55664d7c1 Fixed sending of clipboard format request response
If a request was pending and new formats were announced the response
to a ServerFormatDataRequest was never sent.

(cherry picked from commit 2efb7d92745614a92c66b721205689a433248d31)
2021-02-25 09:51:41 +01:00
akallabeth
47d8505bd0 Fixed primitiveYUV unit test.
(cherry picked from commit f357b9325fed388f0a6c86a403f5f8cc6188097f)
2021-02-25 09:51:41 +01:00
akallabeth
9eeb64ed9f Ignore alpha channel during color conversion.
Most GFX graphics do not carry alpha data. Keep the original
alpha value unless specified otherwise.

(cherry picked from commit 115532ef5a71676a946c9d268dd1294daf99e52d)
2021-02-25 09:51:41 +01:00
akallabeth
e45621fed6 Fixed SCardGetAttrib pbAttr=NULL argument
If fpbAttrIsNULL!=0 set pbAttr NULL on call to SCardGetAttrib

(cherry picked from commit 61b785a89b6a7dc4eab9f8c74d9afa2da6e5a8e6)
2021-02-25 09:51:41 +01:00
Armin Novak
d62e679821 [MAC] Keep original return value for client termination
(cherry picked from commit 9e63f35cc57da6ba79b0a76207848a85a75769a6)
2021-02-25 09:51:41 +01:00
akallabeth
bd0558c47f Fixed missing check for fastpath input messages
Input events are only allowed after a connection was established
(connection state is active)
This check aborts input sending when done before that.

(cherry picked from commit 102869f6a860140174da9dd3189babf6966c9149)
2021-02-25 09:51:41 +01:00
akallabeth
87db6078f0 Do not eliminate original error status.
(cherry picked from commit 050a68fec901030c7428852f8f536ace055eb2f7)
2021-02-25 09:51:41 +01:00
akallabeth
2dbd33b5bb Refactored freerdp_client_settings_command_line_status_print_ex
Now returns 0 if help or version information was requested.

(cherry picked from commit 531dd81836f2c97fcfcfeabdb9671fb76409ce8d)
2021-02-25 09:51:41 +01:00
Ondrej Holy
cf3ba75673 client: Fix exit codes for /help and similar option
Currently, non-zero exit code is returned for /version, /buildconfig, /help,
/monitor-list, /kbd-list and /kbd-lang-list command-line options for several
clients. This is against conventions because 0 is usually returned in
such cases. Also, there is potentially another problem that the returned
codes overflow on UNIX systems (where the exit code is a number between 0
and 255). Let's fix the clients to return 0 in the mentioned cases to honor
conventions and 1 for the command-line parsing errors (or -1 for clients
who already use that value).

Fixes: https://github.com/FreeRDP/FreeRDP/issues/6686
(cherry picked from commit 3ee4cabcfad3a9ccc3c59be21245b57c17e7ae75)
2021-02-25 09:51:41 +01:00
Martin Fleisz
4d409b7c4b channels/smartcard: Fix race in channel cleanup
(cherry picked from commit 1155aade7f52fb594463370004a7a2766787d0d7)
2021-02-25 09:51:41 +01:00
Armin Novak
8d62ec233d Fixed const correctness of RECTANGLE_16 variable
(cherry picked from commit 9549d090ab849c405cb486fad6c9dd3867b28c45)
2021-02-25 09:51:41 +01:00
Armin Novak
5ea5980b10 Fixed pcap capture function const correctness
(cherry picked from commit 87e89bc719110ea369ae431e12f4e91f99cc9304)
2021-02-25 09:51:41 +01:00
Armin Novak
847de7f4ae Fix ColorFidelity use
(cherry picked from commit 8187ab7732dd0184e1123b1c39790a246f9912a6)
2021-02-25 09:51:41 +01:00
akallabeth
2ce5f6f17c Check drive to hotplug for already being redirected
some hotplug implementations report the same drive multiple times.
to avoid redirecting the same drive multiple times check if it is
already in the list before adding.

(cherry picked from commit 9e8d3fbbf5ad7bb75799a8aca9fafa9c2dcf7fd9)
2021-02-25 09:51:41 +01:00
Armin Novak
605e89a38d Fix color fidelity issues with windows 7
(cherry picked from commit 57b58df80644f142067a489640edc40f006329a7)
2021-02-25 09:51:41 +01:00
Armin Novak
a4048b7d11 Fixed problematic cast of integer mask to bool
(cherry picked from commit 8c353e9292f18e938b21f3369ba86d0f71359815)
2021-02-25 09:51:41 +01:00
Martin Fleisz
d3202497ba primitives: Respect alpha values in YUV444 SSE pixel routine
(cherry picked from commit 9eaa820818571d23bd8604fbbc1ff9fa7c634967)
2021-02-25 09:51:41 +01:00
Martin Fleisz
ce61bc41cb core: Remove error code from string returned by rpc_error_to_string
This PR removes the error code from the error string returned by
rpc_error_to_string. The error code is passed into the function so it is
not necessary to append it to the returned string as well.

The PR also fixes the screwed formatting of the error code tables.

(cherry picked from commit c78566d2a239648087949dc4ae58e18093f8bf6c)
2021-02-25 09:51:41 +01:00
Pascal Nowack
a864f0a529 winpr/clipboard: Also save lastWriteTime for FILEDESCRIPTORW
Currently, when a local uri-list is converted into a FILEDESCRIPTORW
list, WinPR doesn't submit the last write time for each file.
The result of this is that the last write time of each file on the
other peer will have the current time and not the actual last write
time that is present on the peer, where the files were copied from.

Fix this by also writing the last write time in addition to the
FD_WRITESTIME flag.

(cherry picked from commit 9ba614a1e3314d9d3daa6e461e7d360c67c8d000)
2021-02-25 09:51:41 +01:00
kubistika
9d8d5e5969 x11: use correct contact flag names in xf_input_touch_state_string
(cherry picked from commit a94fe816a4dce96a26cd2ef284f525181d75c865)
2021-02-25 09:51:41 +01:00
Martin Fleisz
76923c7890 Fix parsing of current keyboard locale
(cherry picked from commit 2e59baa33c23cbd0e0ef6e432d8ef202caa34303)
2021-02-25 09:51:41 +01:00