Commit Graph

5983 Commits

Author SHA1 Message Date
Marc-André Moreau
5aa64a08b0 Merge pull request #1769 from nfedera/fix-2014-04-03-01
libfreerdp-core: fix transport_check_fds
2014-04-03 15:58:45 -04:00
Norbert Federa
4e2b696221 libfreerdp-core: fix transport_check_fds
This patch fixes an issue with hung clients connected to FreeRDP server:

- Removed the completely useless inner while loop which used the transport
  receive buffer stream position as break contition: The transport receive
  buffer stream is replaced after each iteration of this loop with a fresh
  instance from a pool which has the position set to 0. Thus it was
  technically impossible that this loop would ever be run twice.

- We must not always return if transport_read_nonblocking returns 0:
  transport_read_nonblocking() is also called in transport_write() and
  therefore it is possible that the stream position of the transport
  receive buffer is already > 0 when entering transport_check_fds.
2014-04-03 21:42:32 +02:00
Marc-André Moreau
69406d5ef7 Merge pull request #1768 from FreeRDP/mh-svc-start-fix
Ensures that the static virtual channels are started
2014-04-03 10:15:16 -04:00
Martin Haimberger
250a2be8bb Ensures that the static virtual channels are started
before virtual channel data can be received
2014-04-03 06:48:41 -07:00
Norbert Federa
79609139da Merge pull request #1767 from bmiklautz/fix/rdpsec
RDP security fixes
2014-04-03 12:30:08 +02:00
Bernhard Miklautz
16bc9f4bd1 sec-rdp: fixed cleanup in key error case 2014-04-03 12:18:08 +02:00
Bernhard Miklautz
21c425b79c sec-rdp: limit server side key size to 2048 bit
Current code doesn't handle keys > 2048 bit properly in multiple places.
To prevent problems make sure that no larger keys are used for now.
2014-04-03 11:50:06 +02:00
Bernhard Miklautz
9436d64ff5 sec-rdp: fixed *_establish_keys for keys > 256 bit 2014-04-03 11:36:51 +02:00
Marc-André Moreau
500acb3a20 Merge pull request #1766 from nfedera/fix-2014-04-02-02
libfreerdp-core: fix disconnect reason
2014-04-02 09:20:28 -04:00
Marc-André Moreau
446025b5b5 Merge pull request #1765 from nfedera/fix-2014-04-02-01
core: FIPS for fastpath and RDP security fixes
2014-04-02 09:20:15 -04:00
Norbert Federa
68db82f7d1 libfreerdp-core: fix disconnect reason 2014-04-02 14:43:47 +02:00
Norbert Federa
18cb418c81 core: FIPS for fastpath and RDP security fixes
- fixed invalid stream position if extEncryptionMethods is not used
- enabled 56bit rdp security method
- fixed entropy reduction of the keys for 40 bit and 56 bit
- added rdp security incl. FIPS for fastpath output
- added FIPS encryption to fast path input
- fixed FIPS key generation in server mode
- fixed stream length correction in FIPS mode
- added rdp encryption for licensing packets (apparently some clients,
  specifically cetsc, require the license packets received from the
  server to be encrypted under certain RDP encryption levels)
- replace errnous virtual extended mouse event in focus in event
2014-04-02 14:17:39 +02:00
Marc-André Moreau
8bf5559f51 Merge pull request #1764 from awakecoding/ports
Serial Port Improvements
2014-04-01 21:37:25 -04:00
Marc-André Moreau
42a88b93dd libfreerdp-crypto: fix tls_verify_certificate declaration 2014-04-01 21:17:44 -04:00
Marc-André Moreau
56d75ac892 libfreerdp-core: fix non-C89 declaration 2014-04-01 20:56:34 -04:00
Marc-André Moreau
8083350aaa channels/serial: remove debug output 2014-04-01 16:49:09 -04:00
Marc-André Moreau
55e381696e Merge branch 'master' of github.com:awakecoding/FreeRDP into ports 2014-04-01 16:28:39 -04:00
Marc-André Moreau
feea87b42f libfreerdp-crypto: make distinction between TLS connection error and user cancellation 2014-04-01 16:23:27 -04:00
Marc-André Moreau
756daa0cbe Merge branch 'master' of github.com:awakecoding/FreeRDP into ports 2014-03-31 14:26:02 -04:00
Marc-André Moreau
046a33ba9f cmake: fix debug symbols for C++ code 2014-03-31 13:10:57 -04:00
Marc-André Moreau
83ddb7b82c libfreerdp-codec: fix unit test compilation 2014-03-29 12:37:16 -04:00
Marc-André Moreau
2524cebfa2 Merge branch 'master' of github.com:mrthebunny/FreeRDP 2014-03-28 12:30:24 -04:00
Benoît LeBlanc
6d55d8859d Added context error codes 2014-03-28 12:23:16 -04:00
Marc-André Moreau
24cab9176c Merge branch 'master' of github.com:awakecoding/FreeRDP into ports 2014-03-27 17:11:25 -04:00
Marc-André Moreau
a8551f4008 libfreerdp-core: fix potential issue while reading packet headers 2014-03-27 17:09:26 -04:00
Marc-André Moreau
3f07157637 libfreerdp-core: enforce checking of NLA packets in transport only when expecting NLA 2014-03-27 14:24:15 -04:00
Marc-André Moreau
75302e2cc2 libfreerdp-core: don't set connectErrorCode when there is no error 2014-03-27 11:50:56 -04:00
Marc-André Moreau
021776e84b channels/serial: partial EPSON TM-T88III fix 2014-03-26 17:54:36 -04:00
Marc-André Moreau
8e2baab504 channels/serial: code cleanup 2014-03-26 17:11:15 -04:00
Marc-André Moreau
2ff5200f81 channels/serial: remove old async irp code, cleanup to make use of newer utils 2014-03-26 15:21:44 -04:00
Marc-André Moreau
00e6463e1e channels/rdpdr: robustness improvements 2014-03-26 11:05:12 -04:00
Marc-André Moreau
60981532f6 Merge pull request #1758 from awakecoding/master
Bulk Decompression Fix
2014-03-26 09:24:16 -04:00
Marc-André Moreau
797d326252 libfreerdp-core: fix handling of uncompressed packets 2014-03-26 09:16:28 -04:00
Marc-André Moreau
cc3719efa7 Merge branch 'master' of github.com:FreeRDP/FreeRDP 2014-03-26 09:01:39 -04:00
Marc-André Moreau
8040c58ff7 Merge pull request #1756 from hardening/malloc_checks
Adds some check to treat OOM problems + RDP security fix
2014-03-25 21:20:15 -04:00
Hardening
ac7507ab8d Adds some check to treat OOM problems + RDP security fix
Malloc can fail so it will, this patch adds some check in some places
where malloc/strdup results were not checked.

This patch also contains a server side fix for RDP security (credit to nfedera).
The signature len was badly set in the GCC packet. And some other RDP security
oriented fixes are also there.
2014-03-25 23:13:08 +01:00
Marc-André Moreau
374b5e4dcc channels/rdpdr: fix potential robustness issues related to hotplug support 2014-03-25 16:37:47 -04:00
Marc-André Moreau
caecf1823b Merge pull request #1754 from awakecoding/master
Multimon Fix, xfreerdp extensibility, context-specific error handling, Gateway LAN auto-detect
2014-03-25 15:26:38 -04:00
Marc-André Moreau
14b75d1b27 libfreerdp-core: fix build warnings and windows broken build 2014-03-25 15:19:52 -04:00
Marc-André Moreau
65ff98bb99 libfreerdp-core: fix /multimon and /span options 2014-03-25 14:39:21 -04:00
Marc-André Moreau
8fc412bbbc Merge branch 'xkeys' of github.com:awakecoding/FreeRDP 2014-03-25 12:27:22 -04:00
Marc-André Moreau
84cef49678 xfreerdp: treat Super key differently 2014-03-25 12:27:06 -04:00
Marc-André Moreau
4c920506ed libfreerdp-core: add 'Bypass RD Gateway server for local addresses' feature 2014-03-24 14:44:18 -04:00
Marc-André Moreau
25a7225a22 xfreerdp: don't execute action script when not present 2014-03-24 09:40:01 -04:00
Marc-André Moreau
28ab490164 Merge branch 'master' of github.com:awakecoding/FreeRDP into xkeys 2014-03-22 17:43:02 -04:00
Marc-André Moreau
fb12998957 libfreerdp-core: fix context error handling 2014-03-22 17:42:44 -04:00
Marc-André Moreau
234a3fa453 xfreerdp: add action script options for X11 events 2014-03-22 17:12:50 -04:00
Marc-André Moreau
770defc706 xfreerdp: add registration of key combinations 2014-03-22 14:40:52 -04:00
Marc-André Moreau
e534ecb4a6 Merge branch 'master' of github.com:awakecoding/FreeRDP into xkeys 2014-03-22 13:31:12 -04:00
Benoit LeBlanc
21b5f0e418 Fix windows build 2014-03-21 15:25:00 -04:00