Commit Graph

8574 Commits

Author SHA1 Message Date
Norbert Federa 51b697d4c8 transport/mfreerdp: fix async transport
- handle WAIT_TIMEOUT result as error in async transport thread
  if an INFINITE timeout was specified in WaitForMultipleObjects
- fix mfreerdp's async transport handling to not use
  freerdp_get_event_handles/freerdp_check_event_handles if async
  transport is activated
2015-05-14 21:57:16 +02:00
Hardening 7220e34b5b Merge pull request #2620 from nfedera/fix-gdi-cache
gdi: fix nullification of instance->context->cache
2015-05-14 21:13:12 +02:00
Norbert Federa 35c11c721e gdi: fix nullification of instance->context->cache 2015-05-14 20:33:21 +02:00
Hardening f219d341f1 Merge pull request #2611 from nfedera/fix-async-transport-thread
transport: fixed multiple errors in async thread
2015-05-13 08:24:35 +02:00
Hardening 75634d460f Merge pull request #2613 from oshogbo/gethostname
At least at FreeBSD - the gethostname(3) function can fail.
2015-05-12 16:18:08 +02:00
Hardening a0a3eedb21 Merge pull request #2612 from oshogbo/style
Function return bool, so lets return FALSE if 0 or TRUE if 1.
2015-05-12 15:45:55 +02:00
Mariusz Zaborski 401152f357 At least at FreeBSD - the gethostname(3) function can fail.
Check returned value.
2015-05-12 15:43:38 +02:00
Mariusz Zaborski b8c5da138d Function return bool, so lets return FALSE if 0 or TRUE if 1. 2015-05-12 15:40:28 +02:00
Norbert Federa e99b84ef02 transport: fixed multiple errors in async thread 2015-05-11 21:55:58 +02:00
MartinHaimberger e3236c2317 Merge pull request #2605 from nfedera/fix-2015-05-08-01
fixed multiple missing gdi return value checks
2015-05-11 16:59:32 +02:00
MartinHaimberger 692df124c6 Merge pull request #2607 from nfedera/remove_free_null_checks
free can handle NULL perfectly fine
2015-05-11 10:14:30 +02:00
Norbert Federa 1eff1a345e free can handle NULL perfectly fine 2015-05-11 09:07:39 +02:00
Norbert Federa 71a4349928 fixed multiple missing gdi return value checks
mainly gdi_Create* functions
2015-05-08 21:39:23 +02:00
Bernhard Miklautz d4df3a952b Merge pull request #2594 from baruchsiach/fix-math-2
Don't disable C99 long double math on non Unix platforms
2015-05-08 13:44:26 +02:00
Norbert Federa 9fe7ad2878 Merge pull request #2577 from hardening/listen_from_socket
Add the ability to have listener from an existing socket
2015-05-08 11:17:33 +02:00
David FORT acf13da91c Return FALSE under Win32 2015-05-08 10:07:29 +02:00
David FORT 21d9ffcb8f Test the number of listening handles 2015-05-08 10:05:39 +02:00
David FORT fca4374919 Add the ability to have listener from an existing socket 2015-05-08 10:00:38 +02:00
Bernhard Miklautz 81568ff03a Merge pull request #2596 from akallabeth/wlog_default_out_fix
Wlog console output to stderr
2015-05-08 00:49:41 +02:00
Hardening a88adcbb7e Merge pull request #2601 from nfedera/fix-2015-05-07-01
Fix some unchecked create calls
2015-05-07 19:06:59 +02:00
Norbert Federa b9771f8a44 Merge pull request #2597 from clivest/bitstream_read_fix
Fix bitstream reading bounds check
2015-05-07 18:42:15 +02:00
Norbert Federa 509230f6b1 Merge pull request #2598 from clivest/stream_leak_fix
Fix two cases of stream resource leak
2015-05-07 18:24:47 +02:00
Norbert Federa b2dcde35ee Merge pull request #2599 from hardening/fix_wayland_colors
Fix colors with the wayland client
2015-05-07 18:15:01 +02:00
Norbert Federa e290e55554 Merge pull request #2603 from hardening/rail_empty_title_fix
Fix empty window title
2015-05-07 18:13:09 +02:00
Norbert Federa 525ae6c561 Merge pull request #2604 from hardening/rail_fix
Fix remoteApps
2015-05-07 18:11:38 +02:00
Norbert Federa 82843f0700 server/shadow: added missing error message 2015-05-07 17:42:01 +02:00
David FORT c330a3715e Fix empty window title
When the size of a RAIL string was 0, we were reporting an OOM error.
2015-05-07 15:08:00 +02:00
David FORT 0e2925d0b8 Fix remoteApps
The assert that have been removed were preventing RAIL from working when you
have an intermediary screen before seeing the application.
2015-05-07 14:36:07 +02:00
Norbert Federa f9f59cd29b Fix unchecked CreateDirectory calls 2015-05-07 13:28:13 +02:00
Norbert Federa e3fb908686 Fix unchecked CreateSemaphore calls 2015-05-07 13:28:03 +02:00
Norbert Federa c77def3048 Fix unchecked CreateMutex calls 2015-05-07 13:27:49 +02:00
David FORT b09f6bedb7 Fix colors with the wayland client 2015-05-06 21:54:39 +02:00
Clive Stevens 2e41c5425b Fix whitespace 2015-05-06 15:54:23 +01:00
Clive Stevens 75865b5c3b Fix bitstream reading
The bounds checks where previously incorrect
2015-05-06 15:37:11 +01:00
Clive Stevens b06e50479e Fix two cases of potentially leaked streams 2015-05-06 15:23:37 +01:00
Armin Novak 1d3e847f12 Fixed broken indent. 2015-05-06 15:37:55 +02:00
Armin Novak c0fbaa579b Not writing messages if level is WLOG_OFF. 2015-05-06 10:58:57 +02:00
Armin Novak c375071b5d Console logging to stdout and stderr
With this patch the default for the console logger
changes to writing to stdout for TRACE, DEBUG and INFO
messages and stderr for WARNING, ERROR and FATAL messages.
2015-05-06 10:56:30 +02:00
Martin Fleisz 063c1bc806 Merge pull request #2592 from nfedera/fix-2015-05-05-01
Fix unchecked CreateThread calls and misc fixes
2015-05-06 10:16:26 +02:00
Baruch Siach 81fc2c9740 Don't disable C99 long double math on non Unix platforms
CMakeLists.txt may enable HAVE_MATH_C99_LONG_DOUBLE only on Unix platforms.
Limit the effect of this symbol accordingly.
2015-05-05 21:27:17 +03:00
Marc-André Moreau 1de81c30a4 Merge pull request #2587 from floppym/armfix
Remove the ARM_FP_ABI option
2015-05-05 10:56:12 -04:00
Marc-André Moreau 70ecd9b619 Merge pull request #2589 from baruchsiach/fix-math
Don't use unavailable C99 long double math functions
2015-05-05 10:47:03 -04:00
Norbert Federa 25fc866a58 Fix unchecked CreateThread calls and misc fixes 2015-05-05 13:55:48 +02:00
MartinHaimberger 9a4f645f78 Merge pull request #2582 from nfedera/fix-2015-04-28-01
Fix unchecked CreateEvent calls and misc fixes
2015-05-04 10:14:27 +02:00
Baruch Siach 414663cc36 Don't use unavailable C99 long double math functions
uClibc variants do not provide the C99 long double math functions like ceill,
powl, etc.. For future compatibility use check_symbol_exists() to check
whether these functions are available, and keep the result in
HAVE_MATH_C99_LONG_DOUBLE. Use that instead of the fragile Cygwin version
check in triodef.h.

Fixes build failures under uClibc(-ng) like:

../../libwinpr/utils/libwinpr-utils.so.0.1.0: undefined reference to `powl'
../../libwinpr/utils/libwinpr-utils.so.0.1.0: undefined reference to `fmodl'
../../libwinpr/utils/libwinpr-utils.so.0.1.0: undefined reference to `ceill'
../../libwinpr/utils/libwinpr-utils.so.0.1.0: undefined reference to `log10l'
../../libwinpr/utils/libwinpr-utils.so.0.1.0: undefined reference to `floorl'
collect2: error: ld returned 1 exit status

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
2015-05-03 21:12:30 +03:00
Mike Gilbert 2355b54f85 Remove the ARM_FP_ABI option
It's unclear why this option would be necessary, and it causes problems
when people do not match it to their toolchain and CFLAGS.

To set the float abi, either use a toolchain with an appropriate default
or set the float-abi option in the CFLAGS environment variable.

This should resolve #2586.
2015-05-01 17:35:21 -04:00
Bernhard Miklautz dd2e7f393d Merge pull request #2584 from baruchsiach/fix-eventfd-2
Fix build with newer uclibc versions
2015-04-30 14:20:33 +02:00
Norbert Federa 7edb38df84 Increase API version to 1.2.3 2015-04-30 09:20:34 +02:00
Baruch Siach 3b7d3190a1 Fix build with newer uclibc versions
uClibc master branch, as well as uclibc-ng add eventfd_{read,write}
definitions. Instead of testing for __UCLIBC__, have cmake explicitly check
for the existence of eventfd_read and save the result in
WITH_EVENTFD_READ_WRITE.

Fixes build errors like:

.../winpr/libwinpr/synch/event.c:120:12: error: static declaration of 'eventfd_read' follows non-static declaration
 static int eventfd_read(int fd, eventfd_t* value)
            ^
In file included from .../winpr/libwinpr/synch/event.c:39:0:
.../usr/include/sys/eventfd.h:37:12: note: previous declaration of 'eventfd_read' was here
 extern int eventfd_read (int __fd, eventfd_t *__value);
            ^
.../winpr/libwinpr/synch/event.c:125:12: error: static declaration of 'eventfd_write' follows non-static declaration
 static int eventfd_write(int fd, eventfd_t value)
            ^
In file included from .../winpr/libwinpr/synch/event.c:39:0:
.../usr/include/sys/eventfd.h:40:12: note: previous declaration of 'eventfd_write' was here
 extern int eventfd_write (int __fd, eventfd_t __value);
2015-04-29 20:31:25 +03:00
Norbert Federa ef1fd12b15 Fix unchecked CreateEvent calls and misc fixes
1)
Added missing checks for CreateEvent which also required the
following related changes:

- changed freerdp_context_new API to BOOL
- changed freerdp_peer_context_new API to BOOL
- changed pRdpClientNew callback to BOOL
- changed pContextNew callback to BOOL
- changed psPeerAccepted callback to BOOL
- changed psPeerContextNew callback to BOOL

2)
Fixed lots of missing alloc and error checks in the
changed code's neighbourhood.

3)
Check freerdp_client_codecs_prepare result to avoid segfaults
caused by using non-initialized codecs.

4)
Fixed deadlocks in x11 caused by missing xf_unlock_x11() calls
in some error handlers

5)
Some fixes in thread pool:
- DEFAULT_POOL assignment did not match TP_POOL definition
- don't free the pool pointer if it points to the static DEFAULT_POOL
- added error handling and cleanup in InitializeThreadpool
2015-04-29 18:18:39 +02:00