14244 Commits

Author SHA1 Message Date
akallabeth
47b4867729 Destroy channel listeners on terminate
(cherry picked from commit 2f5e5359f60c26a2de244cd6d9f7957b039cd121)
2020-05-18 16:40:52 +02:00
akallabeth
74629de51b drdynvc channel cleanup.
* Clean channel listeners on channel close
* Remove limit on listeners for channels
* Remove limit on channels

(cherry picked from commit 5b2a4434d8becd7b527d5b329eee9915ff8ca77a)
2020-05-18 16:40:44 +02:00
akallabeth
2f75c4ac8d Ensure all NLA structs are freed up
(cherry picked from commit 477ad675f31a1965833304f79406599e0ad97b82)
2020-05-18 16:40:33 +02:00
akallabeth
79cea7b5b6 Fixed #6157: Reset cups instance on disconnect.
(cherry picked from commit 13906f3ec629af4b2b2aeb5b92845f99b7bf7747)
2020-05-18 16:40:23 +02:00
akallabeth
c266a81323 Fixed #6163: Force linking to objective C runtime
Sound channel requires the objective C runtime, force linking to
fix build issues on older mac os versions

(cherry picked from commit eee1d7176b885d09385471bec943c9aabc4a1552)
2020-05-18 16:39:28 +02:00
akallabeth
5fc0ddeff5 Fixed #6156: Enforce synchronized encrypt count
Old style RDP encryption uses a counter, synchronize this for
packets send from different threads.

(cherry picked from commit 873a9bef42017ff694659538f70909f679eb1eac)
2020-05-18 16:38:42 +02:00
akallabeth
fae7b99a84 Fixed #6162: Clipboard temporary path length limit
The limit of clipboard temporary paths is 260 '\0' terminated
wide characters. Fix the checks to enforce that properly.

(cherry picked from commit 06bfcfad672522598a39522830449b444d50a9e4)
2020-05-18 16:38:29 +02:00
Kobi Mizrachi
228d16a868 server: proxy: Register signal handler after modules finished loading.
This prevents a race where the signal handler free's structs that
modules use while initializing.

(cherry picked from commit 42d99f4c6070a984afc43ec7e85650dc4e624af8)
2020-05-18 16:37:36 +02:00
Kobi Mizrachi
70903cc04e server: proxy: print version and buildconfig on startup
(cherry picked from commit f0fe17d94364087136354284543573bf54da162f)
2020-05-18 16:37:28 +02:00
Bernhard Miklautz
11b9b1ca6b
Merge pull request #6152 from akallabeth/stable-backports
Stable backports
2.1.0
2020-05-08 11:40:17 +02:00
akallabeth
2d5ce618bf 2.1.0 release version. 2020-05-08 11:23:05 +02:00
akallabeth
65d3ff4461 Changelog for 2.1.0 2020-05-08 11:11:12 +02:00
akallabeth
fe7124fc8d Fixed integer overflow in winpr_image_bitmap_read_buffer
Thanks to hac425

(cherry picked from commit dffd893dc5874b63c99777d7df147e37c770fc92)
2020-05-08 11:11:12 +02:00
akallabeth
d858616852 Changed smartcard no reader log message level to info
(cherry picked from commit 728f6aff516a12ac8720aa0c9fa1730cde348dca)
2020-05-08 11:11:12 +02:00
akallabeth
3e4a835c29 Fixed wrong error return from drdynvc_write_data
When the channel was closed a wrong error code was returned.

(cherry picked from commit 6446d609fc95830d7c9c1e6a91829146d567e277)
2020-05-08 11:11:12 +02:00
akallabeth
1178381809 Silence valgrind in rdp_read_header
If a disconnect message is received, we returned success but did
not initialize the return arguments.

(cherry picked from commit b45336f51febb4c34b5bf33fdf8d63ce44fe9e99)
2020-05-08 11:11:12 +02:00
akallabeth
b3a1a6683b Silence valgrind in unicode conversion functions
Only check destination buffer for NULL if length argument did not
already indicate the buffer needs to be allocated.

(cherry picked from commit ebe223e7a4ba0131b55e0c8e8baa98deb3f89c4b)
2020-05-08 11:11:12 +02:00
akallabeth
1eae49f8fe Increased uwac library version.
(cherry picked from commit 58b313e6d95d96f942b451c9b635fbc70fe415cf)
2020-05-08 11:11:12 +02:00
akallabeth
b1c7c9f59d Create data copy in case of dynamic sound channel.
(cherry picked from commit f016f1ec09056db856fb662876f934dbc754bc0c)
2020-05-08 11:11:12 +02:00
akallabeth
63730ab349 Fixed warning messages for RDP file options
networkautodetect and bandwidthautodetect are both boolean options
which must match each other. Added adequate warnings.

(cherry picked from commit 5f5bf10703276be3ddb0c5d184e078c0a6a857bb)
2020-05-08 11:06:02 +02:00
akallabeth
1baac780e5 Use dedicated sound decoder thread. 2020-05-08 11:06:02 +02:00
akallabeth
8b37e7fa11 Fixed primary monitor index for wayland fullscreen 2020-05-08 11:06:02 +02:00
akallabeth
4ce390e1b9 Fixed UwacDisplayGetOutput and UwacOutputGetResolution checks
return proper error conditions if arguments are invalid.
2020-05-08 11:06:02 +02:00
Linus Heckemann
3c24e10bf3 shadow_server: allow specifying IP addresses to listen on (#6050)
* shadow_server: allow specifying IP addresses to listen on

This allows using IPv6 as well as listening only on specific
interfaces. Additionally, it enables listening on local and TCP
sockets simultaneously.

* listener: log address with square brackets

This disambiguates IPv6 addresses.

* shadow_server: check error on each socket binding

* Refactored shadow /bind-address for 2.0 compiatibility.

* Made /ipc-socket and /bind-address incompatible arguments.

* Fixed shadow /bind-address handling and description

* Allow multiple bind addresses for shadow server.

Co-authored-by: akallabeth <akallabeth@posteo.net>
2020-05-08 11:06:02 +02:00
akallabeth
eee9dead2d Fixed compiler warnings for usb channel 2020-05-08 11:06:02 +02:00
akallabeth
c903aa0409 Fixed index out of bound access in update_glyph_offset 2020-05-08 11:06:02 +02:00
akallabeth
63fbc976be Unified INLINE definition 2020-05-08 11:06:02 +02:00
Armin Novak
a8c6f012d8 Silence SCARD_E_TIMEOUT warnings
These occur quite often for status calls, so reduce log verbosity.
2020-05-08 11:06:02 +02:00
akallabeth
e928888dab Fixed various input buffer length checks in URBDRC
Thanks to hac425 CVE-2020-11039
2020-05-08 11:06:02 +02:00
akallabeth
c1cef2d68c Fixed int overflow in smartcard_ndr_read
Thanks to hac425
2020-05-08 11:06:02 +02:00
akallabeth
af2ce439e1 Fixed int overflow in msusb_mspipes_read
Thanks to hac425
2020-05-08 11:06:02 +02:00
akallabeth
4c07a00403 Fixed int overflow in printer_write_setting
Thanks to hac425
2020-05-08 11:06:02 +02:00
akallabeth
98a4cd28bd Fixed int overflow in PresentationContext_new
Thanks to hac425 CVE-2020-11038
2020-05-08 11:06:02 +02:00
akallabeth
0f266b5362 Fixed #6112: Segfault in update_decompress_brush
The iterators need to be signed for the loop check to work.
2020-05-05 07:46:10 +02:00
akallabeth
e35d06f6e1 Fixed oob read in rfx_process_message_tileset
Check input data length
Thanks to hac425 CVE-2020-11043
2020-05-05 07:46:10 +02:00
akallabeth
32f705e597 Fixed oob read in clear_decompress_subcode_rlex
Fixed length checks before stream read.
Thanks to hac425 CVE-2020-11040
2020-05-05 07:46:10 +02:00
akallabeth
7c94b425e6 Fixed oob read in rdpsnd_recv_wave2_pdu
Check format index before using it.
Thanks to hac425 CVE-2020-11041
2020-05-05 07:46:10 +02:00
akallabeth
738d4bff00 Fixed oob read in update_recv
properly use update_type_to_string to print update type.
Thanks to hac425 CVE-2020-11019
2020-05-05 07:46:10 +02:00
akallabeth
f5b838de37 update_decompress_brush: explicit output length checks
The output length was just assumed to be >= 256 bytes, with this
commit it is explicitly checked.
2020-05-05 07:46:10 +02:00
akallabeth
00b5ff301f Fixed clipboard 'called with invalid type' warning 2020-05-05 07:46:10 +02:00
akallabeth
f3de3ee16b Fix short format name configuration and format list return. 2020-05-05 07:46:10 +02:00
akallabeth
13dac0ee2a Fixed possible int overflow. 2020-05-05 07:46:10 +02:00
akallabeth
09d0124418 Remove unnecessary cast. 2020-05-05 07:46:10 +02:00
akallabeth
55f18cb8a5 Fix oob read in msusb_msconfig_read 2020-05-05 07:46:10 +02:00
akallabeth
a1a6790f99 Fixed oob read in irp_write and similar 2020-05-05 07:46:10 +02:00
akallabeth
b375d84ed6 Fixed oob read in parallel_process_irp_create 2020-05-05 07:46:10 +02:00
akallabeth
8d3d953264 Fixed oob read in parallel_process_irp_read 2020-05-05 07:46:10 +02:00
akallabeth
1d28ba56bd Fixed oob read in parallel_process_irp_write 2020-05-05 07:46:10 +02:00
akallabeth
19694b0110 Fixed oob read in ntlm_read_AuthenticateMessage 2020-05-05 07:46:10 +02:00
akallabeth
c098f21fda Fixed oob read in ntlm_read_ntlm_v2_response 2020-05-05 07:46:10 +02:00