Bernhard Miklautz
423b15108d
Merge pull request #2522 from realjiangms/fix_WriteLock_leak
...
transport_write sometimes returns directly without cleanup.
2015-04-08 15:39:10 +02:00
zihao.jiang
a057526f1e
transport_write sometimes returns directly without cleanup. Fix code path to always do cleanup job.
2015-04-08 21:20:07 +08:00
Bernhard Miklautz
879ed36a3c
Merge pull request #2513 from hardening/license_and_security_retValues
...
License and security ret values
2015-04-08 11:33:57 +02:00
Bernhard Miklautz
7ae825ff6d
Merge pull request #2512 from hardening/help2353
...
Kill more exit() occurences
2015-04-08 10:35:32 +02:00
David FORT
c03bf75896
Take in account @nfedera's comments
2015-04-07 21:06:53 +02:00
David FORT
c0b191a1c6
Fix a too big Stream_EnsureRemainingCapacity()
2015-04-07 15:19:59 +02:00
Hardening
35892cfaef
Merge pull request #2516 from bmiklautz/cmd_fix
...
Fix regression introduced in 0b7f9d4
2015-04-07 10:51:25 +02:00
Bernhard Miklautz
0615c13dbb
Fix regression introduced in 0b7f9d4
...
This fixes problems with command line parsing.
2015-04-02 22:53:45 +02:00
David FORT
d84c760f7d
Fix a typo in server-side code
2015-04-01 22:26:38 +02:00
David FORT
a4a58aa373
Fix the error case in mcs_send_connect_response()
2015-04-01 17:55:01 +02:00
David FORT
23e11e5a3d
Fix code style
2015-04-01 16:58:25 +02:00
David FORT
5302bad2b7
Drop the limit on key size
2015-04-01 15:11:57 +02:00
David FORT
8685a8e0a2
Fixed missing return value
2015-04-01 14:24:37 +02:00
David FORT
9bb4d64608
Correctly handle HMAC_Init_ex() for older versions of OpenSSL
2015-04-01 14:12:08 +02:00
David FORT
edb915943f
Treat return values in license.c
...
This patch changes functions that should not return void and also treat the
callers of these functions.
2015-04-01 11:38:53 +02:00
David FORT
0cf17ef98c
Complement gitignore files with new generated files
2015-04-01 11:13:05 +02:00
David FORT
0eb399a717
Treat return values for security.c
...
This patch make functions in security.c return values when they should instead of
beeing void. And it also fix the callers of these functions.
2015-04-01 11:11:37 +02:00
David FORT
cf8c7631bd
Kill more exit() occurences
...
In general we should not have any exit() call in libfreerdp.
2015-03-31 23:56:40 +02:00
Marc-André Moreau
121ea23595
Merge pull request #2487 from mfleisz/nla_fix
...
Fix server side NLA
2015-03-31 10:55:04 -04:00
Norbert Federa
89b7eebaf8
Merge pull request #2509 from bmiklautz/security_fixes_v2
...
NULL dereference fixes
2015-03-31 15:37:16 +02:00
Marc-André Moreau
ad6723835b
Merge pull request #2505 from bmiklautz/tls_shutdown
...
rename and update tls_disconnect
2015-03-31 09:26:30 -04:00
Bernhard Miklautz
5692117f8c
wlog: add missing check
...
Integrate pull request feedback
2015-03-31 15:20:10 +02:00
Armin Novak
71d4b81c6d
Removed scopes.
2015-03-31 15:18:46 +02:00
Armin Novak
b1edaf677b
Removed duplicated NULL pointer checks.
2015-03-31 15:18:46 +02:00
Armin Novak
d50ce6bd7a
Corrected end of string checks.
2015-03-31 15:18:46 +02:00
Armin Novak
853ac63afd
Removed INVALID_HANDLE_VALUE.
2015-03-31 15:18:46 +02:00
Armin Novak
bd55b0df80
Removed INVALID_HANDLE_VALUE from types not using it.
2015-03-31 15:18:45 +02:00
Armin Novak
b3ea02a777
Removed INVALID_HANDLE_VALUE from types not using it.
2015-03-31 15:18:45 +02:00
Armin Novak
878aecfa48
Fixed conversion warnings.
2015-03-31 15:18:45 +02:00
Armin Novak
e68726400d
Fixed NULL pointer dereference.
2015-03-31 15:18:45 +02:00
Armin Novak
afe8bd2a86
Fixed missing checks for invalid handle.
2015-03-31 15:18:45 +02:00
Armin Novak
6b0667c959
Fixed use after free and realloc checks.
2015-03-31 15:18:45 +02:00
Bernhard Miklautz
755c9e304b
Merge pull request #2511 from hardening/fix2399
...
Fix segfault when the xkb layout has no variants
2015-03-30 21:54:27 +02:00
David FORT
27c5b5b224
Fix segfault when the xkb layout has no variants
...
This is a fix for #2399 : when there's no variants we should not try to scan them.
I have set the RDP US keyboard for the South African layout, if someone has a better
layout...
Note: we should probably set something that is not zero for other layouts
2015-03-30 21:16:18 +02:00
Hardening
bdb975afe8
Merge pull request #2510 from akallabeth/build_date
...
Added version and build info functions
2015-03-30 19:14:59 +02:00
Hardening
7f497c6b7b
Merge pull request #2502 from bmiklautz/capacity
...
stream: Stream_Ensure*Capacity: change return type
2015-03-30 19:11:11 +02:00
Bernhard Miklautz
79de8168f9
Integrate feedback from pull request
...
* orders.c: remove ; at eol
* rdpdr_main.c: simplify error case
* rdpsnd_pulse.c: fix incorrect check
* rdpsnd_main.c: adapt return value according to documentation
* update.c: fix incorrect return values
2015-03-30 18:29:32 +02:00
Armin Novak
8e521e7aee
Fixed return value in test.
2015-03-30 18:18:14 +02:00
Armin Novak
eedf45583a
Using sprintf_s now.
2015-03-30 18:17:07 +02:00
Armin Novak
0adab13719
Now returning const char*
2015-03-30 18:09:02 +02:00
Armin Novak
cf941304b3
Fixed windows _snprintf.
2015-03-30 18:05:46 +02:00
Armin Novak
827b4f76ca
Added test for freerdp version functions.
2015-03-30 17:57:16 +02:00
Armin Novak
8f228163a8
Added version and build info functions
...
Added functions to get
* Version String
* Build Time String
* Git Revision String
and appropriate tests.
2015-03-30 17:51:29 +02:00
Bernhard Miklautz
8615f74eac
drdynvc: ensure stream != NULL
2015-03-30 17:23:22 +02:00
Bernhard Miklautz
6a997fad53
cliprdr: ensure stream != NULL
2015-03-30 17:17:36 +02:00
Bernhard Miklautz
74c8400789
coding style fixes
...
Add missing space after if
2015-03-30 17:15:45 +02:00
Bernhard Miklautz
f469e069dc
stream: Stream_Ensure*Capacity: change return type
...
Change the return type of Stream_Ensure*Capacity from void to BOOL to be
able to detect realloc problems easily. Otherwise the only way to detect
this was to check if the capacity after the call was >= the required
size.
In case Stream_Ensure*Capacity fails the old memory is still available
and need to freed outside.
This commit also adds checks to most calls of Stream_Ensure*Capacity to
check if the call was successful.
2015-03-30 16:33:48 +02:00
Marc-André Moreau
851626f296
Merge pull request #2492 from bmiklautz/malloc_wrap
...
Fix compiler warnings and code hardening
2015-03-30 09:35:36 -04:00
Marc-André Moreau
ad6dc92e12
Merge pull request #2508 from nfedera/fix-2015-03-30-01
...
crypto: support MSFT iOS clients with faulty SNI
2015-03-30 08:23:59 -04:00
Marc-André Moreau
644fafab8e
Merge pull request #2507 from nfedera/fix-2015-03-30-02
...
nego: fixed X.224 Connection Request PDU parsing
2015-03-30 08:23:40 -04:00
