Commit Graph

1546 Commits

Author SHA1 Message Date
akallabeth
940d067f52
[server,proxy] stricter argument parsing
* Check number of arguments is valid (don't allow additional ones)
* Replace exit() with normal return for helper functions
2024-10-26 19:53:36 +02:00
akallabeth
a3aa01214c
[resource root] unify locations
unify resource locations in case WITH_BINARY_VERSIONING is set.
2024-10-25 11:40:40 +02:00
akallabeth
9caf38bbb6 [warnings] unify CommandLineParseCommaSeparatedValues
CommandLineParseCommaSeparatedValues does some internal hack to allow
the allocated char** to be cleaned up by free.
This enforces compiler warnings as the pointer types do not match.
Use a new free function CommandLineParserFree instead
2024-10-22 21:11:58 +02:00
akallabeth
5353bff104
[assert] use WINPR_STATIC_ASSERT 2024-10-16 19:07:07 +02:00
akallabeth
e6cf35c518
[warnings] fix integer narrowing 2024-10-14 10:31:55 +02:00
akallabeth
15d408d6fc
[warnings] fix integer narrowing 2024-10-14 10:31:45 +02:00
akallabeth
6c8c67b385
Merge pull request #10677 from akallabeth/int-narrow
Int narrow
2024-10-03 21:17:56 +02:00
akallabeth
3a2a65bbed
[server,shadow] fix integer narrow 2024-10-03 18:58:56 +02:00
akallabeth
997ff57301
[proxy,rdpdr] fix integer narrow 2024-10-03 18:58:53 +02:00
akallabeth
f55a1e2bc3
[proxy,modules] fix integer narrow 2024-10-03 18:58:51 +02:00
akallabeth
10bb42e4d8
[server,proxy] fix integer narrowing 2024-10-03 18:58:48 +02:00
Martin Fleisz
966ddd13df
Merge pull request #10694 from akallabeth/qa-fixes
Qa fixes
2024-10-03 13:09:06 +02:00
akallabeth
cfc37caeb8
[cmake] cleaning_configure_file
add a wrapper to automatically add generated files to clean target
2024-10-02 23:28:08 +02:00
Armin Novak
934cf668a2
[winpr,utils] use sam file relative to config home 2024-10-02 23:27:55 +02:00
akallabeth
e95707f3c7
[server,proxy] annotate bugprone-signal-handler 2024-10-01 13:05:32 +02:00
akallabeth
485ebe03bf
[*printf] cast return to void 2024-10-01 13:04:57 +02:00
akallabeth
490ca0453b
[winpr,stream] use Stream_BufferAs instead of casting 2024-10-01 10:34:42 +02:00
akallabeth
11b7633dc0
[channels] use Stream_BufferAs
For WTSVirtualChannelRead and WTSVirtualChannelWrite use Stream_BufferAs
to cast to correct type.
2024-10-01 10:28:13 +02:00
akallabeth
b1cc0a3191
[proxy,modules] eliminate unused variables 2024-09-24 19:45:16 +02:00
akallabeth
239440e28d
[warnings] remove or comment unused macros 2024-09-20 18:49:38 +02:00
akallabeth
f86f70a022
Merge pull request #10637 from akallabeth/dealloc-fix
[warnings] fix mismatched-dealloc
2024-09-20 10:50:20 +02:00
Armin Novak
96052ca2fb
[build,c++] add CXXCompilerFlags to set warnings
Just like with the C components and CompilerFlags.cmake add a
configuration for C++ that disables specific warnings only found in C++
code.
2024-09-20 09:16:30 +02:00
Armin Novak
c7c84682e1
[warnings] fix mismatched-dealloc
Some allocator functions have an error path where the corresponding free
function is called. Since the memory in the allocator function was
allocated using malloc/calloc the free function does not match. Silence
warnings with pragma macros
2024-09-18 15:35:28 +02:00
Armin Novak
65f6541f67
[server,proxy] fix plausibility checks in pf_config_get_uint32 2024-09-18 11:47:01 +02:00
Armin Novak
d55dfa316f
[server,proxy] fix unchecked return 2024-09-18 11:47:01 +02:00
Armin Novak
deec4df8c0
[proxy,module] move list in dyn-channel-dump instead of copy 2024-09-18 11:46:56 +02:00
akallabeth
586f40631f
[warnings] fix shorten-64-to-32 2024-09-17 16:13:48 +02:00
akallabeth
328b7433a4
[server,proxy] fix unchecked return values 2024-09-17 12:57:34 +02:00
akallabeth
a19305569d
[assert] fix ULONG_MAX use
most of the time this was used to check ULONG limits. Replace with
correct UINT32_MAX
2024-09-16 08:22:40 +02:00
akallabeth
bb242b9a89
[return checks] fix use of WaitForSingleObject 2024-09-16 08:22:37 +02:00
akallabeth
965d231e49
[return checks] fix use of CloseHandle 2024-09-16 08:22:31 +02:00
akallabeth
f655843260
[return checks] fix use of rdpSettings getter/setter 2024-09-16 06:48:23 +02:00
akallabeth
c0d06c782b
[return checks] fix missing checks
* Stream_EnsureRemainingCapacity
* rdp_client_transition_to_state
2024-09-16 06:48:19 +02:00
akallabeth
94020c183c
[return checks] fix use of ResetEvent 2024-09-16 06:48:09 +02:00
akallabeth
7d67b8e204
[return checks] fix use of SetEvent 2024-09-16 06:47:58 +02:00
akallabeth
0d5bc92a2b
[warnings] fix apple iOS/macos 2024-09-15 19:47:13 +02:00
akallabeth
1bd6d70057
[warnings] fix some warnings on mac os 2024-09-15 10:06:22 +02:00
akallabeth
f7726ed7b6
[server,shadow] improve command line error logging
print an error message indicating where the parsing failed.
2024-09-15 09:21:38 +02:00
akallabeth
ba41d5e532
[warnings] fix unchecked return 2024-09-15 09:08:02 +02:00
akallabeth
f1be630637
[server,proxy] fix unchecked return 2024-09-15 09:07:49 +02:00
akallabeth
8b6091a007
[winpr,wtsapi] improve API usage
* Mark WTSVirtualChannelOpen and WTSVirtualChannelOpenEx with
  WINPR_ATTR_MALLOC to enforce compiler checks for resource cleanup
* Fix unused result warnings, use the result or cast to (void) where not
  requierd
2024-09-14 21:29:31 +02:00
akallabeth
adc4f2abf8
[warnings] fix unused variables 2024-09-12 13:29:58 +02:00
akallabeth
cc6850bf21
[warnings] fix format nonliteral
add pragma to suppress format nonliteral warnings where appropriate
2024-09-12 09:08:53 +02:00
akallabeth
11671bcd5b
[warnings] fix unreachable code return 2024-09-11 20:50:24 +02:00
akallabeth
a1be46e5dd
[warning] fix function declarations
use same names in declaration and implementation
2024-09-11 20:50:21 +02:00
akallabeth
edf6ab89f7
[warnings] fix dead store 2024-09-10 14:43:11 +02:00
akallabeth
3ab6d2f918
[proxy,modules] fix unchecked return 2024-09-10 14:42:39 +02:00
akallabeth
082c46ba64
[proxy,modules] require C++ 17
Unify required C++ standard and require C++ 17 for all modules. It does
not make a lot of sense to have different standard requirements in the
same project.
2024-09-06 09:20:28 +02:00
akallabeth
749023bacb
Merge pull request #10555 from akallabeth/cast-fix-tls
[crypto,tls] simplify function pointer cast
2024-09-05 17:18:27 +02:00
akallabeth
e3f94e6622 nodiscard 2024-09-04 22:17:35 +02:00