akallabeth
26003e59cc
[va_list] initialize with ={0};
2024-09-24 11:06:18 +02:00
akallabeth
239440e28d
[warnings] remove or comment unused macros
2024-09-20 18:49:38 +02:00
Armin Novak
02b98e9287
[client,sdl] use constexpr instead of defines
2024-09-20 09:17:03 +02:00
akallabeth
84719a4d83
[client,sdl] fix class constructors and operators
...
delete unused move/copy constructors and operators
2024-09-18 23:33:50 +02:00
Armin Novak
3905ef0b01
[client,sdl] split sdl_client_thread_run
...
the function can easily be split into three funcions covering a specific
part of the thread loop. Makes the whole thing less complex and easier
to read.
2024-09-18 13:01:46 +02:00
akallabeth
8ef4b2aefa
[client,SDL] move thread cleanup to own function
...
The cleanup code for the RDP thread of the SDL clients grew quite
complex. Move to a function to reduce complexity and make the main
thread more readable again.
2024-09-18 11:48:35 +02:00
akallabeth
b7601ec755
[client,SDL] remove goto usage, replace with RAII
...
* use std::uniqe_ptr to clean up malloced strings
* use ScopeGuard to run cleanup code whenever the function is exited
2024-09-18 11:48:35 +02:00
akallabeth
586f40631f
[warnings] fix shorten-64-to-32
2024-09-17 16:13:48 +02:00
akallabeth
965d231e49
[return checks] fix use of CloseHandle
2024-09-16 08:22:31 +02:00
akallabeth
94020c183c
[return checks] fix use of ResetEvent
2024-09-16 06:48:09 +02:00
akallabeth
7d67b8e204
[return checks] fix use of SetEvent
2024-09-16 06:47:58 +02:00
akallabeth
2638d9d894
[warnings] fix casts
2024-09-12 13:30:00 +02:00
akallabeth
773eed8878
[client,sdl] use auto for variable declaration
2024-09-12 13:29:53 +02:00
akallabeth
e00661d338
[warnings] fix dead store warnings
2024-09-12 13:29:46 +02:00
akallabeth
c9b0c9ecd5
[warnings] remove unused variables
2024-09-12 10:08:10 +02:00
akallabeth
cc6850bf21
[warnings] fix format nonliteral
...
add pragma to suppress format nonliteral warnings where appropriate
2024-09-12 09:08:53 +02:00
akallabeth
2ae0c456b4
[client,sdl] fix float casts
2024-09-12 09:08:49 +02:00
akallabeth
06097575a4
[client,sdl] fix redundant initializer
2024-09-11 20:50:36 +02:00
akallabeth
9fed64eb0d
[client,SDL] SdlEventUpdateTriggerGuard
...
Delete copy & move assingment operators
2024-09-11 20:48:39 +02:00
akallabeth
edf6ab89f7
[warnings] fix dead store
2024-09-10 14:43:11 +02:00
akallabeth
189abc73f3
[client,sdl] fix missing field initializer warnings
2024-09-10 14:42:42 +02:00
akallabeth
d93d9765b3
[client,sdl] add minimize shortcut
2024-09-10 12:28:36 +02:00
akallabeth
5e123735fa
[warnings] fixed sign-compare
2024-09-04 10:14:05 +02:00
akallabeth
baa70d1ab6
[warnings] fix compare integers of different signs
2024-09-03 15:10:46 +02:00
akallabeth
5a4a1a40ad
fix declaration and implementation parameter names
2024-09-03 12:24:53 +02:00
akallabeth
cbae4155fb
[client,SDL] delete unused copy & move constructors
2024-09-03 12:17:20 +02:00
akallabeth
bd637c6cd1
[warnings] fix various clang-tidy warnings
2024-08-29 17:13:50 +02:00
akallabeth
ceae258e37
[warnings] fix clang-tidy issues in clients
2024-08-29 15:34:27 +02:00
akallabeth
1d33095500
[warnings] fix cert-err33-c
...
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
Armin Novak
d71af44bb1
[warnings] disable warnings for generated code
...
* Disable clang-tidy in test build directories
* Disable compiler warnings for test binary directories.
These contain generated code we can not change, so the warnings are just noise
2024-08-28 09:18:30 +02:00
akallabeth
56d660f258
[cmake] mark dependency includes SYSTEM
...
Mark all dependency include paths SYSTEM so warnings from system headers
are excluded from ci warning statistics
2024-08-26 11:10:49 +02:00
akallabeth
49dc431045
[client,sdl] add support for /monitors argument
2024-08-23 14:00:47 +02:00
akallabeth
37008506c2
[client,sdl] remove tab from dialog messages
2024-08-20 13:31:41 +02:00
akallabeth
39e8c077d4
[client,sdl] improve VerifyCertificate message
...
* Use FreeRDP_CertificateCallbackPreferPEM for callbacks
* Add notBefore and notAfter dates to callback messages
2024-08-20 12:42:51 +02:00
akallabeth
e72bec8441
[client,SDL] fix thread termination order
...
* Wait in SDL thread until RDP thread has terminated to avoid race
conditions during autoreconnect
* Fix exit code mappings in case the connection was cancelled
2024-07-19 09:10:32 +02:00
akallabeth
b0320d8068
[client,SDL] fix autoreconnect
...
retry on handle check failure, not if WaitForMultipleObjects fails
2024-07-18 15:31:24 +02:00
Armin Novak
d3efbe004d
[client,x11,sdl] fix manpage generation
...
* fix name of xfreerdp manpages
* fix name of sdl-freerdp manpages
2024-07-04 12:11:26 +02:00
akallabeth
711a6603f2
Merge pull request #10267 from akallabeth/sdl-fix
...
[client,SDL2] fix renderer height
2024-06-08 09:43:00 +02:00
akallabeth
221a442270
[client,sdl] keep hotkey state of keyboard grab
...
keep the keyboard grab state from:
1. +/-grab-keyboard command line as default
2. toggle this state by hotkey later on
2024-06-08 09:30:28 +02:00
akallabeth
a6abca5e89
[client,SDL2] fix renderer height
2024-06-08 09:08:49 +02:00
akallabeth
04e3fe0b06
[client,sdl] update manpages
...
* Respect default configuration directory depending on
WITH_FULL_CONFIG_PATH
* Unify manpage files for SDL2 and SDL3
2024-06-06 11:42:09 +02:00
akallabeth
cdc8d62108
[client,sdl] move parsing of hotkeys to constructor
...
* implement that for SDL3 just like for SDL2
* rename members to conform to style of file
2024-06-03 11:05:07 +02:00
Michael Tokarev
f8cb7d86f6
SDL2: sdl_kbd: parse keyboard config once instead of at each keypress
...
Currently, sdl-freerdp.json file is parsed at every keypress, which
is just wrong. Instead, parse it at startup and remember the key
configuration for the whole session.
The same should be done for SDL3 I guess.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
2024-05-30 11:53:48 +03:00
akallabeth
06598da910
[client,sdl] fix resourcemanager
...
due to moving to a static class the C++ initializer did no longer work.
add explicit calls for initializers to ensure the generated classes are
referenced.
2024-05-24 09:46:07 +02:00
akallabeth
2efcf1c436
[client,sdl] Use SDL_CreateWindowAndRenderer
...
Recommendated in https://github.com/libsdl-org/SDL/issues/9076
2024-05-24 08:59:10 +02:00
akallabeth
ff772084e6
[client,sdl] add assignmen and move operator delete
2024-05-16 20:50:07 +02:00
akallabeth
cc038ad89b
[client,sdl] merge SDL2 and SDL3 projects
2024-05-16 20:34:11 +02:00
