akallabeth
1cdc864c7d
[warnings] fix integer narrowing
2024-10-14 10:31:38 +02:00
Martin Fleisz
dcc288c3d1
Merge pull request #10704 from akallabeth/int-narrow-cleanups
...
Int narrow cleanups
2024-10-14 09:51:06 +02:00
akallabeth
7ea8774728
Update timezone definitions
2024-10-12 07:08:14 +00:00
akallabeth
d56fac7582
[ci,timezone] remove clang-format off
...
we do format the files now properly before creating the automated pull,
the workaround is no longer required
2024-10-12 09:04:39 +02:00
akallabeth
969e212570
[winpr,timezone] skip newline in generated timezonemap
2024-10-12 08:51:00 +02:00
akallabeth
2cbb5685b4
[winpr,timezone] deactivate clang-format for generated files
2024-10-11 09:16:37 +02:00
Armin Novak
9531b7b270
[winpr,file] add missing WINPR_ATTR_MALLOC
2024-10-09 10:41:19 +02:00
Armin Novak
8abf9cbe7c
[winpr] mark GNU macros with __extension__
...
mark GNU and clang definition of macros using statement expressions with
__extension__ to silence warnings. We know the compilers support that
and do not use it with others.
2024-10-09 10:09:43 +02:00
akallabeth
2d10effd3c
Merge pull request #10716 from akallabeth/kerberos-return
...
[winpr,sspi] fix kerberos return on get_credentials
2024-10-08 17:26:43 +02:00
akallabeth
1fe0a6f40e
[winpr,sspi] fix kerberos return on get_credentials
...
return SEC_E_NO_CREDENTIALS
2024-10-08 10:33:30 +02:00
akallabeth
1952cd0e66
[winpr,utils] fix undefined unwind symbols
...
on arm some reason codes are not defined.
2024-10-08 10:09:19 +02:00
akallabeth
7e8c374fe2
[winpr,file] make handle creators return const
...
* let the file handle creators return const HANDLE_CREATOR
* for comm port use winpr_definition_add(-DWINPR_HAVE_SERIAL_SUPPORT) to
have the definition visible at correct scope
* create namedPipeClient.h for handle creator function declaration
2024-10-07 10:15:34 +02:00
akallabeth
8ea903091b
[winpr,platform] disable GCC pragma
...
GCC does not support -Wtautological-constant-out-of-range-compare
2024-10-04 16:12:03 +02:00
akallabeth
4fc2e1bb3e
[warnings] fix integer narrowing
2024-10-03 21:21:44 +02:00
akallabeth
4b5274c34f
[warnings] fix integer narrowing
2024-10-03 21:21:44 +02:00
akallabeth
544c6ddce6
[warnings] fix integer narrowing
2024-10-03 21:21:42 +02:00
akallabeth
53497a572d
[warnings] fix integer narrowing
2024-10-03 21:21:42 +02:00
akallabeth
57ed259be2
[warnings] fix integer narrowing
2024-10-03 21:21:41 +02:00
akallabeth
b19dcf8d68
[warnings] fix integer narrowing
2024-10-03 21:21:41 +02:00
akallabeth
eceab9aedb
[warnings] fix integer narrowing
2024-10-03 21:21:40 +02:00
akallabeth
704597937d
[warnings] fix integer narrowing
2024-10-03 21:21:39 +02:00
akallabeth
6c8c67b385
Merge pull request #10677 from akallabeth/int-narrow
...
Int narrow
2024-10-03 21:17:56 +02:00
akallabeth
4783546582
[winpr,wlog] fix integer narrow
2024-10-03 18:58:41 +02:00
akallabeth
8a042b33d6
[winpr,utils] fix integer narrow
2024-10-03 18:58:39 +02:00
akallabeth
4a0f996d42
[winpr,timezone] fix integer narrow
2024-10-03 18:58:37 +02:00
akallabeth
57f69ad77d
[winpr,synch] fix integer narrow
2024-10-03 18:58:34 +02:00
akallabeth
22d1810e12
[winpr,sspi] fix integer narrow
2024-10-03 18:58:32 +02:00
akallabeth
a0dbb901df
[winpr,shell] fix integer narrow
2024-10-03 18:58:29 +02:00
akallabeth
cb2cbdabfe
[winpr,ncrypt] fix integer narrow
2024-10-03 18:58:26 +02:00
akallabeth
a5b80925e2
[winpr,interlocked] fix integer narrow
2024-10-03 18:58:23 +02:00
akallabeth
952076afb7
[winpr,crypto] fix integer narrow
2024-10-03 18:58:21 +02:00
akallabeth
67817886ab
[winpr,clipboard] fix integer narrow
2024-10-03 18:58:13 +02:00
Martin Fleisz
966ddd13df
Merge pull request #10694 from akallabeth/qa-fixes
...
Qa fixes
2024-10-03 13:09:06 +02:00
akallabeth
cfc37caeb8
[cmake] cleaning_configure_file
...
add a wrapper to automatically add generated files to clean target
2024-10-02 23:28:08 +02:00
Armin Novak
1f7ec7324d
[winpr,registry] use HKLM.reg relative to config home
2024-10-02 23:27:57 +02:00
Armin Novak
934cf668a2
[winpr,utils] use sam file relative to config home
2024-10-02 23:27:55 +02:00
Armin Novak
276e3d67e0
[winpr,path] add a function to get WinPR config file paths
2024-10-02 23:27:53 +02:00
Armin Novak
ac0acd0463
[winpr,path] add KNOWN_PATH_SYSTEM_CONFIG_HOME
2024-10-02 23:27:49 +02:00
akallabeth
582ff2c319
[winpr,wincrypt] fix a define typo
2024-10-01 13:05:41 +02:00
akallabeth
f6d71a592e
[winpr,assert] silence tautological-constant-out-of-range-compare
...
we do some assertions that can with correct code never trigger. (check
for a unsinged char > 256, ...)
2024-10-01 13:05:39 +02:00
akallabeth
9c33717522
[winpr,file] fix sign warnings
2024-10-01 13:05:25 +02:00
akallabeth
5f9ef68b07
[warnigs] fixed readability-non-const-parameter
2024-10-01 13:05:23 +02:00
akallabeth
574742bae8
[warnings] annotate readability-non-const-parameter
2024-10-01 13:05:19 +02:00
akallabeth
8a0194c105
[clang-tidy] annotate suspicious-memory-comparison
2024-10-01 13:05:11 +02:00
akallabeth
fa21806734
[winpr,error] fix sign of NTE_* defines
2024-10-01 13:05:04 +02:00
akallabeth
953aa6c436
[winpr,sspi] fix kerberos unused parameter warning
2024-10-01 13:04:35 +02:00
akallabeth
490ca0453b
[winpr,stream] use Stream_BufferAs instead of casting
2024-10-01 10:34:42 +02:00
akallabeth
47c5070805
Merge pull request #10635 from akallabeth/initialize-variables
...
Initialize variables
2024-09-30 16:04:20 +02:00
akallabeth
a820912a24
[winpr,utils] fix sterror_r detection and use
2024-09-30 15:41:50 +02:00
akallabeth
98e11c69c1
[winpr,ncrypt] add pragma to disable warning
2024-09-30 15:41:34 +02:00
akallabeth
9d478c2ce7
[winpr,crt] fix redundant casts
2024-09-30 09:32:04 +02:00
akallabeth
3825fe8135
[warnings] fix Wunreachable-code-break
2024-09-30 09:31:36 +02:00
akallabeth
f529345d84
[warnings] fix Wcast-qual
2024-09-30 09:31:36 +02:00
akallabeth
5e998bb078
[winpr,platfom] fix WINPR_PRAGMA_DIAG_IGNORED_UNUSED_MACRO
2024-09-24 20:35:28 +02:00
akallabeth
26003e59cc
[va_list] initialize with ={0};
2024-09-24 11:06:18 +02:00
akallabeth
42e3c6fff8
[winpr,utils] fix winpr_strerror argument types
...
errno is of type int, so use a signed INT32 as argument type to avoid
warings with sign conversions
2024-09-20 10:57:21 +02:00
akallabeth
632e2180f7
[winpr,stream] rewrite stream read functions
...
Use a loop to shift in bytes to avoid casts.
2024-09-19 09:06:20 +02:00
Armin Novak
46457a5033
[winpr,stream] Add Stream_BufferAs macro
...
* Add Stream_BufferAs, Stream_ConstBufferAs, Stream_GetBufferAs and
Stream_GetPointerAs to get a pointer to the stream pointer or buffer
casted to a specific type.
* Use WINPR_STREAM_CAST in these new macros for proper cast according to
C or C++
2024-09-19 09:06:13 +02:00
Armin Novak
bed6e7968e
[winpr,utils] fix plausibility checks in IniFile_Load_File
2024-09-18 11:47:01 +02:00
Armin Novak
58ea63fd84
[winpr,path] fix comparison of unsigned < 0
2024-09-18 11:47:01 +02:00
akallabeth
e2fbab750b
Merge pull request #10625 from akallabeth/bsd-fix
...
[winpr,library] implement GetModuleFileNameA
2024-09-18 09:45:23 +02:00
akallabeth
347ac5a941
[winpr,library] implement GetModuleFileNameA
2024-09-17 18:01:10 +02:00
akallabeth
586f40631f
[warnings] fix shorten-64-to-32
2024-09-17 16:13:48 +02:00
akallabeth
ca260e13bb
[winpr,asn1] fix sign extraction for ASN1 integer
...
ASN1 integer might not be full 32bit integers, so extract the sign from
the first byte and append 0x80000000 after the rest of the integer was
successfully read.
2024-09-17 10:03:50 +02:00
akallabeth
befa4233ad
[warnings] fixed bugprone-not-null-terminated-result
2024-09-16 08:22:42 +02:00
akallabeth
a19305569d
[assert] fix ULONG_MAX use
...
most of the time this was used to check ULONG limits. Replace with
correct UINT32_MAX
2024-09-16 08:22:40 +02:00
akallabeth
bb242b9a89
[return checks] fix use of WaitForSingleObject
2024-09-16 08:22:37 +02:00
akallabeth
965d231e49
[return checks] fix use of CloseHandle
2024-09-16 08:22:31 +02:00
akallabeth
cd18dea174
[return checks] fix use of unicode functions
2024-09-16 06:48:26 +02:00
akallabeth
94020c183c
[return checks] fix use of ResetEvent
2024-09-16 06:48:09 +02:00
akallabeth
7c8c14294f
[return checks] fix use of ReleaseMutex
2024-09-16 06:48:06 +02:00
akallabeth
7d67b8e204
[return checks] fix use of SetEvent
2024-09-16 06:47:58 +02:00
akallabeth
0d5bc92a2b
[warnings] fix apple iOS/macos
2024-09-15 19:47:13 +02:00
akallabeth
0de75b305c
[warnings] fix unchecked return
2024-09-15 10:19:56 +02:00
akallabeth
8b6091a007
[winpr,wtsapi] improve API usage
...
* Mark WTSVirtualChannelOpen and WTSVirtualChannelOpenEx with
WINPR_ATTR_MALLOC to enforce compiler checks for resource cleanup
* Fix unused result warnings, use the result or cast to (void) where not
requierd
2024-09-14 21:29:31 +02:00
akallabeth
a1cef8dd85
[warnings] silence and fix unused results
2024-09-14 21:29:28 +02:00
akallabeth
65de25205b
[winpr,env] add missing WINPR_ATTR_MALLOC
2024-09-14 21:29:26 +02:00
akallabeth
6327b77461
[winpr,crypto] fix type warnings in test case
2024-09-14 17:39:38 +02:00
akallabeth
dbe92795e3
[winpr,kerberos] fix possible NULL argument to strdup
2024-09-14 08:31:01 +02:00
akallabeth
d5b41bb8a0
[warnings] fix casts
...
* Add macro WINPR_REINTERPRET_CAST to cast (checked) from type A to B
* Fix cast warnings
2024-09-14 08:24:51 +02:00
akallabeth
5a711f5ae4
[winpr,collections] fix cast to float
2024-09-14 08:24:45 +02:00
akallabeth
71080e61b0
[warnings] fix a bunch of them
...
* fix uninitialized variable warnings
* modivy ndr_context_* functions to utilize WINPR_ATTR_MALLOC
* build_krbtgt use winpr_asprintf
* add proper Stream_Write_UINT64_BE
2024-09-14 08:24:28 +02:00
akallabeth
16cec716e0
[strtok] replace function with strtok_s
...
Since strtok is not thread safe replace it with strtok_s (WinPR wrapper
around strtok_r for systems not supporting the ISO function names)
2024-09-13 21:19:17 +02:00
akallabeth
d2641ea55f
[winpr,include] fix reserved-identifier warnings
...
* Remove symbols where possible
* Use #pragma where the symbols are implementing ISO or windows
functions
2024-09-13 14:30:33 +02:00
akallabeth
7ef9345743
Merge pull request #10549 from hardening/rcg2
...
core, channels: client-side remote credential guard
2024-09-13 08:24:14 +02:00
akallabeth
163aec7e2b
[warnings] fix documentation command unknown
2024-09-12 21:21:41 +02:00
akallabeth
fb5934007a
[doxygen] add basic documentation for new API
...
* Add basic documentation for new functions/structs/data types since
3.0.0
2024-09-12 20:09:19 +02:00
akallabeth
98f22d49b9
[CMake] add public headers as INTERFACE target
2024-09-12 18:54:40 +02:00
akallabeth
c84655cd62
[warnings] remove const params
...
Avoid const TYPE* const type declarations
2024-09-12 14:29:25 +02:00
akallabeth
a1a1fc8658
[warnings] fix mismatches between declaration and implementation
2024-09-12 13:32:44 +02:00
akallabeth
f74fd1ab0f
[warnings] silence unused macro warnings
...
* Add WINPR_PRAGMA_DIAG_IGNORED_UNUSED_MACRO
* Silence usages that
2024-09-12 13:30:08 +02:00
akallabeth
f62325d443
[winpr] silence -Wreserved-identifier
...
* Add macro WINPR_PRAGMA_DIAG_IGNORED_RESERVED_IDENTIFIER
* Silence use in wtypes.h.in to avoid false positives
2024-09-12 13:30:05 +02:00
akallabeth
adc4f2abf8
[warnings] fix unused variables
2024-09-12 13:29:58 +02:00
akallabeth
29697ca68d
[winpr,ncryt] fix a memory leak
...
NCryptP11EnumKeys did leak memory under certain conditions
2024-09-12 13:29:55 +02:00
akallabeth
6481993305
[winpr,ncrypt] do not abort test if NCryptEnumKeys fails
2024-09-12 13:29:50 +02:00
akallabeth
f9141fb94b
[winpr,ncrypt] improve logging
2024-09-12 13:29:48 +02:00
akallabeth
e00661d338
[warnings] fix dead store warnings
2024-09-12 13:29:46 +02:00
akallabeth
fa9fff6ed0
[winpr,clipboard] properly define guard function
2024-09-12 09:09:00 +02:00
akallabeth
cc6850bf21
[warnings] fix format nonliteral
...
add pragma to suppress format nonliteral warnings where appropriate
2024-09-12 09:08:53 +02:00
akallabeth
8a990644c0
[warnings] fix missing NULL assert/check
2024-09-12 09:08:51 +02:00
