Commit Graph

3027 Commits

Author SHA1 Message Date
Armin Novak
e009a62f06 Fixed sign-compare warnings 2019-04-05 09:14:35 +02:00
Armin Novak
8bb83f2526 Fixed sign-compare warnings 2019-04-05 09:14:35 +02:00
Armin Novak
1762cd1acb Fixed unchecked return warning. 2019-04-05 09:14:35 +02:00
Armin Novak
54098ab0b5 Fixed unused variable warnings. 2019-04-05 09:14:34 +02:00
Armin Novak
1c24450fe0 Fixed sign-compare warnings, removed internal functions from API 2019-04-05 09:14:34 +02:00
David Fort
058ae0db57
Merge pull request #5273 from akallabeth/mac_compile_warning_fix
Fixed mac compilation warnings.
2019-04-04 18:03:50 +02:00
David Fort
52bce4745f
Merge pull request #5249 from akallabeth/mac_timer_crash_fix
Mac timer crash fix
2019-03-28 19:05:48 +01:00
Ilya Shipitsin
7f97574501 client/Windows/wf_event.c: add missing "break" (#5293)
found by cppcheck

[client/Windows/wf_event.c:464] -> [client/Windows/wf_event.c:468]: (warning) Variable 'xNewPos' is reassigned a value before the old one has been used. 'break;' missing?
2019-03-04 09:17:10 +01:00
DraganNSDK
f002c7429b potential fix for ENTER (modifiers) stuck after CTRL-ALT-ENTER (toggle fullscreen), clearing the buffer in xk_keyboard_update_modifier_keys. (#5280)
* xk_keyboard_update_modifier_keys fixed to clear the buffer.

* removed the xf_keyboard_clear(xfc) fix comments
2019-02-25 12:44:51 +01:00
Armin Novak
9566ae0e90 Fixed mac compilation warnings. 2019-02-21 17:30:12 +01:00
Armin Novak
32ea44c037 Added a proper synthesizer for FileGroupDescriptorW to text/uri-list
The file clipboard delegate needs a base URI to operate on for
systems that are not WIN32. Added that to the context and abort
conversion, if that is not set. (currently not fully implemented)
2019-02-21 16:44:40 +01:00
Armin Novak
3680d9f7d2 Fixed cast warnings from freerdp_load_channel_addin_entry 2019-02-21 13:54:25 +01:00
anbukart
b192171434 Embedded window local fix
Client width and height getting set as 0 when embedded using ParentWindowId setting
2019-02-21 11:03:52 +05:30
Armin Novak
0a95e4aa78 Fixed #5262: Vertical mouse wheel direction and whell step
* Vertical wheel uses the inverted direction of horizontal wheel.
* The wheel step is now calculated from the value provided by wayland.
2019-02-20 08:56:36 +01:00
Armin Novak
aacf5bddc4 Updated rail channel, supporting all new messages. 2019-02-19 15:04:11 +01:00
Armin Novak
2a06366de3 Added autoreconnect for wayland. 2019-02-19 14:12:25 +01:00
David Fort
f0e9c95f44
Merge pull request #5248 from akallabeth/naming_fixes
Replace hard coded xfreerdp program name
2019-02-13 18:45:17 +01:00
Armin Novak
2d4f53ed41 Fixed #5234: Added timer invalidate on application willresignactive 2019-02-12 11:23:56 +01:00
Armin Novak
e758e848a2 Replaced hardcoded xfreerdp program name 2019-02-12 10:58:37 +01:00
Armin Novak
92dfa34619 Replaced hardcoded xfreerdp program name 2019-02-12 10:58:36 +01:00
Mathew Winters
dc5efab715 Resolve Gfx mode missing surface updates from cache. 2019-02-12 14:27:11 +13:00
Armin Novak
fe6296a25f Added support for /smart-sizing:<width>x<height> syntax in wayland client. 2019-02-08 12:49:32 +01:00
Armin Novak
f06b31358f Fixed duplicate log tag definition in wayland client. 2019-02-08 12:11:15 +01:00
Armin Novak
cc050f1413 Fixed conversion range checks and cast for use with cairo 2019-02-08 12:08:30 +01:00
Armin Novak
bb755f1944 Removed unused variables. 2019-02-08 12:08:30 +01:00
Armin Novak
4a3f4ad340 Fixed color format for wayland mouse pointer. 2019-02-08 12:08:30 +01:00
Armin Novak
7413370783 Added mouse pointer scaling. 2019-02-08 12:08:30 +01:00
Armin Novak
8d6a6df48a Implements #5215: Smart sizing using libcairo 2019-02-08 12:08:30 +01:00
Armin Novak
81d7e62642 Fixed broken checks in X11 event (RAIL mode) 2019-02-08 10:46:26 +01:00
Martin Fleisz
6415cfec48
Merge pull request #5131 from akallabeth/cmd_line_error_logging
Added extended error logging for assistance, rdp file and command line parser
2019-02-08 09:11:35 +01:00
Armin Novak
753b9c7ce9 Enable server heartbeat PDU by default. 2019-02-07 10:10:57 +01:00
Armin Novak
7610917a48 Disabled offscreen and bitmap cache by default. 2019-02-07 10:10:57 +01:00
Ilya Shipitsin
fb002574c3 client/common/cmdline.c: remove redundant check
found by cppcheck

[client/common/cmdline.c:390] -> [client/common/cmdline.c:399]: (warning) Identical inner 'if' condition is always true.
2019-02-02 10:22:19 +05:00
Ilya Shipitsin
d1939cfc4f client/Wayland/wlf_cliprdr.c: resolve possible null pointer dereference
found by cppcheck

[client/Wayland/wlf_cliprdr.c:143] -> [client/Wayland/wlf_cliprdr.c:158]: (warning) Either the condition 'clipboard' is redundant or there is possible null pointer dereference: clipboard.
[client/Wayland/wlf_cliprdr.c:163] -> [client/Wayland/wlf_cliprdr.c:178]: (warning) Either the condition 'clipboard' is redundant or there is possible null pointer dereference: clipboard.
2019-02-01 03:50:51 +05:00
David Fort
85161c718f
Merge pull request #5223 from akallabeth/scanbuild_null_fixes
Scanbuild null fixes
2019-01-30 18:22:45 +01:00
Bernhard Miklautz
acebd43acf
Merge pull request #5147 from jphein/master
Clarified defaults of /floatbar flag
2019-01-30 16:26:41 +01:00
Armin Novak
2dab778101 Fixed NULL dereferences and uninitialized values 2019-01-30 16:11:10 +01:00
Armin Novak
87c7ddeda6 Asserting arg->Value to silence clang analyzer NULL argument checks. 2019-01-29 17:24:29 +01:00
Armin Novak
6a1ff5c485 Fixed compiler warnings #5210 2019-01-29 16:22:46 +01:00
Armin Novak
5c930dc4aa Fixed compiler warnings #5210 2019-01-29 16:15:33 +01:00
David Fort
72ad4af356
Merge pull request #5221 from akallabeth/wayland_mouse_cursor
Added wayland mouse cursor
2019-01-29 15:11:38 +01:00
akallabeth
0a8ebcfcac
Merge pull request #5187 from astrand/mingw-part1
Mingw build fixes part1
2019-01-29 10:46:21 +01:00
Armin Novak
2418c43cac Fixed pointer image update. 2019-01-29 09:34:30 +01:00
Armin Novak
23fa6b9182 Added mouse cursor callback stubs. 2019-01-29 09:34:30 +01:00
David Fort
05d9d89796
Merge pull request #5149 from akallabeth/cert_deny
New option to disable user certificate dialog
2019-01-25 16:59:33 +01:00
akallabeth
7d226ca596
Merge pull request #5218 from ckelsel/master
May crash if GetCommandLineW failed
2019-01-25 12:19:56 +01:00
David Fort
343bc8c6e4
Merge pull request #5213 from akallabeth/wayland_and_warning_fixes
Wayland and warning fixes
2019-01-25 11:42:38 +01:00
xie.kunming
b8c64b6bf3 May crash if GetCommandLineW failed 2019-01-25 17:54:25 +08:00
Armin Novak
823411c2f3 Fixed wayland buffer updates
The wayland buffer size always matches the current window size.
That might be different from the actual remote framebuffer size,
to when copying always use the correct strides to avoid distorted
screen content.
2019-01-25 10:49:03 +01:00
akallabeth
8ed0b92928
Merge pull request #5216 from ckelsel/master
change SetTimer elapse from 10 to USER_TIMER_MINIMUM
2019-01-25 10:01:30 +01:00
xie.kunming
84493d0039 If uElapse is less than USER_TIMER_MINIMUM (0x0000000A), the timeout is set to USER_TIMER_MINIMUM. 2019-01-25 16:45:52 +08:00
Armin Novak
86e20d7647 Removed buffer damage tracking in client, let UWAC handle that. 2019-01-24 12:44:21 +01:00
Armin Novak
0cf898e722 Fixed warnings found by compiler and static analysis. 2019-01-24 11:53:52 +01:00
Armin Novak
728cdfd689 Fixed warnings found by compiler and static analysis. 2019-01-24 11:53:52 +01:00
Armin Novak
087390b303 Refactored client clipboard function callbacks for const data pointers. 2019-01-23 16:55:13 +01:00
Armin Novak
891d9760dc Ignore clipboard events if channel not loaded. 2019-01-23 16:01:36 +01:00
Armin Novak
d5b3558402 Added log messages for unusual error events. 2019-01-23 15:56:11 +01:00
Armin Novak
9cdddb7722 Fixed some log messages / missing asserts. 2019-01-23 15:56:11 +01:00
Armin Novak
1cec0e0346 Fixed NULL dereference. 2019-01-23 15:56:11 +01:00
Armin Novak
ca2e8e4bc2 Implemented wayland clipboard. 2019-01-23 15:56:11 +01:00
David Fort
2843f1ad60
Merge pull request #5159 from akallabeth/wayland_display
Implemented wayland display resize channel.
2019-01-23 15:41:42 +01:00
David Fort
4c465e7f16
Merge pull request #5209 from akallabeth/wayland_protocol_update_and_keyboard_inhibit
Wayland protocol update and keyboard inhibit support
2019-01-23 10:02:07 +01:00
Armin Novak
97dfa07578 Fixed duplicated check. 2019-01-22 17:27:17 +01:00
Armin Novak
42ad7a8846 Implemented wayland display resize channel. 2019-01-22 17:27:17 +01:00
Armin Novak
81f1fb934c Implemented keyboard shortcut inhibit support. 2019-01-22 14:27:12 +01:00
Armin Novak
5ef6b71974 Implemented DesktopResize callback for wayland client. 2019-01-22 10:29:08 +01:00
Armin Novak
0b17406eec Unified buffer update and screen refresh on focus 2019-01-18 14:38:51 +01:00
Armin Novak
4f99c2946f Unified mouse coordinate scaling. 2019-01-17 13:44:04 +01:00
Armin Novak
864ad5e681 Ignore unknown keywords for windows and posix type detection.
Eliminates wrong detection in case of an unknown keyword used.
2019-01-16 14:32:19 +01:00
Armin Novak
fc9e88d64f Added flag to silence command line parser logging during detection. 2019-01-16 14:32:19 +01:00
Armin Novak
89f3f7d837 Added extended error logging for assistance, rdp file and command line parser. 2019-01-16 14:32:19 +01:00
Armin Novak
a3cfef4e07 Implemented full mouse support for mac client. 2019-01-10 11:30:36 +01:00
Peter Åstrand (astrand)
6619de070a freerdp_client_set_window_size should not be static
Avoid GCC error, since it is not static according to wf_client.h.
2019-01-09 09:54:31 +01:00
Peter Åstrand (astrand)
fcf59b9c4f Add msimg32 library through CMake
MinGW does not support libs through #pragma comments.
2019-01-09 09:52:27 +01:00
Peter Åstrand (astrand)
30cd1ba1ab Use lowercase for includes and libs
Makes build possible on case sensitive systems such as MinGW on Linux.
2019-01-09 09:36:28 +01:00
Ilya Shipitsin
4403448a77 client/Windows/wf_cliprdr.c: remove redundant check
found by cppcheck

[client/Windows/wf_cliprdr.c:2556] -> [client/Windows/wf_cliprdr.c:2561]: (warning) Identical condition '!clipboard', second condition is always false
2019-01-07 22:55:08 +05:00
Martin Fleisz
aa442de059
Merge pull request #5174 from chipitsine/master
resolve several issues found by cppcheck
2019-01-07 15:21:46 +01:00
Armin Novak
b2ef3e69ca Fixed Wayland horizontal mouse wheel direction. 2019-01-07 10:02:04 +01:00
Armin Novak
2dcc2614d4 Fixed X11 horizontal mouse wheel direction. 2019-01-07 10:01:46 +01:00
Ilya Shipitsin
bdc039e719 resolve several issues found by cppcheck
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:796]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:797]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:798]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[libfreerdp/codec/dsp.c:1156] -> [libfreerdp/codec/dsp.c:1154]: (warning) Either the condition '!srcFormat' is redundant or there is possible null pointer dereference: srcFormat.
[channels/drdynvc/client/drdynvc_main.c:1453] -> [channels/drdynvc/client/drdynvc_main.c:1450]: (warning) Either the condition '!drdynvc' is redundant or there is possible null pointer dereference: drdynvc.
[channels/audin/client/opensles/audin_opensl_es.c:98] -> [channels/audin/client/opensles/audin_opensl_es.c:94]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
[channels/audin/client/opensles/audin_opensl_es.c:159] -> [channels/audin/client/opensles/audin_opensl_es.c:153]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
2019-01-02 20:35:24 +05:00
kunming.xie
3ef6dd2f7c fix button_set_locked no return statement 2018-12-24 14:52:59 +08:00
Armin Novak
1984f73db8 Implemented horizontal mouse wheel for wayland. 2018-12-18 13:49:13 +01:00
Armin Novak
f647e5cc3f Implemented mouse buttons 4 and 5 for wayland. 2018-12-18 13:49:08 +01:00
Armin Novak
b60045af27 New option to disable user certificate dialog
The new option +cert-deny aborts a connection automatically if
the certificate can not be validated by OpenSSL or via known hosts.
2018-12-14 10:17:52 +01:00
Jeffrey Hein
d316e7fa1e
Clarified defaults of /floatbar flag 2018-12-13 14:02:38 -08:00
Jeffrey Hein
1e84f00ef8
Added help description for /drive:hotplug,* 2018-12-12 11:29:58 -08:00
Armin Novak
717b0eac9e Enable smooth fonts by default. 2018-12-11 13:02:26 +01:00
Bernhard Miklautz
6f6c8473a1
Merge pull request #5126 from akallabeth/x11_button_mapping
X11 extended button remapping support.
2018-12-11 08:53:39 +00:00
Armin Novak
0fa9f06565 Modified flag checks to avoid invalid flag sets. 2018-12-11 09:34:07 +01:00
Martin Fleisz
29e2e2221d
Merge pull request #5083 from akallabeth/mac_client_fixes
Mac client fixes
2018-12-11 09:19:46 +01:00
Bernhard Miklautz
b3ff75b594 fix [client/Mac]: UI API needs to be called in main thread
With recent SDKs the view won't update it the UI API is called
from a different thread.
2018-12-11 08:33:14 +01:00
Armin Novak
2ce04069cb Fixed crashes in rail mode after merge of floatbar fixes. 2018-12-10 15:41:20 +01:00
Armin Novak
7102927548 X11 extended button remapping support.
Up until now X11 mouse button remapping was only possible for the
default buttons 1 to 3.
With this pull any X11 mouse button can be mapped to any RDP mouse
event and all X11 remappings are respected.
2018-12-10 15:03:29 +01:00
Martin Fleisz
b82c4f779a
Merge pull request #5020 from akallabeth/floatbar_fixes
Floatbar fixes and windows support
2018-12-10 14:45:10 +01:00
Armin Novak
15011b478d Fixed variable hiding by not redeclaring it in subscope. 2018-12-10 14:31:38 +01:00
Armin Novak
0d3192b9f7 Fixed rail window key hash function to work with UINT32 2018-12-10 11:16:43 +01:00
akallabeth
2927114e7b
Merge pull request #5117 from hardening/rail_hash
rails: allow a window with id == 0
2018-12-10 10:26:52 +01:00
David Fort
88e361fa00 rails: allow a window with id == 0 2018-12-08 00:32:00 +01:00
Armin Novak
9166df355b Fixed windows floatbar title. 2018-12-07 15:50:24 +01:00
Armin Novak
4fd8987f5d Unified windows client window title settings. 2018-12-07 15:22:28 +01:00