Commit Graph

18596 Commits

Author SHA1 Message Date
akallabeth
3b108f1839 [core,proxy] ignore empty variable
fixes #9928: ignore a defined but empty proxy environment variable
2024-03-04 14:28:38 +01:00
akallabeth
4b2e192869 [ci] update workflows
* disable codeql schdeuled job
* fix abi-checker scheduled job base reference
2024-03-04 14:27:45 +01:00
David Fort
aebe9742e0 [client,win32] Child session fixes
It seems like WaitFor[Single|Multiple]Object calls aren't reliable on pipes, especially
on the pipe opened for childSession access. The object can be marked as signaled even if
no data is available, making the connection laggy and unresponsive (nearly unusable in some
cases).
This patch works around that by using ReadFileEx() with overlapped instead of simple
ReadFile() and use asynchronous reads.
2024-03-01 09:46:53 +01:00
akallabeth
96c090f182 [ci,mingw] turn off shadow server 2024-02-27 17:39:49 +01:00
akallabeth
3474a21f99 [readme] use clang-tidy status badge from pull_request_target 2024-02-27 17:05:52 +01:00
akallabeth
cdd1be7e1d [ci,mingw] deactivate server builds
the shadow and platform server modules are not finished and use APIs
that mingw does not properly support
2024-02-27 17:05:52 +01:00
akallabeth
f2d7d38973 [ci,mingw] simplify openh264 build 2024-02-27 16:33:39 +01:00
akallabeth
573fdf0608 [ci,mingw] use posix toolchain
we require std::thread, std::mutex, ... which mingw does not provide
unless the -posix toolchain are used.
2024-02-27 16:14:33 +01:00
akallabeth
9e0c0fd5e1 [ci,abi] expose rdtk and uwac
we did not have them statically compilable with 3.0.0, so keep them
shared to make check-abi happy
2024-02-27 16:14:33 +01:00
akallabeth
6483ca29d2 [ci,mingw] add git, meson and cmake deps 2024-02-27 15:30:53 +01:00
akallabeth
7c320056b3 [ci,abi] add suppressions 2024-02-27 15:30:53 +01:00
akallabeth
721c1b9fcd add mingw badge 2024-02-27 14:46:35 +01:00
akallabeth
3086869bf2 [ci,mingw] add ninja to deps 2024-02-27 14:46:35 +01:00
akallabeth
d8c0e7546e [winpr,utils] allow quoted sub arguments
fixes #9890.
2024-02-27 14:15:56 +01:00
akallabeth
9a7d30d174 [clang,tidy] fix a few warnings 2024-02-27 14:15:43 +01:00
akallabeth
43a70ccb90 [client,sdl] use std::filesystem u8string() 2024-02-27 14:10:14 +01:00
akallabeth
c0e3a00502 [ci] add weekly workflow run and status badges 2024-02-27 14:10:14 +01:00
akallabeth
cc427103eb mingw builder workflow 2024-02-27 14:10:14 +01:00
akallabeth
b1cf556cb2 mingw build script 2024-02-27 14:10:14 +01:00
akallabeth
6b5ed8e36a [ci,abi] only check out pull request on trigger 2024-02-27 09:11:16 +01:00
akallabeth
c61fc2a0fa [server,shadow] improve shadow help and startup checks
a SAM file is required for the shadow server to work if NLA is
activated. Better document that and abort startup if no file is
available.
2024-02-26 20:59:39 +01:00
akallabeth
ff353d8f2f [ci,abi] fix checkout for pull_request_target 2024-02-26 20:53:26 +01:00
akallabeth
b791a74e07 [ci,api] fetch complete history 2024-02-26 20:53:26 +01:00
akallabeth
c125ebf8fc [ci,abi] fix workflow 2024-02-26 18:49:57 +01:00
akallabeth
c9f7b7d05c [ci,abi] simplify run 2024-02-26 14:39:15 +01:00
akallabeth
8345838bcc Update abi-checker.yml 2024-02-26 14:18:26 +01:00
akallabeth
fd77b7f044 [ci,abi] fix workflow 2024-02-26 13:32:47 +01:00
akallabeth
0ffe787d5f workflow abi-checker 2024-02-26 13:05:46 +01:00
akallabeth
f10e8e9fa1 [client,common] fix help printing
do not drop characters on linebreaks.
fixes #9899
2024-02-26 10:26:58 +01:00
akallabeth
67f1376b52 [server,win] fix undeclared identifier #9900 2024-02-26 10:26:58 +01:00
amazingfate
e21afefb86 fix build with openssl < 1.1.1 2024-02-23 12:45:36 +01:00
akallabeth
4b2d877bf3 [core,transport] document and fix transport_attach
* [transport_default_attach] Only attach provided socket once the
  function can no longer fail
* [transport_attach] document behaviour
2024-02-23 11:02:06 +01:00
Rubycat
3c2c6cc1d5 don't close freerdp_peer underlying socket twice
freerdp_peer->Disconnect calls BIO_free which then calls close on the
underlying file descriptor.

Then when freerdp_peer_free is called, the file descriptor is closed
again.

This is problematic if the file descriptor is recycled in between:

thread 1: freerdp_peer_new(42);
thread 1: freerdp_peer->Disconnect() closes 42
thread 2: opens a file with fd 42
thread 1: freerdp_peer_free closes 42
thread 2: uses closed file descriptor 42
2024-02-23 11:02:06 +01:00
akallabeth
4be2e2db2d [ci] undate ci scripts
* remove obsolete configurations
* enable manpage generation
2024-02-23 10:02:08 +01:00
akallabeth
f84108010b [client,sdl] use uint32_t instead of SDL_Keymod
the SDL_Keymod enum is not suitable to hold a mask of SDL_Keymod values
2024-02-23 10:02:08 +01:00
akallabeth
517cd69107 [client,sdl] remove not existing docbooc xml 2024-02-23 10:02:08 +01:00
akallabeth
f5704e025f start development cycle 3.3.1-dev0 2024-02-22 15:18:30 +01:00
akallabeth
a1d8b55048 update release to 3.3.0 2024-02-22 15:18:30 +01:00
akallabeth
5455ec21c7 changelog 2024-02-22 15:18:30 +01:00
akallabeth
2de926e172 [core,transport] reserve space in rdpTransportIo
For better ABI compatibility reserve some extra space in this public
struct.
2024-02-22 15:18:30 +01:00
akallabeth
a2b220f828 [client,sdl] fix smartcard pin dialog result 2024-02-22 13:13:49 +01:00
akallabeth
5d3ffea061 [client,sdl] unify window related operations
Access window related operations only in SdlWindow class
2024-02-22 13:13:49 +01:00
akallabeth
867e663872 [client,sdl] add windowevent-id to string 2024-02-22 13:13:49 +01:00
akallabeth
8492738b0d [client,sdl] tidy up code 2024-02-22 13:13:49 +01:00
akallabeth
05175d70f0 [tests,gdi] skip failing test cases 2024-02-22 12:31:50 +01:00
akallabeth
acedd305d3 fixed unused-but-set-variable warnings 2024-02-22 12:31:50 +01:00
akallabeth
05e555feb7 fixed unused-variable warnings 2024-02-22 12:31:50 +01:00
akallabeth
43eae6029f [clang-tidy] fix various review warnings 2024-02-22 12:31:50 +01:00
akallabeth
42cfe9bf1a [cmake,test] deactivate TestGdiLine
The test is broken (and has been for a long time), deactivate it.
2024-02-22 12:31:50 +01:00
akallabeth
d7ebec5a65 [tidy] move loop variable declaration to loop 2024-02-22 12:31:50 +01:00