mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[clang-tidy] fix various review warnings

Browse Source
This commit is contained in:
akallabeth 2024-02-15 13:10:45 +01:00 committed by akallabeth
parent 42cfe9bf1a
commit 43eae6029f
6 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/Windows/wf_gdi.c
View File

@ -135,7 +135,7 @@ static BYTE* wf_glyph_convert(wfContext* wfc, int width, int height, const BYTE*
for (int indexy = 0; indexy < height; indexy++)
{
BYTE* dst = cdata + indexy * dst_bytes_per_row;
BYTE* dst = &cdata[1ull * indexy * dst_bytes_per_row];
for (int indexx = 0; indexx < dst_bytes_per_row; indexx++)
{

4
libfreerdp/codec/color.c
View File

@ -59,7 +59,7 @@ BYTE* freerdp_glyph_convert(UINT32 width, UINT32 height, const BYTE* data)
for (UINT32 y = 0; y < height; y++)
{
const BYTE* srcp = data + (y * scanline);
const BYTE* srcp = &data[1ull * y * scanline];
for (UINT32 x = 0; x < width; x++)
{
@ -767,7 +767,7 @@ static BOOL freerdp_image_copy_overlap(BYTE* pDstData, DWORD DstFormat, UINT32 n
/* Copy up */
else if (nYDst > nYSrc)
{
for (INT32 y = nHeight - 1; y >= 0; y--)
for (INT32 y = (INT32)nHeight - 1; y >= 0; y--)
{
const BYTE* srcLine =
&pSrcData[(y + nYSrc) * nSrcStep * srcVMultiplier + srcVOffset];

2
libfreerdp/primitives/test/TestPrimitivesColors.c
View File

@ -81,7 +81,7 @@ static BOOL test_RGBToRGB_16s8u_P3AC4R_func(prim_size_t roi, DWORD DstFormat)
if (memcmp(out1, out2, dstStride * roi.height) != 0)
{
for (UINT64 i = 0; i < roi.width * roi.height; ++i)
for (UINT64 i = 0; i < 1ull * roi.width * roi.height; ++i)
{
const UINT32 o1 = FreeRDPReadColor(out1 + 4 * i, DstFormat);
const UINT32 o2 = FreeRDPReadColor(out2 + 4 * i, DstFormat);

2
libfreerdp/primitives/test/TestPrimitivesYCoCg.c
View File

@ -69,7 +69,7 @@ static BOOL test_YCoCgRToRGB_8u_AC4R_func(UINT32 width, UINT32 height)
if (memcmp(out_c, out_sse, dstStride * height) != 0)
{
for (size_t i = 0; i < width * height; ++i)
for (size_t i = 0; i < 1ull * width * height; ++i)
{
const UINT32 c = FreeRDPReadColor(out_c + 4 * i, format);
const UINT32 sse = FreeRDPReadColor(out_sse + 4 * i, format);

2
server/Windows/wf_info.c
View File

@ -310,7 +310,7 @@ void wf_info_find_invalid_region(wfInfo* wfi)
GETCHANGESBUF* buf;
buf = (GETCHANGESBUF*)wfi->changeBuffer;
for (int i = wfi->lastUpdate; i != wfi->nextUpdate; i = (i + 1) % MAXCHANGES_BUF)
for (ULONG i = wfi->lastUpdate; i != wfi->nextUpdate; i = (i + 1) % MAXCHANGES_BUF)
{
LPRECT lpR = &buf->buffer->pointrect[i].rect;

3
winpr/libwinpr/sysinfo/cpufeatures/cpu-features.c
View File

@ -428,7 +428,8 @@ static void cpulist_parse(CpuList* list, const char* line, int line_len)
*/
while (p < end && *p != '\n')
{
int start_value, end_value;
int start_value = 0;
int end_value = 0;
/* Find the end of current item, and put it into 'q' */
q = memchr(p, ',', end - p);