Commit Graph

19390 Commits

Author SHA1 Message Date
akallabeth 2170cc65e3
[warnings] cast return of fprintf (void)
fprintf returns a value. Not using it is mostly fine, but it generates
noise when compiling with all warnings on, so cast to (void)
2024-09-06 09:16:21 +02:00
akallabeth 590fbcf005
Merge pull request #10564 from hardening/sdl3_fix
sdl3: fix build with last version of SDL3
2024-09-05 21:51:44 +02:00
akallabeth 749023bacb
Merge pull request #10555 from akallabeth/cast-fix-tls
[crypto,tls] simplify function pointer cast
2024-09-05 17:18:27 +02:00
David Fort 3a9a820092 sdl3: fix build with last version of SDL3 2024-09-05 14:57:11 +02:00
David Fort d0cfd3b502
Merge pull request #10561 from akallabeth/clang-tidy-macro
[clang-tidy] disable bugprone-macro-parentheses
2024-09-05 09:25:53 +02:00
akallabeth ec26c8c168
[clang-tidy] disable bugprone-macro-parentheses
this check has too many false positives (when the macro arguments are
types for example) so disable this.
2024-09-05 08:45:02 +02:00
akallabeth 7d48aee829
Merge pull request #10556 from akallabeth/stream-api-improve
[winpr,stream] add returning stream read/peek
2024-09-05 08:40:15 +02:00
akallabeth 8fd724b7b6
Merge pull request #10560 from akallabeth/warn-fix
Warn fix
2024-09-05 08:39:53 +02:00
akallabeth c670eda6eb
Merge pull request #10559 from akallabeth/clip-endian
[winpr,clipboard] use endian safe bitmap read/write
2024-09-04 22:24:55 +02:00
akallabeth b9202bd0b1 [clang-tidy] disable cert-dcl50-cpp
we do want to use variadic macros in C++ code as we interface with C
2024-09-04 22:20:59 +02:00
akallabeth e3f94e6622 nodiscard 2024-09-04 22:17:35 +02:00
akallabeth 64a0d87c98 fix missing prototype 2024-09-04 22:15:38 +02:00
akallabeth 798421e883 fix missing static for functions 2024-09-04 22:12:32 +02:00
akallabeth 9ae37b094f fix implicit widening of multiplication result 2024-09-04 22:01:09 +02:00
akallabeth 8b92e17e60 modernize includes 2024-09-04 22:00:12 +02:00
akallabeth b980bf2e14
[winpr,clipboard] use endian safe bitmap read/write 2024-09-04 21:56:44 +02:00
akallabeth 6a1c3b4545
[function pointer] use macro for GetProcAddress
Cast all results of GetProcAddress with WINPR_FUNC_PTR_CAST
2024-09-04 21:31:48 +02:00
akallabeth 889ae65a1f
[warnings] add WINPR_CAST_CONST_PTR_AWAY
simple macro casting a const pointer to a non const one.
2024-09-04 20:55:17 +02:00
akallabeth 245afb706c
[function pointers] unify casts with macro 2024-09-04 20:06:45 +02:00
akallabeth 1a9766e190
[warnings] fix function pointer casts 2024-09-04 20:06:43 +02:00
akallabeth 9776cc109e
[crypto,tls] simplify function pointer cast 2024-09-04 20:06:40 +02:00
akallabeth a82821b756
[winpr,stream] fix return value
signed int functions should not return unsigned values
2024-09-04 13:17:50 +02:00
akallabeth d959121b2f
[winpr,stream] add returning stream read/peek
To make use easier add Stream functions that return the value read
instead of taking it as argument.
2024-09-04 13:17:43 +02:00
akallabeth 5aff241096
Merge pull request #10554 from akallabeth/tidy-silence
Tidy silence
2024-09-04 10:35:22 +02:00
akallabeth 9df86daf28
[winpr,comm] add missing includes 2024-09-04 10:14:07 +02:00
akallabeth 5e123735fa
[warnings] fixed sign-compare 2024-09-04 10:14:05 +02:00
akallabeth 3eb905cfb1
Merge pull request #10553 from akallabeth/tables-fn-fix
[channels] fix function pointer casts
2024-09-04 10:13:02 +02:00
akallabeth b6e72c7674
Merge pull request #10551 from akallabeth/arch-fixes
Arch fixes
2024-09-04 09:56:35 +02:00
akallabeth 2fc791fe9b [client,X11] fix shadowed variable 2024-09-04 09:45:00 +02:00
akallabeth 3e933203e2 [crypto,tls] fix bad-function-cast
do silence the compiler warning and add a comment why we do that.
2024-09-04 09:41:53 +02:00
akallabeth ff62730419
[channels] fix function pointer casts
* Cast freerdp_load_channel_addin_entry return with a union (removes the
  incompatible function pointer cast warnings)
* Typedef function pointers in tables.h
2024-09-04 09:12:41 +02:00
akallabeth c851dfcb7f
Merge pull request #10546 from akallabeth/sign-compare-fix
Sign compare fix
2024-09-04 09:11:50 +02:00
akallabeth ebbfe598dc
[winpr,utils] unify bitmap reading
* clipboard synthesizer needs to read the bitmap header, use the function
  from utils/image
* check bitmap header in utils/image and abort if wrong
2024-09-04 09:07:18 +02:00
akallabeth c5f346488f
[crypto,tls] revert const argument
with some build options this needs to be writeable.
2024-09-04 09:03:21 +02:00
akallabeth 16d6c3b795
[clang-tidy] disable modernize-return-braced-init-list
this check does not work well with older C++ standards
2024-09-03 17:41:02 +02:00
akallabeth 9a027833b9
[warnings] fix misplaced widening cast 2024-09-03 17:40:55 +02:00
akallabeth fe6d861a5c
[channels] fix VCAPITYPE for all channel entry points 2024-09-03 17:26:58 +02:00
akallabeth 491c884c7a
[cmake] remove casts from tables.c 2024-09-03 15:15:08 +02:00
akallabeth b77d6e8550
[channels] fix function pointer casts
* Cast freerdp_load_channel_addin_entry return with a union (removes the
  incompatible function pointer cast warnings)
* Typedef function pointers in tables.h
2024-09-03 15:13:58 +02:00
akallabeth f3d84d4557
[warnings] use ARRAYSIZE macro 2024-09-03 15:10:58 +02:00
akallabeth baa70d1ab6
[warnings] fix compare integers of different signs 2024-09-03 15:10:46 +02:00
akallabeth cbeded839d
Merge pull request #10545 from akallabeth/warn-cleanups
Warn cleanups
2024-09-03 13:22:40 +02:00
akallabeth a89aefa8d4
[winpr,smartcard] disable linter warnings
* silenced readability-non-const-parameter warnings that can not be
  changeddue to API requirements
2024-09-03 13:07:16 +02:00
akallabeth 734d4ce43e
[rdtk] fix integer cast warnings 2024-09-03 12:56:21 +02:00
akallabeth ca5a8e0625
[ci,clang-tidy] disable cppcoreguidelines-macro-to-enum 2024-09-03 12:56:13 +02:00
akallabeth 42b078a59d
[emu,scard] smartcard emulation cleanup
* Fix readability-non-const-parameter (disable lint, API requires these
  to be non const)
* Return an appropriate error for functions returning
  SCARD_E_UNSUPPORTED_FEATURE if there is a parameter wrong
* Remove unused functions
2024-09-03 12:24:55 +02:00
akallabeth 5a4a1a40ad
fix declaration and implementation parameter names 2024-09-03 12:24:53 +02:00
akallabeth f7fd817d1c
[warnings] fix redundant casting 2024-09-03 12:24:51 +02:00
akallabeth 72ae7fb54f
[nolint] add cert-dcl37-c,cert-dcl51-cpp 2024-09-03 12:24:48 +02:00
akallabeth 852e0c1450
[common,assistance] fix shadowed variable 2024-09-03 12:17:33 +02:00