Armin Novak
33be80cb41
Removed unused variables.
2018-08-24 13:40:36 +02:00
Ondrej Holy
83e966d9e2
core/gateway/rpc: Fix leak found by covscan
...
0 is valid return value from socket().
leaked_storage: Variable "auth_3_pdu" going out of scope leaks the storage it points to.
leaked_storage: Variable "response" going out of scope leaks the storage it points to.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
2018-08-22 14:34:02 +02:00
Ondrej Holy
6de583e137
core/gateway/rpc: Format code by astyle
...
Run ./scripts/format_code.sh before the following changes.
2018-08-22 14:34:02 +02:00
Ondrej Holy
409e192334
core/gateway/rdg: Fix leak found by covscan
...
leaked_storage: Variable "request" going out of scope leaks the storage it points to.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
2018-08-22 14:34:02 +02:00
Armin Novak
ec0a0fef2a
Added const to function buffer pointers
2018-08-01 12:56:18 +02:00
Pascal J. Bourguignon
15f2bafeab
Cleaned up const char** -> char** for argv, since we definitely do modify the argv!
...
(we overwrite the password and pin arguments).
This implies changes in the argument parsing tests that now must pass a mutable argv
(copied from the statically declared test argvs).
Some other const inconsistency have been dealt with too.
2018-06-06 16:43:09 +02:00
Armin Novak
d4c98e4e71
Fixed formatting.
2018-05-03 12:30:40 +02:00
Armin Novak
5765e9a422
Fixed #4476 : broken casts/variable sizes for custom BIO calls.
2018-05-03 12:30:40 +02:00
Martin Fleisz
296b19e172
Merge pull request #4596 from p-pautov/rdg_ssl_fixes
...
RDG related fixes for better compatibility with mstsc
2018-05-03 10:23:12 +02:00
akallabeth
2215071b23
Merge pull request #4576 from ccpp/bugfix-rdg-poll
...
Fix polling in RDG
2018-05-02 17:59:10 +02:00
David Fort
0f968b782c
proxy: cleanup SOCKS support and add user/password support
2018-05-02 10:51:16 +02:00
Pavel Pautov
a0019ec79c
Fallback to RDG RPC transport only if server does not support RDG HTTP and
...
error out in other cases - invalid RDG SSL cert, bad credentials, PAA failue, etc.
2018-04-25 18:36:43 -07:00
Christian Plattner
4a19f49878
Fail on unimplemented BIO_ctrl for /gt:rpc
2018-04-24 20:45:52 +02:00
Christian Plattner
4739189cfc
Implement BIO_ctrl more correctly for RDG
...
See #3602
This change is discussed in https://github.com/FreeRDP/FreeRDP/pull/4576#pullrequestreview-113381733
2018-04-24 16:47:33 +02:00
Christian Plattner
a15644365e
Fix BIO_get_fd for RDG, again.
2018-04-18 21:50:47 +02:00
Christian Plattner
f9d036a874
Fix #3602 by implementing BIO_get_fd correctly for RDG
2018-04-18 10:47:06 +02:00
Pavel Pautov
c866923897
Avoid buffer to struct cast.
2018-04-16 19:06:16 -07:00
Pavel Pautov
8fc0ea7199
Send correct packet size in case of PAA. Some cleanup.
2018-04-16 19:06:16 -07:00
Pavel Pautov
bbee19ced2
Content-Length and Transfer-Encoding are mutually exclusive.
2018-04-16 19:06:16 -07:00
Pavel Pautov
ec42228b2a
Consolidate IN/OUT data connections establishment into common function and clean up related code.
2018-04-16 19:06:16 -07:00
Pavel Pautov
00256bba1d
Move NTLM auth related code into dedicated functions.
2018-04-16 19:06:16 -07:00
Pavel Pautov
269dec6377
Consolidate rdg_tls_out_connect/rdg_tls_in_connect into single function. This also fixes connections to RDG server via proxy.
2018-04-16 19:06:13 -07:00
Pavel Pautov
e639e2caf3
Removed unused "readEvent" - no one checks if it was set.
...
Removed needless rdg_check_event_handles declaration.
2018-04-16 16:05:40 -07:00
Pavel Pautov
1530bcf916
Consolidate rdg_send_in_channel_request/rdg_send_out_channel_request into single function.
2018-04-16 16:05:40 -07:00
Pavel Pautov
0fbf8f8957
Explicitly skip "seed" payload on RDG OUT connection, to avoid issues when it's split over several SSL records.
2018-04-16 16:05:40 -07:00
Pavel Pautov
44cb710496
Moved some repeated "read all" code into function.
2018-04-16 16:05:40 -07:00
Andre Esteve
d240069b5e
Gateway (RDG) use same IP for both channels
2018-04-10 20:59:33 -07:00
Armin Novak
3f1ef0efc6
Removed unnecessary range check.
2018-04-04 10:45:32 +02:00
Jacco Braat
2af67baea3
Modified RDG connection setup using PAA Cookie.
...
Skip NTLM auth on the IN/OUT channels. Add PAACookie to TUNNEL_CREATE.
2018-02-15 10:56:58 +01:00
Armin Novak
92c62b1dbf
Fixed #4436 : double free of http response.
...
Fixed #4436 : reset of token split.
2018-02-14 14:29:08 +01:00
Armin Novak
990b8c23a9
Fixed PubSub function pointer casts.
2018-02-14 11:00:52 +01:00
David Fort
6e5d86f332
http: fix compilation with valgrind memcheck helpers
2018-02-14 10:16:38 +01:00
Armin Novak
20b4b286f0
Fixed strtoull not supported on windows.
2018-01-16 08:15:34 +01:00
Armin Novak
a49a2299b1
Refactored http parser
...
* Using single buffer for all data
* Added response size limit of 64MiB
* Fixed various memory leaks
2018-01-15 16:51:33 +01:00
Armin Novak
c3f008c36c
Functions static where appropriate.
2018-01-15 13:22:01 +01:00
David Fort
41823080f9
Fix users of Stream_GetPosition() that returns size_t
2017-12-11 22:38:58 +01:00
Armin Novak
4eb5b8e349
Replaced atoi
2017-11-15 15:52:16 +01:00
dodo040
e0a9999fb2
fix: GSS API init, enterprise name management, variable names and format code
2017-11-13 16:20:56 +01:00
dodo040
b81f168f0e
initial commit for kerberos support
2017-11-13 16:20:55 +01:00
Armin Novak
8b9e3fa51e
Fixed use of reserved keywords for include guards.
2017-07-20 09:35:41 +02:00
Armin Novak
0490aeb018
Fixed clang malloc integer overflow warnings.
2017-07-20 09:29:48 +02:00
David Fort
17a4e95a5b
Drop some annoying warning
...
Probably that some unused functions should be removed, but at least it makes
it compile with no warnings.
2017-05-12 13:54:16 +02:00
Armin Novak
99c45405cb
Fixed GetEnvironmentVariable.
2017-03-03 12:43:00 +01:00
Armin Novak
b2c29158be
Scanbuild warning, argument checks and leak fixes.
...
* Added Stream_GetRemainingCapacity to check remaining stream size
before writes.
* Fixed shadow server memory leak.
* Fixed lots of scanbuild warnings
* Added missing argument checks in many functions
* Added missing static function declarations
2017-03-02 18:13:43 +01:00
Armin Novak
a1003ab6f0
Fixed scanbuild warnings.
2017-02-20 14:12:39 +01:00
akallabeth
3762401d43
Merge pull request #1750 from ccpp/master
...
Support for HTTP-Proxy
2017-01-11 11:02:00 +01:00
Martin Fleisz
ac090520c3
Fix compilation with OpenSSL 1.1.0 using MSVC
2017-01-09 16:43:28 +01:00
Norbert Federa
f71b6b46e8
fix string format specifiers
...
- fixed invalid, missing or additional arguments
- removed all type casts from arguments
- added missing (void*) typecasts for %p arguments
- use inttypes defines where appropriate
2016-12-16 13:48:43 +01:00
Christian Plattner
58ef7cc42d
More abstracted proxy handling
2016-12-10 23:13:35 +01:00
Christian Plattner
5d10b3bf5b
Merge branch 'gateway-http-bugfix'
...
Conflicts:
client/common/cmdline.c
include/freerdp/settings.h
libfreerdp/common/settings.c
libfreerdp/core/settings.c
libfreerdp/core/tcp.c
libfreerdp/core/transport.c
2016-12-09 20:43:02 +01:00