Commit Graph

18525 Commits

Author SHA1 Message Date
akallabeth
1197384315 [coverity] 1543218 Resource leak 2024-04-11 12:04:07 +02:00
akallabeth
fbc5dfffac [coverity] 1543183 Resource leak 2024-04-11 12:04:07 +02:00
akallabeth
8bef31fdae [coverity] 1543108 Resource leak 2024-04-11 12:04:07 +02:00
akallabeth
18b4c59d17 [coverity] 1543107 Resource leak 2024-04-11 12:04:07 +02:00
akallabeth
88bea503fc [coverity] 1543087 Resource leak 2024-04-11 12:04:07 +02:00
akallabeth
843ecfc01a [coverity] 1543172 Pointer to local outside scope 2024-04-11 12:04:07 +02:00
akallabeth
55aa202ff5 [coverity] 1543037 Out-of-bounds read 2024-04-11 12:04:07 +02:00
akallabeth
80c562d040 [coverity] 1543235 Out-of-bounds access 2024-04-11 12:04:07 +02:00
akallabeth
61e0d122b7 [coverity] 1543235 Out-of-bounds access 2024-04-11 12:04:07 +02:00
akallabeth
3997eeb5b3 [coverity] 1543227 Readlink used insecurely 2024-04-11 12:04:07 +02:00
akallabeth
3b04ab95d4 [coverity] 1543146 Use after free 2024-04-11 12:04:07 +02:00
akallabeth
b4fb4161d9 [coverity] 1088726 Resource leak 2024-04-11 12:04:07 +02:00
akallabeth
b7f369bfe0 [coverity] 1543063 Out-of-bounds access 2024-04-11 12:04:07 +02:00
akallabeth
c831717cb0 [coverity] 1543129 Uninitialized scalar variable 2024-04-11 12:04:07 +02:00
akallabeth
2fefc29249 [coverity] 1543164 Free of address-of expression 2024-04-11 12:04:07 +02:00
akallabeth
9768a5f48f [coverity] 1543257 Buffer not null terminated 2024-04-11 12:04:07 +02:00
akallabeth
1473931ecd [coverity] 1543220 Double free 2024-04-11 12:04:07 +02:00
akallabeth
1affbd0655 [coverity] 1543285 Resource leak 2024-04-11 12:04:07 +02:00
akallabeth
1e325dc2de [core,settings] add missing autoreconnect option
Split settings, there was a double use for AutoReconnectEnabled.
AutoReconnectEnabled is a setting responsible for client side
autoreconnection.
AutoReconnectPacketSupported is a flag set by the server to announce
support for AutoReconnectPacket allowing fast reconnect.
2024-04-11 11:19:18 +02:00
Martin Fleisz
14cdd6a105 location: Increase buffer size for printing channel info
The current buffer size of 32 bytes was too small to hold the version
info string which resulted in a non-null terminated buffer (_snprintf
does not null-terminate the buffer if it is too small) being printed.
2024-04-11 11:18:43 +02:00
akallabeth
2b7146575f recreate codeql.yml 2024-04-11 11:04:08 +02:00
Ilya Shipitsin
be9df8d62b CI: add coverity scheduled workflow 2024-04-11 09:01:25 +02:00
Armin Novak
f6a18d142d [packaging,rpm] fix excludes 2024-04-10 11:22:36 +02:00
Ilya Shipitsin
1f3a49c57a libfreerdp/utils/http.c: fix resource leak
found by coverity

128                if (winpr_asprintf(&headers, &size, post_header_fmt, path, hostname, blen) < 0)

CID 424888: (#1 of 1): Resource leak (RESOURCE_LEAK)
15. leaked_storage: Variable hostname going out of scope leaks the storage it points to.
129                        return FALSE;
130        }
2024-04-08 11:39:20 +02:00
Ilya Shipitsin
822537be0e channels/cliprdr/client/cliprdr_main.c: fix resource leak
found by coverity

655        if (Stream_Write_UTF16_String_From_UTF8(s, tmpDirCharLen - 1, tempDirectory->szTempDir,
656                                                ARRAYSIZE(tempDirectory->szTempDir), TRUE) < 0)

CID 424748: (#1 of 1): Resource leak (RESOURCE_LEAK)
9. leaked_storage: Variable s going out of scope leaks the storage it points to.
657                return ERROR_INTERNAL_ERROR;
658        /* Path must be 260 UTF16 characters with '\0' termination.
659         * ensure this here */
2024-04-08 11:39:20 +02:00
Ilya Shipitsin
c7954ad0f3 channels/urbdrc/client/data_transfer.c: fix resource leak
found by coverity

705        if (transferDir == USBD_TRANSFER_DIRECTION_OUT)
706        {
      18. Condition !Stream_CheckAndLogRequiredLengthEx("com.freerdp.channels.urbdrc.client" /* "com.freerdp.channels.urbdrc.client" */, 3, s, OutputBufferSize, 1, "%s(%s:%zu)" /* "%s(%s:%zu)" */, <anonymous>, "/home/runner/work/FreeRDP/FreeRDP/channels/urbdrc/client/data_transfer.c", 707UL /* (size_t)707 */), taking true branch.
707                if (!Stream_CheckAndLogRequiredLength(TAG, s, OutputBufferSize))

CID 424733: (#1 of 1): Resource leak (RESOURCE_LEAK)
19. leaked_storage: Variable out going out of scope leaks the storage it points to.
708                        return ERROR_INVALID_DATA;
709                Stream_Copy(s, out, OutputBufferSize);
710        }
2024-04-08 11:39:20 +02:00
akallabeth
b3d8434578 [ci] do not run clang-tidy by scheduler 2024-04-08 11:38:02 +02:00
akallabeth
4b1bdc622a [x11,client] always use current clipboard owner 2024-04-07 08:59:51 +02:00
akallabeth
0905796cd7 [core,gateway[ fix use after free 2024-04-06 09:17:17 +02:00
akallabeth
7efd75cb01 [client,wlfreerdp] use wm-class for app_id 2024-04-06 09:17:17 +02:00
Ilya Shipitsin
25edec803b libfreerdp/crypto/certificate.c: handle malloc error 2024-04-06 07:11:14 +02:00
Armin Novak
8b2e13d989 [emu,scard] abort busy loop on session cancel 2024-04-05 13:06:57 +02:00
Armin Novak
330fe90b21 [cmake] Fix warning in FindOSS.cmake 2024-04-05 13:06:57 +02:00
Ilya Shipitsin
309509808c libfreerdp/core/gateway/rdg.c: handle malloc failure 2024-04-05 09:59:12 +02:00
akallabeth
00cd1c7130 [cmake] do not set NO_SONAME
if set the linker might insert full paths to dependencies
2024-04-04 21:51:09 +02:00
Martin Fleisz
f62a61886f common: Parse actual value of redirectlocation rdp file setting 2024-04-04 21:20:39 +02:00
Armin Novak
1b7e0ffb97 [core,smartcard] allow userhint to match UPN
the username might match the UPN of the smartcard certificate. If not
fall back to compare to userHint
2024-04-04 14:05:39 +02:00
akallabeth
4a56e2f74c [winpr,kerberos] use profile_abandon
suggested by @greghudson to just release the profile and not flush
changes back to config file. See #9766
2024-04-03 15:37:43 +02:00
akallabeth
1956fffd3d [build,mingw] fix build issues found 2024-04-03 11:53:58 +02:00
akallabeth
0712d0c899 [build,mac] check required tools are installed 2024-04-03 11:50:34 +02:00
Armin Novak
ff92ef4331 [client,windows] clean up clipboard 2024-04-03 10:45:12 +02:00
Ilya Shipitsin
be50010d1d client/Windows/wf_cliprdr.c: handle malloc error 2024-04-03 10:45:12 +02:00
akallabeth
735cb1ec14 [cmake] fix mingw linking 2024-04-03 09:42:44 +02:00
Armin Novak
e5799ec947 [locale,xkbfile] improve mapping
* Add missing keycodes to mapping
* Use sorted list to create mapping table
2024-04-03 08:22:25 +02:00
Armin Novak
18612bb513 [mingw] fix missing shlwapi link 2024-04-02 09:31:55 +02:00
Kai Pastor
4b52dfd70c Add #include to declare winpr_strerror 2024-04-01 09:31:57 +02:00
Mathias Lithen
532a3cd1a9 Set res_class on classHints 2024-04-01 09:30:30 +02:00
sasha0552
d864393a8a [client,X11] fix detection of need to use relative movements
Register XI raw masks when MouseUseRelativeMove enabled
Fix duplication of sent events (in previous implementation relative and absolute events were sent at the same time)
Slightly refactor code
2024-03-26 09:20:50 +01:00
akallabeth
8bd1e72dd4 [client,common] guard ainput access with correct guard 2024-03-26 09:20:35 +01:00
akallabeth
82dc655979 [core,gateway] improve warning for bad request
In case of E_PROXY_ORCHESTRATION_LB_SESSIONHOST_DEALLOCATED print a
warning with the message body or a generic fallback should that not be
provided.
2024-03-26 09:19:45 +01:00